diff options
author | Jeremy Huddleston Sequoia <jeremyhu@apple.com> | 2014-01-02 01:03:49 -0800 |
---|---|---|
committer | Jeremy Huddleston Sequoia <jeremyhu@apple.com> | 2014-01-02 01:04:31 -0800 |
commit | dcb6c39feb63dcf7e843bd2394a2544fd4e79f9f (patch) | |
tree | 418208ea5898baa10be34d70077500992f36f455 | |
parent | 4b0b74f953619164dc2863ee2cd3f09d15c65a51 (diff) |
FSOpenServer: Fix double-free in error path
FSOpenServ.c:266:5: warning: Use of memory after it is freed
OutOfMemory(svr, setup);
^~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
-rw-r--r-- | src/FSOpenServ.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/FSOpenServ.c b/src/FSOpenServ.c index 9b51e20..b8ccb2f 100644 --- a/src/FSOpenServ.c +++ b/src/FSOpenServ.c @@ -66,7 +66,7 @@ static fsReq _dummy_request = { 0, 0, 0 }; -static void OutOfMemory ( FSServer *svr, char *setup ); +static void OutOfMemory ( FSServer *svr ); FSServer *_FSHeadOfServerList = NULL; @@ -85,13 +85,11 @@ void _FSFreeServerStructure(FSServer *svr) static void OutOfMemory( - FSServer *svr, - char *setup) + FSServer *svr) { if (svr->trans_conn) _FSDisconnectServer(svr->trans_conn); _FSFreeServerStructure(svr); - FSfree(setup); errno = ENOMEM; } @@ -263,7 +261,7 @@ FSOpenServer(const char *server) FSfree(alts); FSfree(alt_data); FSfree(auth_data); - OutOfMemory(svr, setup); + OutOfMemory(svr); return (FSServer *) NULL; } |