Avoid fd leak when fdopen() fails in openFiles()

Found by parfait 1.1 bug checker:
   File Descriptor Leak: Leaked File Descriptor newfd
        at line 590 of xdm/auth.c in function 'openFiles'.
          newfd initialized at line 573 with open
          newfd leaks when newfd >= 0 at line 574.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

1 files changed, 4 insertions, 1 deletions

diff --git a/xdm/auth.c b/xdm/auth.c
index fd6bc7d..068a643 100644
--- a/xdm/auth.c
+++ b/xdm/auth.c
@@ -571,8 +571,11 @@ openFiles (char *name, char *new_name, FILE **oldp, FILE **newp)
 	 */
 	(void) unlink (new_name);
 	newfd = open (new_name, O_WRONLY | O_CREAT | O_EXCL, 0600);
-	if (newfd >= 0)
+	if (newfd >= 0) {
 	    *newp = fdopen (newfd, "w");
+	    if (*newp == NULL)
+		close(newfd);
+	}
 	else
 	{
 	    LogError ("Cannot create file %s: %s\n", new_name,