summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEamon Walsh <ewalsh@tycho.nsa.gov>2009-09-22 13:13:03 -0700
committerEamon Walsh <ewalsh@tycho.nsa.gov>2009-10-21 19:32:05 -0400
commit4814532133e6c57f2656e8363ec051edd312f26c (patch)
tree8b2884fdffff4a6760cb127d82709d08842e9ce7
parentc1a861eedf2e3b0d11896adaab72b013a885af5a (diff)
xace: Relax permissions on XkbGetState from Read to Getattr.
This request is used to get the current keyboard group and is called from GTK. It does not return an actual keymap (aside from modifiers) so it should be safe to relax the permission on it. However it does return button state information which should be controlled through a separate pointer Read check. Signed-off-by: Eamon Walsh <ewalsh@tycho.nsa.gov> (cherry picked from commit c4ffce4dc84a0a9d134a59b7e7765c99ed767e53)
-rw-r--r--xkb/xkb.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/xkb/xkb.c b/xkb/xkb.c
index 7abbeaaff..98e879ddb 100644
--- a/xkb/xkb.c
+++ b/xkb/xkb.c
@@ -554,7 +554,7 @@ ProcXkbGetState(ClientPtr client)
if (!(client->xkbClientFlags&_XkbClientInitialized))
return BadAccess;
- CHK_KBD_DEVICE(dev, stuff->deviceSpec, client, DixReadAccess);
+ CHK_KBD_DEVICE(dev, stuff->deviceSpec, client, DixGetAttrAccess);
xkb= &dev->key->xkbInfo->state;
bzero(&rep,sizeof(xkbGetStateReply));