diff options
| author | Peter Hutterer <peter.hutterer@who-t.net> | 2009-07-28 14:54:30 +1000 |
|---|---|---|
| committer | Peter Hutterer <peter.hutterer@who-t.net> | 2009-07-30 08:43:13 +1000 |
| commit | 0217d0370c0b0bce66a9c09092eda8e820274e2e (patch) | |
| tree | 3b6a4d0742b6c473a17057d3592e1d38493d73f3 | |
| parent | 4e9b2938cd8637a5d3b0a4c9f69d6ee75faab3a0 (diff) | |
record: ifdef out RecordExtensionInit and print a warning to the log.
The RECORD extension is currently broken. By ifdef'ing out the content of
RecordExtensionInit the extension isn't added to the server's internal list
and it does not get advertised to the client. Clients can thus fail
gracefully with a "extension not supported" instead of waiting forever for
events that never arrive.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
| -rw-r--r-- | record/record.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/record/record.c b/record/record.c index fd8855228..effb9263d 100644 --- a/record/record.c +++ b/record/record.c @@ -2865,6 +2865,13 @@ RecordCloseDown(ExtensionEntry *extEntry) void RecordExtensionInit(void) { + /* FIXME Record is currently broken. Dont initialize it so that clients + * that require it can bail out correctly rather than waiting for stuff + * that'll never happen */ + ErrorF("record: RECORD extension enabled at configure time.\n"); + ErrorF("record: This extension is known to be broken, disabling extension now..\n"); + ErrorF("record: http://bugs.freedesktop.org/show_bug.cgi?id=20500\n"); +#if 0 ExtensionEntry *extentry; RTContext = CreateNewResourceType(RecordDeleteContext); @@ -2887,5 +2894,6 @@ RecordExtensionInit(void) } RecordErrorBase = extentry->errorBase; +#endif } /* RecordExtensionInit */ |