summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Hurley <peter@hurleysoftware.com>2012-12-23 15:45:01 -0500
committerRichard Hughes <richard@hughsie.com>2012-12-29 13:13:56 +0000
commit9f31068707fc79744961cea7258b0eb262effbf1 (patch)
tree37317ca2302779201c4496424735095d378e06da
parent99768c18eb1ff4a98a4b74e32f79fabe0427c11d (diff)
Fix device matching for recent kernels
In recent kernels, hiddev* devices now have class "usbmisc", rather than "usb" (see http://www.spinics.net/lists/linux-usb/msg62276.html). This change translates into a change in SUBSYSTEM matching for hiddev* devices. This fix addresses this for recent kernels while retaining existing behavior. For reference, here is an attribute-walk for a CyberPower CPS 1500C on kernel 3.7.0: [Ubuntu bug #1091702: udev rules fail to match hid devices with new kernels] udevadm info --attribute-walk --path=/devices/pci0000:00/0000:00:1d.2/usb4/4-1/4-1:1.0/usbmisc/hiddev0 Udevadm info starts with the device specified by the devpath and then walks up the chain of parent devices. It prints for every device found, all possible attributes in the udev rules key format. A rule to match, can be composed by the attributes of the device and the attributes from one single parent device. looking at device '/devices/pci0000:00/0000:00:1d.2/usb4/4-1/4-1:1.0/usbmisc/hiddev0': KERNEL=="hiddev0" SUBSYSTEM=="usbmisc" DRIVER=="" looking at parent device '/devices/pci0000:00/0000:00:1d.2/usb4/4-1/4-1:1.0': KERNELS=="4-1:1.0" SUBSYSTEMS=="usb" DRIVERS=="usbhid" ATTRS{bInterfaceClass}=="03" ATTRS{bInterfaceSubClass}=="00" ATTRS{bInterfaceProtocol}=="00" ATTRS{bNumEndpoints}=="01" ATTRS{supports_autosuspend}=="1" ATTRS{bAlternateSetting}==" 0" ATTRS{bInterfaceNumber}=="00" looking at parent device '/devices/pci0000:00/0000:00:1d.2/usb4/4-1': KERNELS=="4-1" SUBSYSTEMS=="usb" DRIVERS=="usb" ATTRS{bDeviceSubClass}=="00" ATTRS{bDeviceProtocol}=="00" ATTRS{devpath}=="1" ATTRS{idVendor}=="0764" ATTRS{speed}=="1.5" ATTRS{bNumInterfaces}==" 1" ATTRS{bConfigurationValue}=="1" ATTRS{bMaxPacketSize0}=="8" ATTRS{busnum}=="4" ATTRS{devnum}=="2" ATTRS{configuration}=="" ATTRS{bMaxPower}==" 50mA" ATTRS{authorized}=="1" ATTRS{bmAttributes}=="c0" ATTRS{bNumConfigurations}=="1" ATTRS{maxchild}=="0" ATTRS{bcdDevice}=="0001" ATTRS{avoid_reset_quirk}=="0" ATTRS{quirks}=="0x0" ATTRS{version}==" 1.10" ATTRS{urbnum}=="36" ATTRS{ltm_capable}=="no" ATTRS{manufacturer}=="CPS" ATTRS{removable}=="unknown" ATTRS{idProduct}=="0501" ATTRS{bDeviceClass}=="00" ATTRS{product}==" CP 1500C" looking at parent device '/devices/pci0000:00/0000:00:1d.2/usb4': KERNELS=="usb4" SUBSYSTEMS=="usb" DRIVERS=="usb" ATTRS{bDeviceSubClass}=="00" ATTRS{bDeviceProtocol}=="00" ATTRS{devpath}=="0" ATTRS{idVendor}=="1d6b" ATTRS{speed}=="12" ATTRS{bNumInterfaces}==" 1" ATTRS{bConfigurationValue}=="1" ATTRS{bMaxPacketSize0}=="64" ATTRS{authorized_default}=="1" ATTRS{busnum}=="4" ATTRS{devnum}=="1" ATTRS{configuration}=="" ATTRS{bMaxPower}==" 0mA" ATTRS{authorized}=="1" ATTRS{bmAttributes}=="e0" ATTRS{bNumConfigurations}=="1" ATTRS{maxchild}=="2" ATTRS{bcdDevice}=="0307" ATTRS{avoid_reset_quirk}=="0" ATTRS{quirks}=="0x0" ATTRS{serial}=="0000:00:1d.2" ATTRS{version}==" 1.10" ATTRS{urbnum}=="50" ATTRS{ltm_capable}=="no" ATTRS{manufacturer}=="Linux 3.7.0-030700-generic uhci_hcd" ATTRS{removable}=="unknown" ATTRS{idProduct}=="0001" ATTRS{bDeviceClass}=="09" ATTRS{product}=="UHCI Host Controller" looking at parent device '/devices/pci0000:00/0000:00:1d.2': KERNELS=="0000:00:1d.2" SUBSYSTEMS=="pci" DRIVERS=="uhci_hcd" ATTRS{irq}=="18" ATTRS{subsystem_vendor}=="0x1028" ATTRS{broken_parity_status}=="0" ATTRS{class}=="0x0c0300" ATTRS{consistent_dma_mask_bits}=="32" ATTRS{dma_mask_bits}=="32" ATTRS{local_cpus}=="00000000,00000000,00000000,00000000,00000000,00000000,00000000,000000ff" ATTRS{device}=="0x268a" ATTRS{msi_bus}=="" ATTRS{local_cpulist}=="0-7" ATTRS{vendor}=="0x8086" ATTRS{subsystem_device}=="0x021e" ATTRS{numa_node}=="-1" ATTRS{d3cold_allowed}=="0" looking at parent device '/devices/pci0000:00': KERNELS=="pci0000:00" SUBSYSTEMS=="" DRIVERS=="" Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Richard Hughes <richard@hughsie.com>
-rw-r--r--rules/95-upower-hid.rules2
-rw-r--r--src/linux/up-backend.c4
2 files changed, 4 insertions, 2 deletions
diff --git a/rules/95-upower-hid.rules b/rules/95-upower-hid.rules
index 87a0956..dcf4380 100644
--- a/rules/95-upower-hid.rules
+++ b/rules/95-upower-hid.rules
@@ -4,9 +4,11 @@
4# to keep up to date, monitor: http://svn.debian.org/wsvn/nut/trunk/scripts/upower/95-upower-hid.rules 4# to keep up to date, monitor: http://svn.debian.org/wsvn/nut/trunk/scripts/upower/95-upower-hid.rules
5 5
6# only support USB, else ignore 6# only support USB, else ignore
7SUBSYSTEM=="usbmisc", GOTO="up_hid_chkdev"
7SUBSYSTEM!="usb", GOTO="up_hid_end" 8SUBSYSTEM!="usb", GOTO="up_hid_end"
8 9
9# if usbraw device, ignore 10# if usbraw device, ignore
11LABEL="up_hid_chkdev"
10KERNEL!="hiddev*", GOTO="up_hid_end" 12KERNEL!="hiddev*", GOTO="up_hid_end"
11 13
12# if an interface, ignore 14# if an interface, ignore
diff --git a/src/linux/up-backend.c b/src/linux/up-backend.c
index 0ca6ca7..0ae3413 100644
--- a/src/linux/up-backend.c
+++ b/src/linux/up-backend.c
@@ -134,7 +134,7 @@ up_backend_device_new (UpBackend *backend, GUdevDevice *native)
134 /* no valid TTY object */ 134 /* no valid TTY object */
135 device = NULL; 135 device = NULL;
136 136
137 } else if (g_strcmp0 (subsys, "usb") == 0) { 137 } else if (g_strcmp0 (subsys, "usb") == 0 || g_strcmp0 (subsys, "usbmisc") == 0) {
138 138
139#ifdef HAVE_IDEVICE 139#ifdef HAVE_IDEVICE
140 /* see if this is an iDevice */ 140 /* see if this is an iDevice */
@@ -328,7 +328,7 @@ up_backend_coldplug (UpBackend *backend, UpDaemon *daemon)
328 GList *l; 328 GList *l;
329 guint i; 329 guint i;
330 gboolean ret; 330 gboolean ret;
331 const gchar *subsystems[] = {"power_supply", "usb", "tty", "input", NULL}; 331 const gchar *subsystems[] = {"power_supply", "usb", "usbmisc", "tty", "input", NULL};
332 332
333 backend->priv->daemon = g_object_ref (daemon); 333 backend->priv->daemon = g_object_ref (daemon);
334 backend->priv->device_list = up_daemon_get_device_list (daemon); 334 backend->priv->device_list = up_daemon_get_device_list (daemon);