diff options
author | Nelson Benítez León <nbenitezl@gmail.com> | 2021-03-01 00:22:26 -0400 |
---|---|---|
committer | Nelson Benítez León <nbenitezl@gmail.com> | 2021-03-01 00:28:42 -0400 |
commit | 1d91d03325662ca368cf5da77d09012998e7720e (patch) | |
tree | 4ede780c290248c8073fa9acd3df84ff43447087 | |
parent | 6a81075c91277d7106bccba66dea0c0bca7be536 (diff) |
glib/poppler-structure-element: fix memleak
in convert_doubles_array(), which was not
assigning the allocated memory to the
out variable.
This means this function was never returning
anything until now, which means there's probably
no users of this function in the wild (certainly
not in Evince).
Issue #1049
-rw-r--r-- | glib/poppler-structure-element.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/glib/poppler-structure-element.cc b/glib/poppler-structure-element.cc index c63e9567..aec7cd15 100644 --- a/glib/poppler-structure-element.cc +++ b/glib/poppler-structure-element.cc @@ -1090,6 +1090,8 @@ static inline void convert_doubles_array(Object *object, gdouble **values, guint for (guint i = 0; i < *n_values; i++) { doubles[i] = object->arrayGet(i).getNum(); } + + values = &doubles; } static inline void convert_color(Object *object, PopplerColor *color) |