summaryrefslogtreecommitdiff
authorRay Strode <rstrode@redhat.com>2012-10-24 18:50:27 (GMT)
committer root <root@halfline-ssd.usersys.redhat.com>2012-10-24 18:52:24 (GMT)
commit4b7fe818d9d310ae746efb82b5b37b9dae410993 (patch) (side-by-side diff)
tree149ce7dcba6566af9df32069584bf0ac78ddd2bd
parenta91db63f11527e49bef344027fadb06d73057b19 (diff)
downloadplymouth-4b7fe818d9d310ae746efb82b5b37b9dae410993.zip
plymouth-4b7fe818d9d310ae746efb82b5b37b9dae410993.tar.gz
boot-splash: avoid crash if plugin doesn't support system updates
Right now if the user hits escape a couple of times they'll get a crash, since the details plugin doesn't support system updates. This commit makes ply_boot_splash_system_update a no-op in the event the splash doesn't support that feature.
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--src/libply-splash-core/ply-boot-splash.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/libply-splash-core/ply-boot-splash.c b/src/libply-splash-core/ply-boot-splash.c
index d82d610..93d9345 100644
--- a/src/libply-splash-core/ply-boot-splash.c
+++ b/src/libply-splash-core/ply-boot-splash.c
@@ -613,7 +613,9 @@ ply_boot_splash_system_update (ply_boot_splash_t *splash,
assert (splash->loop != NULL);
assert (splash->plugin_interface != NULL);
assert (splash->plugin != NULL);
- assert (splash->plugin_interface->system_update != NULL);
+
+ if (splash->plugin_interface->system_update == NULL)
+ return false;
ply_trace ("updating system %i%%", progress);
splash->plugin_interface->system_update (splash->plugin,