From 114d38e57d78b4141a8cf4359437773f931877a5 Mon Sep 17 00:00:00 2001 From: Daniel Schürmann Date: Wed, 14 Jul 2021 13:47:01 +0200 Subject: aco/isel: avoid unnecessary calls to nir_unsigned_upper_bound() These were responsible for ~20% of the time spent in instruction selection. Reduces overall compile times by ~0.5%. Reviewed-by: Rhys Perry Part-of: --- src/amd/compiler/aco_instruction_selection.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/compiler/aco_instruction_selection.cpp b/src/amd/compiler/aco_instruction_selection.cpp index 85f5ae23dde..d5a48264ff8 100644 --- a/src/amd/compiler/aco_instruction_selection.cpp +++ b/src/amd/compiler/aco_instruction_selection.cpp @@ -855,8 +855,8 @@ emit_vop2_instruction(isel_context* ctx, nir_alu_instr* instr, aco_opcode op, Te Operand op1(src1); for (int i = 0; i < 2; i++) { - uint32_t src_ub = get_alu_src_ub(ctx, instr, swap_srcs ? !i : i); if (uses_ub & (1 << i)) { + uint32_t src_ub = get_alu_src_ub(ctx, instr, swap_srcs ? !i : i); if (src_ub <= 0xffff) bld.set16bit(i ? op1 : op0); else if (src_ub <= 0xffffff) -- cgit v1.2.3