diff options
| author | Samuel Iglesias Gonsalvez <siglesias@igalia.com> | 2014-04-03 08:30:06 +0200 |
|---|---|---|
| committer | Kenneth Graunke <kenneth@whitecape.org> | 2014-04-16 23:00:40 -0700 |
| commit | 9927180714662456ff7b895221f67112f2567a53 (patch) | |
| tree | 41fa4c65d224e7015679fec35769ac7fcaf4a849 /src | |
| parent | 42a26cb5e441a01d5288b299980f23affaad53fe (diff) | |
mesa: fix check for dummy renderbuffer in _mesa_FramebufferRenderbufferEXT()
According to the spec:
<renderbuffertarget> must be RENDERBUFFER and <renderbuffer>
should be set to the name of the renderbuffer object to be
attached to the framebuffer. <renderbuffer> must be either
zero or the name of an existing renderbuffer object of type
<renderbuffertarget>, otherwise an INVALID_OPERATION error is
generated.
This patch changes the previous returned GL_INVALID_VALUE to
GL_INVALID_OPERATION.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76894
Cc: mesa-stable@lists.freedesktop.org
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/mesa/main/fbobject.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 6c4f1b548be..7669a0c5df5 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -2676,8 +2676,7 @@ _mesa_FramebufferRenderbuffer(GLenum target, GLenum attachment, return; } else if (rb == &DummyRenderbuffer) { - /* This is what NVIDIA does */ - _mesa_error(ctx, GL_INVALID_VALUE, + _mesa_error(ctx, GL_INVALID_OPERATION, "glFramebufferRenderbufferEXT(renderbuffer %u)", renderbuffer); return; |