diff options
| author | José Fonseca <jfonseca@vmware.com> | 2014-07-24 15:50:56 +0100 |
|---|---|---|
| committer | José Fonseca <jfonseca@vmware.com> | 2014-07-29 15:41:32 +0100 |
| commit | 66a1b3a1da5cbb75d727c9b4751a06bdd403f0f9 (patch) | |
| tree | 3a171c505b8e91f431e6bef7f6b04b6c0ac11251 | |
| parent | 8d0a1a6bc05af7edd25b15ce9159025036b636ff (diff) | |
st/wgl: Clamp wglChoosePixelFormatARB's output nNumFormats to nMaxFormats.
While running https://github.com/nvMcJohn/apitest with apitrace I noticed that Mesa was producing bogus results:
wglChoosePixelFormatARB(hdc, piAttribIList = {...}, pfAttribFList = &0, nMaxFormats = 1, piFormats = {19, 65576, 37, 198656, 131075, 0, 402653184, 0, 0, 0, 0, -573575710}, nNumFormats = &12) = TRUE
However https://www.opengl.org/registry/specs/ARB/wgl_pixel_format.txt states
<nNumFormats> returns the number of matching formats. The returned
value is guaranteed to be no larger than <nMaxFormats>.
Cc: "10.2" <mesa-stable@lists.freedesktop.org>
Reviewed-by: Brian Paul <brianp@vmware.com>
| -rw-r--r-- | src/gallium/state_trackers/wgl/stw_ext_pixelformat.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/gallium/state_trackers/wgl/stw_ext_pixelformat.c b/src/gallium/state_trackers/wgl/stw_ext_pixelformat.c index d303b0153cb..91682d115a4 100644 --- a/src/gallium/state_trackers/wgl/stw_ext_pixelformat.c +++ b/src/gallium/state_trackers/wgl/stw_ext_pixelformat.c @@ -448,9 +448,11 @@ wglChoosePixelFormatARB( */ for (i = 0; i < count; i++) { if (scores[i].points > 0) { - if (*nNumFormats < nMaxFormats) - piFormats[*nNumFormats] = scores[i].index + 1; + piFormats[*nNumFormats] = scores[i].index + 1; (*nNumFormats)++; + if (*nNumFormats >= nMaxFormats) { + break; + } } } |