summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBjoern Michaelsen <bjoern.michaelsen@canonical.com>2011-09-23 01:13:34 +0200
committerBjoern Michaelsen <bjoern.michaelsen@canonical.com>2011-09-26 22:21:18 +0200
commit6a3faed5b459ea133c39ef5243dad8e366ca00c3 (patch)
tree8dea394dba51e89d3c40604b7f346799a51d3888
parentf8f5d96666bff5051cc88d06b10d855548a441de (diff)
fdo#39510: comment added
Signed-off-by: Michael Stahl <mst@openoffice.org>
-rw-r--r--sw/source/core/layout/newfrm.cxx10
1 files changed, 10 insertions, 0 deletions
diff --git a/sw/source/core/layout/newfrm.cxx b/sw/source/core/layout/newfrm.cxx
index 7f19c1a398..39433365c4 100644
--- a/sw/source/core/layout/newfrm.cxx
+++ b/sw/source/core/layout/newfrm.cxx
@@ -607,7 +607,17 @@ SwRootFrm::~SwRootFrm()
{
bTurboAllowed = sal_False;
pTurbo = 0;
+ // fdo#39510 crash on document close with footnotes
+ // Object ownership in writer and esp. in layout are a mess: Before the
+ // document/layout split SwDoc and SwRootFrm were essentially one object
+ // and magically/uncleanly worked around their common destruction by call
+ // to SwDoc::IsInDtor() -- even from the layout. As of now destuction of
+ // the layout proceeds forward through the frames. Since SwTxtFtn::DelFrms
+ // also searches backwards to find the master of footnotes, they must be
+ // considered to be owned by the SwRootFrm and also be destroyed here,
+ // before tearing down the (now footnote free) rest of the layout.
AllRemoveFtns();
+
if(pBlink)
pBlink->FrmDelete( this );
if ( static_cast<SwFrmFmt*>(GetRegisteredInNonConst()) )