From c4820200312e3d50a12d3605147772759938bcf6 Mon Sep 17 00:00:00 2001 From: Kohei Yoshida Date: Fri, 25 Jan 2013 12:57:14 -0500 Subject: fdo#59056: Re-calculate cell anchor position of a pasted drawing object. Else it would re-use the anchor position of the original one (minus the sheet index which is correctly adjusted). Change-Id: I52d11eb9953ee7539c9d5da41edd7dd28604587c Reviewed-on: https://gerrit.libreoffice.org/1869 Reviewed-by: Eike Rathke Tested-by: Eike Rathke --- sc/inc/drwlayer.hxx | 1 + sc/source/core/data/drwlayer.cxx | 7 +++++++ sc/source/ui/view/viewfun7.cxx | 8 ++++++-- 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/sc/inc/drwlayer.hxx b/sc/inc/drwlayer.hxx index 298d619010af..72b980d5fea7 100644 --- a/sc/inc/drwlayer.hxx +++ b/sc/inc/drwlayer.hxx @@ -166,6 +166,7 @@ public: String GetNewGraphicName( long* pnCounter = NULL ) const; void EnsureGraphicNames(); + static bool IsCellAnchored( const SdrObject& rObj ); static void SetPageAnchored( SdrObject& ); static void SetCellAnchored( SdrObject&, const ScDrawObjData &rAnchor ); // Updates rAnchor based on position of rObj diff --git a/sc/source/core/data/drwlayer.cxx b/sc/source/core/data/drwlayer.cxx index 76d67944a161..8ea4fcaa4b9f 100644 --- a/sc/source/core/data/drwlayer.cxx +++ b/sc/source/core/data/drwlayer.cxx @@ -1787,6 +1787,13 @@ void ScDrawLayer::UpdateCellAnchorFromPositionEnd( SdrObject &rObj, const ScDocu pAnchor->maEndOffset.X() = aCellRect.Right()-aObjRect.Left(); } +bool ScDrawLayer::IsCellAnchored( const SdrObject& rObj ) +{ + // Cell anchored object always has a user data, to store the anchor cell + // info. If it doesn't then it's page-anchored. + return GetFirstUserDataOfType(&rObj, SC_UD_OBJDATA) != NULL; +} + void ScDrawLayer::SetPageAnchored( SdrObject &rObj ) { DeleteFirstUserDataOfType(&rObj, SC_UD_OBJDATA); diff --git a/sc/source/ui/view/viewfun7.cxx b/sc/source/ui/view/viewfun7.cxx index c69dc656d8e3..63e2f1ac40fd 100644 --- a/sc/source/ui/view/viewfun7.cxx +++ b/sc/source/ui/view/viewfun7.cxx @@ -172,8 +172,8 @@ void ScViewFunc::PasteDraw( const Point& rLogicPos, SdrModel* pModel, pDestPage->InsertObject( pNeuObj ); pScDrawView->AddUndo(new SdrUndoInsertObj( *pNeuObj )); - // Chart braucht nicht mehr getrennt behandelt zu werden, - // weil es seine Daten jetzt selber hat + if (ScDrawLayer::IsCellAnchored(*pNeuObj)) + ScDrawLayer::SetCellAnchoredFromPosition(*pNeuObj, *GetViewData()->GetDocument(), nTab); } } @@ -238,6 +238,10 @@ void ScViewFunc::PasteDraw( const Point& rLogicPos, SdrModel* pModel, { if ( pObject->ISA(SdrUnoObj) && pObject->GetLayer() != SC_LAYER_CONTROLS ) pObject->NbcSetLayer(SC_LAYER_CONTROLS); + + if (ScDrawLayer::IsCellAnchored(*pObject)) + ScDrawLayer::SetCellAnchoredFromPosition(*pObject, *GetViewData()->GetDocument(), nTab); + pObject = aIter.Next(); } } -- cgit v1.2.3