From b8345af80078f9eee29a391fe84b2506b37d24ea Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Mon, 12 Mar 2018 14:29:48 +0000 Subject: tdf#107094 backward heading search doesn't always work MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit regression from... commit 84e44386d70e886f9bae633ebe915ea3a52f8dbd Author: Caolán McNamara Date: Wed Nov 12 10:35:18 2014 +0000 coverity#982189 Unchecked return value so put it back the way it was and explicitly ignore the return instead Change-Id: I6f5ef42b38236ea5f70ddbccfa25a81f2f3e976c Change-Id: I0c0084247e8570ace2198fa893db273dab00d2b0 Reviewed-on: https://gerrit.libreoffice.org/51147 Tested-by: Jenkins Reviewed-by: Michael Stahl --- sw/source/core/crsr/crstrvl.cxx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sw/source/core/crsr/crstrvl.cxx b/sw/source/core/crsr/crstrvl.cxx index 8c1a0627f1d0..b65ba7d8dcf3 100644 --- a/sw/source/core/crsr/crstrvl.cxx +++ b/sw/source/core/crsr/crstrvl.cxx @@ -976,8 +976,9 @@ bool SwCursorShell::GotoPrevOutline() SwNode* pNd = &(pCursor->GetNode()); SwOutlineNodes::size_type nPos; - bool bRet = rNds.GetOutLineNds().Seek_Entry(pNd, &nPos); - if (bRet && nPos) + bool bRet = false; + (void)rNds.GetOutLineNds().Seek_Entry(pNd, &nPos); + if (nPos) { --nPos; // before -- cgit v1.2.3