summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2017-07-04loplugin:casttovoidStephan Bergmann2-8/+6
...cases that were initially missed due to the broken containsProcessingConditionalInclusion() Change-Id: Ib7d801ab5173ee590ef35a9e075d3ce4d4aa06da
2017-07-04loplugin:casttovoid in VCL_BUILDER_DECL_FACTORYStephan Bergmann2-6/+3
Change-Id: I4b0dd08963cf50daa41901975c6f92fe21db2048
2017-07-03loplugin:oncevar (clang-cl): vclStephan Bergmann6-15/+11
Change-Id: I0459978c2cfb61cd7251f0e8d9a30f1f19c02c11
2017-07-03tdf#39468 Translate German comments/termsJens Carl1-1/+1
Change-Id: I9edef3138964d3f43745be39956bc6bb66d0cc4d Reviewed-on: https://gerrit.libreoffice.org/39403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Johnny_M <klasse@partyheld.de> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-07-03gtk+ FIXMEs vs. loplugin:casttovoidStephan Bergmann2-4/+2
Lets assume the functionality will actually be implemented and the parameters be used. Change-Id: I8500b0f8cbd336132a357423b3e1651d52e605cc Reviewed-on: https://gerrit.libreoffice.org/39455 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-07-03C++11 remove std::unary_function bases from functorsJochen Nitschke5-8/+5
std::unary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::unary_function base class was used in 3 places: * chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole is used in a std::not1 function helper who uses the members return_type and argument_type. - replace deprecated std::not1 with a lambda * chart2/source/tools/ModifyListenerHelper.cxx: lcl_weakReferenceToSame used the argument_type member in the operator() parameter. - inline the parameter type. * xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement used result_type and argument_type in operator(). - inline the types Also fix compile error with gcc about finding std::for_each. Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f Reviewed-on: https://gerrit.libreoffice.org/39358 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-07-03Fix typosAndrea Gelmini1-1/+1
Change-Id: Iaf63c488f895c446bb54119d8c9f15e0adcd1eff Reviewed-on: https://gerrit.libreoffice.org/39454 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-07-02loplugin:casttovoid: vclStephan Bergmann11-48/+24
Change-Id: Icdc9d009849f2a93f6e1dbba07b1042dbb1ff561
2017-06-30loplugin:unusedfields in toolkit..xmloffNoel Grandin15-107/+38
Change-Id: I4964ff97e0a1735dc08c6ad204cae0b08e9ffc2c Reviewed-on: https://gerrit.libreoffice.org/39406 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-30Fix previous commit for non-MACOSXStephan Bergmann1-7/+4
Change-Id: I5192d299910120e65ad577fa63846e13a1c31e76
2017-06-30loplugin:oncevarStephan Bergmann5-9/+7
Change-Id: I740ccb3335d602d309422ba26913c4503c6345f0
2017-06-29Don't let m_nGrabLevel become negative, tdf#108705 relatedEike Rathke1-3/+6
... which then later leads to 2 Giga loops on the next GtkSalFrame dtor call, for example on the second AutoFilter button popup in Calc. Fall-out from commit 9b32355ea6d8d5e34363ba0c57e74d75d7a7b1b7 Date: Fri Jun 23 12:48:12 2017 +0100 Resolves: tdf#108705 remove grabs on widget before destroying it that brought this to surface. Change-Id: I0edb7eec9384c716800f07ef1ed91fc8f1d7c119
2017-06-28Call ~Idle with SolarMutex lockedStephan Bergmann1-5/+9
...may be the cause for rather frequent UITest failures on Jenkins bot lo_tb_master_linux_dbg, like <https://ci.libreoffice.org/job/lo_tb_master_linux_dbg/14067/console> during UITest_calc_demo: > Thread 1 (Thread 0x2b2622036700 (LWP 12315)): > #0 0x00002b2604d495eb in Task::~Task() (this=0x2b2622034f90, __in_chrg=<optimized out>) at /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/vcl/source/app/scheduler.cxx:362 > #1 0x00002b2604d7cddc in Timer::~Timer() (this=0x2b2622034f90, __in_chrg=<optimized out>) at /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/vcl/source/app/timer.cxx:73 > #2 0x00002b26047eb25a in Idle::~Idle() (this=0x2b2622034f90, __in_chrg=<optimized out>) at /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/include/vcl/idle.hxx:30 > #3 0x00002b2604e900fd in UIObjectUnoObj::executeAction(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x304ce50, rAction="TYPE", rPropValues=uno::Sequence of length 1 = {...}) at /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/vcl/source/uitest/uno/uiobject_uno.cxx:118 > aIdle = {<Timer> = {<Task> = {_vptr.Task = 0x2b2605888c10 <vtable for Task+16>, mpSchedulerData = 0x0, mpDebugName = 0x2b2605264160 "UI Test Idle Handler", mePriority = HIGH, mbActive = false}, maInvokeHandler = {function_ = 0x2b2604e8fa66 <(anonymous namespace)::ExecuteWrapper::LinkStubExecuteActionHdl(void*, Timer*)>, instance_ = 0x2de91c0}, mnTimeout = 1, mbAuto = false}, <No data fields>} > func = {<std::_Maybe_unary_or_binary_function<void>> = {<No data fields>}, <std::_Function_base> = {static _M_max_size = 16, static _M_max_align = 8, _M_functor = {_M_unused = {_M_object = 0x27aafc0, _M_const_object = 0x27aafc0, _M_function_pointer = 0x27aafc0, _M_member_pointer = (void (std::_Undefined_class::*)(std::_Undefined_class * const)) 0x27aafc0, this adjustment 38138176}, _M_pod_data = "\300\257z\002\000\000\000\000@\361E\002\000\000\000"}, _M_manager = 0x2b2604e90ac7 <std::_Function_base::_Base_manager<UIObjectUnoObj::executeAction(const rtl::OUString&, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&)::__lambda0>::_M_manager(std::_Any_data &, const std::_Any_data &, std::_Manager_operation)>}, _M_invoker = 0x2b2604e90aa5 <std::_Function_handler<void(), UIObjectUnoObj::executeAction(const rtl::OUString&, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&)::__lambda0>::_M_invoke(const std::_Any_data &)>} > lk = {_M_device = 0x304cef0, _M_owns = true} > pWrapper = 0x2de91c0 > #4 0x00002b261d76951d in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) (pThis=0x304cea0, nVtableIndex=4, pRegisterReturn=0x0, pReturnTypeRef=0x16b42c0, bSimpleReturn=true, pStack=0x2b2622035160, nStack=0, pGPR=0x2b26220352d0, pFPR=0x2b2622035300) at /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:133 > data = {pMethod = 47442291130818, pStack = 0x2b2622035160, nStack = 0, pGPR = 0x2b26220352d0, pFPR = 0x2b2622035300, rax = 47442779394304, rdx = 47442779394256, xmm0 = 2.3439542265158875e-310, xmm1 = 2.343984744210869e-310} > pMethod = 47442301612736 > #5 0x00002b261d76815c in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, typelib_TypeDescriptionReference*, sal_Int32, typelib_MethodParameter*, void*, void**, uno_Any**) (pThis=0x27ade30, aVtableSlot=..., pReturnTypeRef=0x16b42c0, nParams=2, pParams=0x27b0850, pUnoReturn=0x0, pUnoArgs=0x2eecbc0, ppUnoExc=0x2b2622035488) at /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:237 > pStack = 0x2b2622035160 > pFPR = {2.3439847442227266e-310, 2.3439819402763736e-310, 8.4879831638610893e-314, 2.3439847442246535e-310, 2.0565652466724057e-316, -2.1644405065794623e-51, 2.3439847442250981e-310, 0} > __PRETTY_FUNCTION__ = "void cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, typelib_TypeDescriptionReference*, sal_Int32, typelib_MethodParameter*, void*, void**, uno_Any**)" > pCppArgs = 0x2b2622035120 > pStackStart = 0x2b2622035160 > pGPR = {50646688, 41629936, 47442779394304, 47442703110834, 0, 41625344} > nTempIndices = 1 > nFPR = 0 > pAdjustedThisPtr = 0x304cea0 > ppTempParamTypeDescr = 0x2b2622035140 > nGPR = 3 > pReturnTypeDescr = 0x16b42c0 > pCppReturn = 0x0 > bSimpleReturn = true > pTempIndices = 0x2b2622035130 > #6 0x00002b261d768bdb in bridges::cpp_uno::shared::unoInterfaceProxyDispatch(_uno_Interface*, _typelib_TypeDescription const*, void*, void**, _uno_Any**) (pUnoI=0x27ade30, pMemberDescr=0x27b2700, pReturn=0x0, pArgs=0x2eecbc0, ppException=0x2b2622035488) at /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:425 > nMemberPos = 4 > aVtableSlot = {offset = 0, index = 4} > pThis = 0x27ade30 > pTypeDescr = 0x27aeab0 > __PRETTY_FUNCTION__ = "void bridges::cpp_uno::shared::unoInterfaceProxyDispatch(uno_Interface*, const typelib_TypeDescription*, void*, void**, uno_Any**)" > #7 0x00002b261ea0ff28 in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const (this=0x17eaec0, returnValue=0x2b26220358a0, outArguments=0x2b2622035920) at /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/binaryurp/source/incomingrequest.cxx:242 > exc = <error reading variable: Cannot access memory at address 0x7261686320747376> > pexc = 0x2b26220354b0 > retType = {_pTypeDescr = 0x16b42c0} > nSize = 0 > retBuf = std::__debug::vector of length 0, capacity 0 > outBufs = empty std::__debug::list > args = std::__debug::vector of length 2, capacity 2 = {0x27b38f0, 0x27b3908} > __PRETTY_FUNCTION__ = "bool binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny>*) const" > isExc = false > #8 0x00002b261ea0ed16 in binaryurp::IncomingRequest::execute() const (this=0x17eaec0) at /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/binaryurp/source/incomingrequest.cxx:79 > resetCc = true > oldCc = {m_pUnoI = 0x0} > ret = {data_ = _uno_Any(void)} > outArgs = std::__debug::vector of length 0, capacity 0 > isExc = false > #9 0x00002b261ea2f7a4 in binaryurp::(anonymous namespace)::request(void*) (pThreadSpecificData=0x17eaec0) at /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/binaryurp/source/reader.cxx:85 > __PRETTY_FUNCTION__ = "void binaryurp::{anonymous}::request(void*)" > #10 0x00002b25fd2edf5f in cppu_threadpool::JobQueue::enter(long, bool) (this=0x2d036e0, nDisposeId=41587312, bReturnWhenNoJob=true) at /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/cppu/source/threadpool/jobqueue.cxx:107 > guard = {pT = 0x2d036e0} > job = {pThreadSpecificData = 0x17eaec0, doRequest = 0x2b261ea2f73b <binaryurp::(anonymous namespace)::request(void*)>} > pReturn = 0x0 > #11 0x00002b25fd2f2bfd in cppu_threadpool::ORequestThread::run() (this=0x27a9270) at /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/cppu/source/threadpool/thread.cxx:172 > #12 0x00002b25fd2f312b in osl::threadFunc(void*) (param=0x27a9280) at /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/include/osl/thread.hxx:185 > pObj = 0x27a9280 > #13 0x00002b25f9a194a5 in osl_thread_start_Impl(void*) (pData=0x27a9540) at /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/sal/osl/unx/thread.cxx:237 > terminate = false > pImpl = 0x27a9540 > __PRETTY_FUNCTION__ = "void* osl_thread_start_Impl(void*)" > #14 0x00002b25fa404dc5 in start_thread () at /lib64/libpthread.so.0 > #15 0x00002b25fa131ced in clone () at /lib64/libc.so.6 Change-Id: Iad8402ce9fd3315b7446d6274a4fe18f8e8012fd
2017-06-28loplugin:oncevar in vclNoel Grandin47-196/+130
Change-Id: I37a6dacda12e1c2910737d74aa344c7e2e195aeb Reviewed-on: https://gerrit.libreoffice.org/39328 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-27tdf#108809 Message boxes: Add more descriptive window titleSamuel Mehrbrodt3-6/+67
E.g. 'Error' for error boxes instead of just 'LibreOffice 6.0' Change-Id: I7142d15e9219a2aa6733523887cdf43b50200b7b Reviewed-on: https://gerrit.libreoffice.org/39284 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-27gpg4libre: Show error message when signing failsSamuel Mehrbrodt1-0/+10
Change-Id: I58f3febaaaaa225952e87ad3f092950ace37d15d Reviewed-on: https://gerrit.libreoffice.org/39283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-23Resolves: tdf#108705 remove grabs on widget before destroying itCaolán McNamara1-0/+5
Change-Id: If02a0b4340788db638c74b98e855258145643452 Reviewed-on: https://gerrit.libreoffice.org/39165 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-23simplify some string handling in tracing callsNoel Grandin9-58/+21
Change-Id: I0fb76562429e691400a02216019c7f96791cf9b3 Reviewed-on: https://gerrit.libreoffice.org/39159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23convert to std::vectorCaolán McNamara1-5/+5
Change-Id: I37a866f4248ad6441cb73b826c13b3602b96e03a
2017-06-23coverity#1412987 Untrusted value as argumentCaolán McNamara1-3/+11
Change-Id: Ia41c81d7cf864a5b38594b85577139bdaf5fc7bb
2017-06-23move pBuffer out of classCaolán McNamara3-30/+28
Change-Id: I88120530b21ebe72796ddee39c2446a70c3fd193
2017-06-23coverity#1412988 Uninitialized scalar fieldCaolán McNamara1-2/+5
Change-Id: I98bcb9f45caab6b8b052737baf5500766f94f88d
2017-06-22Resolves: tdf#108452 gtk3 xbm cursors invisible on black bgCaolán McNamara1-6/+15
Change-Id: I5c9b27862da6ac76ae38542f85a51f9aefdd013d Reviewed-on: https://gerrit.libreoffice.org/39111 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-21convert ErrCode to strong typedefNoel Grandin8-59/+46
would have preferred to re-use o3tl::strong_int, of which this is a modified copy, but there are lots of convenience accessors which are nice to define on the class. Change-Id: I301b807aaf02fbced3bf75de1e1692cde6c0340a Reviewed-on: https://gerrit.libreoffice.org/38497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-20Propagate failure out from css.ui.test.XUITest::executeCommand/DialogStephan Bergmann2-14/+10
Change-Id: Id7bd2d6f35f45d9957facf56d66cfc57a1e0ef6a Reviewed-on: https://gerrit.libreoffice.org/39002 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-06-20new cannot return nullptrNoel Grandin1-6/+3
unless we are using std::nothrow Change-Id: I3bdd13c8ce18f4e977f18ee5196311bf4fc62de0 Reviewed-on: https://gerrit.libreoffice.org/38998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-19restore gtk3 menu separatorsCaolán McNamara1-0/+4
Change-Id: I48b302780db420346280d782c1804fe6e93c90be
2017-06-19don't parse align and scale in VclAlignmentNoel Grandin1-8/+0
allow it to pass up to superclasses for parsing, from discussion: <noel_grandin> caolan, is it intended that the VclAlignment x/y align/scale members are effectively unused? <caolan> noel_grandin: its based off the GtkAlignment so that's why it had them in the first place. Never got around to doing anything about scale so no surprise there and might as well remove those <noel_grandin> caolan, will do, thanks <caolan> I would have expected the xalign/yalign to do something, I think looking closer that we should be using those and probably that stub impl is blocking the underlying Window::set_property from using the supported left/right top/bottom values, so you can try remove those too, but I'd do it in a separate commit from the definitely useless scale ones <noel_grandin> caolan, at the moment, the change will remove them, but not the parsing of the values, so it should not change the functionality <noel_grandin> caolan, I'll do the removal of the parsing in a separate commit, which will pass them up to Window::set_property Change-Id: I5bb043a5c38d494355bf4766af8521838b7fc3f2 Reviewed-on: https://gerrit.libreoffice.org/38957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-19Avoid -fsanitize=shift-base about left-shift of negative valuesStephan Bergmann1-2/+2
...assuming these values are indeed intended to be negative (and <https: //developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6.html#Types>) mentions a "Fixed: 16.16-bit sgined fixed-point number" type, apparently represented here by F16Dot16, so the assumption looks plausible). During CppunitTest_vcl_pdfexport, encountered negative values -1184 and -22 with instdir/share/fonts/truetype/Carlito-Regular.ttf and -8 with instdir/share/fonts/truetype/LiberationSans-Bold.ttf. Change-Id: Ia07c61aebc2c9c67d0ed6173ecac94bab2abb2a8
2017-06-18Fix typosAndrea Gelmini1-2/+2
Change-Id: If28e198b8e1a26660e07dce49db66a651de43d3f Reviewed-on: https://gerrit.libreoffice.org/38850 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-18coverity#1412875 Uninitialized pointer fieldCaolán McNamara2-0/+6
Change-Id: Ib9e40cdec5c8b87eaccf4ce941c0c8641b28e5c7
2017-06-18remove unused osl/mutex.hxx includesJochen Nitschke13-16/+0
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb Reviewed-on: https://gerrit.libreoffice.org/38905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-06-18another fix after loplugin:unusedfields in vclMarkus Mohrhard1-1/+0
Change-Id: I11a43d1285b474efcb5d4fb157d9e80f0930f081
2017-06-18fix the headless plugin after removal of unused variablesMarkus Mohrhard1-1/+0
Change-Id: I3681cdbb128575fdb9ce389c6da34bf637f3e38c
2017-06-17loplugin:unusedfields in vcl part3Noel Grandin34-188/+5
Change-Id: I5a6319ba1667af6e9b7b92c22f858188c28c4c61 Reviewed-on: https://gerrit.libreoffice.org/38835 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-17loplugin:unusedfields in vcl part2Noel Grandin43-235/+26
Change-Id: Icd02f63e9738c0bb91348e2084649f9edc281e67 Reviewed-on: https://gerrit.libreoffice.org/38833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-17loplugin:unusedfields in vcl part1Noel Grandin39-164/+12
Change-Id: I67d176003f39992cd0ff9271a7d6ce26d2cb6619 Reviewed-on: https://gerrit.libreoffice.org/38828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-16silence DrMemory warning about Selected font handle deletedCaolán McNamara1-1/+2
This might actually matter in practice given https://stackoverflow.com/questions/27422871/does-deletedc-automatically-unselect-objects "DCs get a default 1x1x1 bitmap when they're created. This will leak if you don't put it back." Change-Id: Ib2d361995621ad429277ff52cb8c9fdfc0009953 Reviewed-on: https://gerrit.libreoffice.org/38875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-16Profiling API: add ProfileZonesLászló Németh1-0/+3
Change-Id: Ie5669bd75d9b4be047d98402cb69ac313ab618df Reviewed-on: https://gerrit.libreoffice.org/38787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-15make LANGUAGE setting universal, not just gtk specificCaolán McNamara2-7/+17
Change-Id: I845e808be27e2fad959a73d0d34a204b4bdcdd1f Reviewed-on: https://gerrit.libreoffice.org/38211 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-15add quattro pro filter to fftesterCaolán McNamara1-0/+14
Change-Id: If59114dca8adb94266838f496d8b5d60d322bca2
2017-06-15continue if theme cannot be determinedCaolán McNamara1-2/+13
Change-Id: Ia5b6e77b66357dd74c5163472e07a5c31166e8d2
2017-06-15tdf#99680 save graphic state even for empty clipping regionVasily Melenchuk3-1/+49
Previous fix was causing Adobe Reader errors due to mistmatch of save and restore operators. Corresponding unittest is extended to verify save/restore operators count. Change-Id: I102722140e216cb9ad29107aae3bdaa70472d471 Reviewed-on: https://gerrit.libreoffice.org/38694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-06-14use ERRCODE_NONE instead of 0Noel Grandin7-14/+14
peeling off a small chunk of my ErrCode strong_int conversion Change-Id: Idc89e8496083beed7608cba705cd981139eb7111 Reviewed-on: https://gerrit.libreoffice.org/38777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-14use more SAL_N_ELEMENTS part 1Noel Grandin5-13/+9
- teach comphelper::containerToSequence to handle sized arrays - also use range based for-loop where appropriate. Change-Id: I73ba9b6295e7b29c872ee53de7a9340969e07f99 Reviewed-on: https://gerrit.libreoffice.org/38769 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-13make opengl transitions under X flicker free on enter/leaveCaolán McNamara5-2/+53
Change-Id: I109637dc6b3d23c0beca21f3cf0c7ba918ecb4f8 Reviewed-on: https://gerrit.libreoffice.org/38749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-13remove TDE integration (vclplug, address book, config backend)Michael Stahl21-5788/+0
It has ~no users, can't even be built on modern Linuxes, and it annoys folks who want to refactor VCL. Per ESC decision from 2017-06-08, remove --enable-tde and --enable-tdeab. Change-Id: I51ce4786f29f8fcac2e2bb2a654c41fbfbbd8afd Reviewed-on: https://gerrit.libreoffice.org/38718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-12Avoid use-after-freeStephan Bergmann1-12/+14
...as seen in UITest_calc_demo: > ==1010== Invalid read of size 4 > ==1010== at 0x58DA550: __pthread_mutex_unlock_usercnt (/usr/src/debug/glibc-2.24-33-ge9e69e4/nptl/pthread_mutex_unlock.c:39) > ==1010== by 0x58DA550: pthread_mutex_unlock (/usr/src/debug/glibc-2.24-33-ge9e69e4/nptl/pthread_mutex_unlock.c:324) > ==1010== by 0x1085FB42: __gthread_mutex_unlock(pthread_mutex_t*) (/usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/x86_64-redhat-linux/bits/gthr-default.h:778) > ==1010== by 0x10861414: std::mutex::unlock() (/usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/bits/std_mutex.h:121) > ==1010== by 0x10861901: std::unique_lock<std::mutex>::unlock() (/usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/bits/std_mutex.h:323) > ==1010== by 0x108604C6: std::unique_lock<std::mutex>::~unique_lock() (/usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/bits/std_mutex.h:232) > ==1010== by 0x1085FA5E: (anonymous namespace)::ExecuteWrapper::ExecuteActionHdl(Timer*) (/vcl/source/uitest/uno/uiobject_uno.cxx:103) > ==1010== by 0x1085EDE7: (anonymous namespace)::ExecuteWrapper::LinkStubExecuteActionHdl(void*, Timer*) (/vcl/source/uitest/uno/uiobject_uno.cxx:85) > ==1010== by 0x10715647: Link<Timer*, void>::Call(Timer*) const (/include/tools/link.hxx:84) > ==1010== by 0x107154A6: Timer::Invoke() (/vcl/source/app/timer.cxx:89) > ==1010== by 0x106D3841: ImplSchedulerData::Invoke() (/vcl/source/app/scheduler.cxx:46) > ==1010== by 0x106D3D28: Scheduler::ProcessTaskScheduling(bool) (/vcl/source/app/scheduler.cxx:159) > ==1010== by 0x107040EF: ImplYield(bool, bool, unsigned long) (/vcl/source/app/svapp.cxx:508) > ==1010== by 0x106FE9A7: Application::Yield() (/vcl/source/app/svapp.cxx:558) > ==1010== by 0x106FE92A: Application::Execute() (/vcl/source/app/svapp.cxx:458) > ==1010== by 0x513F498: desktop::Desktop::DoExecute() (/desktop/source/app/app.cxx:1354) > ==1010== by 0x5141660: desktop::Desktop::Main() (/desktop/source/app/app.cxx:1698) > ==1010== by 0x10711884: ImplSVMain() (/vcl/source/app/svmain.cxx:192) > ==1010== by 0x10713197: SVMain() (/vcl/source/app/svmain.cxx:230) > ==1010== by 0x51AEDF7: soffice_main (/desktop/source/app/sofficemain.cxx:166) > ==1010== by 0x40091C: sal_main (/desktop/source/app/main.c:48) > ==1010== by 0x4008F6: main (/desktop/source/app/main.c:47) > ==1010== Address 0x2ccca4e8 is 72 bytes inside a block of size 96 free'd > ==1010== at 0x4C2F21A: operator delete(void*) (/builddir/build/BUILD/valgrind-3.12.0/coregrind/m_replacemalloc/vg_replace_malloc.c:576) > ==1010== by 0x1085FA55: (anonymous namespace)::ExecuteWrapper::ExecuteActionHdl(Timer*) (/vcl/source/uitest/uno/uiobject_uno.cxx:102) > ==1010== by 0x1085EDE7: (anonymous namespace)::ExecuteWrapper::LinkStubExecuteActionHdl(void*, Timer*) (/vcl/source/uitest/uno/uiobject_uno.cxx:85) > ==1010== by 0x10715647: Link<Timer*, void>::Call(Timer*) const (/include/tools/link.hxx:84) > ==1010== by 0x107154A6: Timer::Invoke() (/vcl/source/app/timer.cxx:89) > ==1010== by 0x106D3841: ImplSchedulerData::Invoke() (/vcl/source/app/scheduler.cxx:46) > ==1010== by 0x106D3D28: Scheduler::ProcessTaskScheduling(bool) (/vcl/source/app/scheduler.cxx:159) > ==1010== by 0x107040EF: ImplYield(bool, bool, unsigned long) (/vcl/source/app/svapp.cxx:508) > ==1010== by 0x106FE9A7: Application::Yield() (/vcl/source/app/svapp.cxx:558) > ==1010== by 0x106FE92A: Application::Execute() (/vcl/source/app/svapp.cxx:458) > ==1010== by 0x513F498: desktop::Desktop::DoExecute() (/desktop/source/app/app.cxx:1354) > ==1010== by 0x5141660: desktop::Desktop::Main() (/desktop/source/app/app.cxx:1698) > ==1010== by 0x10711884: ImplSVMain() (/vcl/source/app/svmain.cxx:192) > ==1010== by 0x10713197: SVMain() (/vcl/source/app/svmain.cxx:230) > ==1010== by 0x51AEDF7: soffice_main (/desktop/source/app/sofficemain.cxx:166) > ==1010== by 0x40091C: sal_main (/desktop/source/app/main.c:48) > ==1010== by 0x4008F6: main (/desktop/source/app/main.c:47) Change-Id: Ie95bf07f2fcd9420c9c24e6829272430895957a6
2017-06-12cleanup unused css/frame/* includesJochen Nitschke4-4/+0
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65 Reviewed-on: https://gerrit.libreoffice.org/38633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12Refactor create layout cache in status barTamas Bunth2-53/+39
Create SalLayout in StatusBar instead of getting cache through output parameter. Pass cache as a constant to the output device afterwards. Results in a more readable code, with more evident memory management. Change-Id: I4f949ea8f390b31379f661d611a183ceb3d91c25 Reviewed-on: https://gerrit.libreoffice.org/38651 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-24 04:44:11 +0000