summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2017-03-29loplugin:unusedmethodsNoel Grandin1-10/+0
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0 Reviewed-on: https://gerrit.libreoffice.org/35834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29vcl PDF export, norefxobj: add UI for thisMiklos Vajna1-0/+7
Disable the "use reference XObjects" (old behavior) by default, but keep it as an option in case someone wants it. Summary till the help is updated: the old way is simpler code, so it's always correct, but really only Acrobat supports that markup. The new way is supported by all readers, but more complex, so it's more likely it goes wrong. Change-Id: I4769474f29d98412be496a0aa4e8254ae4f0919e Reviewed-on: https://gerrit.libreoffice.org/35826 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-29Attempted fix for mirrored geometry crasher.Michael Meeks1-12/+13
Only plausible cause is pWindow->GetParent() being null, while we have a pParent which has to be valid. http://crashreport.libreoffice.org/stats/crash_details/6161398d-17b6-4a93-aa70-a559efa07868 Code was initially introduced in this form: commit 4716735ba7d0ad133ff018481f94d6b4f201bbd9 Author: Stephan Schäfer <ssa@openoffice.org> Date: Thu Sep 19 15:46:19 2002 +0000 #103362# improve positioning and resizing of system windows No public report, sadly. And modified by commit fba46c6efd08d50fee92cc11546f3ed253a57af8 Author: Chris Sherlock <chris.sherlock79@gmail.com> Date: Mon Feb 3 16:46:04 2014 +1100 fdo#74424 Use Window::GetOutDev() to access ImplReMirrored() Part of the decoupling of Window from OutputDevice. We now get he Window's OutputDevice instance and manipulate this. Do not rely on the inherited function. where the GetParent()/pWindow->GetParent() problem surfaces Change-Id: Ia261028a4719525135e3fe4b00074427c1d9df6c Reviewed-on: https://gerrit.libreoffice.org/35796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-03-29loplugin:singlevalfieldsNoel Grandin3-5/+0
Change-Id: I7f05903aaab9b0b274358243d680d0c30694ae61 Reviewed-on: https://gerrit.libreoffice.org/35804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-28ofz#954 out of memoryCaolán McNamara14-1/+38
Change-Id: Ib27f2dfe0d0837544910208f38a1bc11a35e3cb4 Reviewed-on: https://gerrit.libreoffice.org/35794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-28vcl PDF export, norefxobj: have the list of keys to copy at one placeMiklos Vajna1-11/+11
To avoid repeting ourselves. Change-Id: I39667620b9cf391251327c8f66ad8b9649ead36f Reviewed-on: https://gerrit.libreoffice.org/35810 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-28tdf#106693 vcl PDF export, norefxobj: handle multiple refs in copied arraysMiklos Vajna2-17/+48
Also fix confusion about dictionaries in arrays and arrays in dictionaries. Change-Id: I0d71d5796b1eb4f89e3fd9a5b1f807d2a7340a35 Reviewed-on: https://gerrit.libreoffice.org/35806 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-28Resolves: tdf#106155 avoid opengl for toplevel X window iconsCaolán McNamara3-0/+30
because an opengl context requires a toplevel window so it recurses to death. Only the gen/kde4 vclplugs are affected here Change-Id: If5396d183d90d1872931b170dc90c3a70d8ea6b6
2017-03-28tdf#106693 vcl PDF export, norefxobj: copy nested arrays correctlyMiklos Vajna2-2/+10
When copying an array we're only interested in the start/end position of the outermost array, otherwise only part of the array is copied. Change-Id: I9f5cb5e3ed395142fd82db34e1153ddfdf9f0eb3 Reviewed-on: https://gerrit.libreoffice.org/35797 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-27ofz#948 optimize the edge-case of converting masks to 1bit during dib loadCaolán McNamara1-36/+46
Change-Id: Ibed50b92ab49685a1ac033c93bd52bc7d2ea581c Reviewed-on: https://gerrit.libreoffice.org/35757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-27tdf#106693 vcl PDF export, norefxobj: handle multiple refs in copied dictsMiklos Vajna2-16/+49
When copying font definitions the dictionary has multiple values where the type is a reference. Improve PDFWriterImpl::copyExternalResource(), so that multiple references are copied correctly as well. With this the bugdoc (from comment 5) text appears in the output. Change-Id: I2343e616d8b36e3cdcbd4e713bd3f7fa7bce6d3b Reviewed-on: https://gerrit.libreoffice.org/35760 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-27Resolves: rhbz#1436050 im window misplaced for gtk3Caolán McNamara1-1/+1
events are relative to event window not the toplevel window which includes a menubar widget (and maybe the decoration topbar as well) Change-Id: I5101bd4a35d6e3aee03191594e5f6edb7ca34c69
2017-03-27vcl PDF export, norefxobj: improve ref handling in dictsMiklos Vajna2-19/+20
When copying objects referenced from the page stream support references in any item value, not just for one single item key. Also move the dictionary entry generator code to PDFWriterImpl::copyExternalResources(), so other keys can be copied without code duplication. Change-Id: I4004e82014cec915c66a8a9d3aed2155fa2452ef Reviewed-on: https://gerrit.libreoffice.org/35755 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-27move bitmap allocation after palette readCaolán McNamara1-10/+10
Change-Id: Ie7b2d64bde48d49c6e389c0770f2456187107bda
2017-03-27return early on errorCaolán McNamara1-186/+184
no logc change intended Change-Id: I9a000ccc53b13d2948264b18ae0abf29a6ddc33c
2017-03-27reuse palette objectCaolán McNamara1-3/+3
Change-Id: I72035a49d30955cdc6334f6064a1a2e902c1a9f0
2017-03-27process palette standaloneCaolán McNamara1-5/+6
Change-Id: I489a5cdecf4a5c856e9e5fdd03e6f9c920c0a4d5
2017-03-27tdf#106693 vcl PDF export, norefxobj: copy array objectsMiklos Vajna2-4/+87
So far only the dictionary and the stream of the object was copied, see if it has an array, and take care of that as well. Also check if the array contains a reference and act accordingly. Change-Id: I7f3bb12ec0bbc6f6e1db4f43625c7768b862c895 Reviewed-on: https://gerrit.libreoffice.org/35744 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-26Fixes tdf#106772 show the window in X11 in VCL gtk3 plugin.Arnaud Versini1-0/+4
The window is shown only in Wayland. Thanks to Jean-Baptiste Faure for the bisect. Change-Id: Ibeffc5ae62d4c341e30b15021eb695859fc1025a Reviewed-on: https://gerrit.libreoffice.org/35720 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-26tdf#106458 Color widget should list an exact number of itemsheiko tietze1-1/+1
mnColorValueSetMaximumRowCount set to 9 Change-Id: I818512da16c1f31616f200253e72a8576996fa16 Reviewed-on: https://gerrit.libreoffice.org/35719 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-03-26uitest: provide a way to select a floating window, e.g. popup menuMarkus Mohrhard2-0/+21
Change-Id: Ice418b974c59c7d8c773b81a82f0a06c84547f10 Reviewed-on: https://gerrit.libreoffice.org/35699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-26uitest: handle float windows better in the hierarchy dumpMarkus Mohrhard1-6/+15
Change-Id: Ic49ac5774116bf9d8af980ecc0d99b0056fc8bed Reviewed-on: https://gerrit.libreoffice.org/35695 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-26uitest: allow to find ourself with an IDMarkus Mohrhard1-0/+3
Change-Id: I5418aba05acd53f00c8d60a7ac7005c83a04e5a4 Reviewed-on: https://gerrit.libreoffice.org/35701 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-25Fix typosAndrea Gelmini32-34/+34
Change-Id: I623135cd4c76dd6569f4ee521f97dee41de4cb1e Reviewed-on: https://gerrit.libreoffice.org/35660 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-24tdf#106693 vcl PDF export, norefxobj: update XObject refsMiklos Vajna3-26/+93
Start copying referenced objects recursively, and also take care of updating references to the object IDs as they appear in our output. With this, the 4th image referenced from the PDF image has a correctly updated reference in its dictionary's ColorSpace key. Change-Id: I8b49701c1f60bd0ef5a097b24ce59164554c44fa Reviewed-on: https://gerrit.libreoffice.org/35653 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-24lok: Unit test for setting of the language during load of the document.Jan Holesovsky1-0/+9
Change-Id: Idf4d3ba6b55be1f885f9d8fc89157e7e498d4e42
2017-03-24fix macosx build failureCaolán McNamara2-9/+1
I only *need* it for the fuzzers, just wanted to keep this in sync with those for simplicity Change-Id: I4fd8aef54c6604c0d44faca9a6515bfd8e85d8bf
2017-03-24update fftester documentationCaolán McNamara1-1/+1
Change-Id: I091491a628b267a18d044d770a28a6b9e96f39f4
2017-03-24tdf#106693 vcl PDF export, norefxobj: copy XObject referencesMiklos Vajna3-8/+97
With this the images inside the PDF image show up correctly. Change-Id: I430502fb6ae9de8111dda7e67db33642ff263317 Reviewed-on: https://gerrit.libreoffice.org/35621 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-24ofz: explicitly release fontconfig options on every iterationCaolán McNamara7-6/+38
fontconfigs alloc mechanism is too complicated for lsan/valgrind so force the fontconfig options to be released at the end of every iteration, they are demand loaded so will be recreated if necessary on next use Change-Id: I061117b1fb8136298593a165847f78eabe008f0f
2017-03-24ofz#937 sanity check claimed record lengthCaolán McNamara4-1/+5
Change-Id: Ic0b9b23764bd7533adbc746419d38da8ab7ce704
2017-03-24shared_ptr->unique_ptrCaolán McNamara3-5/+5
Change-Id: I89aa885c2d5a5c1150ac83b515c0bb84ff2ce039
2017-03-24vcl printer: hold a reference on mxPrinter member while operating on it.Michael Meeks1-10/+18
Hopefully addresses: http://crashreport.libreoffice.org/stats/crash_details/7a33b96a-b479-47a4-a006-eb62718128cc Change-Id: I221c04a6626a39449405387343cdc43e9f02dee1 Reviewed-on: https://gerrit.libreoffice.org/35587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-03-24loplugin:unusedfieldsNoel Grandin1-10/+2
improve the plugin to find fields which are only assigned to in the constructor Change-Id: I95b5be238ebba83d950ca15093abdd1849740359 Reviewed-on: https://gerrit.libreoffice.org/35613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-24vcl: clean up ANDROID ifdefs in pdfwriter_implMiklos Vajna1-18/+12
HAVE_FEATURE_NSS is already 0 on Android, so an "&& !defined(ANDROID)" is redundant. Change-Id: I275ed71d9ebdb56878d980a23c4480e41b28bd6b Reviewed-on: https://gerrit.libreoffice.org/35614 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-24convert ViewShellId to o3tl::strong_intNoel Grandin1-1/+1
Change-Id: I45553d11d56aa8c4432aec126ca51f24bd3ead09 Reviewed-on: https://gerrit.libreoffice.org/35421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23Remove unused #include <ctype.h>Stephan Bergmann3-3/+0
Change-Id: I8bf3e30687e20151a9e1936e69362abfe9b3a99d
2017-03-23ofz: when skipping actions, only skip forwardsCaolán McNamara1-15/+26
Change-Id: I1a80de4bf5c6c44ed10c1b720f85895ad8f4f8e5
2017-03-23add svm cppunit testCaolán McNamara12-15/+4
and rely on new safe multiple check of commit 4f0b226600fdad4e5aef9313fe8754c765cfee42 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Mar 21 11:23:09 2017 +0000 check for overflow in multiply rather than trying to detect them here in advance Change-Id: I7fb9a9960e428cf00f745b6156a588e2c990c03f Reviewed-on: https://gerrit.libreoffice.org/35595 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-23tdf#106693 vcl PDF export, norefxobj: handle compressed page streamMiklos Vajna1-42/+84
Since we want to avoid re-compressing the page stream create two form XObjects: one that resets the graphic state to the default (e.g. line width) and an other one that contains the original page stream as-is. With this PDF images where the page stream is compressed are handled correctly. Change-Id: Ib44dae2e167e4d5604a0a3a3cf91e09795137343
2017-03-23ofz: readjust LLVMFuzzerInitialize to get ppt SdDLL::Init outside leak detectCaolán McNamara25-6/+162
Change-Id: I01a6d19ef27c4678929e8e7554569c9219ea83f6
2017-03-23Notebookbar: move shortcuts if multiple rows of tabsSzymon Kłos1-0/+14
Change-Id: I8b164a34eeff13d70712a84d5621d169b6528962 Reviewed-on: https://gerrit.libreoffice.org/35588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-03-23Related: rhbz#1334915 tdf#100158 hack using startcenter icon under waylandCaolán McNamara1-0/+16
cause I can get no traction with gnome#779143 to allow changing wayland app_ids for windows, so might as well bodge something to make us look less pathetic than the broken app icon Change-Id: I9810ba4908dd06a2fdbb2e58e7ad6ff4978ddd43
2017-03-23TODO: move to ScrollBar when binary incompatibility is no longer problematicCaolán McNamara1-34/+24
since... commit 72ebade6ba9e88a5a24db57266a53e8f52049214 Author: Ivo Hinkelmann <ihi@openoffice.org> Date: Thu Sep 13 15:33:31 2007 +0000 INTEGRATION: CWS aquavclcarbonfixes (1.20.70); FILE MERGED 2007/08/29 12:59:47 hdu 1.20.70.1: #i77549# extend native scrollbar NWF by adding PART_TRACK_*_AREA controls Change-Id: I124c4014556f3a10b986a2886202210ebfc9eb10 Reviewed-on: https://gerrit.libreoffice.org/35586 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-23tdf#106693 vcl PDF export, norefxobj: copy page streamMiklos Vajna2-7/+58
This gives correct result in very simple cases when the page stream is not compressed and it references no other objects from the original file. Change-Id: I11ed50180a256bdb5c587fd8927d21c925100a4d Reviewed-on: https://gerrit.libreoffice.org/35580 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-23loplugins:redundantcast teach it about c-style typedef castsNoel Grandin11-14/+14
Change-Id: I1ac11a2481c0f4d8be1e1fd7c7637ac0ece3d65c Reviewed-on: https://gerrit.libreoffice.org/35558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-22Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char)Stephan Bergmann3-12/+19
Change-Id: I10c0433d314808cb1c51c3bde4f826bce7c8a97b
2017-03-22Related: tdf#106645 make gtk3 scrollbar themes with arrows workCaolán McNamara1-71/+90
properly, e.g. breeze-dark has arrows Change-Id: Ic59c0de3fb385adc2f8fddc605edd7498230d5fb
2017-03-22Resolves: tdf#106645 gtk3 scrollbar is too wideCaolán McNamara1-24/+410
Change-Id: I4041dff0945c4bd34e085078a7130b637124c6cd
2017-03-22tdf#106693 vcl PDF export: initial UseReferenceXObject optionMiklos Vajna1-10/+17
It's still on, but in experimental mode start work towards the ability to not use that markup. Change-Id: Idf11c0e0a3c61ad93af331346ec7107304f6dc0f Reviewed-on: https://gerrit.libreoffice.org/35538 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>