summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2017-07-27gtk3: Resolves: tdf#109277 take modifier key into account for dndCaolán McNamara1-2/+26
Change-Id: Id0aa4ced8644ddbee9e1a0453887f07907547aae (cherry picked from commit 0c840d9bf308464d58a2df8aaa1e61481b5e4f52) Reviewed-on: https://gerrit.libreoffice.org/40476 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-07-27Resolves: tdf#109289 add SvxColorListBox::IsValueChangedFromSavedCaolán McNamara1-1/+0
and remove PushButton::IsValueChangedFromSaved Change-Id: Ib1c51e27fd708c5d4811c90ef5659b4d55dd8860 (cherry picked from commit 39fd7e97c253153a10161ef3694b64e90e65e80a) Related: tdf#109289 move PushButton::IsValueChangedFromSaved to consumer inheriting the IsValueChangedFromSaved from PushButton has allowed undesirable behaviour to be selected Change-Id: Ifccb1657d2565005e6f9e239c6118f2e5ae7970c (cherry picked from commit 247607727986df0fd0fef198459eb6646e056ea3) Reviewed-on: https://gerrit.libreoffice.org/40484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-25tdf#109281 add fallback to GDI back when we can't bind a DCTomaž Vajngerl1-0/+5
Change-Id: Ideae3a5bcacfaadd2cb9d6b014a449d423d332dc Reviewed-on: https://gerrit.libreoffice.org/40395 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-07-21tdf#107166 improve AA mode selection, retry, more checksTomaž Vajngerl2-42/+91
Major problem when setting the render mode and the text antialias mode is that when you set the render mode to something that isn't compatible with the text antialias mode, then every next call will cause an error (invalid parameters). So we need to be sure that we never set incompatible modes. Additionally we just need to set it one time when we create the surface and not every time we draw. If we get the D2DERR_RECREATE_TARGET we can create a new render target and retry the whole call. Somethimes this is not possible so we try 3 times and the give up. We need to add more checks where we exit early or not continue with some calls as any additional calls could taint the draw state and some things wouldn't be drawn. For example if we calculate the sizes of 0 glyphs we shouldn't continue with binding the hDC with an "empty" rectangle. This will fail and cause some text that is called afterwards to not draw. Change-Id: I8f802da2e7ece0bf16d665f2e5011ffaa5267fca Reviewed-on: https://gerrit.libreoffice.org/40260 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-19tdf#109194 cleanse startup notification foo from envThorsten Behrens1-0/+8
So when the desktop environment does startup notification, this DESKTOP_STARTUP_ID gets passed on to the launched application. Problem is, XDG spec says app should read it from the env, then discard - which LibreOffice never does. When passed on to child processes, funny effects might ensue, so let's just erase this at the end of VCL init, when I'm reasonably sure every gtk/kde/whatnot backend did read it. Change-Id: I1f758c7a02455028d2b520c144ffe32538621f19 Reviewed-on: https://gerrit.libreoffice.org/40153 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 8180b6801dca2052a9d40411f9bbdcc96198c52f) Reviewed-on: https://gerrit.libreoffice.org/40164 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-07-16tdf#107166 BindDC doesn't handle 0 width/height rect consistentlyTomaž Vajngerl1-1/+4
When binding a GDI device context to D2D we need to provide a rectangle where the surface will have effect. When we just need some font information we need to bind the DC too, but we aren't really interested what the rectangle is, so we just provided a 0,0,0,0 rectangle in that case. This sometimes fails with a "out of memory" result and is dependent on the renderer. Instead of 0,0,0,0 rectangle we rather define a 0,0,1,1 rectangle which should never fail. This is not problematic as for actual rendering we later rebind with an actual rectangle. Change-Id: I79c7f0cf4d69f213370ed26a811a908ed16070ff Reviewed-on: https://gerrit.libreoffice.org/39902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-16vcl: fix -Werror=format (32-bit GCC)Michael Stahl1-1/+1
Change-Id: Ia7afb5b9750704797ff8030688d0531c27d80836 (cherry picked from commit c356884319f254fdd944376fe2f841532dc36433) Reviewed-on: https://gerrit.libreoffice.org/39965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-15tdf#104883 Don't call InstallFontconfigResources if it's not availableSamuel Mehrbrodt1-0/+9
We need to call it once because we have no other way to detect whether it's working or not. But if we receive an error the first time, we disable it from now on. Change-Id: I67dba8b65660ff7e05bdf2ddc18b565550901cd1 Reviewed-on: https://gerrit.libreoffice.org/39894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-14fix crash when aInkBoxes might be emptyMarkus Mohrhard1-1/+5
e.g. http://crashreport.libreoffice.org/stats/signature/WinFontInstance::CacheGlyphToAtlas(bool,HDC__%20*,HFONT__%20*,int,SalGraphics%20&) Change-Id: I0f32b549c687c2da6534f59a13ce1c5d57047829 Reviewed-on: https://gerrit.libreoffice.org/39874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 008d7abcdd246cfc9bef6cbdbef85890ca2efd69) Reviewed-on: https://gerrit.libreoffice.org/39877 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-06tdf#106990 set cleartype setting / force to use GDI render modeTomaž Vajngerl2-3/+86
With this we read the system setting for cleartype and set it to the render target we are using. Additionally we set the GDI like rendering mode which forces that the text is rendered similar as this was done with GDI. Change-Id: If6fb72bc371accf50278c968c94e625aee3f0953 Reviewed-on: https://gerrit.libreoffice.org/39602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit a5a3e82e99e7a60ec65c339dd0463af5c680cead) Reviewed-on: https://gerrit.libreoffice.org/39647 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-07-04Resolves: tdf#108452 gtk3 xbm cursors invisible on black bgCaolán McNamara1-6/+15
Change-Id: I5c9b27862da6ac76ae38542f85a51f9aefdd013d Reviewed-on: https://gerrit.libreoffice.org/39112 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-29Don't let m_nGrabLevel become negative, tdf#108705 relatedEike Rathke1-3/+6
... which then later leads to 2 Giga loops on the next GtkSalFrame dtor call, for example on the second AutoFilter button popup in Calc. Fall-out from commit 9b32355ea6d8d5e34363ba0c57e74d75d7a7b1b7 Date: Fri Jun 23 12:48:12 2017 +0100 Resolves: tdf#108705 remove grabs on widget before destroying it that brought this to surface. Change-Id: I0edb7eec9384c716800f07ef1ed91fc8f1d7c119 (cherry picked from commit 637d917d7551fed19c9685f974fb3e732a8f97e2) Reviewed-on: https://gerrit.libreoffice.org/39387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-23Resolves: tdf#108705 remove grabs on widget before destroying itCaolán McNamara1-0/+5
Change-Id: If02a0b4340788db638c74b98e855258145643452 Reviewed-on: https://gerrit.libreoffice.org/39166 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-22ofz#2287 check multiplyCaolán McNamara1-2/+4
Change-Id: Ibc4c93ac1f5686a476b5e303347dc951daa58e33 Reviewed-on: https://gerrit.libreoffice.org/38910 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-19silence DrMemory warning about Selected font handle deletedCaolán McNamara1-1/+2
This might actually matter in practice given https://stackoverflow.com/questions/27422871/does-deletedc-automatically-unselect-objects "DCs get a default 1x1x1 bitmap when they're created. This will leak if you don't put it back." Change-Id: Ib2d361995621ad429277ff52cb8c9fdfc0009953 Reviewed-on: https://gerrit.libreoffice.org/38875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit ceb6b00e3d861825dd59c8b565b122c2eadfb2cb) Reviewed-on: https://gerrit.libreoffice.org/38954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-06-16tdf#99680 modified clipping for PDF exportVasily Melenchuk4-5/+89
If clipping is requested, but no clipping region is defined, clipping is ignored. This squashes the following 3 commits: Change-Id: I793c1de1f4f6b0203727c0ff6aa8adecc43ad413 Reviewed-on: https://gerrit.libreoffice.org/38021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Change-Id: Id4565858b0135b3177044558db87a68ef828955b Reviewed-on: https://gerrit.libreoffice.org/38403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Change-Id: I102722140e216cb9ad29107aae3bdaa70472d471 Reviewed-on: https://gerrit.libreoffice.org/38694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-on: https://gerrit.libreoffice.org/38825 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-06-14make opengl transitions under X flicker free on enter/leaveCaolán McNamara5-2/+53
Change-Id: I109637dc6b3d23c0beca21f3cf0c7ba918ecb4f8 Reviewed-on: https://gerrit.libreoffice.org/38752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-06tdf#94632 Enable sifr dark and set fallbackYousuf Philips2-0/+7
Change-Id: If77b33acf4f8d3e2e9c38b3e5ef359a1fc966910 Reviewed-on: https://gerrit.libreoffice.org/38387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> (cherry picked from commit 59c0682c46e52aa18bdbee4c14ef05af9329de33) Reviewed-on: https://gerrit.libreoffice.org/38426 Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-30tdf#107682 - Repeated images replace correct ones in exported PDFMarco Cecchetti1-0/+15
The problem was due to the buffer acquire methods: in Bitmap::Checksum (old implementation) Bitmap::AcquireReadAccess is used to get the bitmap buffer: indeed this method relies on SalBitmap::AcquireBuffer (which is used in the new implementation) but in case the buffer acquisition fails, instead of giving up, it tries to update the imp bitmap instance embedded in the bitmap (see BitmapInfoAccess::ImplCreate). The solution is to perform this further attemp in Bitmap::Checksum when the value returned by ImpBitmap::GetChecksum is 0. Change-Id: Ib901ac941db57756e9a951bacbc573ca206316e0 Reviewed-on: https://gerrit.libreoffice.org/38167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-05-26Resolves: tdf##108069 2nd OpenGLContext::init should dispose earlier resultsCaolán McNamara1-1/+2
Change-Id: If6bb9517a4081576347d71ddf26d020119d34247 (cherry picked from commit 0b9b36cafe29916a9fdeac420a49c174adb10c59) Reviewed-on: https://gerrit.libreoffice.org/38064 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-25tdf#108056 PDF export: work with double page sizeMiklos Vajna3-8/+8
Our coordinate system has the origo in the top left corner, PDF's one is at the bottom left corner. So the page height affects the coordinate of all widths and y positions. That page width is 870.25 in the case of the bugdoc, but it was handled as 870 due to the integer rounding. The coordinates and heights are now closer to the expected ones. (cherry picked from commit a05dc747caf5b8fef6bd95a999cb6098f2b4dbc7) Change-Id: I9c7d77298df3850bbc170c9ace18120900d7e3fa Reviewed-on: https://gerrit.libreoffice.org/38035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-05-23tdf#105461 PDF export of editeng fill color: restrict to logic map modesMiklos Vajna3-20/+89
The original use case was Writer/Impress shape text, but when the map mode is pixels, the reference device gives bogus values for the PixelToLogic() calls, affecting e.g. form controls. Just go back to the old way of not painting the background for those. (cherry picked from commit 919a4ef592b6026a7533a93682f39118fef29ce8) Change-Id: I52f1901af15732274915fa3c77c06909b5164afb Reviewed-on: https://gerrit.libreoffice.org/37939 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-05-23test for DejaVuSansRene Engelhard1-0/+6
Change-Id: I963c9a9ac0239af5550de50f39f080b9f19d494f Reviewed-on: https://gerrit.libreoffice.org/37920 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2017-05-21make string translation loading more uniformCaolán McNamara14-34/+34
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2155e04d6343638ca9815d394cbc4f78c2b17c3a) drop toString Change-Id: I0f67c8931523bbe90bfbc8cc7d9a5bd523758ee5 (cherry picked from commit 8b1101023f01b2c7478a014b5ead73ada4fd4861) pNameResId is unused Change-Id: Ic1fe6abc7066517187695266c4d1a0888b41ffe7 (cherry picked from commit c2667d7ff558a1b7bf83e694909465f00d1a16f6) Reviewed-on: https://gerrit.libreoffice.org/37843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-18Related: rhbz#1367846 queue and merge scroll eventsCaolán McNamara3-43/+112
Change-Id: Ib45f61bbb35bd240829491ac8a79803222974778 Reviewed-on: https://gerrit.libreoffice.org/37780 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-18ofz#1605 check multiply and shiftCaolán McNamara3-4/+50
Change-Id: I6aad9ad23e7bf080b3b610223f92df7074530beb Reviewed-on: https://gerrit.libreoffice.org/37764 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-18Clean up a set of RTL-related commentsTor Lillqvist16-57/+25
It is fairly pointless to have a comment like "--- RTL --- (mirror mouse pos)" in front of code that obviously is related to RTL anyway, like "if( AllSettings::GetLayoutRTL() )". Also, the fact that many comment were exactly the same indicates that they has been added as an in-line version control change marker. In other places, comments were informational, but no need for them to include yet another metasyntax, "--- RTL ---". Just "RTL:" works fine. Change-Id: I20feef308ed8ac9d32a8bf440fc20b442753c4ff
2017-05-18Remove sfx2 include from vclMaxim Monastirsky1-4/+1
(And we don't have menus with item ids from sfx2 anymore.) Change-Id: Ic4d0f3c6a2d15cfda6498617a45ba2e25b5dd7f1
2017-05-16ExternalZoom and ExternalScroll are unusedCaolán McNamara2-38/+4
which leads to CommandWheelMode::ZOOM_SCALE becoming unused and so touch/touch.h is unnecessary Change-Id: I7cb9a4f6af2719deb0d768e35d514b59010daf79 Reviewed-on: https://gerrit.libreoffice.org/37671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-16Remove unused mpVirtDev (vcl/textview)Julien Nabet1-10/+0
Unused since commit 72edb6967f245f0c99c6a61e0ce8d0a245600cba "loplugin:unusedmethods in vcl" + remove useless EraseVirtualDevice Change-Id: I1b932bb49e9f84e3ddb5c3ab69b3d1b3131233e2 Reviewed-on: https://gerrit.libreoffice.org/37685 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-16Resolves: rhbz#1367846 improve gtk3 trackpad scrollingCaolán McNamara4-18/+12
convert number of "lines" scrolled to double and allow fractional parts of lines/columns Change-Id: Ib99c815cfc8823e22fc1d76e201903c34ed0f61b Reviewed-on: https://gerrit.libreoffice.org/37669 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-15ofz#1612 avoid oomCaolán McNamara1-0/+2
Change-Id: I2e327ea449dad8ec88963b6b9429e478a3332e22
2017-05-12Look for help-specific images in the new images_helpimg archiveKatarina Behrens1-0/+2
This requires distinguishing between 2 kinds of images: internal to help (in helpcontent2/media/ and helpcontent2/res subfolder) and external images from core repo (mostly icons) referenced in help Change-Id: If1d639c255fb802c3ee7d7eab10fc0a84324f335 Reviewed-on: https://gerrit.libreoffice.org/31417 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-05-12loplugin:constantparamNoel Grandin3-5/+2
Change-Id: I67d74072c776c32a1f91df94c621efe180baf5dc Reviewed-on: https://gerrit.libreoffice.org/37481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-12remove unused uno::Reference varsNoel Grandin4-9/+1
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-11ensure cow_wrapper contents are queried through a const pointerCaolán McNamara1-25/+25
otherwise the query will call make_unique to make this a unique copy of the underlying shared font which is a waste if the contents are going to be the same and the if branch contents are skipped. I was tempted to call the Font accessors like GetLanguage, etc. but a bunch of the accessors have two versions, a const and non-const one which behave differently so that looks like another rats nest This relates to the changes of commit 188439aac2e2e85821b4a114c1298bdf36a7b2ea Date: Fri Apr 22 23:43:52 2016 +0200 tdf#62525 vcl: use cow_wrapper for font Change-Id: Ic0661fccb414b3636308975e265fe5751476e1b8 Reviewed-on: https://gerrit.libreoffice.org/37502 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-11remove some unnecessary temporary OUStringsNoel Grandin3-11/+4
found with: git grep -nP 'OUString\(\s*\w+\s*\)' | grep -v new | grep -v return Change-Id: I923109b4339210aed2639e423fbc4d5f19233f02 Reviewed-on: https://gerrit.libreoffice.org/37463 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-10Resolves: rhbz#144437 make gnome-documents not crash the whole timeCaolán McNamara1-0/+8
accept that once initted that LibreOffice cannot be deinitted and reinited (without lots of work), but allow the main loop to quit and restart so LOKs thread can run and exit successfully, new LOK connections will restart the main loop. The buckets of global state continues to be valid the whole time this way Change-Id: Ide54c0df2ce4065f7c192ae8c2cedfaaa2b58d72 Reviewed-on: https://gerrit.libreoffice.org/37399 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke6-6/+0
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-09make loplugin constantparam smarter about string paramsNoel Grandin3-5/+4
Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294 Reviewed-on: https://gerrit.libreoffice.org/37426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09coverity#1250405 Division or modulo by float zeroCaolán McNamara1-16/+19
another stab at this Change-Id: I893f4b4a211a85718bf51bfbdb3e8bdb1df0066c Reviewed-on: https://gerrit.libreoffice.org/37405 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-09remove unnecessary empty OUString fields and varsNoel Grandin8-17/+12
Change-Id: I940120087a0bc6b1b0abc30a3e7727ce22b7d9a7 Reviewed-on: https://gerrit.libreoffice.org/37394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08vcl: split jpeg import into two partsMiklos Vajna13-37/+92
Split the import into two: 1) Just create the bitmap, this part is not thread-safe (e.g. OpenGLContext::makeCurrent() is called when OpenGL is enabled). 2) Import the image into an existing bitmap. The point is that the second part takes much more time than the first, and in the future that part may be executed on a thread, while without such a split the whole ImportJPEG() can't do that. For now GraphicFilter::ImportGraphic() simply invokes the two parts after each other, so no real functional changes yet. Change-Id: Iee742a2cd3c581aeaf1a1ed9f55cd543955a85e0 Reviewed-on: https://gerrit.libreoffice.org/37397 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-05-08Resolves: tdf#107693 move CreateAutoMnemonics from Execute to ActivateCaolán McNamara1-4/+3
Change-Id: Id65dfcc40dd20c391e12108abc6a6531e4c96523
2017-05-08cleanup tools/debug.hxx includesJochen Nitschke59-59/+0
with command > git grep -l tools/debug.hxx | xargs grep -L DBG_ | xargs sed -i '/#include *\(<\|\"\)tools\/debug.hxx.*/d' don't change files in includes/ and */pch Change-Id: Ie429d6a7dca5dfa1073e0f5ba037f7c84bdbec08 Reviewed-on: https://gerrit.libreoffice.org/37349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08hNonAliasedFont is unusedNoel Grandin1-6/+0
ever since commit e45d80f20ff6a05888f92ae942abed67609d5b20 Author: Tim Eves <tim_eves@sil.org> Date: Tue Feb 23 16:45:21 2016 +0000 "tdf#97171: Use DirectWrite for OpenGL glyph caching" Change-Id: Ib6675e89caa68a5ee725a36a0d5ded973cc98723 Reviewed-on: https://gerrit.libreoffice.org/37348 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08teach loplugin:constantparam about simple constructor callsNoel Grandin21-87/+73
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9 Reviewed-on: https://gerrit.libreoffice.org/37280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07tdf#106265 ScopedHDC to clean-up hDC when rendering glyphsTomaž Vajngerl2-6/+51
Change-Id: I96ecf625126740610200c012c3c7002fac7e1548 Reviewed-on: https://gerrit.libreoffice.org/37347 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-05-07Revert "coverity#1250405 Division or modulo by float zero"Caolán McNamara1-4/+0
This reverts commit 445ac42cc2f2f759a43d97198039b980026ed70e. Change-Id: I4f106a67385776262f187e63c445ea8c0cb0207b
2017-05-07break circular includeJochen Nitschke5-1/+8
of include/vcl/window.hxx and include/vcl/vclevent.hxx Change-Id: Iacb3cc942693a732de5899af26e08e0977a83102 Reviewed-on: https://gerrit.libreoffice.org/37338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-08 16:04:55 +0000