summaryrefslogtreecommitdiff
path: root/ucb
AgeCommit message (Collapse)AuthorFilesLines
2015-10-07clang-analyzer-deadcode.DeadStoresStephan Bergmann1-6/+2
Change-Id: Ic94b5fdcf88a9580e816aceb199753e88636810a
2015-10-07clang-analyzer-deadcode.DeadStoresStephan Bergmann1-1/+0
Change-Id: I5f5eb507e1c5bbdc8a0517244e867724249f3661
2015-10-05tdf#83531 Opening WebDAV URL WebDav fails if write is restrictedGiuseppe Castagno1-0/+22
Happened because LOCK method was not allowed without credentials. Change-Id: I7b204e67079791a08211410ced4b0b4f015d524a Reviewed-on: https://gerrit.libreoffice.org/17856 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2015-10-05tdf#82744: fix WebDAV lock/unlock behaviour - part 3Giuseppe Castagno5-77/+301
Changes done to the code in sfx2, ucbhelper, ucb, unotools in no particular order - add method helpers to call the ucb lock/unlock - add lock/unlock 'real' management - make DateChange property retrieval working for WebDAV as well - add check for changed content of a WebDAV file, in order to reload it correctly when 'Edit Mode' command is activated from GUI - Unlock WebDAV file while saving only if explicitly enabled Needed in order to avoid the small window of file unlocked state that opens while saving a file. When saving LO actually does as follows: - unlock the prevoius version of the file - prepares operations to save the modified version - lock the new file - save the new version - the lock method is enabled if the DAV resource supports it. In case the lock is not supported, for example example DAV with lock disabled, the lock method is disabled. Exception: when the resource is first created and the lock is not supported: a lock command is sent anyway, because if the resource is not yet present, there is no method to detect the lock/unlock availability in this case. - cppcheck:noExplicitConstructor Change-Id: I0aa876c4e3364d86e5740977b97f3db9a01e4491 Reviewed-on: https://gerrit.libreoffice.org/17189 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2015-10-01remove old standalone Sun bug numbersNoel Grandin6-9/+8
Sun bug numbers without any accompanying text are completely useless. Fixed with git grep -lP '//\s*#\d+#\s*$' | xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print' And then hand-checking the result to restore places where it deleted code. And then some more grepping and hand-editing to kill the others. Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29 Reviewed-on: https://gerrit.libreoffice.org/19023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini4-6/+6
Change-Id: I3926eca56ac9f54f9ddbf88610888ce97cf00b34 Reviewed-on: https://gerrit.libreoffice.org/18990 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-29loplugin:removeunusedmethods, remove unused stuffNoel Grandin1-11/+0
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-24boost->stdCaolán McNamara4-28/+28
Change-Id: I24ecb1173af3711dfd6e8a9284f5d7a095d9c544 Reviewed-on: https://gerrit.libreoffice.org/18819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-23boost::scoped_ptr->std::unique_ptrCaolán McNamara9-42/+40
Change-Id: I03020e3536ee692a96224a517794c0d0a294f607 Reviewed-on: https://gerrit.libreoffice.org/18793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17"unnamed namespaces don't work well yet" is no longer trueStephan Bergmann1-6/+3
Change-Id: I7a04c2d04e3fc52982d83119755e0b349d232a47
2015-09-16Related rhbz#1259746: Buffer file content read from GIO UCPStephan Bergmann3-35/+13
...for one, this avoids sending seek requests down the GIO/GVFS stack, which can silently fail with corrupt data read from certain broken servers for current versions of the GIO/GVFS stack; for another, it should considerably speed up loading documents via the GIO UCP, as LO's document type detection is notorious for issuing lots of seek and (small-chunk and/or re-) read operations on a file. (This issue has become more relevant after 51e0d789c344547956764c3b5f0ef5a304f4e0aa "rhbz#1134285: Access dav, davs URLs via GVFS," where the old route via the WebDAV UCP was apparently not affected by those broken servers, so happened to start affecting opening certain remote files in LO via Nautilus.) Change-Id: I91f91128b2d1a16f976eafeacf216a91747f4df1
2015-09-10ucb: fix another duplicate WeakImplHelper<XInteractionRequest>Michael Stahl3-34/+19
Change-Id: I0728601cd7abd8f8d718728d5983aed94355bdc0
2015-09-10ucb: fix mergedlib duplicate WeakImplHelper<XInteractionRequest>Michael Stahl3-36/+20
Change-Id: I0666bb38e43240a0cbd972a141ecc36573c2ad6a
2015-09-09ucb: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe21-58/+55
with the variadic variants. Change-Id: I0e4c7e26af86806e75bb75b7eb6c70b57e1c9514 Reviewed-on: https://gerrit.libreoffice.org/18427 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-02ditch gnome-vfs2 supportCaolán McNamara11-3407/+0
Change-Id: I882c04fd3a255f55511b1884157de26e7574e6db Reviewed-on: https://gerrit.libreoffice.org/18262 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann10-52/+52
Change-Id: I18420ed24918d77be30a1b4b3a7d55f5299fb82e
2015-08-27Add vnd.sun.star.webdavs URL schemeStephan Bergmann6-3/+40
...as https-equivalent to complement vnd.sun.star.webdav scheme. See the mail thread starting at <http://lists.freedesktop.org/archives/libreoffice/2015-August/069929.html> "What autogen.sh for an alternative ContentProvider for dav:// scheme?" for why it is considered beneficial to have the WebDAV UCP support---in addition to the standard pair of http[s] schemes---a non-standard pair of vnd.sun.star.webdav[s] schemes different from the "accidentally supported" non-standard pair of dav[s]. Change-Id: I7032aa1ed599f735969cf0163cd9dc121a1fdcb3
2015-08-27Apply webdav-neon/ fix to webdav/, tooStephan Bergmann1-3/+7
cf. 9228f41209b1a043e4ec29af8c2f71bb5ad7f798 "Missing davs URL scheme handling" Change-Id: Ia161691cc213b5b2c1a3a589ce05b6ad8558013c
2015-08-27Missing davs URL scheme handlingStephan Bergmann1-3/+7
...looks like it was just forgotten in e557f06cb172dfa5ca04d215226b30e8ca4af4aa "INTEGRATION: CWS tkr10: i84676 neon and gnome-vfs2"? Change-Id: I1bae95273f43e58425181bbc4667f87a6389e3a9
2015-08-27Clean up initialization of UcbPropertiesManager::m_pPropsStephan Bergmann2-311/+150
(which is a single-instance service, so there is likely no benefit in initializing it lazily anyway) Change-Id: Ie7e8272f11372149391a1190d5e71137dddaa03b Reviewed-on: https://gerrit.libreoffice.org/18016 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-08-21remove last WeakImplHelper8 usesCaolán McNamara2-7/+5
Change-Id: I7ecadedb77832fb3073870880dbfba121fdae826
2015-08-21loplugin: defaultparamsNoel Grandin5-8/+7
Change-Id: If1d183f32079548645b4974a16161dc997c026b7
2015-08-19Consolidate isFileUrl checksStephan Bergmann1-1/+2
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
2015-08-18cppcheck:noExplicitConstructor in webdav, serf versionGiuseppe Castagno3-17/+5
Explicitly add constructors that where previously hidden. The right implementation of what I did in aade7198d72bc4ddb18f10729b89f0435e6ca197. The explict keyword was added in 6343754e310a589cb49e2a1da0cd68472571179d Change-Id: I66f6ee51c8b51d93d6ac673e75555e13024e4b48 Reviewed-on: https://gerrit.libreoffice.org/17823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-08-17Clean up reinterpret_castsStephan Bergmann1-17/+6
Change-Id: Idd25acf645af7f99e332ec1d5431f7988408675d
2015-08-17loplugin:cstylecastStephan Bergmann2-6/+5
Change-Id: I32a9feb5851691b02475e9eb5dbb024d3330b232
2015-08-17cppcheck:noExplicitConstructorGiuseppe Castagno2-1/+13
Added a constructor and a method there were missing. The explict keyword was added in 6343754e310a589cb49e2a1da0cd68472571179d Change-Id: Iaff33eba8581dc201a8e899c7be024e87f8e6b0e Reviewed-on: https://gerrit.libreoffice.org/17781 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-14CMIS: remember new session for each userSzymon Kłos5-10/+29
Change-Id: I7d0a72e48b8f9056e8761cae8939e2b8f6dbdd24
2015-08-07cppcheck:noExplicitConstructorNoel Grandin8-14/+13
Change-Id: I2717d3d120df8af5b7e9af8d147a57b9f5b5ecbe
2015-08-05loplugin:unusedmethodsNoel Grandin1-4/+0
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba Reviewed-on: https://gerrit.libreoffice.org/17506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03inline some use-once typedefsNoel Grandin1-6/+3
Change-Id: I02cbbba56a2ad83e0ac3d806265a7e0d6a29594d Reviewed-on: https://gerrit.libreoffice.org/17495 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03remove some unused typedefsNoel Grandin1-1/+0
Change-Id: I98c1e7eaa66b7afb05255a017a3de54714637501 Reviewed-on: https://gerrit.libreoffice.org/17491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03new loplugin: refcountingNoel Grandin2-4/+3
This was a feature requested by mmeeks, as a result of tdf#92611. It validates that things that extend XInterface are not directly heap/stack-allocated, but have their lifecycle managed via css::uno::Reference or rtl::Reference. Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692 Reviewed-on: https://gerrit.libreoffice.org/16924 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-30loplugin:unusedmethodsNoel Grandin2-19/+0
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-27loplugin:cstylecastNoel Grandin4-8/+5
Change-Id: I21fd75b3c891d98f6ad1e4c8af985c2cd21c7db4
2015-07-27loplugin:staticmethodsNoel Grandin4-12/+12
Change-Id: Iab1eda788690366bfc03ba7c4f085cb474fef1b8
2015-07-27loplugin:loopvartoosmallNoel Grandin1-1/+1
Change-Id: I9114a7dd3eae7a76432655c4459a7326bb1908f4
2015-07-27loplugin:simplifyboolNoel Grandin2-8/+4
Change-Id: Id57ee3c09b11c3ce4820ed06a15f13866a10f19a
2015-07-27loplugin:stringconstantNoel Grandin5-19/+20
Change-Id: I95765e9c26e393a838ee0c617fde415e6c50e884
2015-07-27fix --with-webdav=serf buildNoel Grandin1-1/+1
fallout from the conversion to variadic WeakImplHelper template Change-Id: I1ff6b4aa0b574bbd4787f548e0bc4bf51b211aba
2015-07-27inline a bunch of use-once macrosNoel Grandin11-56/+19
no point in having a macro unless it's actually going to reduce the number of lines of code Change-Id: Ic8760d6506cf272d7bd088f7b3b4dcbf288099fc
2015-07-27remove some unused definesNoel Grandin4-19/+4
Change-Id: Ib2d50e8c29ccbc5ffcb52cdff4ae3eaae9a62188 Reviewed-on: https://gerrit.libreoffice.org/17332 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-23inline a handful of use-once #definesNoel Grandin4-59/+28
Change-Id: Id2654555c4042f8c0bdbd6bab6507e705f08326b
2015-07-22tdf#82744: fix WebDAV lock/unlock behaviour - part 1Giuseppe Castagno2-18/+91
There are some areas in ucb outside the issue scope that should later be addressed, among them: - in ucb/webdav make flag m_bTransient working right, currently lock option for WebDAV server not supporting it is suboptimal: there are not needed lock requests; - change the method the modified file is checked against the old one, using DAV:etag instead of the DateTime; - some http status code returned by the server don't seem to be managed; - during WebDAV operation some redundant request of properties is carried out. Probably some clean up to remove these not needed transactions is to be done. Accessing only those really supported by the referenced href would be better. Changes done to the code in ucb, in no particular order - remove current WebDAV lock management - have the lock/unlock working correctly when the webdav resource is first created: in the case of creation is the first lock on the non existent resource that actually creates it - fix a problem while fetching WebDAV properties. If a single WebDAV non-cached property was requested, it would not be fetched from the server without this fix. - change the lock owner name. This should probably be different. Something to be discussed. This same string can be read by all the applications accessing the lock. Spec reference is: RFC4918 [2007]: '14.17. owner XML Element' link (as of 20150713): http://tools.ietf.org/html/rfc4918#section-14.17 - manage WebDAV locked file exception directly while locking. The ucb::InteractiveLockingLockedException is thrown directly when detected by the lock command, to avoid the user interaction activated by the cancelCommandExecution method. - terminate gracefully if WebDAV lock/unlock is not supported Change-Id: I4c5cd652ac7b2c32fb1c3307c34fc31d1a0305c2 Reviewed-on: https://gerrit.libreoffice.org/17080 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-20cmis: throw an error if we were not able to open repositoryVasily Melenchuk2-12/+52
It was an crash before, if we have stored CMIS url with repository that does not exist. Session was created, but with empty repo. Now this nuance is checked and slightly improved error reporting for cmis. Change-Id: I447ec767fd735829f8a507733552b26e05cba441 Reviewed-on: https://gerrit.libreoffice.org/17224 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-07-16loplugin:simplifyboolStephan Bergmann2-2/+2
Change-Id: I164b62e2c98fad49d581b2ee282b6329b83bdbfb
2015-07-16If user cancels authorization, don't show login dialog againSzymon Kłos1-0/+5
Change-Id: I4b110c041f1b8908fdfeeec3b4544f8607f23ddb
2015-07-16PlaceEditDialog: only one error after failed authSzymon Kłos1-1/+5
Change-Id: I215de03282b3692ebfdc6a7a0e9fd02ecc04f722
2015-07-16tdf#84190 : when auth fails, don't remember passwords for cmisSzymon Kłos2-3/+3
Change-Id: Ia1e0d553556693e0efa6de0bfc6f8b0ae9d40b5d
2015-07-16PlaceEditDialog: temporary error box (showing when auth failed)Szymon Kłos1-0/+1
Change-Id: I614c62df60e4da4f6bb36438cbd3360484cd518c
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-09 10:56:44 +0000