summaryrefslogtreecommitdiff
path: root/ucb
AgeCommit message (Collapse)AuthorFilesLines
2016-05-16tdf#87938 libcmis: Google 2FA implementationSzymon Kłos4-0/+52
2 Factor Authentication for Google Drive, changes: + parsing additional page with challenge - pin code verification + calling the interaction dialog requesting the code + dialog title changed to more general: Authentication Code + dialog shows url field only if not empty Change-Id: Idb3ebbad6a12849b9e50af87b46324bfbe966bab Reviewed-on: https://gerrit.libreoffice.org/25002 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-05-13clang-tidy modernize-loop-convert in toolkit to uuiNoel Grandin8-37/+30
Change-Id: I805aa1389ef8dde158f0b776d6b59579fa3082e4 Reviewed-on: https://gerrit.libreoffice.org/24921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Assign 0 explicitly, avoiding intermediate downcastsMatteo Casalin1-1/+1
Change-Id: I43a9adeaf7078551a3447032fbf65affab817b15
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann3-6/+6
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-06tdf#99426 Use correct path for lock in PUT methodGiuseppe Castagno1-1/+7
Change-Id: I2091024a601bebede5d2fb8596dda1054ca4ef3b Reviewed-on: https://gerrit.libreoffice.org/24691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin2-6/+6
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04use Any constructor instead of temporariesNoel Grandin8-65/+25
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-03tdf#98644 : better error message when wrong password enteredSzymon Kłos2-92/+123
Change-Id: Idf4da8000cce43cb66cb94fdfc8be8a3d6909fa6 Reviewed-on: https://gerrit.libreoffice.org/23475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-28teach stylepolice plugin about ref-counted-pointer namingNoel Grandin1-12/+12
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-25Some more sal_Bool -> boolStephan Bergmann1-1/+1
Change-Id: I974a1c8d64f5b13b9052365c3219dcd2dc6927dc
2016-04-22Related tdf#88502 a better implementation than the one in...Giuseppe Castagno1-23/+1
...commit 70bb8c257e7fc402da60fa70109cece1fe4c69d1. This commit reverts previous implementation in commit 70bb8c257e7fc402da60fa70109cece1fe4c69d1 and makes use of a dedicated interaction wrapper instead. See comphelper::SimpleFileAccessInteraction for details. Change-Id: Ia037ea14267afaf66d8f9aa2324649264a7cb4bf Reviewed-on: https://gerrit.libreoffice.org/24275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-21new plugin stylepoliceNoel Grandin3-15/+15
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann16-97/+97
Change-Id: Ib340ec1731cba5a4409f0e8d8bdde48753312672
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin1-2/+1
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke5-28/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-15Related tdf#88502 Add default XCommandEnvironment to ...Giuseppe Castagno1-1/+23
... Content::getResourceType During WebDAV operation the css::ucb::XCommandEnvironment is almost always needed. Depending on the operation, sometimes the client doesn't set it, in order to disable the exception processing that takes part in ucbhelper::cancelCommandExecution. Change-Id: Ib4bf6a7ca3a902437cab9050c3e310342c655ff2 Reviewed-on: https://gerrit.libreoffice.org/23327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin9-32/+32
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in ucbNoel Grandin10-12/+12
Change-Id: I4ba18c767c67c9c8d23aac3f8de728b7a229804d
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke5-15/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: Ie25240030fd848a5b30526746206bfd5fe543091
2016-04-05These are SAL_INFO, at bestStephan Bergmann1-2/+2
Change-Id: I2f4c34de154aa71db721dc30da29173d6c37709f
2016-04-05loplugin:constantparam in ucbNoel Grandin9-49/+21
Change-Id: Ifa36b58a36232e6333a1c85d85d0372fb0de219b Reviewed-on: https://gerrit.libreoffice.org/23829 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04unnecessary reallocNoel Grandin2-14/+12
Change-Id: Iafd6495a8b6a2b371cf004e4383ed92ac6ae4bd2 Reviewed-on: https://gerrit.libreoffice.org/23760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke5-13/+0
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin5-9/+9
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-30loplugin:nullptr: Find some more cases in templatesStephan Bergmann1-2/+2
Change-Id: I1f127d56e40b04f2b4df85c0afbcfd424d68a8cc
2016-03-29Avoid reserved identifiersStephan Bergmann2-20/+20
Change-Id: I210133e82bc72dcb89da5f7700314ddcf6bee269
2016-03-18Remaining argument from loplugin:constantparam in ucbKorrawit Pruegsanusak1-1/+1
Still one remaining after b47cb646ff2a62fcd3fac0e453a7261bbaefbcb7 Change-Id: If1dfaa6bbc9f8582f7b2a7dab49815a0a4c6a7b8 Reviewed-on: https://gerrit.libreoffice.org/23355 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-18Restore WebDAV credential dialog functionality...Giuseppe Castagno1-1/+0
...that was broken in 3d264450989cecdc59a2e64f46a0328432ba0d08. Change-Id: Icd601196867258490f9241efc3d0d6ebea334a2a Reviewed-on: https://gerrit.libreoffice.org/23353 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16loplugin:constantfunction in ucbhelperNoel Grandin5-11/+6
Change-Id: I80e00b5ac2621378801f89532ed88b377ef72b60 Reviewed-on: https://gerrit.libreoffice.org/23297 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-15loplugin:constantparamNoel Grandin4-7/+7
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-15tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar1-22/+7
I removed OSL_DEBUG_LEVEL > 1 conditionals and the g_warning() with SAL_INFO() and SAL_WARN Change-Id: Icb4ab72245111b52c59a47cc659dfdb79d5690ee Reviewed-on: https://gerrit.libreoffice.org/23232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-14inline some use-once macrosNoel Grandin2-4/+1
Change-Id: I7ebd8fe70b083a772118a1aab8cdfbf795d6f1e5 Reviewed-on: https://gerrit.libreoffice.org/23235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-11tdf#97966 redundant static keywords removed 6Wastack1-3/+3
Change-Id: Iaf034f3b2282a973f6503edea41cb3184543fb11 Reviewed-on: https://gerrit.libreoffice.org/23133 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-10Avoid reserved identifiersStephan Bergmann1-10/+10
Change-Id: Ic2c7cc2a78e8e58c3ca28acd9b6a35ddaceeab60
2016-03-10Avoid reserved identifierStephan Bergmann1-1/+1
Change-Id: I4d0dc49e44b9e9f7504008ea1d10876cd80e76f8
2016-03-10Avoid reserved identifierStephan Bergmann1-2/+2
Change-Id: I6c60905541de56229bc26e9dc6e589d4099e9266
2016-03-10Avoid reserved identifiersStephan Bergmann1-4/+4
Change-Id: I75158ff7588452f38306b0bed351a6532b9c8d1f
2016-03-10Make CppunitTest name match *.mk file nameStephan Bergmann1-9/+9
...so "make CppunitTest_ucb_webdav_local_neon" works as expected. Change-Id: Iecdd5d1ad19be4789bca60d455a3dfdd8fee9cb3
2016-03-10These tests can just derive from plain CppUnit::TestFixtureStephan Bergmann1-18/+3
...and then no longer need to override any base class setUp/tearDown Change-Id: Iaea19dfb341325bb45062d0ac0b5fa1eed0d34e0
2016-03-09loplugin:constantparams in ucbNoel Grandin3-23/+7
Change-Id: I6b925336b13404ccf0f78f194bd3488a22f99b97
2016-03-08follow the boost lib naming scheme for DateTime tooDavid Tardon1-1/+1
Change-Id: Iae7967bd5f161ecbe888824a4bcb9b87ec8d947a
2016-03-07tdf#97499 Remove some Default arguments in unordered containerJaskaran1-1/+1
Change-Id: Ic008e244b8ae1888fa45379371f5525ee77f6087 Reviewed-on: https://gerrit.libreoffice.org/22887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-07loplugin:unuseddefaultparamsNoel Grandin1-8/+4
Change-Id: Ia414f7845425ef73859ed04853378e96cc738795 Reviewed-on: https://gerrit.libreoffice.org/22971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07improve defaultparams lopluginNoel Grandin2-8/+4
to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-03loplugin:stringconstantStephan Bergmann1-1/+1
Change-Id: I1a594a3d62790125244d221aeaa6d989adf30d97
2016-03-03ucb: replace boost::bind with C++11 lambdasMichael Stahl1-5/+1
... and remove now unused comphelper::TNamedValueEqualFunctor. Change-Id: Ia6cac4ae4e34d2ba134e2f2a4a5b4daea58bf0b3
2016-02-29loplugin:unuseddefaultparam in ucbNoel Grandin5-37/+18
Change-Id: Ie0ea0b4dc13271a2bde5e3843bb3f8042ab880b4
2016-02-23new loplugin: commaoperatorNoel Grandin2-10/+10
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-19new loplugin: find write-only fieldsNoel Grandin1-2/+0
Change-Id: I0f83939babacf92485420ee63f290a297d7cb717 Reviewed-on: https://gerrit.libreoffice.org/22498 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>