Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: Ibdc7e7432d7ce48473e16298fdb8eddea5241938
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102541
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id9c326d28cf7049e692108cdeccef6714c142e2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102540
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
- make it final for starters
- dont use GetRegistered() variants to prepare removal of
SwClient/SwModify
- dont use CheckRegistration() as the observed format should never die
Change-Id: I9bfb587e5e88896eb36d2da6edcf4f41a93195cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102500
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
|
|
Change-Id: Ifd43ff792612baba104d4cf09e3ee9bb6ed1c7a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102409
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
|
|
author Noel Grandin <noelgrandin@gmail.com> 2020-09-12 08:15:30 +0200
committer Noel Grandin <noel.grandin@collabora.co.uk> 2020-09-12 13:35:16 +0200
commit d52674ad92172ce67c94b5970668aeb00d1c6ac5 (patch)
tree e4011c86f470c710fa80b22edfe081ddd2475adf
parent 286a7f3ec8976761f3e796e13b374700063dbc4b (diff)
std::list->vector in SwTable
Change-Id: I6c3db995750de65f2255d7a39323d9d7594d1aff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102539
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
Change-Id: I603ddde15c869a66b05c18815326931fbcfd9076
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102537
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I9ee4ffd9a54fc62a9fa8d8f15dc90d458d87bbc1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102520
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: If4209f165912f5026d8bb2c311314dba8aaba1ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102518
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
+ remove sal_Char check on compilerplugins
Change-Id: I0f7da14e620f0c3d031d038aa8345ba4080fb3e9
Change-Id: Ia6dba4f27b47bc9e0c89159182ad80a5aee17166
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102499
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I4bd23ef011e002133c01dcfcab13b5a100926e04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102507
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Handle css::text::PositionAndSpaceMode::LABEL_WIDTH_AND_POSITION
Change-Id: I5024359b1a34b0ebb63165ace5e517dd90994faa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102510
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I8f0f03a3ea0eafda166d19a5cd9fa24e97345a69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102399
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Change-Id: Ica93ad739eb32372addc01e1c72804e33d8ce819
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102508
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I6b2579c6c92f0090fe7bee732ab6c8571272e9b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102454
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
Change-Id: If38daeb35ae8ba09aac50490a15c66dc0650f784
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102485
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ie6fd0f0e9894f2795e87580e00f4d75272bb3c68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102462
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
which wasn't exported.
Note: the enlarged monolithic export function was
split in the following new functions:
- WriteOLEShape() exports the replacement shape of
the OLE object.
- GetOLEStyle() returns the string value of the
style attribute.
- ExportOLESurround() handles the surround settings.
Also add GetVMLShapeTypeDefinition() to reuse picture
frame VML formula string used by VMLExport.
Co-authored-by: Arató Dániel (NISZ)
Change-Id: I29800a50c60a824a14849ac286a18e5e2f97c689
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102034
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
(resulting for example, invisible shapes).
Co-authored-by: Szabolcs Tóth
Change-Id: I328514022f4a594c374d5a97db39d1cf3a954e02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102195
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
From-scratch `make CppunitTest_sw_core_layout` had failed for me on Linux with
> warn:vcl.builder:1528301:1528301:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder
> when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/svt/ui/editcontrol.ui xmlreader/source/xmlreader.cxx:66
and
> warn:vcl.builder:1529052:1529052:vcl/source/window/builder.cxx:467: DBG_UNHANDLED_EXCEPTION in VclBuilder
> when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///.../instdir/share/config/soffice.cfg/svx/ui/sidebarstylespanel.ui xmlreader/source/xmlreader.cxx:66
Change-Id: I021cf45a61a894a88aee64110a9b9ea8f7a20888
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102452
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I1963a5d899da2d122e60c4d87ca32aba4fb1f32a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102449
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Ie0ecacb69b1e99ca52abd9038baa176be8383661
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102404
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
The text wrap distance (also sometimes called "margin") of
OLE VML icons used to be thrown away when a .docx file is opened.
Change-Id: I79837421470dde5e68e916f87924b170ebf1d734
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102159
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
The default style was not being imported because it
was based on itself, and therefore deduplicated itself away,
or something like that.
Probably this is the only scenario that truly would
end up deduplicating itself, but I made it generic
just in case. Why not?
Change-Id: I621092bf2e067933b5d23d27689a5d3a7f8cf2bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102328
Tested-by: Jenkins
Tested-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
Change-Id: I58090ced672267614ade2e3e81e6264d01b77901
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102405
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I0ec82de4932f4200aeb7cf778bf93dd9d1c28eda
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102402
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
...that were added with the same name UITest_options in
107af098311beafaadb343c5a3634389f56006a0 "uitest for bug tdf#117458" and
ec914194382654aa4b0ad9973acc0eed15a4ab43 "add uitest for bug tdf#78133",
respectively
Change-Id: I31a967d2ce14f86d91951a836b694f360802c5a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102391
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
This reverts commit 5ad17c85dc93973c0cbb1d633b9eed144f0677de
for the benefit of all mankind, and specifically tdf#136644.
Reason for revert: LO's UI for this is totally messed up,
so I want to completely get out of anything to do with
numbering/bullets.
It is inconsistent with how it handles default tab stops
(delete all when none are shown and things act different),
it doesn't always increment levels properly,
and does all kinds of weird things.
Change-Id: Ifaf8c3a7c9ac30b7103b82dd119cb4629f0b2578
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102415
Tested-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
since...
commit c4ea034beb2fa0f1e874a39391a9498bdd7c7aad
Date: Tue Sep 1 16:43:20 2020 -0300
tdf#118148 Extended tips for HC2/swriter
Change-Id: Ifa76663c52e880c9ab11ed0d32370405a77135f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102386
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I440e70b51a75a19e18d5f5d4df24fb2402d239de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102385
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Goes from more than 30s to less than 1s on my pc.
We were getting stuck inside the loop in sw::UndoManager::AddUndoAction,
because the RemoveOldestUndoAction was continually doing nothing because
it was hitting the
if ( IsInListAction()
{
assert(!"SfxUndoManager::RemoveOldestUndoActions: cannot remove a
not-yet-closed list action!");
return;
}
code.
Which means that there is some bug here, but I'm not sure what. We are
deep inside the delete logic at that point, and it doesn't seem
unreasonable to opportunistically delete some of the UNDO list at that
point.
So the real fix is just the conversion from a while loop to an if-check.
Change-Id: Ie2707009dd6574b996421f67d952ab9fdaaaf6aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102378
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
I'm reusing the test for tdf#93068.
We already have other tests where the Character dialog
is used so a test only testing the dialog opens is
recurrent
Change-Id: I5b75be6a2b4ccef9a794be76f089a70ec0903665
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102369
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
LEFT and RIGHT by converting them to Writer cell ranges.
These ranges start at the first cell above/below/right/left
(including empty cells or cells with text content!) and end
at the end of the first value cell range. If there is no
value cell range, they end at the table border.
Note: In MSO, table functions COUNT(), AVERAGE() etc. use
non-value cells, as zero with ABOVE, BELOW, LEFT and RIGHT,
but skip them using A1:A10 like range names.
Change-Id: I906f27ecccaa8ded5460cd861ef8808000722860
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102320
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
sometimes it doesn't happen to crash, but its always dereferencing
a deleted frame
Change-Id: I056808398c97c5de12542c6c342e7d9d7e5195d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102334
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I66e36a638d040d2a38ac234383d6f314a2ff4d88
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102368
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
because of empty namespace and prefix
Change-Id: I5710e15c38fa5d22ca2dc7c875c2d9b1076fa93d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102365
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Maybe I'm missing something, but its usage -
"if ( !GetExport() && !GetHidden() )" seems like expects
it to be true and false at the same time. Anyway, there's
no diff in workdir/SdiTarget after this change, so should
be safe to remove.
Change-Id: I6db508ff40c05dc828ffa91bb41a37c17b697503
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102345
Tested-by: Jenkins
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
|
|
Change-Id: Ib7a8eb77b31a8abb08be501b1e0ce8d480f163c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102340
Tested-by: Jenkins
Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
|
|
... until such a time when the underlying problem of
textbox position not syncing with the moved frame is fixed.
Bug 77794 moved the frame to the correct position,
but the text only followed when going to the frame property,
looking at the values, and pressing OK.
So, it seems like the layout is re-positioning the frame,
but that frame change is not being synchronized back
to the paired up textbox.
Since I couldn't figure out how to resolve that,
I'm just temporarily avoiding the problem
that my 7.1 change for tdf#77794 has exposed.
That means that the textbox/frame is in the wrong position
(same as in previous LO versions), but at least the
text is inside of the frame.
Change-Id: I7dc712c613b164317bc4adf19ac231488d610c95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102258
Tested-by: Justin Luth <justin_luth@sil.org>
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
The only thing that a style needs to be valid is a name.
In this case, there was no name imported, so the
exception killed the import of the rest of the styles.
As a test, I forced the empty name to "junk"
and that also worked, so I am fairly confident
that this is all that is necessary to prevent
an exception.
This improves on 7.1 commit for tdf#68326.
NOTE: this unit test does prove that LO is not importing
the Normal style at all. It should import with
fontsize 32. So a proper reading of the RTF file
would also have solved the bug.
Change-Id: I9258bf985a501952dcd5aa52e54f920c99e509f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102315
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
Change-Id: I52541e74a07fa2decdae75b8a6f145432ac7e114
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102292
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
::finishParagraph normally resets this, but it exited
early because of m_bDiscardHeaderFooter, so the setting
spilled over into the following paragraph.
This is a bit of a bandaid - likely stacks of paragraphs
and sections need to be used so each can hold its
own settings and not worry about them being clobbered.
But this particular case seems to a single level problem,
isolated to headers/footers, so the change should
both be enough and regression-safe.
Change-Id: I84c9a5d6bf95c35c4996a9b31e53f18c05ade727
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102314
Tested-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
LEFT, RIGHT,and OPTIMAL all can legitimately use contour wrap,
so don't reset it to PARALLEL unless it is currently NONE
or THROUGH. (And in that case, the UI already has contour
hidden, but just to keep each part individually correct,
it seems to make sense to check for that case.)
The original import included the dead code
if (nSurround == SURROUND_THROUGH)
nSurround = SURROUND_PARALLEL;
which probably ought to have been
if (nOldSurround == SURROUND_THROUGH)
So that tells me that someone was at least thinking about
the situation, but very poorly implemented it.
Indeed, several followup patches add nOldSurround code,
but unfortunately they didn't catch this situation.
Change-Id: I971a31582ec600bc3416bef46ba17e7b0c3a6543
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101947
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
All these new test suites are named in a way, so that in case the fix is
in sw/source/foo/bar/, then the matching test suite is sw_foo_bar.
Rename to this schema, so next time a bug is fixed in that directory, we
don't need to add a new suite.
Change-Id: I968711754cb587cc2f97fff6431be416b477728f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102274
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I56c157e9e8c5b5ea6eb64ea1eac6fed40e3b97cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102265
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
to find any global variable, was checking the wrong property of
VarDecl
Change-Id: I454b4e0c1701bb0771768a1ee10cd738c4ab0726
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102278
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
SvxSearchItem is very expensive to construct, so move it outside the
primary loop.
This takes the time from 6s to 3s for me.
Change-Id: Ie6491761e69c4f787910d7ecfbd071b7e68efd35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102231
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This is a followup to much earlier
commit a9afa89e953f0f32acf26b143717e7d067cbc75a
This serves two purposes. It helps to prevent regressions
and it allows focus on features that still don't export properly.
A few more DO export, but things like lazy-load are
just testing load-related things, so skipped a few
that didn't seem to have any value in being round-tripped.
Change-Id: I718e3c09074e7b52d8e83dc9a659f6439ce17d3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102073
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
Change-Id: Ibd0fac93fccce6c9e1da02794f880bb73c2433d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102242
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
and move one test to sw_uiwriter. It fits more there
Change-Id: I335b83936f9570d18fe14be860cbc4818eaf0007
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102246
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
and if the test fails, move it to sw_ooxmlimport2
Change-Id: I2fb18f9cef40ba502ee4d719de543b5e78cd31d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102241
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|