summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2017-06-09use comphelper::InitPropertySequence in more placesNoel Grandin2-7/+6
Change-Id: I72d7b13a23ce306b752b39187a0e9fbb7028643a Reviewed-on: https://gerrit.libreoffice.org/38606 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-08remove some unnecessary use of OUStringBufferNoel Grandin1-1/+1
Change-Id: Ia4e02589d2fe79a27b83200a0e7a528a2c806519 Reviewed-on: https://gerrit.libreoffice.org/38508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-07Exporting EditEngine document into a buffer with ODF FilterVarun Dhall1-2/+1
Change-Id: Ib0304de5d873ac833dcc121235b8de494a1bb3bf Reviewed-on: https://gerrit.libreoffice.org/37999 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-06Eliminate dynamic_cast<const SfxVoidItem*>, use SfxPoolItem::IsVoidItem()Eike Rathke2-2/+2
Change-Id: I09dafffd64dd107e802d016494d884f32363521a
2017-06-06add COVERITY_NOEXCEPT_FALSECaolán McNamara1-1/+1
to markup dtors that coverity warns might throw exceptions which won't throw in practice, or where std::terminate is an acceptable response if they do Change-Id: I32b94814e8245372e1d1dc36be0d81e3564042f4 Reviewed-on: https://gerrit.libreoffice.org/38318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-06tdf#39674 Translate some German variable/function namesJohnny_M4-36/+36
No functional change is intended. Change-Id: Ib693d5f15bb279e8fe6771e3a64a976b53c6d13d Reviewed-on: https://gerrit.libreoffice.org/38391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-05Improved loplugin:cstylecast to reference types: svxStephan Bergmann18-78/+76
Change-Id: Idb58ca86ea6c0593283c455880ca7c0e99983c60
2017-06-05Improved loplugin:redundantcast, const/static_cast combinations: svxStephan Bergmann1-5/+5
Change-Id: Iad640d9b2b7b2dea7b991d563cb32fd9c70ea695
2017-06-05Remove all allocation of VCLExternalSolarLock.Arnaud Versini2-10/+10
This patch is graciously offered by Arnaud Versini. Change-Id: I3ed5e1758d09542a2ca0533e3f4a6ceb2dbb6346 Reviewed-on: https://gerrit.libreoffice.org/38404 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-05clang-tidy performance-unnecessary-value-paramNoel Grandin3-3/+3
Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192 Reviewed-on: https://gerrit.libreoffice.org/38400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-03cleanup unused css/inspection/ and css/reportdesign includesJochen Nitschke1-1/+0
Change-Id: I123522dc1df439898dab13c2259e4116e330ad99 Reviewed-on: https://gerrit.libreoffice.org/38367 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-02Improved loplugin:redundantcast const_cast handling: svxStephan Bergmann1-1/+1
Change-Id: I6a504593e6331c75053bce4743d2671277c9204f
2017-06-02fix spelling Countour->ContourNoel Grandin3-3/+3
Change-Id: I2dd8c0dcca439d1d435bdd339f7e76d139faa98b Reviewed-on: https://gerrit.libreoffice.org/38345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-02Improved loplugin:redundantcast static_cast handling: svxStephan Bergmann2-3/+3
Change-Id: I299d53fcef4276626944cfbaefbf1bbd4ce5d5ab
2017-06-02convert GRFILTER constants to ERRCODE_GRFILTER_Noel Grandin4-20/+21
since various code mixes these constants in with ErrCode values from other code, let us just make it into real ErrCode values. Change-Id: Ifa3d0f7526172609a44e6749bed9f730ab6b1a95 Reviewed-on: https://gerrit.libreoffice.org/38313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-01merge ofa res file into svt oneCaolán McNamara3-165/+0
Change-Id: I3f22301e4301ab90e4a1090f2c47cf2403422282 Reviewed-on: https://gerrit.libreoffice.org/38309 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-01Fix typosAndrea Gelmini1-1/+1
Change-Id: Ic7fbd750321e4cfde1cfb0e04ffb545bb1f66d9c Reviewed-on: https://gerrit.libreoffice.org/37921 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-31disambiguate dual use of toolbar idsCaolán McNamara3-8/+8
for toolbar title string resource and identifier (for config) Change-Id: I2657c3cbb586a62d8075db7cb43cc064b2030f28 Reviewed-on: https://gerrit.libreoffice.org/38274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-31clang-tidy readability-redundant-control-flowNoel Grandin1-2/+0
Change-Id: I832f7ef0f1bd55e365db7e49823fe8bc30390c04 Reviewed-on: https://gerrit.libreoffice.org/38215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30Related: tdf#107961 ensure notifyhdl is unset after disposeCaolán McNamara1-2/+18
Change-Id: I69790c8d3cfffc09ee6d6c165e17823223c5058a Reviewed-on: https://gerrit.libreoffice.org/38205 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-30remove duplicate 'using namespace'Jochen Nitschke4-13/+8
Change-Id: I7f8828f677cfb588135ff75c03ffb75895773440 Reviewed-on: https://gerrit.libreoffice.org/38201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30Fix quotingStephan Bergmann1-1/+1
...broken with 020e1bff16a7bb5f401a2547d211807acd7db0fb "tdf#105204: ShellCheck nitpicks for gengal.sh" Change-Id: I5e7cd0b29be7840f0af44a028eb1c56ac7ffb33b
2017-05-30Restrict loplugin:redundantcast to "real" castsStephan Bergmann2-14/+14
Change-Id: Ifc9de898e5c9a084cbfd739625c679185c3a1534
2017-05-30missing resourcesCaolán McNamara1-0/+36
since commit 17e872c3fa87bb596ec8b263b7a2e692b927dcef Date: Fri Mar 17 13:11:27 2017 +0200 remove unused defines from HRC files in svx(1) because SdrRectObj::TakeObjNameSingul adds some numbers to ids to find other ones Change-Id: I9d0bd3686f4a60b7436950f8e80def9cc3586d9c
2017-05-30missing resourcesCaolán McNamara1-2/+20
since commit 17e872c3fa87bb596ec8b263b7a2e692b927dcef Date: Fri Mar 17 13:11:27 2017 +0200 remove unused defines from HRC files in svx(1) because SdrRectObj::TakeObjNamePlural adds some numbers to ids to find other ones Change-Id: I9d0bd3686f4a60b7436950f8e80def9cc3586d9c
2017-05-30teach redundantcast plugin about functional castsNoel Grandin14-15/+15
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0 Reviewed-on: https://gerrit.libreoffice.org/37910 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-28aAttr is now (more obviously) unusedCaolán McNamara1-9/+0
Change-Id: Icf646cbb10921cc8673e22c7028e896c1c4aa036
2017-05-28coverity#704341 Logically dead codeCaolán McNamara1-18/+1
Change-Id: I1986daab3ec6576ac1b7d65f5944bbf21cd450b3
2017-05-28remove unnecessary use of OString::getStrNoel Grandin4-65/+26
Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-26coverity#1409894 Dereference after null checkCaolán McNamara1-1/+1
Change-Id: If475a0415c9faf98c978576743dbfdaa79d16d3f
2017-05-25loplugin:constantparamNoel Grandin1-3/+2
add the results files so I can just see the diff in future Change-Id: Ia20a1aa6418be95ed620719cde340c00b7b053e1 Reviewed-on: https://gerrit.libreoffice.org/37988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-24tdf#107008 Pass char style names to NBOTypeMgrBaseMaxim Monastirsky1-9/+10
Change-Id: I26db31b8f9db968aa33b92a4abe917ac20cd5844 Reviewed-on: https://gerrit.libreoffice.org/37963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-05-23tdf#107731 New default red and yellow for font and highlight colorYousuf Philips1-2/+2
Change-Id: Ide81a7a3fce963a13b5c65861f566878ccb15676 Reviewed-on: https://gerrit.libreoffice.org/37884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-05-23enhance useuniqueptr lopluginNoel Grandin2-4/+3
teach it to look for the following sequence in a destructor: delete m_pfoo; m_pfoo = nullptr; Change-Id: Icd6271a63a024e32b53cc9e599f8f59952160380 Reviewed-on: https://gerrit.libreoffice.org/37900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-22Fix the from-German translation of "UNO binding"Johnny_M2-2/+2
As noted in the comment in https://gerrit.libreoffice.org/#/c/37839/3/forms/source/component/EventThread.hxx, this improves translation of "UNO-Anbindung" to the computing-specific term of "UNO binding" instead of "UNO connection". (All occurrences are translations, most of them by me.) Change-Id: I84daf94a0248e53010a569b1d3140c4394adce54 Reviewed-on: https://gerrit.libreoffice.org/37917 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-22Resolves: tdf#107981 SID_FM_CTL_PROPERTIES colorbox needs a 'default' entryCaolán McNamara2-0/+14
we don't need MakeHexStr either, the colorbox will do that on its own Change-Id: Ifad523092c0f15cd51d0d829790c0cec1c96bb53 Reviewed-on: https://gerrit.libreoffice.org/37898 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-20tdf#105204: ShellCheck nitpicks for gengal.shYeliz Taneroğlu1-11/+11
Use $(STATEMENT) instead of legacy `STATEMENT`. Double quote to prevent globbing and word splitting. Double quote array expansions to avoid re-splitting elements. Change-Id: I7fac5d187597aa37920754ed53be7bcc83603cee Reviewed-on: https://gerrit.libreoffice.org/37549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-05-20cleanup unused css/script/ includesJochen Nitschke1-1/+0
but keep exception includes in headers for now Change-Id: I826828675a2d14b906e57068cbced2e790e12bce Reviewed-on: https://gerrit.libreoffice.org/37846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-19loplugin:stringcopy: svxStephan Bergmann11-24/+24
Change-Id: Ic1874b2bfe28149deab3e6903ef7d7dac77cfc4b
2017-05-19make string translation loading more uniformCaolán McNamara98-442/+428
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-19loplugin:unusedfieldsNoel Grandin1-2/+0
make it a little smarter in dealing with fields that are smart pointers Change-Id: I44072105170882dc29fb19558f1065cffc7e5f11 Reviewed-on: https://gerrit.libreoffice.org/37751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-18Remove parentheses around some comparisonsStephan Bergmann2-2/+2
...where Clang would otherwise start to emit -Wparentheses-equality as soon as the order of arguments were switched by loplugin:comparisonwithconstant Change-Id: If064c2c6e2f81478154395137138b71f2d1c6534
2017-05-18tdf#100072 zero height of shape's path was causing geometry errorsVasily Melenchuk1-2/+15
DOCX custom geometry shape's path width and height are now used independently for scaling calculations. Change-Id: I368dd4dc065b8f122c4eb2911261e45047f03c70 Reviewed-on: https://gerrit.libreoffice.org/37639 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-05-16tdf#107298 Rename Snap Position to Constrain ObjectsIlmari Lauhakangas1-1/+1
Change-Id: Ic4fe262051e8202b8e11c7378d0c37d06bb1c931 Reviewed-on: https://gerrit.libreoffice.org/37654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-15tdf#107845 string resource ids effectively ended up in the gallery formatCaolán McNamara1-1/+24
which is a problem since... commit 34f7e618ddd3399d9e7f3998e25545256255d02d Date: Sun Apr 30 17:01:32 2017 +0100 untranslated strings are just strings and recover GALLERY_THEME_HTMLBUTTONS and GALLERY_THEME_DUMMY5 from commit 2d3a9c51055a285a2ac8d45e3ef31d248362589b Date: Mon Jul 2 21:02:19 2012 +0200 hrc cleanup: Remove unused defines Change-Id: I3fa45e4550295b94a6ab0acf9bcd0b25db73e689 Change-Id: Idae2c00f43e2062544f3de22e586bb163864bc03
2017-05-14fix gdi resource leak (svx/compressgraphicdialog)Julien Nabet1-1/+1
Change-Id: Iea6e481384cee4d7e2ff6787c64d3048ba9c9d65 Reviewed-on: https://gerrit.libreoffice.org/37587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-14fix gdi resource leak with unreleased virtual deviceMarkus Mohrhard1-1/+1
Change-Id: I1fd8c76a206cfc940e3d646e4025618785985e52 Reviewed-on: https://gerrit.libreoffice.org/37583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-13tdf#101885: fix crash in AccFrameSelectorJulien Nabet1-0/+2
Deal with no parent case 0x00007ffff5e98240 in vcl::Window::GetChildCount() const () 0 0x00007ffff5e98240 in vcl::Window::GetChildCount() const () 1 0x00007ffff54f2d1f in svx::a11y::AccFrameSelector::getAccessibleIndexInParent() () See https://bugs.documentfoundation.org/attachment.cgi?id=127141 Change-Id: I795dc4c083d743466b5605d3dcc8f9fca8674c43 Reviewed-on: https://gerrit.libreoffice.org/37575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-12Translate German comments (rest of svx/)Johnny_M18-114/+113
Additionally to comments, this translates dbg. assertion strings. Change-Id: Ia35b2a7336f2b5b30da36445274b1ea726f71f39 Reviewed-on: https://gerrit.libreoffice.org/37559 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-05-12fix bug in ColorNameMap constructorNoel Grandin1-4/+5
introduce by commit 9ffb86c7e93c1633866ed89f0749831fd7f31a35 Author: Noel Grandin <noel@peralex.com> Date: Wed Mar 27 10:41:40 2013 +0200 fdo#46808, convert drawing::ColorTable to new style Change-Id: I5e91b41caa6e7e43ff0f261a22b027c8574b669a Reviewed-on: https://gerrit.libreoffice.org/37532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-14 01:33:07 +0000