summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2017-09-08-Werror,-Wtautological-compare with latest clangNoel Grandin1-1/+1
Change-Id: I073f1893b759f8d31a24187f542b031b86dc4b8a error: comparison of unsigned enum expression >= 0 is always true [-Werror,-Wtautological-compare] Reviewed-on: https://gerrit.libreoffice.org/42103 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08clean up SdrDragStatNoel Grandin3-27/+16
- some light formatting in the header file - change aPnts from std::vector<Point*> to std::vector<Point>, no point in dynamically allocating a small value class - rename aPnts -> mvPnts - use std::unique_ptr for userdata - rename pUser to mpUserData - change some methods protected->private, since nothing external is using them Change-Id: I7a3f4c30c60ae1be3713f460fe65de95bed2f124 Reviewed-on: https://gerrit.libreoffice.org/42102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08svx: Make SdrDragStatUserData's dtor pure virtualTakeshi Abe1-0/+2
to clarify that it is an abstract base class, and to avoid memleak when deleting derived instance as pUser in SdrDragStat::Clear(). Change-Id: I39670841fda1ea3c45698585ce50aec944e0d4ab Reviewed-on: https://gerrit.libreoffice.org/42097 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08set parent for file dialog helperCaolán McNamara4-8/+11
Change-Id: I3994ee48dcb5b2732cb27cb9ccb54926abf0828a Reviewed-on: https://gerrit.libreoffice.org/42048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-06Don't run the OLEObjCache timer for an empty cacheJan-Marek Glogowski1-14/+9
Change-Id: I210f6bdec14491bea6d15bca133011059091f21b
2017-09-06svx: Simplify code with std::unique_ptrTakeshi Abe2-22/+11
Change-Id: I6f22417edc70812c64f7b4a9c6d59947059db414 Reviewed-on: https://gerrit.libreoffice.org/41971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-06loplugin:unnecessaryparen include case statementsNoel Grandin4-9/+9
Change-Id: I79fb3eec0d5d466e33b2e18621a7169695edf82f Reviewed-on: https://gerrit.libreoffice.org/41920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-05tdf#112199 Fix and extend enabled state for items in find toolbarJim Raykowski1-13/+10
Fixes bug that sets enabled state for 'Find Next' and 'Find All' instead of the intended 'Find Previous' and 'Find Next'. Adds the same enabled state dependency to 'Find All'. Change-Id: I01d4f0effaa343e1498d9610755b256761dacfd7 Reviewed-on: https://gerrit.libreoffice.org/41264 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-04loplugin:unnecessaryparen include c++ castsNoel Grandin10-24/+24
Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb Reviewed-on: https://gerrit.libreoffice.org/41874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-03iOS, avmedia lib not usedjan Iversen1-1/+2
Change-Id: I13636250552211fa53039178851a64b9e2715cef
2017-09-03svx: Fix memleak at early returns from SvxXMLXTableExportComponent::saveTakeshi Abe1-5/+2
Change-Id: Ic6da38a47f2c2f2e350a15bad2b2731ed12409a9 Reviewed-on: https://gerrit.libreoffice.org/41853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-02svx: Simplify code with std::unique_ptrTakeshi Abe1-19/+5
as SdrPathObj owns mpDAC. Change-Id: I3e4411046fa55ae8ffae2da5e406ad7d20a7ca6e Reviewed-on: https://gerrit.libreoffice.org/41818 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-01svx: add mutex guards to SvxFmDrawPageMichael Stahl1-0/+5
These trigger asserts that were added in previous commit. Change-Id: I78f0768c0dc9e035f3bff633560be936a2a1e487
2017-09-01tdf#111970 svx: use SolarMutex for locking in FmXFormShellMichael Stahl10-476/+488
FmXFormShell has a confusing mess of 3 of its own locks plus some SolarMutexGuards in a couple functions. But despite all that, most members are accessed without any locking. First, add a "_Lock" suffix to all (non-API) functions that access members or call into VCL, then add SolarMutexGuard in all API entry points that call _Lock functions, and finally remove the existing silly mutex members. This should also fix the reported assertion (which probably doesn't happen on master any more since the Scheduler has its own mutex now). Change-Id: I215cdfe49ffe675229baa4b19ab419f440f0ffb0
2017-09-01bump FileDialogHelper to XFilePicker3Caolán McNamara1-3/+3
Change-Id: I726676aaa8944bc3b6418abe305ad03f8ec96c59 Reviewed-on: https://gerrit.libreoffice.org/41783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-01Use named enum/constant instead of commentEike Rathke1-2/+4
Change-Id: I91c6e50518d2430e32312ba35f9ff5d76635460e
2017-08-31tdf#111734 Reorder buttons to reach them with the Down arrowGabor Kelemen1-32/+32
This seems to be enough to step through the buttons with the Down arrow. Change-Id: Ib9ad76bedb6abbf87164aafdf1c95cc438af8c3d Reviewed-on: https://gerrit.libreoffice.org/41772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-30nothing is reading the futilely set WB_AUTOSIZE bitCaolán McNamara1-1/+1
Change-Id: Ifbc2dffcb8db1511d5c08e51c972e822355f41c6 Reviewed-on: https://gerrit.libreoffice.org/41737 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-29Resolves: tdf#112017 crash on particular odtCaolán McNamara1-1/+2
Change-Id: I6ba2e73562a16afecb6abdfe4f1a40b1e316379e Reviewed-on: https://gerrit.libreoffice.org/41685 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-29move ListControl to vclMarkus Mohrhard2-159/+0
Change-Id: I022bba9a9a4d3d0bdb25ca8fa43aef2544decddb Reviewed-on: https://gerrit.libreoffice.org/41682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-29handle scroll wheel scrolling in new ListControlMarkus Mohrhard1-0/+13
Change-Id: I8dc68b674aabf446c4b949770ae066d41204efc3 Reviewed-on: https://gerrit.libreoffice.org/41680 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-29add a listbox that can contain any controls as childrenMarkus Mohrhard2-0/+146
This is adapted from the code that I originally wrote for the conditional format dialogs. Change-Id: I3349b7c720d99ede595cc6ebea2046e0f9dadc57 Reviewed-on: https://gerrit.libreoffice.org/41653 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-08-29Remove duplicate codeMaxim Monastirsky1-17/+0
The base class has now the same code since 9f61005dd9c4b ("tdf#109309 Currency dropdown is misplaced under Wayland"). Change-Id: Id0380ea10711a46c125c1f2ba6be82f21830bd9f
2017-08-29svx: FmXFormView owns m_pWatchStoredListTakeshi Abe2-8/+5
so simplify code with std::unique_ptr. Change-Id: I640bcbde4a59a239b33229168fd48cac29a3fc4d Reviewed-on: https://gerrit.libreoffice.org/41663 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-29svx: Mark functions as localTakeshi Abe4-3/+14
Change-Id: I15498d3d2b80b20cfae35ce6b304fd83ce8f5083 Reviewed-on: https://gerrit.libreoffice.org/41641 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-08-28tdf#111818: add SearchItem.AlgorithmType2 optionJulien Nabet1-17/+13
and use InitPropertySequence Change-Id: I1e7b6498828fc19c46c51501f1908dc830d8d826 Reviewed-on: https://gerrit.libreoffice.org/41654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-28svx: fix assert in SdrEdgeObj::ConnectToNode()Michael Stahl1-1/+5
When loading ooo68143-1.sxw we get an assert: Assertion `!(bListeningAlready && !bPreventDuplicates) && "duplicate listener, try building with DBG_UTIL to find the other insert site."' The connector is connected to the same SdrObject on both ends: <draw:connector ... draw:start-shape="id13" draw:start-glue-point="2" draw:end-shape="id13" draw:end-glue-point="2"> Change-Id: Ia0dd140b7c2ca948ace3fbf93d8c4abd4331399d
2017-08-27fix buildCaolán McNamara1-2/+2
Change-Id: I6064cef802aac56e99b1bc053bd2612a87038e3d
2017-08-27remove some unused svx error codesNoel Grandin1-16/+0
which seem to be unused ever since initial import Change-Id: I19460961876c73a0754c54b1a5c0ff8cc6311e4e Reviewed-on: https://gerrit.libreoffice.org/41490 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-27OUString: reduce temporaries and constifyMatteo Casalin1-27/+13
Change-Id: I8d806f1efb090a2e8dd42db228e7f07600816b2b
2017-08-27Share common codeMatteo Casalin1-81/+36
Change-Id: I98089cf93ba229f723628f8a70ef67ec7739c686
2017-08-26Fixed typos (whitespace)Matthias Seidel1-1/+1
(cherry picked from commit cda9ee31f7f1913660c6dce17192076ddf52c4a9) Change-Id: Ib948200084ae341c2f3f6d201aeeb9f84703623c Reviewed-on: https://gerrit.libreoffice.org/41579 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-25Drop gratuitous initial :: from comphelper::ProfileZoneTor Lillqvist1-3/+3
Change-Id: Iae7d86b857d0563d9ed9d9b4187e009554698412
2017-08-25Allow non-modal Dialogs during FileImport/LoadArmin Le Grand1-1/+1
When opening a file that triggers Dialogs (e.g. cannot read/repair/FileType) the Frame from which it was initialized gets blocked. This irritates quite some people. Changed this to a non-modal Dialog so that the user can continue to work with all opened docs, open new ones, close and print/PDF/export these. Change-Id: I048d3de3369527cec20d26396b87439254764b8a Reviewed-on: https://gerrit.libreoffice.org/41534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2017-08-25loplugin:unusedmethodsNoel Grandin4-80/+0
Change-Id: Iaaf9092ec4d6189492906648b84494d087fed81f Reviewed-on: https://gerrit.libreoffice.org/41539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-25no need to use ERRCODE_RES_MASK hereNoel Grandin1-21/+21
the relevant usage sites already call GetRest() before comparing Change-Id: I5e8ce3a3c2b6972810aa527356f6350c61b8bd63 Reviewed-on: https://gerrit.libreoffice.org/41470 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23convert message box style bits to scoped enumNoel Grandin2-2/+2
and fix harmless bug in ImpSVGDialog::ImpSVGDialog, which there since commit 6456f1d81090dd5fe44455c09ae3ede7ec6ac38a Date: Fri Feb 4 14:52:54 2011 +0100 ka102: added/removed files for SVG import and module cleanup Change-Id: I66b2ec2b029431ab453e54e962863e4ed7d78962 Reviewed-on: https://gerrit.libreoffice.org/41412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22drop unused SvxScriptTypeItemJochen Nitschke2-10/+0
apparently there was never a user for this item since initial commit in the year 2000. SvxScriptSetItem gets the ScriptType by parameter see GetItemOfScript and PutItemForScriptType. remove SID_ATTR_CHAR_SCRIPTTYPE and don't put the item in any set. keep the gap in the ID range because it's not part of any range and there are already other gaps. Change-Id: Iee24f13b329593af2dc5548d8b6bc2282c2dc5b3 Reviewed-on: https://gerrit.libreoffice.org/41423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22Convert ErrCode area to scoped enumNoel Grandin1-1/+1
Change-Id: Ifa365bbac3c7eb21da9381ec8bb3be6b6785016b Reviewed-on: https://gerrit.libreoffice.org/41402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21fix bogus always-true assertsMichael Stahl2-5/+5
Most of these were converted from OSL_ASSERT Change-Id: Ia95a758cdebf72ee80d00866644d92e6bb915071
2017-08-21drop pointless headersJochen Nitschke4-68/+2
Change-Id: Ia4e26760d4fad655bbd20714fa0abcad0921605a Reviewed-on: https://gerrit.libreoffice.org/41369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-20Crash when drawing freeform lineTamás Zolnai1-1/+1
Change-Id: I31b3e2c7cff5a7898fbc40e77f1d997d840a9546 Reviewed-on: https://gerrit.libreoffice.org/41354 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-08-18no need to redefine WB_NO_DIRECTSELECTNoel Grandin1-5/+0
Change-Id: Id9823a4b10982eb0a7c8f31d253a2d71005fa531 Reviewed-on: https://gerrit.libreoffice.org/41299 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18WB_ANIMATION is deadNoel Grandin1-3/+1
ever since commit 5bb93690aad419ceafbd14a61da1a86f674fdfea INTEGRATION: CWS hedaburemove01 (1.1.2); FILE ADDED Change-Id: Iad592e268644d10944e46bf80eae30042beab6da Reviewed-on: https://gerrit.libreoffice.org/41298 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18Revert "Related tdf#105500: leaks in PaletteManager and SvxColorToolBoxControl"Noel Grandin2-2/+0
This reverts commit 8c0cc5cd7befffc6e8e6361ba67807a799cc997f. These changes are unnecessary, the compiler already automatically generates the necessary code.
2017-08-18loplugin:unnecessaryparenNoel Grandin1-3/+3
look for statements like return (function()); Change-Id: I906cf2183489f87225b99b987caca67e39b26cc3 Reviewed-on: https://gerrit.libreoffice.org/41260 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17Related tdf#105500: leaks in PaletteManager and SvxColorToolBoxControlJulien Nabet2-0/+2
See comments of the bugtracker for more details Again thank you Alex for very useful information about leaks! Change-Id: I96743e8b167224f1bec73db5f2ba82536c7f23fa Reviewed-on: https://gerrit.libreoffice.org/41265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-17Fix typosAndrea Gelmini2-4/+4
Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3 Reviewed-on: https://gerrit.libreoffice.org/41194 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-17drop unused SdrCustomShapeReplacementURLItemJochen Nitschke3-13/+0
no user found at least since 2004 last traceable commit 50a73f5963c4d0ca34629f36cc04e8b45f61bd62 Date: Fri Apr 2 13:07:39 2004 +0000 INTEGRATION: CWS sj05 (1.1.2); FILE ADDED Change-Id: Iaaf80e93ed60611f5e03688f4d95ab0a7d024e79 Reviewed-on: https://gerrit.libreoffice.org/41262 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17drop unused SdrCustomShapeAdjustmentItemJochen Nitschke4-122/+0
unused since commit 935baf97a926baa50d985808736e0adb8837c716 Date: Tue May 19 09:32:45 2009 +0000 CWS-TOOLING: integrate CWS impress169 Change-Id: I1e8b0285ae1f6e8d92efd3f5a2463ff3126f1a0d Reviewed-on: https://gerrit.libreoffice.org/41248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-17 20:49:57 +0000