summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2015-02-05convert all remaining BOOST_STATIC_ASSERT to static_assertCaolán McNamara1-3/+1
and we can include a few less headers Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
2015-02-05push this windows build along a bit furtherCaolán McNamara1-9/+8
Change-Id: Id22ba872865bd8136c65c73152097805e696a695
2015-02-05cppcheck: Returning/dereferencing 'pEntry' after it is deallocated / releasedJulien Nabet1-0/+1
Change-Id: If96b66d5bbfcf4426bb602909599cd36e1f3c994
2015-02-05yet yet yet yet yet yet yet another 'Locale' ambiguous symbolEike Rathke1-2/+2
Change-Id: Ic6b813b3f826300d3b59b7105690ab611bb4bd44
2015-02-05yet yet yet yet yet yet another Windows build 'Locale' ambiguous symbolEike Rathke1-6/+5
Change-Id: I910c37a19c1f627ec0c92dcb044db92e9e24c25e
2015-02-05Updated all precompiled headers.Ashod Nakashian2-8/+22
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: https://gerrit.libreoffice.org/14292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-05callcatcher: update unused codeCaolán McNamara1-8/+0
Change-Id: I540d192a361938cd4dca811e7170d762841662ee
2015-02-03callcatcher: shave off some moreCaolán McNamara3-58/+0
Change-Id: I8ed7028f865bd4a6425859ab3b57ed8e928a78e4
2015-02-02callcatcher: remove some unused methodsCaolán McNamara1-5/+0
Change-Id: Id3ca991e9ede13512a39865496429aabb7e71088
2015-02-01loplugin:unreffunStephan Bergmann1-20/+0
Change-Id: I25213abc84c3e512fa620aa7c08e0c2e1bc0159a
2015-01-30coverity#1267684 Uncaught exceptionCaolán McNamara1-2/+3
Change-Id: Ie444d89108087c39ad429743e76c383f640c8751
2015-01-30ensure the default export filter is really availableDavid Tardon1-7/+4
Change-Id: Ie9b8a25d8d33c6211c43277f4d3b4cdbd79f5783
2015-01-30remove copypastaDavid Tardon1-4/+0
Change-Id: If3e33ee0a24e8a4850b2242ab3806d8dc57ddf09
2015-01-30tdf#85195 only check export formats for default formatDavid Tardon1-16/+0
What good would would a pre-selected export filter format to me if I cannot save into it? Change-Id: I9e5d06cec5ffa0ba325b8bfcfadc4fd55d39017a
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara15-476/+0
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-29use a less ugly string to double conversion, tdf#88740 follow-upEike Rathke1-11/+17
And check string length before accessing characters.. Change-Id: Iac3c2bf2f67f0cc7fc106515a875512771676e01
2015-01-29tdf#78854 do not crash when undoing layout changeDavid Tardon1-66/+0
It turns out that the ordinal number adjustment that was added for fdo#34548 is no longer necessary. Change-Id: I2c491a008500b6a269b6f05a2a72f5aa70edecb2
2015-01-28tdf#88740 fix sidebar angle rotation i18nAndras Timar1-0/+6
Change-Id: I30355f3aaf77b1952e21050e3593e575571d7aaa
2015-01-27tdf#82524: Mismatch of ValueSet and metric field valuesKatarina Behrens1-0/+1
Regression from commit ab50bc9d4a72193c1fefcbf0652938995094bc41 which adds space separator between value and unit. As metric fields now output values with separator, LineWidthValueSet items must be adjusted accordingly, otherwise they'll never match Change-Id: I55778c9c0cc36d968a061e5e35b6db3f2a159977
2015-01-27Lock SolarMutex around fmFormShell::DetermineForms callsStephan Bergmann1-0/+5
At least in JunitTest_forms_unoapi there are calls via URP of SfxShell::UIFeatureChanged FmFormShell::DetermineForms FmXFormShell::elementInserted cppu::OInterfaceContainerHelper::NotifySingleListener<...>::operator() cppu::OInterfaceContainerHelper::forEach<...> cppu::OInterfaceContainerHelper::notifyEach<...> frm::OInterfaceContainer::implInsert frm::OInterfaceContainer::insertByName frm::OFormsCollection::insertByName ... where SfxShell::UIFeatureChanged does an svtools::AsynchronLink::Call, and there are notorious crashes during JunitTest_forms_unoapi in vcl::Window::ImplRemoveDel Application::RemoveUserEvent svtools::AsynchronLink::~AsynchronLink SfxShell_Impl::~SfxShell_Impl SfxShell::~SfxShell FmFomrShell::~FmFormShell ... and the naive hope is that the former's unlocked operations cause some corruption that make the latter operate on a dangling AsynchronLink::_nEventId. (As always, the question is at which level to lock the solar mutex; frm::OFormsCollection et al appear to be properly mutex'ed, FmXFormShell appears to be virtually un-mutex'ed, except for some smelly m_aInvalidationSafety and m_aAsyncSafety, and FmFormShell and SfxShell appear to run under the assumption that the solar mutex is always locked. So stick the guards into FmXFormShell--- which is the only place calling DetermineForms---under the assumption that that is the most likely place needing general mutex clean-up in the future, and thus bears the highest chance the potentially becoming redundant guards will be noticed again.) Change-Id: Iad0f4bd9af2bf62330e26ac50edd170f470e79c4
2015-01-26coverity#1266476 silence Dereference null return valueCaolán McNamara1-3/+3
Change-Id: I1085d6df3af1198e0fc087da4058f705f13e2f61
2015-01-26coverity#1266440 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: I84a9c08e539c98408d49b2f4276fb547d2deefd7
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin15-107/+71
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-24Typo: syncro->synchroJulien Nabet2-9/+9
Change-Id: I0a377f3686e0f8d8f576aacbee49a392b039d3a5
2015-01-24coverity#1265796 Dereference null return valueCaolán McNamara1-1/+9
Change-Id: I779dacdb7fb18ba8148e932b4dc684d08f824cbe
2015-01-24coverity#1265799 Dereference null return valueCaolán McNamara1-3/+3
Change-Id: I7f1838b55d7b526327efb0562f3ad1ab5a1778a1
2015-01-22On init of DbCellControl, load value from ModelLionel Elie Mamane1-0/+2
This fixes a regression introduced by "fdo#88551 no need to update content from field when activating grid cell" that when switching from design mode to normal mode before one moved row at least once, the current cell (inevitably of the first row) was always displayed empty. Before, the update was done by the activation event (which was too often), so now we need to do it once at initialisation. Not sure if using updateFromModel instead of UpdateFromField makes a difference. Hope not. Else need to change that. Change-Id: I878dea0f91b370a4f83c3c1a3ed185a51ac9f0b7
2015-01-22fdo#88551 no need to update content from field when activating grid cellLionel Elie Mamane1-8/+0
It is already loaded correctly, and reloading leads to bogus TextChanged event. Change-Id: I9ad384ce60bbfd477199a1c9fb81e8e201a5162b Reviewed-on: https://gerrit.libreoffice.org/14096 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-01-21callcatcher: update unused codeCaolán McNamara1-24/+0
Change-Id: I225cbb3a4a66a8f20bec91c4770ad78e72b663b1
2015-01-20Some more loplugin:cstylecast: svxStephan Bergmann7-12/+12
Change-Id: I5eb4e1cae38decb293ea11f7cd4bfda0bad3afcb
2015-01-19Resolves: fdo#88417 Dropdown for ruler settings should show radio buttonsCaolán McNamara1-11/+11
This reverts commit 9995222d1141b326197a387cc7897b3971ce9e9a and additionally converts the ruler settings to radio buttons and not checkboxes Conflicts: vcl/source/control/tabctrl.cxx Change-Id: Ie0eac5f07729447942065b7f415398165fbf067c
2015-01-19initializeControlModel needs parent to be setLionel Elie Mamane1-5/+6
And thus it seems it expects to be called *after* insertion. Change-Id: I752dcd84c76c7beba75cd564162def5eaee7de4c
2015-01-19argh damnitMichael Stahl1-1/+1
Change-Id: I639d82ace116a09218cd71c62ac9e37efd6d957d
2015-01-19svx: ExternalToolEdit: don't terminate if SystemShellExecute throwsMichael Stahl1-3/+11
Change-Id: Ia527a2c9467e2ab097cf688164f4176a52fa1d36
2015-01-19svx: ExternalToolEdit: check that temp file is actually createdMichael Stahl1-2/+14
Change-Id: I03e49493c549561b4dc806f1e191a73d06733cff
2015-01-19Mistake in choice of FM_PROPJulien Nabet1-1/+1
Change-Id: Idb23bdefaf4abcbf4f7493c0dfea2abe84948023 Reviewed-on: https://gerrit.libreoffice.org/13982 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-01-19Fix typo code Resouce->ResourceAndrea Gelmini1-4/+4
Change-Id: I6e68c13e4513c2f8cc38e237646db7dffc88fe3b Reviewed-on: https://gerrit.libreoffice.org/13986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-18Typo: sDatasouce->sDatasourceJulien Nabet1-9/+9
Change-Id: I4ffaf4195ae17ecf86dffc9c44e4672c4b2835d7
2015-01-17rhbz#1136013: svx: try to make the ExternalToolEdit not crash all the timeMichael Stahl1-19/+78
This thing was starting a timer that re-starts itself forever, and when the file it was watching changed, it would just assume the drawing objects were still there (and the document, for that matter...) Change-Id: I35f187f0828097a05618dc1733dce819fc6bffc6
2015-01-16make OverlayTriangle public, allow to change each pointTomaž Vajngerl3-64/+27
Change-Id: Ifdc8df1852e29173ee571102aed1c21d5611171b
2015-01-15convert sal_uIntPtr to longNoel Grandin1-1/+1
Change-Id: I662f51d8d7c88a6c6f7306c344d99841a3102bb4
2015-01-14fdo#39440 svx: reduce scope of local variablesMichael Weghorn11-42/+24
This addresses some cppcheck warnings. Change-Id: I800242bbac3092d2dbaa9098fc6355fe675872e1 Reviewed-on: https://gerrit.libreoffice.org/13906 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-14fdo#39440 svx: reduce scope of local variablesMichael Weghorn18-48/+30
This addresses some cppcheck warnings. Change-Id: I8c63a767c62b3a666ad445a0a3095d1bb1224f5e Reviewed-on: https://gerrit.libreoffice.org/13908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-14GetData is a hopelessly generic nameCaolán McNamara1-1/+1
when you want to find the uses of it Change-Id: I580c194f0fd200505d3df99089afc0872921a67b
2015-01-14HiDPI changes to ruler to respect screen DPIdbeurle1-1/+26
Change-Id: I4cbb303b395ad60d4935bff55fbaea08f13334a0 Reviewed-on: https://gerrit.libreoffice.org/13867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-13simplify Date/Time/DateTime conversion codeNoel Grandin1-1/+1
add constructors to Date/DateTime/Time, that take the css::util counterparts, to simplify code converting between these type Change-Id: I4b03da02c63f65b6ec18cb4d6ecc3859bdef1ff7 Reviewed-on: https://gerrit.libreoffice.org/13855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2015-01-13svx, canvas, desktop: gb_OBJCXXFLAGS are not needed at allDouglas Mencken1-4/+0
Change-Id: Iea164e00262822d571f2c49665165795706a57a4 Reviewed-on: https://gerrit.libreoffice.org/13645 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-01-12Resolves: fdo#79975 toggle checkered background back onCaolán McNamara1-1/+0
Change-Id: Id856d8dbf437acb7e528e60b4d1b012102ff0557
2015-01-12convert SETTINGS_ #defines to 'enum class'Noel Grandin18-26/+26
and dump the ones that nothing is listening to Change-Id: I253ef284df785812a439dd160edba1b07fdbaac4
2015-01-12fdo#84938: replace DATACHANGED_ constants with 'enum class'Noel Grandin18-28/+28
and drop DATACHANGED_DATETIME because no-one is using it Change-Id: Id5ac9a7fbba0e35501ed82e5252f66858621f7ff
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-25 15:46:27 +0000