summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)AuthorFilesLines
2017-05-01unnecessary PairedList macroNoel Grandin1-3/+1
Change-Id: I54a6478522f03706b5d2d10b58857a3de2876ca8 Reviewed-on: https://gerrit.libreoffice.org/37118 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-28ofz: fix leakCaolán McNamara1-8/+7
Change-Id: Ib31b3bfabaaaeb9b71635dadd099874d9c972fd0 Reviewed-on: https://gerrit.libreoffice.org/37080 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-28bNeedUpdate is set to false twiceCaolán McNamara1-1/+0
Change-Id: I10348d36828008ebddc3b923e2e9d252d0394fa6 Reviewed-on: https://gerrit.libreoffice.org/37079 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-28loplugin:salunicodeliteral: svtoolsStephan Bergmann1-3/+3
Change-Id: I566b71b421bb2f2458f5d3f60e7d761d8725a004
2017-04-28move builder attributes from OString to OUStringCaolán McNamara1-1/+1
Change-Id: I235188c9a086337b104e600f31a1c81deeca6c17 Reviewed-on: https://gerrit.libreoffice.org/37076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-28another name for a nonlocalized string is a stringCaolán McNamara4-39/+21
Change-Id: I165d74c59d1cccba295072a3df7b9f54dfb60449
2017-04-27tdf#39468 cleanup source code commentsdennisroczek1-3/+2
* translate German source code comments * remove ascii art * remove bogus source Code comments * remove old StarOffice/Sun internal bug tracker references Change-Id: I443bf2fdba3780c411d69809111daf3aa3a48451 Reviewed-on: https://gerrit.libreoffice.org/36005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-27last private:resource ... bitmapex user is goneCaolán McNamara1-53/+0
so drop private:resource ... bitmapex example and update docs Change-Id: I244c575573cffda5eb8ca52afd2f4a04a9b18f14
2017-04-27tools: move errcode.hxx to the vcl moduleChris Sherlock1-1/+1
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27vcl: move RegisterDisplay() from ErrorHandler to ErrorRegistryChris Sherlock1-1/+1
It is the error registry that should register the display, not the error handler. Move this function to the class that is responsible for it. Change-Id: I95ca1662b907a7f38a42a39ec729b35fd530bb79 Reviewed-on: https://gerrit.libreoffice.org/36853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27Fix the copy-pasteMaxim Monastirsky2-8/+3
Use m_xUrlTransformer, and drop the now unneeded m_xContext.is() check. Here is the history of this: - commit ef8f9cfb262a7 (CWS docking1) introduced this code in ToolboxController::execute. - commit a2bbbc5130b80 (CWS docking3) copy-pasted this into GenericToolbarController::execute. - commit 0fc90c8a064f7 (CWS insight02) changed the original code, but not the copy-pasted one. - commit d7afd8e128177 (CWS toolbars2) That CWS didn't have the above change yet, and copy-pasted the old code to yet another place (GenericToolboxController::execute). Change-Id: I7f4e8dfb52b96ea5285ea7b2bb3083847dd84932
2017-04-26last private:resource ... bitmap user is goneCaolán McNamara1-1/+1
so drop private:resource ... bitmap example and remove bitmap case, bitmapex case persists Change-Id: Iabf7c48517c17e3117f88daa80a258b7303b85dd
2017-04-26remove svtools bitmaps from .src filesCaolán McNamara12-696/+356
Change-Id: I13280315c2af2277d5c8d31c079075337b2c8f82
2017-04-26use strong_int for LanguageTypeNoel Grandin3-122/+86
Change-Id: If99a944f7032180355da291ad283b4cfcea4f448 Reviewed-on: https://gerrit.libreoffice.org/36629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25vcl: change ErrorHandlerFlags to DialogMaskChris Sherlock1-23/+23
Change-Id: I1959ac97f679d8d719f851f9869962b39a20ded9 Reviewed-on: https://gerrit.libreoffice.org/36841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25clang-tidy readability-simplify-boolean-expr in svtoolsNoel Grandin15-85/+23
Change-Id: I13286a691348e136d16c07473285313c3ba5bba2 Reviewed-on: https://gerrit.libreoffice.org/36928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tdf#75280: convert sal_uIntPtr to sal_uInt32 for ErrorInfo memberChris Sherlock1-1/+1
Change-Id: I97f3b18604f17b0ccc9fd1bbb0221ff5e11fe826 Reviewed-on: https://gerrit.libreoffice.org/36840 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25make __RSC a builtin define for the RSC compilerNoel Grandin3-4/+1
instead of randomly defining it in only some of .src files Change-Id: Ifec3920740723d248400f451d717b5288c421b8d Reviewed-on: https://gerrit.libreoffice.org/36832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock11-0/+11
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-24loplugin:checkunusedparams in i18nlangtag and l10ntoolsNoel Grandin1-10/+4
Change-Id: If7c7404b1cc1cf9445a2af8106f7326b76524388 Reviewed-on: https://gerrit.libreoffice.org/36883 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-24Drop unused string resources from svtools/soerr.hxxGabor Kelemen1-56/+0
Change-Id: If3060b101dc0692f47d9d5eaf649bce60965b04f Reviewed-on: https://gerrit.libreoffice.org/36864 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky5-5/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21convert HTML_OPTION_IDS to scoped enumNoel Grandin3-171/+183
Change-Id: Ia766dc58a571e5853005fd394283d7b53f02e4a6 Reviewed-on: https://gerrit.libreoffice.org/36748 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin6-10/+10
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20convert EDynamicMenuType to scoped enumNoel Grandin1-10/+10
and drop unused E_HELPBOOKMARKS Change-Id: I5756ea326bdc1a99f7d6f1ba43baf6aca9f7f2fc Reviewed-on: https://gerrit.libreoffice.org/36728 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20loplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-19convert MeasurementSystem to scoped enumNoel Grandin1-1/+1
Change-Id: I5d26c50aa0e2c68edab6ee217ae6bdb0ee45dc09 Reviewed-on: https://gerrit.libreoffice.org/36525 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-17move the exception handlingCaolán McNamara1-23/+36
Change-Id: Ie61a424a78be85c1dc54dd56451319356227f443
2017-04-14convert fileview context menu to .uiCaolán McNamara5-65/+42
Change-Id: I4631b4fa0312c6548a1176872e3a836d377f518c
2017-04-12can use gb_CppunitTest_use_configuration and still access .ui filesCaolán McNamara1-2/+1
after... commit 506cab1a01b0481d0831a7a692a26dc5a5b55e91 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Apr 12 16:14:10 2017 +0100 take the .ui files from $BRAND_BASE_DIR/$BRAND_SHARE_SUBDIR Change-Id: I9cffdc092206c038da32a32a2cfe629e68b5c258 Change-Id: I906d16037cdf0b9203a4120cb1a5e9846a5c7b7f Reviewed-on: https://gerrit.libreoffice.org/36482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-10loplugin:inlinefields in OpenFileDropTargetListenerNoel Grandin1-7/+4
Change-Id: Ib1f7004ce57f144309d396bc71419f3d1036ff74 Reviewed-on: https://gerrit.libreoffice.org/36353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-07loplugin:redundantcast find cstyle arithmetic castsNoel Grandin2-3/+3
Change-Id: If7c259f0d12a41182f476ddb558f7cb5f76f9577 Reviewed-on: https://gerrit.libreoffice.org/36253 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-07tdf#39468 Translate German commentsJens Carl1-1/+1
Translate German comments and terms in dbaccess/, extensions/, formula/, include/, reportdesign/, rsc/, sd/, svtools/, and vcl/ Change-Id: Ie20dadda0eeb0786eb328c6c652287d5481c5e3b Reviewed-on: https://gerrit.libreoffice.org/36249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-07Drop remains of the Welcome Screen featureGabor Kelemen1-14/+0
Which was dropped in e299ef4952a580bdbd416cef3e1a2feba4979e13 (that was in 2001) Change-Id: I5860bb44ced35b338f667e47d89f6ed1d597dc11 Reviewed-on: https://gerrit.libreoffice.org/36159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-06Improved loplugin:redundantcast, static_cast on arithmetic types: svtoolsStephan Bergmann2-3/+3
Change-Id: Idcd8a32f85788fe0d763c2f72475e3bef4221366
2017-04-06Fix typosAndrea Gelmini1-1/+1
Change-Id: I9e7f7fa6a8b89304883a843f9fb0b905f5e8a8a4 Reviewed-on: https://gerrit.libreoffice.org/36100 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-05loplugin:redundantcast find c-style bool castsNoel Grandin3-3/+3
Change-Id: I3237b93babc67de12c3771aa84766c2141ca93b2 Reviewed-on: https://gerrit.libreoffice.org/36137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05loplugin:constantparam part2Noel Grandin1-14/+8
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746 Reviewed-on: https://gerrit.libreoffice.org/36072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04tdf#99352: assert on stray VclPtrs past DeInitBjoern Michaelsen1-12/+13
- ignore on Windows for now, as it is acting up Change-Id: I98dbb887ed556b58188870c3eb3de1327bc58109 Reviewed-on: https://gerrit.libreoffice.org/35816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-04-03tdf#39468 Translate German commentsJens Carl9-10/+10
Translate German comments and terms in UnoControls/, editeng/, filter/, odk/, reportdesign/, sd/, sfx2/, starmath/, svl/, svtools/, toolkit/, tools/, writerfilter/, and xmloff/. Change-Id: Ibc401a425ddfdf41e4e4a78600f3fbce8cfaa2b1 Reviewed-on: https://gerrit.libreoffice.org/35992 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-03use actual UNO enums in reportdesign..svtoolsNoel Grandin1-1/+1
Change-Id: Idcd916382b87f8542dc6b5cdcb5ecb01d6947203 Reviewed-on: https://gerrit.libreoffice.org/36043 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-01Display unknown token for html key in consoleJulien Nabet1-1/+1
Change-Id: I57740e52a8e76d4f0f68cb2e58ca3f1aab249a0b Reviewed-on: https://gerrit.libreoffice.org/35989 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna65-630/+630
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-30remove type decorations on char literalsJochen Nitschke1-2/+2
they are only needed where type deduction fails. left them in defines for now. Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09 Reviewed-on: https://gerrit.libreoffice.org/35893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-30loplugin:unusedenumconstantsNoel Grandin2-5/+1
Change-Id: I628a0114e56ec25926bd08d159c61cfecb719a1c Reviewed-on: https://gerrit.libreoffice.org/35854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29loplugin:unusedmethodsNoel Grandin2-31/+0
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0 Reviewed-on: https://gerrit.libreoffice.org/35834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-26uitest: allow to change state of checkbox in treelistMarkus Mohrhard1-0/+9
Change-Id: If76ab528dfd835ea7718e153a943d182ecc4ce0a Reviewed-on: https://gerrit.libreoffice.org/35698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-26uitest: add info whether a tree list box contains check boxesMarkus Mohrhard1-0/+10
Change-Id: Id214928de2e74ac7ec707eaf2276e4e808b630a4 Reviewed-on: https://gerrit.libreoffice.org/35697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-03-25Make loplugin:loopvartoosmall find more suspicious casesStephan Bergmann1-2/+2
...where the "controlling expression" of any sort of loop contains a sub- expression of the form var < val where the type of var is smaller than that of val. Theoretically, this could turn up lots of false positives, but practically it didn't run into any. Most findings have been cleaned up over the last weeks. There's just a handful remaining places that are hard to clean up, so I flagged them here with (deliberately awkward) sal::static_int_cast for later clean-up. Change-Id: I0f735d46dda15b9b336150095df65cf247e9d6d3 Reviewed-on: https://gerrit.libreoffice.org/35682 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-25Fix typosAndrea Gelmini4-5/+5
Change-Id: I4eda687db6ad8d41e6a28430c76b288510da605d Reviewed-on: https://gerrit.libreoffice.org/35645 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>