summaryrefslogtreecommitdiff
path: root/svl
AgeCommit message (Collapse)AuthorFilesLines
2014-07-13fdo#81309: Adjust references during sort.Kohei Yoshida1-1/+23
Change-Id: I2b98610f6b774400ecfaffe2905201c27fcab33f
2014-07-10Translate German comments (continued)Philipp Weissenbacher1-183/+151
Change-Id: Ia33f8b85120381c75bcb3696845dfab1fd8b61fc Reviewed-on: https://gerrit.libreoffice.org/10151 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-10fdo#75757: remove inheritance to std::vectorTakeshi Abe1-15/+33
This also fixes possible memory leaks of SfxAllEnumValue_Impl which may occur in SfxAllEnumItem::RemoveValue() of the original implementation. Change-Id: I5f458c546575d9e1f88b1167ae561537963c7b95 Reviewed-on: https://gerrit.libreoffice.org/10167 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-10Avoid possible memory leaks in case of exceptionsTakeshi Abe4-49/+36
Change-Id: I1dd003bc984a11d6d71c92aae44accc9d358db0c
2014-07-08Drop unused nSfxFlagValTakeshi Abe1-11/+0
It has gone at 0e73ffc339ff51fc610de5fcbad0aef813610f36. Change-Id: I98fcdfe4861e47fbd33ff620971f247bee89290e
2014-07-07fix crash on loading fdo70673-1.odsCaolán McNamara1-1/+1
rStr is NaN Change-Id: I8206ab322a08d558cf5f05750efd700875b2134c
2014-07-03work around nonsense -Werror=maybe-uninitialized, fdo#80166 follow-upEike Rathke1-0/+7
Change-Id: I0f9cf74550e43d174bf6ac75e70c51ab7f51ccf8
2014-07-02resolved fdo#80166 check input against date acceptance pattern plausibilityEike Rathke1-1/+30
... to prevent confusion of #.### input with D.M that then later is discarded as invalid date input instead of accepted as valid numeric input. Change-Id: I178e28b7ef3b26d04eecc73e5e5c61ee41f89e32
2014-07-01New loplugin:stringconcatStephan Bergmann1-1/+1
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-06-30Make sure IMPL_STATIC_LINK's type matches Link::pFunc's typeStephan Bergmann1-1/+1
...to avoid -fsanitize=function warnings in Link::Call. Change-Id: I837b35bd3052716fbb41bf4f893961257d1f9b2c
2014-06-30Translate German comments in filerec.cxx and doxygen-ify.Jeroen Nijhof1-300/+245
Change-Id: Iebe05867395ca5674242b18038b53d5362869d07 Reviewed-on: https://gerrit.libreoffice.org/9956 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-27loplugin:unreffun: also warn about redundant redeclarationsStephan Bergmann1-4/+0
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
2014-06-27DBG_ASSERT->assertCaolán McNamara1-5/+1
Change-Id: Ic2933fc686d3bb030291756bd94127ee7583c833
2014-06-26svl now depends on mdds.Kohei Yoshida1-1/+4
Change-Id: Ifd0bde11ad7e72683e1b95106f487e1eb2a4b487
2014-06-26Initialize it with empty OUString instances.Kohei Yoshida1-1/+1
Since we only store strings the matrix. Change-Id: Ie30e9ce0235810b3082ba13ac17c7d1b3c19375a
2014-06-26Move SheetPrinter to svl and rename it to GridPrinter.Kohei Yoshida2-0/+142
I need to use this outside of sc. Change-Id: I153863d6c5c31e5ab5f25da2dba81bd4d4b6d3fe
2014-06-26Revert needless inlining of methods for publicly exposed class.Kohei Yoshida1-0/+32
Keep the method implementations unexposed please. Change-Id: Ic9b1f8654e6ebef428d4182782c1aa4962934c6a
2014-06-24Improve SfxItemPool documentation.Michael Meeks1-2/+6
Change-Id: If5a555dae067d023c9dd1fd8e0409ca327739f08
2014-06-23Start translation of German commentsPhilipp Weissenbacher1-89/+79
Change-Id: If936d3f8647cbcd15d42de985ae0351d683d4b44 Reviewed-on: https://gerrit.libreoffice.org/9832 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-06-19related fdo#63230: Fix unit test for fdo#44286 to run in all localesIsamu Mogi1-1/+1
fdo#44286 test fails depending on system language. To fix it, this commit sets output language to LANGUAGE_ENGLISH_US. Erorr message: | $ LANG=fr_LU.UTF-8 make -rs CppunitTest_svl_qa_cppunit | [build CUT] svl_qa_cppunit | /home/master/src/libreoffice/workdirs/master/svl/qa/unit/svl.cxx:403:(anonymous | namespace)::Test::testFdo44286 | equality assertion failed | - Expected: 1902-04-22 | - Actual : YYYY-04-DD | | svl.cxx:403:Assertion | Test name: (anonymous namespace)::Test::testFdo44286 | equality assertion failed | - Expected: 1902-04-22 | - Actual : YYYY-04-DD | | Failures !!! | Run: 7 Failure total: 1 Failures: 1 Errors: 0 Change-Id: I58756c7508c7f02bec9c3b7b693032265d18c6ae Reviewed-on: https://gerrit.libreoffice.org/9826 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-06-18related fdo#63230: Add unit test for fdo#44286Isamu Mogi2-0/+35
It fails if 6013fe19a40dd16ce435a2428f7405b51930689e is reverted. Change-Id: Iabf13b15e3c26d7ebafdc9284642183f27723d8c Reviewed-on: https://gerrit.libreoffice.org/9781 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-17fdo#38513 - Accelerate non-poolable item add / remove.Michael Meeks8-67/+259
For large documents we create and destroy a large number of non-poolable SfxPoolItems, which get inserted into and removed from a vector. Unfortunately the performance of this (depending on pattern) is O(N) and this insert/remove/extend pattern can happen per text span we insert. This patch makes this O(const) via a hash. This gives a 5x speedup for the above bug; 176s to 34s or so, and moves the remaining performance issues elsewhere. Unfortunately, we have to retain the ordered array to keep the binary file format code (used for editeng cut-and-paste) in place, so have to keep both a hash, and an array, and a list around for free slots. cf. fdo#79851 where there is a start at removing that. This wastes space; but not that much - for a large open document collection we have O(100's) of SfxItemPools, and O(1000's) of SfxPoolItemArray_Impls; having fixed fdo#79851 we can consolidate this. Add skeletal unit test; translate several German comments; remove un-necessary include. Change-Id: Ie0de32b1a29217560c5591c71a6cd4e26d39a531
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin4-36/+0
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-13loplugin:staticcallStephan Bergmann1-2/+2
Change-Id: I7777ec51b00e11204457dd11359d14c2bcf0e283
2014-06-11allow additional i18n formats to define defaultsEike Rathke1-5/+8
a5f62d96b124564f522eac7925e9c3d22c37e503 would had liked to let usage="DATE_TIME" formatindex="55" define the default format of that usage, which wasn't possible. There is no reason to prevent this. Change-Id: Ibef453c8a07aa03b0a8bb626b9cf71d362be0699
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin3-20/+0
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-06fixincludeguards: fix include guardsThomas Arnhold1-0/+6
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b Reviewed-on: https://gerrit.libreoffice.org/9629 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-06simplify SfxListener::EndListening and StartListeningNoel Grandin1-11/+9
No-one is using the return values, so we can simplify the methods Change-Id: Icc2dbfb797bcd82afcbf42ed3bdc20b0426ccba1 Reviewed-on: https://gerrit.libreoffice.org/9542 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-06-06resolved fdo#79719 recognize ##-MMM-## as date even if ambiguousEike Rathke1-8/+3
Force ##-MMM-## to be ##-MMM-#### if the first number is a day value. Note that the previous implementation of (bDay1 && bDay2 && ((bYear1 && !bYear2) || (!bYear1 && bYear2))) never matched anyway as the detection of bDay1 and bDay2 were changed to only yield true if bYear1==false or bYear2==false. Change-Id: If6bb6d3e1757015552eaa81c1f58d53c0794846e
2014-05-28This needs to be debugged and understood, not just randomly "fixed"Tor Lillqvist1-3/+1
This reverts commit 72827968e606adcdf8c16e5381b887180975ae46. Change-Id: Ie79bb1d57d05c0a1e51733bacc1b103f44ddc153
2014-05-28Related: fdo#79142 make SetName default to ReindexingCaolán McNamara1-1/+3
Change-Id: I408042bc7bf1a5a955203d65d2c68ebf9527b9b5
2014-05-28Try to avoid "attempt to erase from container with a past-the-end iterator"Tor Lillqvist1-1/+3
I saw such an error (and the resulting abort) in CppunitTest_sw_ooxmlexport, and the helpful backtrace displayed (it was on Linux) indicated it was caused by the erase() call in SfxListener::RemoveBroadcaster_Impl(). (Obviously this was when building against the debugging C++ runtime, i.e. --enable-dbgutil.) Unfortunately this seems to be one of those random error conditions that are hard to reproduce. At least I could not. But this is hopefully an obvious improvement. Change-Id: I0f247cf8f9fd0c151aafa59c43a49c100c518f19
2014-05-27remove unnecessary use of Reference constructor in throwNoel Grandin1-12/+8
Convert code like this: throw IOException("xx", Reference< XInterface >(static_cast<OWeakObject*>(this)) ); to this: throw IOException("xx", static_cast<OWeakObject*>(this) ); Change-Id: Ife9f645f0f1810a8e80219126193015502c43dbb
2014-05-27remove unnecessary use of OUString constructor when throwingNoel Grandin1-4/+4
Change-Id: I4a3f3f911dcfbf88696053215a2fb7a94678244c
2014-05-27Remove unnecessary semicolonsPeter Senna Tschudin1-1/+1
A simplified version of the semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p // </smpl> Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e Reviewed-on: https://gerrit.libreoffice.org/9493 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-23Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20Julien Nabet3-16/+16
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23remove boilerplate in UNO Exception constructor callsNoel Grandin1-2/+2
Now that we have default values for Exception constructor params, remove lots of boilerplate code. Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-21ODS load perf: 7% of the time re-creating sheet name strings.Michael Meeks1-1/+0
No need to create cached versions of stringified sheet tokens for a given grammar at great for every formula that we compile; defer until use. Is this a large cost on save ? Change-Id: I8058ed564dbdc00ff45c02cb483c1a20a48af272
2014-05-20take a shortcut on common separating ASCII charactersEike Rathke1-3/+17
Change-Id: I991801b9a0b7be6024612c8f29262f2ebd8e6a64
2014-05-20resolved fdo#34724 Jan1 or 1Jan without separating character is not dateEike Rathke1-26/+59
Change-Id: I2cf02a26b81fa634c842df455de669f1c60241bc
2014-05-19hrc and src files: squeeze multiple newlinesThomas Arnhold1-3/+0
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-17Back out change for fdo#78119 now that we have StringContainsWord()Eike Rathke1-48/+21
This reverts commit 3b3b690c1f0479cfbebcfa68595f75a4994e7a5f. With the use of StringContainsWord() it is unnecessary to loop all available names.
2014-05-17resolved fdo#41166 match month and day name word instead of substringEike Rathke1-3/+8
Follow-up, check for ASCII first to avoid calls to i18n, and check the type flags instead of calls to CharClass methods that give unexpected results with their masks. Change-Id: I10e685998299dceb2dbcf1d87ae1de09680b8a99
2014-05-17resolved fdo#41166 match month and day name word instead of substringEike Rathke2-9/+57
Change-Id: I897dbcee47de574d91ba3e3b40a39a35b779fef8
2014-05-15update_pch: add svlThomas Arnhold3-0/+193
55s -> 28s How to find possible pch candidates: for i in `git grep -l 'gb_Library_set' -- '*.mk' | sort -u`; do if [ $(git grep 'precompiled_' $i | wc -l) == 0 ]; then echo missing: $(sed -n -e '/gb_Library_add_exception_objects/,/))/ p' $i | wc -l) files in $i else echo ok: $i fi done | sort -h -t' ' -k2 Change-Id: Ib9fe16c0afb6e6687881c987c3af7bf59b929fd4
2014-05-15fix-includes.pl: svlThomas Arnhold22-113/+113
Change-Id: I18fb7a677e2bb98c83f43f5af3fa988393dc23f9
2014-05-14Find places where uno::Sequence is passed by value.Noel Grandin1-1/+1
Implement a clang plugin to find them, and clean up existing code to pass them by reference. Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8 Reviewed-on: https://gerrit.libreoffice.org/9351 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-13remove dead codeNoel Grandin1-6/+0
Change-Id: Ic4fb478921714429af138ca212bd7f67f408d434
2014-05-12fdo#78119 find the longest match for month nameDavid Tardon1-21/+48
Change-Id: Idad7b083ce5528f5c735f3a8bd091819bf043fc8
2014-05-11coverity#982701 Improper use of negative valueCaolán McNamara1-0/+4
Change-Id: I3c932e8386d994450f05a876b6ad76ba141bd4e9
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-17 08:54:46 +0000