summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2017-03-16Notebookbar: fixed crash after customizationSzymon Kłos1-11/+36
+ removed listener + prevent from using invalid pointers Change-Id: I3a846d2344148456d3edba23296a4781496eba8b Reviewed-on: https://gerrit.libreoffice.org/35248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-03-15tdf#105040 Notebookbar: added shortcuts toolboxSzymon Kłos4-42/+247
In the tabbed notebookbar the shortcuts toolbox is introduced. It is placed before tab labels, after the menu button. Customization is possible, buttons are loaded from the newly created toolbar "Notebookbar shortcuts". NotebookbarTabControl was moved to the sfx module. Change-Id: Ifa4a1688c6e92c2f03bd386608e3e9d1c28069d4 Reviewed-on: https://gerrit.libreoffice.org/35194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-14remove unused RID constantsNoel Grandin4-19/+0
found with the attached bin/find-unused-rid.py script Change-Id: I1cf79caa6cafedb8bc642f394dc7e7da889d6fdf Reviewed-on: https://gerrit.libreoffice.org/35136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-14remove noise UUUU tags in commentsNoel Grandin1-1/+1
Change-Id: Id8a2940ae7348bf75ca967f31adf8489dc678d00 Reviewed-on: https://gerrit.libreoffice.org/35161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13tdf#95416 remove ../ in #include headers of sfx2 filesJeevan8-9/+9
Change-Id: I5f3e1a8fe559500aec7ea9e38edaba42dff3f98b Reviewed-on: https://gerrit.libreoffice.org/35028 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-03-13Clean up integer types representing positions in ToolBox's item vectorStephan Bergmann2-3/+3
(vs. uses of sal_uInt16 representing such items' IDs). APPEND and ITEM_NOTFOUND are members of ToolBox now (and have been bumped to the corresponding type's max). The payload of VclEventIds ToolboxButtonStateChanged ToolboxClick ToolboxHighlightOff ToolboxItemAdded ToolboxItemDisabled ToolboxItemEnabled ToolboxItemRemoved ToolboxItemTextChanged ToolboxItemUpdated ToolboxItemWindowChanged ToolboxSelect has been changed too (note that reading/writing of those payloads isn't very consistent, though: for some of these, values are written that are never read, while for some others no values are ever written but the reading code would like to receive some value if the payload wasn't a nullptr). Change-Id: I4856ffb3637404b8d866621a3503d7922b1b8141
2017-03-11Fix typosAndrea Gelmini2-2/+2
Change-Id: Ia79bc8d35cf19438d177f31a8e0c8603102b4ef1 Reviewed-on: https://gerrit.libreoffice.org/35061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-10shuffle this around a littleCaolán McNamara1-4/+4
Change-Id: Ibf23114885c49163d50b3249db8788770fe74352
2017-03-09Clean up uses of integer typesStephan Bergmann1-26/+27
Change-Id: If022ca9de8db49b885065c32b4f6f89debae1392
2017-03-08Simplify GetStateCache callStephan Bergmann1-2/+1
Change-Id: I527d8112f7cf0e4fbc6380484be0c6704f3dfdd4
2017-03-08No need for extra heap allocationStephan Bergmann1-79/+54
Change-Id: I69435ff2be66f8b2ed879bdf7998bd8145ef59b4
2017-03-08valgrind: fix leakCaolán McNamara1-1/+1
Change-Id: I49a9a03ef59bca5a5c43d2835e6c4f1cbf0cfab8
2017-03-08loplugin:loopvartoosmallStephan Bergmann8-39/+35
Change-Id: I788afd92bb404d8faf96b631d2e7c6f869e49c2d
2017-03-08make SfxGetpApp just get and move GetOrCreate to the peripheryCaolán McNamara2-2/+2
Change-Id: If3b22635e46dbccf0fad101f51bb653cbbcd3a32 Reviewed-on: https://gerrit.libreoffice.org/34957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-07shouldn't need these SfxGetpApp as it will already existCaolán McNamara4-9/+0
SfxGetpApp will get or create SfxApplication in normal use we start SfxApplication via SfxGlobalEvents_Impl ctor theGlobalEventBroadcaster right from the start in Desktop::Main Change-Id: I5fec2dfb79c8bc322266048603252a9aa93a883f
2017-03-07Notebookbar: don't show unnecessary separators in the popupSzymon Kłos1-0/+34
Change-Id: I89d11e2859676696e7bc0751ae9e71e5ae939a79 Reviewed-on: https://gerrit.libreoffice.org/34945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-03-07only one use of GetLastSaveDirectoryCaolán McNamara1-15/+0
which is to get its value and do a const_cast dance to save and restore its value which is a strange thing to do just for one obscure dialog when no other use of the save/load dialogs does this Change-Id: I7700d7ed738d578869284d415197de06167001b5
2017-03-07can use a reference hereCaolán McNamara1-28/+25
Change-Id: I3e9599e92679a66cae410090b5d17651a3698cce
2017-03-07Add Tooltips for emoji toolbar controlAkshay Deep2-6/+10
Change-Id: I93d9fb1af42d83c7f7f518a1441f4666fd7ee30a Reviewed-on: https://gerrit.libreoffice.org/32231 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-07remove dead codeJochen Nitschke4-142/+0
was deactivated in 2010 by commit 9334f7757330fdd113d37b3faed728e56e6330c8 Temporarily disable the extra ACL check. Change-Id: Ia9d2b7f55285e78f0737bf798b627740ccb11979 Reviewed-on: https://gerrit.libreoffice.org/34937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06convert ScrollingMode to scoped enumNoel Grandin3-9/+9
Change-Id: Ice1628ba09998be455fd6a77a044cb403235d462 Reviewed-on: https://gerrit.libreoffice.org/34914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06make use of the SfxItemSet::GetItem<T> methodNoel Grandin1-2/+2
Change-Id: I8201429993129b019a6dd51c203a9f8dcbb2253e Reviewed-on: https://gerrit.libreoffice.org/34867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06templatize HTMLEnumOption::GetEnum methodsNoel Grandin2-9/+7
And consequently fix bug in htmlfld.cxx in the RES_DOCSTATFLD/SwDocStatSubType handling, where it was updating the m_bUpdateDocStat fields by comparing the wrong enum variable. Change-Id: If9a68699a9d375ace120a3bf4f4bf4d4ae20a8e0 Reviewed-on: https://gerrit.libreoffice.org/34857 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann5-48/+48
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03lok: Listen to change tracking related commandsPranav Kant1-1/+3
Change-Id: Ieafd31342b356d7e95e4321cc49580b57f32e5be
2017-03-02Fix typosAndrea Gelmini4-5/+5
Change-Id: If5e709c9d6e3a4fbb568bdc261cccd214dd0cbd3 Reviewed-on: https://gerrit.libreoffice.org/34784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-01Correct indentation of try blockTor Lillqvist1-64/+65
Change-Id: I32ca961ebb4393e483bab12a6c69ab4c2016cc3f
2017-02-28loplugin:unoanyStephan Bergmann1-4/+4
Change-Id: Id50b15bbb9f8c62ac5258358431ff6ce0e7584d1
2017-02-28don't have to create SfxApplication if none existsCaolán McNamara1-6/+15
Change-Id: I312f00e8b2956470eaa496abfa2687c296f256ae Reviewed-on: https://gerrit.libreoffice.org/34717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-28might as well move append 'usage' into the msConfigPath from the startCaolán McNamara1-4/+5
Change-Id: Ie8a15f1a20621ebdd00ab4ed195495e0acd111a5
2017-02-28Revert "move append 'usage' into the msConfigPath from the start"Caolán McNamara1-4/+3
oops This reverts commit dc1c69a4efe9368a1f4fae4bc11325485bcc0772. Change-Id: I5fb9016040636fb44d4337567a6b894bfe16f503
2017-02-28might as well move append 'usage' into the msConfigPath from the startCaolán McNamara1-3/+4
Change-Id: Ic3e141d91607f8e34ff4a74cd1ae3276e42934e7
2017-02-28new loplugin unoanyNoel Grandin15-55/+55
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-28Run macro:// via LOKitKatarina Behrens1-1/+17
Change-Id: I54d3c734d86d4b44e1dfe1ad7728e2f51cd26d53 Reviewed-on: https://gerrit.libreoffice.org/34538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-27tdf#105829 Infobar design, tdf#102785 Font issueheiko tietze4-119/+106
Only one constructor to append an infobar Colors defined at one place in infobar.cxx based on InfoBarType Icons as an additional attribute of the notification Change-Id: I4dc85c2b4ef0b7eafc139290b3b4ee21636da6ec Reviewed-on: https://gerrit.libreoffice.org/34426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-02-25check for SfxApplication::Get means SfxGetpApp is just SfxApplication::GetCaolán McNamara2-3/+4
Change-Id: I12953d93c81bd60ad27284ac0b62c4435ac9e390
2017-02-24vector::data seems more natural than &vector::frontCaolán McNamara2-4/+4
Change-Id: I0ce48075ad186cf1f9bd3e13fa76269fa9819af1
2017-02-24rtfrow-crash.rtf throws a o3tl::divide_by_zeroCaolán McNamara1-0/+7
from writerfilter/source/dmapper/DomainMapperTableManager.cxx Change-Id: I69fca8376166850cdedbc7c2b3908d7336e8bed9
2017-02-24don't have to create SfxApplication if it doesn't already existCaolán McNamara1-5/+17
Change-Id: I3ade4e2c2513f334217a85c676ada93c5ed683ff
2017-02-24Notebookbar: Better resize supportSzymon Kłos1-42/+54
Change-Id: I0bb5a5600be60a68e53132f2c3c42f79c958b2b3 Reviewed-on: https://gerrit.libreoffice.org/34491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-23tdf#101652 No infobar when doc attr is readonlySamuel Mehrbrodt1-2/+2
One can set the a document attribute to open the doc read-only. In this case the read-only infobar should not be shown. Change-Id: I92b78dc3e20ccf0d258cdf3e4a79530f87a2e311 Reviewed-on: https://gerrit.libreoffice.org/34581 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-23Simplify logicSamuel Mehrbrodt1-18/+3
Change-Id: I4d2e94bb050f163cc691fda90be9dccbd2ca5e5f Reviewed-on: https://gerrit.libreoffice.org/34580 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-02-23loplugin:unusedmethodsNoel Grandin1-5/+0
Change-Id: I5a72ee666e71b4c5c8f43d327aa7e8eb62d1e51b Reviewed-on: https://gerrit.libreoffice.org/34537 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21Fix typos/translations, following 04644956e53dAndrea Gelmini2-3/+3
No automatic tools Change-Id: I3a6d18760f90c4ee02b9380758f97f6fca6c4428 Reviewed-on: https://gerrit.libreoffice.org/30874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-21loplugin:unusedmethodsNoel Grandin2-32/+0
Change-Id: I52a9f16f3ed543a3c83ca111df70e3f7ae1ef33c Reviewed-on: https://gerrit.libreoffice.org/34508 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21loplugin:subtlezeroinit: sfx2Stephan Bergmann2-2/+2
Change-Id: I1a880bb4df7866b1185ef862ff84693c44a73385
2017-02-21sfx2: fix incorrect debug outputPranav Kant1-2/+3
Fallback from 9351353b63886f494782f28f5400f5d71d22bcbd While at it, add one more such statement in Execute_ Change-Id: Ibebc6f007542751718b53ed978ee52c300d14439
2017-02-20Minor capitalization issuesAdolfo Jayme Barrientos1-3/+3
Change-Id: I2b817859e4e6e0ea6dd15b0052da2370a262c6a4
2017-02-21Use module name when getting labelsMaxim Monastirsky2-10/+3
Change-Id: I1d5196e1ca888dfb11d5bd6ef4676937dce49fdc
2017-02-21tdf#95844 Refactor CommandInfoProviderRohan Kumar4-5/+5
Instead of a singleton, CommandInfoProvider should just be a set of static methods. Change-Id: I16d4406e361a72f013d78f18d6bd0ae20c0cc5e9