summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2017-04-23Replace GetImage with CommandInfoProvider::GetImageForCommandMaxim Monastirsky10-224/+3
And move ToolBoxButtonSize->ImageType mapping code to a common place. Change-Id: If158f4b6f2750054fcf64491c2941706e7d3a329
2017-04-23tdf#95845 Use CommandInfoProviderMaxim Monastirsky2-58/+19
And a few unused theUICommandDescription includes. Change-Id: Ic80dbfb91e5e7662723efe0cb4090416994adabd
2017-04-23No usage of the private:commandimage thingMaxim Monastirsky1-15/+1
Change-Id: I8e5c1431f095c875cda6f66f16a03af4bbd1d1fb
2017-04-23Use automatic integer type, with minor simplificationsMatteo Casalin1-4/+4
Change-Id: I08b8370311b11d45ab744875f7ad6b885f318a74
2017-04-23OUStrings: avoid temporaries and constifyMatteo Casalin1-6/+5
Change-Id: Id6b4b26df09ddb750f3e5430636b41c89e4d9e8e
2017-04-23These data members can be file scope consts, and reusedMatteo Casalin2-24/+20
Change-Id: I977d523d6aefeb2475044783ba30744b950d3708
2017-04-22Notebookbar: better tab placing for the NotebookbarTabControlSzymon Kłos1-0/+24
Change-Id: Ia44ce20455829048be457584c49fde0996f4a699 Reviewed-on: https://gerrit.libreoffice.org/36814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky6-6/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21LOK - Calc: changed the way header is updated on row/col insert/removeMarco Cecchetti1-0/+11
This patch introduce a new LOK callback for informing the client that the row/col header is no more valid and needs to be updated. Change-Id: I21a3a41d69bd1a3c11c9ffaf1d7d53dbc3b9681d Reviewed-on: https://gerrit.libreoffice.org/36733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-04-21convert HTML_OPTION_IDS to scoped enumNoel Grandin2-24/+21
Change-Id: Ia766dc58a571e5853005fd394283d7b53f02e4a6 Reviewed-on: https://gerrit.libreoffice.org/36748 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin9-31/+31
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20convert EDynamicMenuType to scoped enumNoel Grandin4-4/+4
and drop unused E_HELPBOOKMARKS Change-Id: I5756ea326bdc1a99f7d6f1ba43baf6aca9f7f2fc Reviewed-on: https://gerrit.libreoffice.org/36728 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20loplugin:unusedmethodsNoel Grandin6-68/+1
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-19loplugin:inlinefields in SfxSplitWindowNoel Grandin2-24/+22
Change-Id: I62ea079e448c871de34d4a48a4e017dd456c7e72 Reviewed-on: https://gerrit.libreoffice.org/36664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-18Clarify intended behaviourMatteo Casalin1-1/+2
Change-Id: Ib1edda4886940223bd32c8a78d3aa4241f57ec84
2017-04-18Avoid 'else' after a returnMatteo Casalin1-32/+9
Change-Id: Ia530aa2fdaa5f6d77180da3139a47407adf9f519
2017-04-18Fix indentationMatteo Casalin1-6/+6
Change-Id: If2c567450c27fe442e8c68627888fe7d39a65acb
2017-04-18OUStrings: constify and reduce temporariesMatteo Casalin1-100/+65
Change-Id: I34f6d51ad3088d1561f103a21b78f4bb6780f95c
2017-04-18Reduce scope and simplify by early returnMatteo Casalin1-17/+9
Change-Id: I12f8c6cb002cb0af63a096c7b66dd1e7d2db92a5
2017-04-18Reduce scope and simplifyMatteo Casalin1-29/+22
Change-Id: I055e05ff04c9a839fb142be5cbf08e40e7eb35f3
2017-04-18OUStrings: constify and avoid temporariesMatteo Casalin1-42/+24
Change-Id: I91d5969468da6d9bd61bc7bd321cc065910f7639
2017-04-18OUStrings: constify and avoid temporariesMatteo Casalin2-8/+6
Change-Id: I06e058d3ae16bbf504f2e5d8f72b00527c53e336
2017-04-18OUStrings: constify and avoid temporariesMatteo Casalin1-9/+9
Change-Id: I8ba379d2418eec012de62354dab474e6e7c8a1c6
2017-04-18Remove isEmpty check on (just set) non-empty sURLMatteo Casalin1-5/+1
Change-Id: I669b720c976c51d248dadb11b5e93ab1708ccfbb
2017-04-18OUStrings: constify and avoid temporariesMatteo Casalin1-25/+19
Change-Id: Ib69ad52577f8d94dbd363ba1799d5294db7a580a
2017-04-18OUStrings: constify and avoid temporariesMatteo Casalin1-23/+13
Change-Id: I4459c84afbe68d29f1fd8dbce3c4aa6f7846a912
2017-04-18Avoid temporary OUStringsMatteo Casalin1-4/+2
Change-Id: I0fb456874595814339a420b61fbf4cb957af095e
2017-04-18tdf#95992 "Edit" > "Compare Document..." opens dialog that is...Matteo Casalin4-6/+55
misnamed "Insert" Issue is that the caption of the dialog is handled by generic code, which was not designed with comparison in mind. This fix extends the captions that can be used by such generic codes, without modifying the underlaying architecture. Letting callers directly provide caption text might be more versatile, though. The fix is extended to: * Writer Merge functionality * Calc Compare/Merge functionalities which use the same dialog (and thus were also displaying "Insert"). Change-Id: I452b37bf7d0024924c87316cd47572c09b373b65 Reviewed-on: https://gerrit.libreoffice.org/35285 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-18remove sfx2/sfxcommands.hCaolán McNamara3-5/+1
Change-Id: Ic131adc90f2891497623441dd94da2d3401a93e5
2017-04-15Fix typosAndrea Gelmini1-1/+1
Change-Id: I0238202c0dc0380b0e33a9c4567a9513c0afbe91 Reviewed-on: https://gerrit.libreoffice.org/36556 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-14convert style context menu to .uiCaolán McNamara7-65/+76
Change-Id: Ie72a1ecb91ddbbf2230ff2a56e361af98898d730
2017-04-14only one button should have has_default setCaolán McNamara1-1/+0
Change-Id: If47aa714e34d4acd7a9fc2e3f600ad4de847cdda
2017-04-14convert bookmark menu to .uiCaolán McNamara6-37/+53
Change-Id: I7b62c3234fd986a0648b9a543d0e44a922ee15e4
2017-04-13Removed duplicated includesAndrea Gelmini1-1/+0
No automatic tools. Manual checked and tested. Change-Id: Ife260fa4e1d786cf81f2917a901664cc54943754 Reviewed-on: https://gerrit.libreoffice.org/36371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-12can use gb_CppunitTest_use_configuration and still access .ui filesCaolán McNamara2-3/+2
after... commit 506cab1a01b0481d0831a7a692a26dc5a5b55e91 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Apr 12 16:14:10 2017 +0100 take the .ui files from $BRAND_BASE_DIR/$BRAND_SHARE_SUBDIR Change-Id: I9cffdc092206c038da32a32a2cfe629e68b5c258 Change-Id: I906d16037cdf0b9203a4120cb1a5e9846a5c7b7f Reviewed-on: https://gerrit.libreoffice.org/36482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-12Notebookbar: remove dependency between all containers and IPrioritableSzymon Kłos3-12/+14
Change-Id: I92bff0d68470763c88172744e82d9b5915ffb6f1 Reviewed-on: https://gerrit.libreoffice.org/36387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-04-12drop document_io_logring.txt and use global loggingCaolán McNamara5-235/+55
Change-Id: Ibda0ce925bc76355e636022c955077ac89e66cce Reviewed-on: https://gerrit.libreoffice.org/36434 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-10loplugin:inlinefields in SfxSaveAsTemplateDialogNoel Grandin1-10/+9
Change-Id: I7b32fc64b96e2f89edc810d4a95d3a3f6f885957 Reviewed-on: https://gerrit.libreoffice.org/36352 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-07Revert "Remove button handler and let the button dispatch the uno cmd"Michael Stahl1-1/+6
This reverts commit 6584735bba4b96fbde5c7be55dc6c98878ad059a. Ooops, that doesn't build any more without the previous reverted one.
2017-04-07Revert "Related tdf#105566 Update Infobar when signature status changes"Michael Stahl5-106/+36
This reverts commit d8faf3bf9a82e8f49340b5020ec4ee931cc2f3f4. This causes an infinite recursion in JunitTest_sfx2_complex involving the newly added SignatureHelper::updateInfoBarState().
2017-04-07Remove button handler and let the button dispatch the uno cmdSamuel Mehrbrodt1-6/+1
Change-Id: Iac4d0e1bf96505b02102ae94ca703c00d5348466 Reviewed-on: https://gerrit.libreoffice.org/36252 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-07Related tdf#105566 Update Infobar when signature status changesSamuel Mehrbrodt5-36/+106
gpg4libre Change-Id: I8f29cf16905c79d19d46662b087f4fd8778c8147 Reviewed-on: https://gerrit.libreoffice.org/36251 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-07Drop remains of the Welcome Screen featureGabor Kelemen1-12/+0
Which was dropped in e299ef4952a580bdbd416cef3e1a2feba4979e13 (that was in 2001) Change-Id: I5860bb44ced35b338f667e47d89f6ed1d597dc11 Reviewed-on: https://gerrit.libreoffice.org/36159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-04-06Improved loplugin:redundantcast, static_cast on arithmetic types: sfx2Stephan Bergmann2-2/+2
Change-Id: Ic524a0fc2c1038202456dcf0aa51a8a3eb9a70b0
2017-04-06Resolves: rhbz#1438876 detect preferred help module for csv dialogCaolán McNamara1-18/+33
For calc import before any toplevel is created the context is otherwise unknown. If a help id starts with a specific module name, then default to that module name as default help category context. Cosmetic, same help is shown in any case because its in the shared section, but title bar would state "Writer" when context is expected to be "Calc" Change-Id: I3323bc55ef23ec162dad4349efb5e84ec3e8054c
2017-04-06split out module->help mappingCaolán McNamara1-27/+40
and add the missing not-toplevel-in-help ones from... ls instdir/share/config/soffice.cfg/modules|sort|uniq Change-Id: I618d91e1271b3a200928494156d93cbfef45c19f Reviewed-on: https://gerrit.libreoffice.org/36206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-05teach constantparam plugin to find always on and always off bitmask valuesNoel Grandin4-11/+5
Change-Id: If56a483494bd3d7feb3fa67c01000dddd0d34421 Reviewed-on: https://gerrit.libreoffice.org/36085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05loplugin:constantparam part2Noel Grandin2-4/+3
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746 Reviewed-on: https://gerrit.libreoffice.org/36072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05loplugin:constantparamNoel Grandin1-1/+1
Change-Id: I1996319e5b664dff95f7a9b2346aea6092d333ec Reviewed-on: https://gerrit.libreoffice.org/36070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04Finally switch MSVC to sal_Unicode = char16_t, tooStephan Bergmann1-1/+1
There is lots of (Windows-only) code that relied on sal_Unicode being the same as wchar_t, and the best change may be different in each case (and doing the changes may be somewhat error prone). So for now add SAL_U/SAL_W scaffolding functions to sal/types.h, remove their uses one by one again, and finally drop those functions again. Change-Id: I2cc791bd941d089901abb5f6fc2f05fbc49e65ea Reviewed-on: https://gerrit.libreoffice.org/36077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-03 15:12:41 +0000