summaryrefslogtreecommitdiff
path: root/sc/source/ui/view/gridwin5.cxx
AgeCommit message (Collapse)AuthorFilesLines
2018-05-12Replace ScGlobal::GetRscString with simple ScResId callsGabor Kelemen1-2/+3
After the gettext migration there is no point to have two APIs for reading the same .mo file. This patch is for sc/source/ui/view/ for easier review. Change-Id: Ic07f7e924236d29f3cafd69c5ee634ae92105459 Reviewed-on: https://gerrit.libreoffice.org/54137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-17Revert "loplugin:changetoolsgen in sc" and reapply pluginNoel Grandin1-2/+2
because I (a) forgot to insert parentheses which changes the meaning of some expressions and (b) I now use the AdjustFoo calls when changing unary operations, which reads much better This reverts commit 95fab7cbf2f0576d0f728bed8898b7ff769d90e6. Change-Id: Icbdcc0f4227d88812be12e18ba6961088db80c3e Reviewed-on: https://gerrit.libreoffice.org/49840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-14loplugin:changetoolsgen in scNoel Grandin1-2/+2
Change-Id: Ic24332cac65e665b55b9e1bbaf09ee56066875fd Reviewed-on: https://gerrit.libreoffice.org/49703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-30tdf#113901: Grid offset for notes and temporary notes modified.Vasily Melenchuk1-20/+1
Older calculations for gird offset were incomplete: are not used for notes (only for temporary ones on mouse over), were not taken into account during temporary note disappear and contain duplicated code from ScDrawView::SyncForGrid() New approach elminate described above problems. Change-Id: I5f92971e156f37f052b4e6d47b2f16480bdbaf7e Reviewed-on: https://gerrit.libreoffice.org/44464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-10-23loplugin:includeform: scStephan Bergmann1-17/+17
Change-Id: I2ed763e0584a188032c80fde60890de3c6985cbd
2017-08-26loplugin:constparam in sc part7Noel Grandin1-1/+1
Change-Id: Ica5421ddc343ce18a08f993778f42183b571ed0e Reviewed-on: https://gerrit.libreoffice.org/41578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-23drop the SCsROW/SCsCOL/SCsTAB typedefsNoel Grandin1-5/+5
which are exactly the same as the regular SCROW/etc typedefs, and have been this way since commit 43a21999a92c99867bc3417291719996776b0647 Author: Oliver Bolte <obo@openoffice.org> Date: Fri Jun 4 09:00:39 2004 +0000 INTEGRATION: CWS rowlimit (1.1.2); FILE ADDED Change-Id: Ia7f75d71227ca3167b5fd56019bb9bdf0697d1b0 Reviewed-on: https://gerrit.libreoffice.org/37911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-04-06tdf#39468 Translate German commentsJens Carl1-1/+1
Translate German comments and terms in sc/ Change-Id: I93c7cf423325715435910a89420e7522b440c81e Reviewed-on: https://gerrit.libreoffice.org/36192 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna1-2/+2
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-15tdf#100726 Improved readability in sc directoryFakabbir Amin1-8/+7
cleaning concatenation in sc directory. Change-Id: I137eb0eaf161edece272b084980e622831200803 Reviewed-on: https://gerrit.libreoffice.org/34288 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-10convert SvtSecurityOptions::EOption to scoped enumNoel Grandin1-1/+1
and drop unused E_MACRO_DISABLE enumerator Change-Id: I0bd706d4d4e1d8b9004e68c9e77c11410c62a64a Reviewed-on: https://gerrit.libreoffice.org/34067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin1-1/+1
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-11-14coverity#703927 Unchecked return valueCaolán McNamara1-4/+4
make these less odd and simply return the thing they selected, rather than a bool that indicates that the rpObj arg was successfully set to non-null, so there's one flag to check not two which both mean the same thing. Change-Id: If70e412f98dea8b7114fb77f26a9c59aab93be50 Reviewed-on: https://gerrit.libreoffice.org/30794 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-22convert SdrHitKind to scoped enumNoel Grandin1-1/+1
Change-Id: Ia7a18814fed7787e47ac2d3c02654a3648c5491e
2016-08-19convert SdrEventKind to scoped enumNoel Grandin1-1/+1
Change-Id: I96c298089d9ca75909380843c7dbc255c4953b88
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann1-11/+11
Change-Id: I765d2a600f9c57da50c85354688e3ae796750d94
2015-10-28com::sun::star->css in scNoel Grandin1-2/+2
Change-Id: I7774890f46f9343e944e34db27af8bce3b1d0915
2015-10-20loplugin:defaultparamsStephan Bergmann1-1/+1
Change-Id: If189c1e4254ae00725ec76a5ca6354d24df2d351
2015-10-05tdf#94687: Keep original ordering of overall initialization stepsStephan Bergmann1-0/+1
...between ScGridWindow::CreateAccessible, ScAccessibleDocument ctor, and ScAccessibleDocument::Init, by introducing ScAccessibleDocument::PreInit into which the this-using parts of the ScAccessibleDocument ctor are offloaded now. This is a follow-up to 6f1e77fc600f776433a759172323b4afec3d811e, "rhbz#1264753: Avoid this being release()ed to 0 in ScAccessibleDocument ctor;" turns out my fears that the slight re-ordering of initialization code coulb break something were well-founded after all. Change-Id: Ibf62983030d7abbe4b1ead9ee5add5f9627e7d60
2015-07-19fdo#39468 translated german comments in gridview4.cxx and gridview5.cxxAlbert Thuswaldner1-15/+15
Change-Id: I2537bedfab6856787d9b75e919cd3973a514bd3c Reviewed-on: https://gerrit.libreoffice.org/17184 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-06-25loplugin:stringconstant: Flag more inefficienciesStephan Bergmann1-2/+2
Change-Id: Icdd850336caf998e62cdb5a90fc3683eddd04a3e
2015-04-29convert SDRMOUSE constants to scoped enumNoel Grandin1-1/+1
Change-Id: Ia5389095683a1c012a988ed71bf769a1f25d80fb
2015-04-29convert SDRSEARCH_ constants to scoped enumNoel Grandin1-2/+2
Change-Id: I1495dbaf05b642d98f41639d41f831f007601df3
2015-04-23loplugin:staticmethodsNoel Grandin1-1/+1
Change-Id: I6207b475127099872c6f3764331006688129b673
2015-04-07Remove dead INetProtocol::VimStephan Bergmann1-1/+1
...which removes the need to abstract over the standard URI '%' escape prefix vs. the silly vim '=' special case invention. Change-Id: I54a52dd912c3aafc38275a0ac2466a6daeec328f
2015-03-10GridWindow: change pNoteMarker to unique_ptrTomaž Vajngerl1-17/+19
Change-Id: I1e141632172f53ddbd2f5f434206646c9a1e9cf0
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara1-12/+0
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-05Resolves fdo#87863: Calc tooltip text for hyperlink wrong on OSXJulien Nabet1-1/+10
I copied pasted the Writer way, with "follow" and "link" instead of "open" and "hyperlink" There are still the management of ":" + space (which could be different according to i10n) Change-Id: Ic8516c667b1882030d527add228a98e1081f608f Reviewed-on: https://gerrit.libreoffice.org/13712 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin1-3/+3
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: https://gerrit.libreoffice.org/12333 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin1-1/+1
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-10-28loplugin: cstylecastNoel Grandin1-2/+2
Change-Id: I42cd0be78478536322357ca7a03cf30e624b1afc
2014-09-23fdo#82577: Handle WindowNoel Grandin1-4/+4
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-10callcatcher: update unused codeCaolán McNamara1-18/+0
Change-Id: Ie31c16318b09699e080484292d489a378e3a6dce
2014-07-23Revert "opengl charts: Move the init from sc to chart2 ...Markus Mohrhard1-0/+13
This reverts commit 46cea34638b371570073c0e86f79969753c543ed. Conflicts: chart2/source/view/charttypes/GL3DBarChart.cxx Change-Id: Ia29ea6a95b8b9eb870d14538d0cadaa40472582f
2014-07-22callcatcher: update unused codeCaolán McNamara1-13/+0
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
2014-06-25remove whitespaceMarkus Mohrhard1-2/+0
Change-Id: Ib15413e73409cc33de01fa92a47b9d1237cfc4b2
2014-05-08fix another crash on exitMarkus Mohrhard1-0/+13
Change-Id: I580d17b16760516b73ac9f882fd8f9707ce6337b
2014-05-07fix crash on exitMarkus Mohrhard1-0/+5
Change-Id: I31374684a09f1b056154efcaa5c7dfe73bcc1a61
2014-04-23sc: sal_Bool->boolNoel Grandin1-6/+6
Change-Id: I70aad0b38979f45a313b8ac36890fb6c64d11bb0
2014-04-06whitespace cleanup in scMarkus Mohrhard1-2/+0
Change-Id: Id1dcadcac179c52977e48a6912ce4d5fd542f60c
2014-04-01Bin pointless INET_HEX_ESCAPETor Lillqvist1-1/+1
Change-Id: I72238e511c2fca4a4aba0be60b0f2d3b1f46e5c2
2014-03-22coverity#983377 Dereference before null checkCaolán McNamara1-18/+15
Change-Id: Ifca7439523d63919b631b24d9edc8e471027a7d3
2014-02-23Remove unneccessary commentsAlexander Wilms1-2/+2
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21vcl: sal_Bool -> boolStephan Bergmann1-2/+2
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-19sal_Bool->boolNoel Grandin1-1/+1
Change-Id: I1269075218632a2fe6979c85c395e267ddd80008
2013-12-02Integrate branch of IAccessible2Steve Yin1-2/+22
Conflicts: everything Change-Id: I3d8cf956f511a0d953a1cefe83b6ef987806da25
2013-10-23Re-implement cell note storage using mdds::multi_type_vector.Laurent Godard1-1/+1
Change-Id: I34ea91e360e2a6b85d65f970c6e43db687d213ca
2013-10-08convert sc/source/ui/view/*.cxx from String to OUStringNoel Grandin1-16/+16
Change-Id: I906217b453d3a0ec2ec8deaa5dce739f0cacfd01
2013-10-04convert sc/source/ui/inc/gridwin.hxx from String to OUStringNoel Grandin1-1/+1
Change-Id: Ib2b5185dfb803a8b8321f6025ab7b91d2d5af65a
2013-06-24fdo#51296 Helptext added for hyperlinks, hlinks behave as in writerAkash Shetye1-4/+44
Added prefixed of "ctrl+click to open hyperlink" to hlinks depending on the security setting. Now clicking links behave as in writer. Change-Id: I87d0fecb6268463cd99478b70eb081ed958976be Reviewed-on: https://gerrit.libreoffice.org/4051 Signed-off-by: Luboš Luňák <l.lunak@suse.cz>