summaryrefslogtreecommitdiff
path: root/sal
AgeCommit message (Collapse)AuthorFilesLines
2016-09-29tdf#83306: sal: fix compare of rtl::OUString/OString containing '\0'Michael Stahl1-4/+5
For whatever reason oox shape import code uses OUStrings that contain '\0' characters. The rtl_uString / rtl_String are allowed to contain '\0' but the strncmp/wcsncmp functions stop comparing on the first '\0', so use memcmp/wmemcmp instead. (regression from 281989007fd7dea997ed9a65f513f80b1aff67dd) Change-Id: If148927f19d065a21f32f3c14433b0bda7ae9301 Reviewed-on: https://gerrit.libreoffice.org/29384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit de7ed418e7813c85f192b558ff06e976eccaa54d) Reviewed-on: https://gerrit.libreoffice.org/29387 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-20move the code for tdf#99410 to the sal init windows codeMarkus Mohrhard1-0/+6
Change-Id: I4ead30fa1736a3a99fb3379e89367934c8df2809 Reviewed-on: https://gerrit.libreoffice.org/26444 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 909d87cc6187ecffa2704e67ffbe372fd2d90e49) Reviewed-on: https://gerrit.libreoffice.org/26489
2016-06-07tdf#100021 - format argument issue in process.cxxRichard PALO1-1/+1
avoid warning whether pid_t is long or int Change-Id: I533175b53166cb233169902d277906f5ce979421 Signed-off-by: Richard PALO <richard@NetBSD.org> Reviewed-on: https://gerrit.libreoffice.org/25593 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit acbbb01940588604de965c4fcef64b2e17473fe6) Reviewed-on: https://gerrit.libreoffice.org/25979
2016-05-25SAL_FALLTRHOUGH in Windows-only codeStephan Bergmann2-0/+4
Change-Id: If35da46c209746a86687e1c3f60f72f2f08aa681
2016-05-22Convert oslCheckMode to scoped enumNoel Grandin1-13/+13
Change-Id: I7cd31d5624682bf7bd021586769593499d2481af Reviewed-on: https://gerrit.libreoffice.org/25204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-22Convert AllocMode to scoped enumNoel Grandin3-12/+12
Change-Id: I642d7546059f1af993ab15eb3948949109df05c4 Reviewed-on: https://gerrit.libreoffice.org/25203 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18limit scanf string field widthJochen Nitschke1-2/+2
Change-Id: I9070bae914d923171b6eaf8209de00922dc87be7 Reviewed-on: https://gerrit.libreoffice.org/25052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-05-16get breakpad signal handler working on windowsMarkus Mohrhard1-2/+12
The LibreOffice signal handler overwrites the breakpad signal handler. Just store the old handler and call that handler before we do any work in our own handler. Our own handler implementation is just insane as we are even trying to take the SolarMutex which can easily deadlock. Change-Id: I2401bba18701115561d00c7fc11138ead2a48205 Reviewed-on: https://gerrit.libreoffice.org/25022 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-16fix typoMarkus Mohrhard1-1/+1
Change-Id: Icfc4b73d5664c205ad642c660af5227f403d20ff Reviewed-on: https://gerrit.libreoffice.org/25021 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-12-Werror,-Wimplicit-fallthroughTor Lillqvist1-6/+6
Fix "fallthrough annotation in unreachable code". Clang is clever enough to know that code after assert(false) is unreachable in a non-NDEBUG build. Seriously, micro-optimisation of the case that should never be reached? Change-Id: I10d7ae60895437be52c27aa93539d17e0f091ac4
2016-05-11sal: -Werror,-Wimplicit-fallthroughMichael Stahl1-2/+2
Change-Id: Id8262e735b9f95d8b476a4939c362648e2a4328a
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann3-0/+16
Change-Id: Ib67f7cb71255a32810f09a6b7e528f024bbef9df
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann3-10/+8
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-05clang-tidy modernize-loop-convert in oox to saxNoel Grandin2-17/+17
Change-Id: If0d87b6679765fc6d1f9300c6972845cf3742b9c Reviewed-on: https://gerrit.libreoffice.org/24674 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-02sal_Bool -> boolStephan Bergmann1-2/+2
Change-Id: I6e86cb7ffbd8c8cbf3cccaef656cf7b7e755e24f
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin1-9/+1
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-22Avoid reserved identifiersStephan Bergmann1-5/+5
Change-Id: I0164df28e2d05f4f73bd640d3ca3cc3220b57df6
2016-04-22Is __OPENTRANSPORTPROVIDERS__ (still) neededStephan Bergmann1-1/+0
...to be set before including Carbon/Carbon.h? Was originally introduced with c34f2e30bbad1a6b92308d0daabe413bd1bc161b "INTEGRATION: CWS pj51: #i61959# patch applied", but might just be cargo cult these days. Change-Id: I20cdc938d28e075614f6711a06ab785700833aff Reviewed-on: https://gerrit.libreoffice.org/24293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-21Remove redundant checksStephan Bergmann1-2/+0
(that started to cause loplugin:salbool after 13758a3d154e8e450fdfe8bcdeb6b3a03996c53a "SourceManager::isMacroArgExpansion has only one param in older Clang") Change-Id: Ibbdf4552d81385cf952e2d47d1fe23daf78824b5
2016-04-21new plugin stylepoliceNoel Grandin1-12/+12
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann18-111/+111
Change-Id: I6c656f991999791469015500aff1905fdb16ba65
2016-04-18clean-up: unused using declarations and includesJochen Nitschke4-8/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-15fix case when fileName lacks "/MacOS/"Douglas Mencken1-2/+3
Change-Id: Ic89d1c3be1939c8989ad5ee806980e8904f8e44d Reviewed-on: https://gerrit.libreoffice.org/24069 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-14Work around -Werror=logical-op (GCC 6)Stephan Bergmann1-34/+33
...when SIG_DFL happens to be defined as nullptr, by initializing the Signals array to SIG_DFL in the first place Change-Id: Ie9183540e2e8fd795aa288bf30266bc5d9af3e69
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke2-2/+0
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-12Avoid reserved identifiersStephan Bergmann1-55/+55
Change-Id: I0a8dc9591c00188d0a31feb784d14ec53f389f27
2016-04-11tdf#94306 replace boost::noncopyable r.. to sdextJochen Nitschke7-18/+40
... in modules reportdesign to sdext Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Make some overloaded ctors explicit (most in sd slidesorter). Add deleted copy-assignment in sc/inc/chart2uno.hxx. Change-Id: I21d4209f0ddb00063ca827474516a05ab4bb2f9a Reviewed-on: https://gerrit.libreoffice.org/23970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-07Drop pointless "internal" directory level for already internal include filesTor Lillqvist22-18/+18
Change-Id: I496fdbab3e17c806c2d16513412c4c1b9120bc3c
2016-04-07Bin unneeded forward declarations of static functionsTor Lillqvist1-30/+0
The file contains their definitions before they are used anyway. Change-Id: Iaa541ec9a12e4971c0cd4ba7cfb4790d328b7b63
2016-04-06sal: GetSystemTimePreciseAsFileTime requires Windows 8Michael Stahl1-6/+7
3979afceecb98780549fda60c7f75c8015bb33d8 broke the build on Windows 7. Change-Id: I142208c062d56d6a3daa8213a877411edde45e55
2016-04-04osl_getSystemTime: use high precision timer of W32, if availableLászló Németh1-2/+20
Change-Id: I7029f37639ead7a8b597ff39d1abcd295fab0551
2016-04-04tdf#97499 Fixed containers parameters clearing #4tymyjan1-1/+1
Change-Id: I7c96181399f4d7e62d4aceca404b22d68f903513 Reviewed-on: https://gerrit.libreoffice.org/23754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-01tdf#97966 Drop 'static' keywordsWastack2-3/+3
Including no keywords from extern "C" blocks Change-Id: I87f2ed75888b51ec9e0cb75566bf7c2351b479b4 Reviewed-on: https://gerrit.libreoffice.org/23675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31...one more detail to get things fixedStephan Bergmann1-2/+2
Change-Id: If5d3cb2242e08e559380a4e2c86c96dc6cdc0c71
2016-03-31Fix Windows part of 97858ca008fd8cf405e52795c8db415ef6c5afb3Stephan Bergmann4-17/+4
"tdf#93548 Refactor sal signal to reduce code duplication" Change-Id: Ib0a872fb6023b6989c7931f4d57d911ddf76936f
2016-03-30loplugin:staticanonymousStephan Bergmann1-1/+1
cf. <https://gerrit.libreoffice.org/#/c/23630/> "tdf#97966 Compiler plugin"; in code not covered by Tamás's pending "tdf#97966 Drop 'static' keywords" changes. Change-Id: Ifbaef83fdb1fde7e25fafd5746cdbf99c334c5be
2016-03-29tdf#93548 Refactor sal signal to reduce code duplicationAleksas Pantechovskis5-339/+302
Change-Id: Iff331a48fadc23da8b24f9ca3a841000313a03dd Reviewed-on: https://gerrit.libreoffice.org/23477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-29handle failure to expand ~ in path elements.Michael Meeks1-2/+5
This can occur in some online corner-cases. Change-Id: Id8b419179d775a21110d682ba76d8a02f45eb828 Reviewed-on: https://gerrit.libreoffice.org/23577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-29sal: re-enable most getSystemPathFromFileURL tests.Michael Meeks1-13/+22
Change-Id: If03ec4f8705b75b9d007078260ef8cca5155a8f3 Reviewed-on: https://gerrit.libreoffice.org/23576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-22tdf#84323: Make osl::Thread::wait more readableGurkaran1-2/+2
It is to improve the readability of calls to osl::Thread::wait. Change-Id: I025d89abf8e84ca73ba08f001be3f45b86c89957 Signed-off-by: Gurkaran <gurkran@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/23416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16Remove code that has been commented-out for longTor Lillqvist1-69/+0
Commented-out in a198aa60a9d346128043e3e65ae82bb8ff670272 in 2005. Change-Id: Id174dae6632fa8d8e9845b06b916a8515cd6acf3
2016-03-15loplugin:constantparamNoel Grandin1-6/+6
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-11Better fix for -Werror=shadowStephan Bergmann1-16/+20
Change-Id: I2dff3eeef6e9d2bcf089f054475c164c8c641941
2016-03-10-Werror=shadowStephan Bergmann1-2/+2
Change-Id: I82d2d44fd43ff2a641df74b9e05aea01991d001c
2016-03-10Remove unnecessary typedefs (that introduced reserved identifiers)Stephan Bergmann1-5/+5
Change-Id: I42d09cccf07dca6733f763b1026f6c138cb70a61
2016-03-10Avoid reserved identifiersStephan Bergmann1-10/+10
Change-Id: I309985d65752c4aa041cdb7c060c32d4312d442d
2016-03-10Remove unnecessary typedefs (that introduced reserved identifiers)Stephan Bergmann1-10/+10
Change-Id: I726ca611cce66d7e25dc91b8baaec7e588eb1b8e
2016-03-10Avoid reserved identifiersStephan Bergmann1-32/+32
Change-Id: I074b5c4b9caec0a1c22f36e153a84104c5187e91
2016-03-10Drop __osl_ prefix from static entities (avoid reserved identifiers)Stephan Bergmann1-10/+10
Change-Id: I725783d10bc1e6300c480542c536d409433ff532
2016-03-10Drop __osl_ prefix from static entities (avoid reserved identifiers)Stephan Bergmann2-32/+29
Change-Id: I68e51e09ffea9328034254b694b01082dbb4e3bd
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-08 19:55:20 +0000