summaryrefslogtreecommitdiff
path: root/reportdesign
AgeCommit message (Collapse)AuthorFilesLines
2016-07-08Resolves: rhbz#1353069 don't clear XATTR_FILL* from stylesheet if...Caolán McNamara2-3/+3
the master page is not the sole owner. Which happens when copying and pasting slides which bring along a duplicate master page to an already existing one, and the attempt to remove the duplicate strips the fill properties from the shared stylesheet in use by the other regression from... commit b876bbe2cacce8af379b10d82da6c7e7d229b361 Author: David Tardon <dtardon@redhat.com> Date: Tue Apr 26 09:17:11 2016 +0200 rbhz#1326602 avoid exp. bg bitmaps from deleted slides Change-Id: I91fb8f622a0e35741ecc37cef14fc93199bb730b (cherry picked from commit de4908eb4d2f1f2ce38a37eea18a9efc4a0073b1) Reviewed-on: https://gerrit.libreoffice.org/26975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-06-23Resolves: tdf#100303 Report crashes on close of conditional formatting dialogCaolán McNamara2-1/+5
Condition multiply inherits so the Builder::disposeBuilder call was missed and prenotify occurs during ::dispose when there is no m_pConditionPlayground anymore, so m_pConditionPlayground == 0 where pPlaygroundCandidate is 0 passes, so a random widget gets cast to somethings its not, hence the bad cast exception Change-Id: I6d081dd55df1a68ab893294858e1ab0054d5e049 (cherry picked from commit 547e4b3a80708600edbc3f5669b4428877b5a951) Reviewed-on: https://gerrit.libreoffice.org/26568 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-15tdf#100325 reportdesign: try to set URL as DocumentBaseURLMichael Stahl1-0/+5
... if it is missing, similar to what SfxObjectShell::DoLoad() does. Change-Id: I5b0ae1f892355a5e9786d590c821656b58d29cf2 (cherry picked from commit cd7671ef5e3102e91c68588d1ccc39d2521af561) Reviewed-on: https://gerrit.libreoffice.org/26332 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-25(nearly) nothing uses GetUniqueId anymore, so remove it.Caolán McNamara5-11/+1
The odd one out is the usage in Formula, which attempts to restore focus to a particular window identified by an unique id. In this case restore focus by keeping a VclPtr to the desired window. Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
2016-05-25Fix typosAndrea Gelmini1-1/+1
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266 Reviewed-on: https://gerrit.libreoffice.org/25420 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Revert "remove some manual ref-counting"Noel Grandin2-6/+8
until I have a better understanding of the UNO reference counting. This reverts commit 111de438ea3e512a541281dc0716cc728ea8d152.
2016-05-24remove some manual ref-countingNoel Grandin2-8/+6
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: Ie1abeaed75c1f861df185e3bde680272dbadc97f Reviewed-on: https://gerrit.libreoffice.org/25363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-23clang-tidy clang-analyzer-deadcode.DeadStoresNoel Grandin2-34/+10
Change-Id: I7113a13ac36db5beef3a17e9849c1f5506df2374 Reviewed-on: https://gerrit.libreoffice.org/25194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-20Convert PROP_FLAG to scoped enumNoel Grandin4-70/+72
Change-Id: Ia08a22cffa07c6c3a82497671d0e246fc5aa88a0 Reviewed-on: https://gerrit.libreoffice.org/25163 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19loplugin:unusedmethods in package to rscNoel Grandin5-50/+3
Change-Id: I61c6f56a69891d656a41d3617d0ce2b34d848c84 Reviewed-on: https://gerrit.libreoffice.org/25108 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin2-10/+10
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12reportdesign: replace rest of boost::ref usage with C++11 lambdasMichael Stahl6-29/+13
Change-Id: Ib530bbecbbb19fa09b24d3837d8f8f023d4ed359
2016-05-12reportdesign: replace boost::bind with C++11 stuffMichael Stahl4-22/+41
Change-Id: Idd164e36d6f20a24123886ee1f15202c796eacc6
2016-05-12convert SFXWB file dialog flags to scoped enumNoel Grandin1-1/+1
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b Reviewed-on: https://gerrit.libreoffice.org/24881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann5-8/+8
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann2-1/+3
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-05-10convert WINDOWSTATE_MASK to scoped enumNoel Grandin1-1/+1
Change-Id: Ic8259d81d8080c518aa07697e253a59cd6efaa4b
2016-05-09convert FONT_EMPHASIS_MARK to scoped enumNoel Grandin1-1/+1
Change-Id: I137c78b337e57d3442db08334128e79d186b278f Reviewed-on: https://gerrit.libreoffice.org/24753 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin6-6/+6
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-05clang-tidy modernize-loop-convert in oox to saxNoel Grandin9-48/+48
Change-Id: If0d87b6679765fc6d1f9300c6972845cf3742b9c Reviewed-on: https://gerrit.libreoffice.org/24674 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04use Any constructor instead of temporariesNoel Grandin1-3/+1
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-04-27Add default line width defines for TableBordersslideon1-2/+4
This define makes things clearer. Change-Id: Idd4abf11ed7657c688ea95aac1958ee4b1fd32ee Reviewed-on: https://gerrit.libreoffice.org/23732 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-25Some more sal_Bool -> boolStephan Bergmann1-1/+1
Change-Id: Ic36c3d707e75c541e443cc4c0b4da9625ae08ef3
2016-04-22Avoid reserved identifiersStephan Bergmann23-94/+94
Change-Id: Ifccf58c748ca8189949efeecc1ac7329a07be1f7
2016-04-22Elide const varsStephan Bergmann1-6/+2
Change-Id: I1b2a7b071f9740e8c848f543e32fd47f054c8318
2016-04-21new plugin stylepoliceNoel Grandin1-2/+2
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann20-91/+91
Change-Id: Ieee84933a3067cada2e8105ac61db994f282c383
2016-04-20Replace sal_Bool with bool in vector<pair<...>>Stephan Bergmann2-5/+5
Change-Id: I158e78ff4c7fc5d5d894a27599d533419eea1fe7
2016-04-20clang-tidy clang-analyzer-deadcode.DeadStoresNoel Grandin1-2/+1
suspect that some of these may reveal latent bugs.... Change-Id: I9de9aabbda9c8952715631577c29c1830df1eb71 Reviewed-on: https://gerrit.libreoffice.org/24200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18cppcheck: silence known condition warning in reportdesignJochen Nitschke1-23/+19
Change-Id: I6debdd6fce7296e8a8827eab7a99fe96ef176d12 Reviewed-on: https://gerrit.libreoffice.org/24202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-18Avoid reserved identifier (_CreateShape -> CreateShape)Stephan Bergmann2-4/+4
Change-Id: Idcdd35302e60392fae9f63de1828e1a41ab89610
2016-04-18Avoid reserved identifier (_CreateSdrObject -> CreateSdrObject_)Stephan Bergmann2-3/+3
Change-Id: Iee63999e4953a083783cb5c9811640150616472d
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin2-3/+2
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke2-2/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin4-8/+8
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in reportdesignNoel Grandin15-26/+26
Change-Id: I6e024c3043e1fa9f618e96088581ade3c3a00c3c
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke3-3/+0
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-12Avoid reserved identifiersStephan Bergmann3-9/+10
Change-Id: I93e7c254f8777c2dfbb192b306c991387d9cc641
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke3-7/+1
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11tdf#94306 replace boost::noncopyable r.. to sdextJochen Nitschke13-31/+30
... in modules reportdesign to sdext Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Make some overloaded ctors explicit (most in sd slidesorter). Add deleted copy-assignment in sc/inc/chart2uno.hxx. Change-Id: I21d4209f0ddb00063ca827474516a05ab4bb2f9a Reviewed-on: https://gerrit.libreoffice.org/23970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04coverity#705112 Using invalid iteratorCaolán McNamara1-2/+2
Change-Id: I95a4646e7ecff90babd8c140fdfa5f6fc47ce399
2016-04-03coverity#1358027 silence Using invalid iteratorCaolán McNamara1-2/+2
Change-Id: Id4306122a7d51491392996b8914e1411e9a4ed0f
2016-04-01tdf#97966 Drop 'static' keywordsWastack1-1/+1
Including no keywords from extern "C" blocks Change-Id: I87f2ed75888b51ec9e0cb75566bf7c2351b479b4 Reviewed-on: https://gerrit.libreoffice.org/23675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31tdf#97525 vcl: make DeletionListener internalJochen Nitschke2-2/+0
move include/vcl/impdel.hxx to vcl/inc/ include impdel.hxx in salframe.hxx remove vcl/impdel.hxx includes in pch add missing <list> includes Change-Id: Id146363b2e20ce0238542929c26a83efb1e8c4bd Reviewed-on: https://gerrit.libreoffice.org/23664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin11-20/+21
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-31use SAL_N_ELEMENTS in for loopsNoel Grandin8-34/+30
for with git grep -n 'for.*sizeof' Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f Reviewed-on: https://gerrit.libreoffice.org/23569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-29Avoid reserved identifiersStephan Bergmann2-28/+28
Change-Id: I759939aa74570be63f5d41814c22aad1851d65c4 Reviewed-on: https://gerrit.libreoffice.org/23587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-29Use const_iterator when possible (reportdesign)Julien Nabet17-107/+107
Change-Id: I2695fdf64670f4df844c1362a84af83f48fc29be Reviewed-on: https://gerrit.libreoffice.org/23575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-23loplugin:constantparam in reportdesignNoel Grandin9-22/+13
Change-Id: Ic1bba5e63359894115b3d1e293a5d9efdab041e1
2016-03-18loplugin:constantparam in formulaNoel Grandin1-1/+1
Change-Id: I3adeed435b62ae60b5d0d4b763dceced5675cd85 Reviewed-on: https://gerrit.libreoffice.org/23330 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-20 10:20:26 +0000