summaryrefslogtreecommitdiff
path: root/oox
AgeCommit message (Collapse)AuthorFilesLines
2014-12-22ERROR: Invalid content was found starting with element 'p:pic'.Miklos Vajna1-2/+5
Again, as pointed out by CppunitTest_sd_export_tests. Sadly it seems that the spec and PowerPoint is not in sync here, so just do what makes both happy. This fixes the --with-export-validation build. Change-Id: I49e22d154d30106f91f1c972012f99a863784d23
2014-12-22ERROR: Attribute 'spid' must appear on element 'p:oleObj'.Miklos Vajna1-0/+1
As pointed out by CppunitTest_sd_export_tests. Change-Id: I8ecbc3ef4ea9dc84ebf88506967d02de04ded852
2014-12-22bnc#862510: PPTX import: Wrong text vertical adjustment inside shape.Zolnai Tamás2-1/+16
When alignment is not specified, it should be set to the default "left" value just on time, when properties are pushed to the property set, otherwise uninitialized value is better. Change-Id: Ic294c5d7cc477f7515aea1c071ad9b67275c012d
2014-12-22bnc#862510: PPTX import: Wrong text color inside shapeZolnai Tamás1-5/+8
When theme index is 0, it means it's unset so we should not apply that. Change-Id: I62a9cd2a9b4c19f5acffc334d5e8263fe24fc8fd
2014-12-22bnc#822341: PPTX export of embedded text documentsZolnai Tamás1-27/+81
-Make embedded text documents exported by analogy with spreadsheet embedded documents. -Convert MS ole objects to LO sepcific objecst to allow exporting those ole objects too. Plus use gb_CppunitTest_use_rdb instead of wasting time on finding out which missing components cause test failing. Especcially when we have platform dependent components (e.g. related to embedded object) Change-Id: Ic76d659b51274777a1669c215344a1169ebcba81
2014-12-22Refactor building perfect hash tabels for tokensDaniel Sikeler2-100/+5
moved the defines to be usable in more modules moved perl-script to be usable in more modules Change-Id: If893e4b7e9dc670646bdf097cb6fa5710e45f1ac
2014-12-19fdo#39440 reduce scope of local variablesMichael Weghorn1-1/+1
This addresses some cppcheck warnings. Change-Id: Idcedd908c653d5a5700884f233ad134dde8be018 Reviewed-on: https://gerrit.libreoffice.org/13540 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-19WaE: variable 'nModuleCount' set but not usedTor Lillqvist1-1/+1
Change-Id: If7893fcfbac978710c664cfd013910ece77cda59
2014-12-19defining a macro for two lines of code introduces more noiseNoel Grandin1-4/+2
.. than it solve Change-Id: Ic60021aa428289fffb26bc349425e9b8be520d0a
2014-12-19remove operator>> and operator<< methodsNoel Grandin4-11/+12
in favour of ReadXXX/WriteXXX methods Change-Id: I75fcb04cb9e2981a10146a96de27916ca7f6bc57
2014-12-19remove operator>> and operator<< methodsNoel Grandin4-10/+7
in favour of ReadXXX/WriteXXX methods Change-Id: I849fd10c689fb9834ae9974e430dc337adc68755
2014-12-18cppcheck: Same expression on both sides of '||'Julien Nabet1-1/+1
Change-Id: Ibdadac46483ca3b17a12e3d1ae31f75a869b8dbc
2014-12-18oox: Use appropriate OUString functions on string constantsStephan Bergmann7-22/+22
Change-Id: I63db342676e1116c2ed1eef4e27599add0a318c9
2014-12-17Introduce rtl::OUStringLiteral1Stephan Bergmann3-4/+4
...to use single ASCII character literals "more directly" in the OUString API (instead of having to go via an intermediary OUString ctor call). Especially useful for character literals that are defined as const variables or via macros ("direct" uses of character literals in the OUString API can often simply be replaced with single-character string literals, for improved readability). (The functions overloaded for OUStringLiteral1 are those that are actually used by the existing LO code; more could potentially be added. The asymmetry in the operator ==/!= parameter types is by design, though---writing code like 'x' == s is an abomination that shall not be abetted.) Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
2014-12-15Resolves: fdo#87281 Crash on importing diagram in .docx fileGary Houston1-1/+3
Change-Id: Ic2c7326ab83258e2e9dcbac88aa9f76f771a9b12
2014-12-15no point checking for null before deleteCaolán McNamara1-5/+1
Change-Id: I58cbb075a56518d71874137180ad92ae764ec4bf
2014-12-15oox: Use appropriate OUString functions on string constantsStephan Bergmann11-34/+32
Change-Id: I55ee581c9d3fc0a17639833a6a034e2addf768d1
2014-12-12fix commitNoel Grandin1-1/+1
fix my commit aa2f02a4dc8a05f49e679a26f2beebb9d66b232 "remove operator>> and operator<< methods" I incorrectly inverted the conditional Change-Id: Iade05b88bdedb7e5b0cff25a80d3b88ff4a0235f
2014-12-12remove operator>> and operator<< methodsNoel Grandin13-60/+81
in favour of ReadXXX/WriteXXX methods Change-Id: I69eebee3a8ce5b40301db7940a1d85915c0bf6f4
2014-12-05fdo#38835 strip out OString globalsNoel Grandin1-53/+53
Change-Id: Id2eb27132fd6c1734e50c02617ce1bbb75e294a0
2014-12-02Resolves: fdo#70157 fix crash on loadingCaolán McNamara1-3/+7
Change-Id: I0d248a195852c14cd95d4e337823076dd2fbc19d
2014-11-30PPTX import: shape effect properties defined by themeZolnai Tamás1-1/+4
Effect import is so poor by now that this changes does not seem to have any effect, but later it can be helpful. See also: 81cd386facedfbb15be6dffc10351262abf733f3 and 664a56b3c81503bdf199edf1806676f0a35b956f Change-Id: I4e6a9952aa138959ab273db0494ef0cf76d8fc24
2014-11-30PPTX import: fix import of shape line properties defined by themeZolnai Tamás1-1/+4
See also: 81cd386facedfbb15be6dffc10351262abf733f3 Change-Id: Ibb21d3e5b52a4d4996202acd4a989910fa223632
2014-11-30bnc#904423: Text(box) is rendered white on white when it is notZolnai Tamás1-1/+6
The problem was that the background color defined by theme was not imported correctly, because the different fill style comes from different sources (master slide, theme, direct formatting) were applied on the shape in wrong order. To solve this we need to store master slide defined fill style in a different variable so theme style can be applied after master slide defined style but before direct formatting. Change-Id: I99ea981858b9fa391915570187c8ddfdf2be1f7a
2014-11-27fix higher debug level buildCaolán McNamara1-0/+1
Change-Id: Id35efda5e4df820cda2afd7b65b5f890fec03f2f
2014-11-22small cosmetic clean-upMarkus Mohrhard1-2/+1
Change-Id: Idce2856f656576dc58e137800e11da0178eb5201
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl5-0/+5
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl65-0/+76
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17Add rtl::OUString::toUtf8()Miklos Vajna1-3/+3
There is rtl::OUStringToOString() already to do OUString to OString conversion using UTF-8 encoding on a best effort basis. However multiple modules have code where we assume that such a conversion is perfect. Add a new method that asserts such an expected success instead of duplicating it at multiple places. Change-Id: I0e55b53f558df82b67af6a463c8144655cf0ca74
2014-11-15oox: these are expected to be UTF-8Miklos Vajna1-3/+3
Change-Id: I2e9cb96948d7f990dd8be5f4505f00306fa62f8f
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava8-10/+10
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini4-5/+5
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11build fixCaolán McNamara1-1/+2
Change-Id: I9d4dc8a165bc042a674eb472162292a486f3761c
2014-11-11coverity#1187643 Unchecked return valueCaolán McNamara1-6/+10
Change-Id: I2ba56fbff1ae05d1185d08d4fbd0285954fed38b
2014-11-10coverity#1130169 Unchecked return valueCaolán McNamara1-4/+4
Change-Id: I62ed42412a0cafa33ddafe536723f5e336c92a7a
2014-11-07Swapping Graphic is a privilage of GraphicObject.Zolnai Tamás1-13/+0
This means more things: * Graphic won't swap out itself, so those classes which uses Graphic without GraphicObject won't need to deal with swapping. * When a Graphic is queried from GraphicObject the caller won't need to deal with swapping, because GraphicObject swaps it in before return. * GraphicObject will swap in the Graphic always when a swapping dependent data is queried (e.g. whole graphic, transformed graphic or AnimationNotifyHdl) Change-Id: I2bf6e37291ec94146f10aac4a35084682437ed16
2014-11-07MS export: don't need to manually swapout images after swapin themZolnai Tamás1-3/+0
We have some good auto mechanisms for that. Change-Id: I487dbf4a5fc69c7563dfbc5c21f9ebdb05ba6b9e
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann1-3/+3
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin1-3/+3
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05fdo#85813 drawingML export: fix handling of impress tablesMiklos Vajna1-2/+5
Change-Id: Ia17b14c4b27e808ceab388aa33602875e67433a5
2014-11-05oox: document PPTX export entry pointMiklos Vajna1-1/+4
Change-Id: I8102f31d46257c96837b6c9497e9c49f92ac29b1
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin4-11/+7
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-04Actually we shouldn't always set Overlap flag on for all xlsx charts...Kohei Yoshida1-1/+1
The correct fix unfortunately would require making the axis label layout smarter, to avoid overlapping of angled text label objects. Change-Id: I92198dbb90fd4a206ee226307992343d064f733a
2014-11-03typo: geomtery -> geometryAndras Timar1-1/+1
Change-Id: I20263c836dd55e663cdad9fc8283fe8fbf02b1f1
2014-11-02unused includes in RTF filter and related filesMiklos Vajna2-11/+0
Change-Id: Id13e10f2ceed3985c78ccc542e6677eccc0cb1c7
2014-11-01oox: introduce W_TOKEN() macroMiklos Vajna5-82/+83
It was inconsistent that when parsing <a:foo> elements, A_TOKEN(foo) was available, but for <w:foo> elements there was no W_TOKEN() macro. Also, there were two manual variants (NMSP_doc|XML_foo or via OOX_TOKEN(doc, foo)), replace both of them with W_TOKEN() for easier searching. Change-Id: Ic5cd027f07518535b92671ffe3c486016a3f9f0a
2014-10-31Removed duplicated includesAndrea Gelmini2-2/+0
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-29constStephan Bergmann1-1/+1
Change-Id: Ia76df719b2f76a993e65e0bf6d55723b1a2f5b93
2014-10-29constStephan Bergmann1-1/+1
Change-Id: I0d89cc99a1d8f7b3c17986b45653dce5e4b436d7
2014-10-28coverity#735309 Unchecked return valueCaolán McNamara1-2/+2
Change-Id: I15cbfb15054962998a058da1381a84bb667944ef