summaryrefslogtreecommitdiff
path: root/oox
AgeCommit message (Collapse)AuthorFilesLines
2016-06-21simplifyNoel Grandin1-1/+1
Change-Id: I67de532443cbb9e64bed67fe28ee94fef38f5eae
2016-06-18fix indentationMarkus Mohrhard1-10/+10
Change-Id: I3a65eae9a7d55aa42540567a19052d6339ecdbec
2016-06-15tdf#42949: clean up includes in include/filter with iwyuJorenz Paragas2-0/+3
Change-Id: Id08a999764bfeeff3bb3409b46f48b278009ccbe Reviewed-on: https://gerrit.libreoffice.org/26238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-13Fix typosAndrea Gelmini1-1/+1
Change-Id: Ic3efae53430fbb2c1eb7962c3cf69bf99315e55b Reviewed-on: https://gerrit.libreoffice.org/26202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-10Clean up uses of Any::getValue() in ooxStephan Bergmann2-86/+77
Change-Id: I76d83ad472eb0cd44b593a86dac1f8c1ee8c3585
2016-06-10tdf#42949: clean up includes in include/oox/vml with iwyuJorenz Paragas3-0/+3
Change-Id: I753880ce146fef6523561290b8e13310d9f7219c Reviewed-on: https://gerrit.libreoffice.org/26142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-09Revert "Slideshow: Add 'Oval' Shape Transition variant"jan iversen2-18/+0
The patch caused problems with the export filter tests, to check that you need to add --with-export-validation to your autopen.input see https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/export-validation for more info on how to set it up This reverts commit 248c5ea771255b54e64394458a321ccf829bbd02. Change-Id: Ib3b8fa7bf80630feeca1f24dfb1ceb5a945d7162 Reviewed-on: https://gerrit.libreoffice.org/26114 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09Slideshow: Add 'Oval' Shape Transition variantMayank Gupta2-0/+18
Change-Id: Ibc3d617d3bb94bdd0702bb4d60ce5fbe2eea8e24 Reviewed-on: https://gerrit.libreoffice.org/23661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko3-12/+3
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-08Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann1-1/+1
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl2-6/+6
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-31tdf#93883 don't add space to empty paragraph when bullet is turned off.Mark Hung1-1/+4
Change-Id: Ia1bad61cb5585dae0501e8cd657fc84bfea60ab2 Reviewed-on: https://gerrit.libreoffice.org/25679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-31Convert GfxLinkType to scoped enumNoel Grandin1-9/+9
Change-Id: Iae074ef0927a55f1fbf401cb66f4f183213f547c Reviewed-on: https://gerrit.libreoffice.org/25656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31teach refcounting clang plugin about uno::ReferenceNoel Grandin1-2/+2
uno::Reference is only allowed to used with classes that have a ::static_type member. So convert all those places to rtl::Reference. Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and uno::Reference to make this a little smoother? Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3 Reviewed-on: https://gerrit.libreoffice.org/25516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27Convert GRAPHIC to scoped enumNoel Grandin1-2/+2
Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea Reviewed-on: https://gerrit.libreoffice.org/25534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-26tdf#42949: clean up includes in include/oox/ppt with iwyuJorenz Paragas10-1/+11
Change-Id: Ib2cf76418e8406b925113ae7a9e3c5b07ffd2de2 Reviewed-on: https://gerrit.libreoffice.org/25011 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-26loplugin:unusedreturntypesNoel Grandin1-2/+1
and clean up the python script Change-Id: I0a7068153290fbbb60bfeb4c8bda1c24d514500f Reviewed-on: https://gerrit.libreoffice.org/25439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25oox: replace boost::array with std::arrayMichael Stahl1-4/+2
Change-Id: Id9a8f7dbbf13890e7c9787d9b0737f1087e4a509
2016-05-20warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bitsNoel Grandin1-1/+1
in VisualStudio reported by Luke Benes Change-Id: I908039750a3e89e4d1b77631f7d309191735c765
2016-05-18clang-tidy modernize-make-sharedNoel Grandin14-35/+34
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13tdf#42949: clean up includes in include/oox/ole with iwyuJorenz Paragas2-0/+6
Change-Id: I9cbdc78b540b0f735c451ac561f0f0ccdaf7efbd Reviewed-on: https://gerrit.libreoffice.org/24911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11tdf#42949: clean up includes in include/oox/mathml with iwyuJorenz Paragas1-0/+2
Change-Id: Iefb4e7184009318c0b8859aa895e0b25fc9d9213 Reviewed-on: https://gerrit.libreoffice.org/24871 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10tdf#42949: clean up includes in include/oox/helper with iwyuJorenz Paragas88-5/+150
...and fix the many compiler errors that occurred as a result. Change-Id: I497c326272b2f02737ca3765720d6815b735423b Reviewed-on: https://gerrit.libreoffice.org/24735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-10Silence Clang -Wimplicit-fallthrough in gperf-generated codeStephan Bergmann1-3/+2
...in preparation of eventually enabling -Wimplicit-fallthrough for Clang. Change-Id: Idca352d011505e83dbe275cb19626c8b9d8560c8
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann5-6/+25
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann4-0/+4
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-05-10loplugin:rangedforcopyTor Lillqvist1-2/+2
Loop variable passed by value, pass by reference instead. Change-Id: I12d1cb639cbe7a5686a1854168362b85322fa2e5
2016-05-10remove STATIC_ARRAY_END and usagesJochen Nitschke4-93/+93
used in loops, rewrite to range based loop oox/source/drawingml/color.cxx has some mappings in plain arrays make them arrays of pairs which can be used in range based loops Change-Id: Ib6693197d890f595c27ca24b9f9b4e0763747f4c Reviewed-on: https://gerrit.libreoffice.org/24809 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-05-06basegfx,oox,slideshow: replace boost::next/prior with std::next/prevMichael Stahl2-26/+24
Change-Id: I38fde54d0fdbb9c61e3df004242a70e14429f52f
2016-05-06tdf#42949: clean up includes in include/oox/export with iwyuJorenz Paragas2-0/+3
...and fix the usual compiler errors that occurred as a result. Change-Id: I54781d3f01e9f5a87fd008870c825b2d8154fd59 Reviewed-on: https://gerrit.libreoffice.org/24686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin2-2/+2
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-05clang-tidy modernize-loop-convert in oox to saxNoel Grandin5-18/+18
Change-Id: If0d87b6679765fc6d1f9300c6972845cf3742b9c Reviewed-on: https://gerrit.libreoffice.org/24674 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-03tdf#42949: clean up includes in include/oox/drawingml with iwyuJorenz Paragas19-0/+23
Add includes in other files to fix compiler errors. Change-Id: I566e2e081094cb074d20afbe7ceee49f759c725b Reviewed-on: https://gerrit.libreoffice.org/24510 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-29tdf#99030: PPTX import: Fixed lost slide background colorMatus Uzak2-2/+4
Regression from commit f3d1ac7 Change-Id: I5cb9fe1bb6c753c34b49e72194a9fbe4c10c1654 Reviewed-on: https://gerrit.libreoffice.org/23930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-04-29tdf#90736: PPTX import: Improved table border line style supportMatus Uzak1-1/+41
Map preset line dash values from ooxml to the smaller set of LO's predefined table border line styles. Map custom dashing scheme to a simple dashed line style. Change-Id: Ia81d94cb7e20b05f1c2cc0c20c8ad398c5613d6c Reviewed-on: https://gerrit.libreoffice.org/24048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-04-28teach stylepolice plugin about ref-counted-pointer namingNoel Grandin2-5/+5
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-27tdf#80999 Canceling password prompt should abort detectionMaxim Monastirsky1-5/+13
... instead of continuing the detection loop and being "detected" as plain text. The detection API will from now return a type based on the file extension only, which is far more useful than "plain text" anyway. Plus the media descriptor has a flag to indicate that the detection wasn't completed, which can be also used by the loading code to abort the loading process. Change-Id: Ida37e2687bd5cd86b5780620724e9bce82e11946 Reviewed-on: https://gerrit.libreoffice.org/24428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-04-26tdf#42949: clean up includes in include/oox/crypto with iwyuJorenz Paragas5-3/+20
The includes in CryptTools.hxx that are within #if/#endif directives are not altered. iwyu suggested replacing the includes for nss.h, pk11pub.h, and sechash.h with hasht.h, pkcs11t.h, seccomon.h, and secmodt.h. I decided not to because it might make CryptTools.hxx harder to refactor in exchange for little gain. Before creating this commit, I ran 'make check' after passing --with-tls=openssl to ./autogen.sh to ensure that building with either OpenSSL or NSS (the default except on iOS and Android) works. Change-Id: I20260d18f073ffd8077bbcc597e7a8e4954e2ec5 Reviewed-on: https://gerrit.libreoffice.org/24386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin8-39/+39
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-25Some more sal_Bool -> boolStephan Bergmann1-1/+1
Change-Id: Iaae2c92e011c55f8739ecb7972ef9a3f71300765
2016-04-25tdf#42949: clean up includes in include/oox/core using iwyuJorenz Paragas68-2/+159
This allows the headers in that folder to stand on their own and not depend on any transitively included headers. All changes to other files are needed to fix compiler errors related to missing includes that occurred afterwards. Change-Id: I2083b30763f0b2c1aacdff00226e5f567ae52db4 Reviewed-on: https://gerrit.libreoffice.org/24355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-22Avoid reserved identifiersStephan Bergmann2-3/+3
Change-Id: Ie1664e06dc02f7070e4ef77155e6541c70b2f8e8
2016-04-21new plugin stylepoliceNoel Grandin2-7/+7
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann21-48/+48
Change-Id: I379e89e1e6b9fd8668ba7ac59af33f63487a4f66
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin2-18/+16
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke14-50/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke1-1/+0
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13loplugin:passstuffbyref in ooxNoel Grandin7-8/+8
Change-Id: Iec989e9060c77dd5b010224b37633179cee4f7e9
2016-04-12tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar3-13/+11
I disentangled my previous patch to make one patch per module. I also modified the patch according to new directions given by Sweet5hark Change-Id: Id690f7c1e87230e4d10e1c9fe472f35d1d1caa8b Reviewed-on: https://gerrit.libreoffice.org/22924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-12tdf#99135 VML import: handle image cropMiklos Vajna2-0/+39
The spec says in theory a % suffix could be also supported, but let's wait till that is seen in a real-world document. Change-Id: Ie026915e38dcb03c99085a1740075364b00e1c8d
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-28 17:48:11 +0000