summaryrefslogtreecommitdiff
path: root/forms
AgeCommit message (Collapse)AuthorFilesLines
2016-05-31tdf#93403 check for changed DataSource on all Controls on form reloadLionel Elie Mamane1-1/+1
1) OBoundControlModel: when reload() asks us to connect to database column, redo it even if it was previously done. 2) FmXGridPeer: when getting Reloaded event that we subscribed to (and specifically from frm::ODatabaseFrom), pass along the event to all columns before we treat it. The columns (controls) are themselves subscribed to it, but they may get the event after us, which means our treatment still uses stale data, which we continue to display. The column controls should continue to subscribe by themselves for the case that they are not in a grid, but direct children of the form. Change-Id: I0cbcf2dc792e8650157a69ddc414d755de0e549a Reviewed-on: https://gerrit.libreoffice.org/25553 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin5-24/+2
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12convert SFXWB file dialog flags to scoped enumNoel Grandin2-2/+2
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b Reviewed-on: https://gerrit.libreoffice.org/24881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann4-5/+5
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann1-0/+1
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-05-10Missing break in switchStephan Bergmann1-0/+1
Apparently forgotten when introducing the case PROPERTY_ID_GENERATEVBAEVENTS in 4fae740db79d4e7cc97440e2bab8d1ef612d9b51 "Disable fake VBA events for the old-style form controls." Change-Id: Id2783fd4f087669bd200a9c33eaad2bb6b7b50cd
2016-05-09fix windows build, ambiguous symbolNoel Grandin1-2/+2
Change-Id: Ib3a2419198a6e2b1ee5330f99bc526f2d63edd7c
2016-05-04use Any constructor instead of temporariesNoel Grandin1-1/+1
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-03Remove unnecessary setBOOL, makeBoolAnyStephan Bergmann2-12/+12
Change-Id: Id82c3f352fcc2d4dafad877517098cb6f5d046d4
2016-05-01Fix typosAndrea Gelmini1-1/+1
Change-Id: Ifb7c33d6052efe5ea8a1e0e10b3178073cd29ca0 Reviewed-on: https://gerrit.libreoffice.org/24536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-27clang-tidy modernize-loop-convert in f*Noel Grandin1-6/+6
Change-Id: Id866aa244378758e3bdb9e99d02cdd2ae6104e16
2016-04-26tdf#60418: improve perf of opening/closing odts with form tagsAron Budea2-220/+167
Opening/closing times using "Without Frame tags" attached file from bug report changed as follows on my system (debug build): open: 2:06 -> 1:32 close (doc unchanged): 1:52 -> 0:18 The performance fixes in the different CXX files are independent, eventattachermgr.cxx is related to doc close, the others to doc open. Change-Id: I24fc4558f79b9123494a3939c0a313fcd47a067f Reviewed-on: https://gerrit.libreoffice.org/24359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-22Avoid reserved identifiersStephan Bergmann3-15/+15
Change-Id: Icc658a3adce2e93c3cc4e8a88689f462b1c7c8a1
2016-04-22Elide const varsStephan Bergmann1-4/+2
Change-Id: I1b2a7b071f9740e8c848f543e32fd47f054c8318
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann23-64/+64
Change-Id: I74cf43df85a878ee9af69901b2535f63461cb61e
2016-04-20loplugin:simplifyboolStephan Bergmann1-1/+1
Change-Id: I6e8c06c28d710709d4a6b240e634d0216823cbe4
2016-04-18cppcheck: silence known condition warning in formsJochen Nitschke1-7/+3
Change-Id: I191dc169eea01d49ee357716a6bcc249e91437ec Reviewed-on: https://gerrit.libreoffice.org/24201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke14-64/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-15loplugin:passstuffbyrefStephan Bergmann2-2/+2
Change-Id: Ic2625b08a57b0f8c1e93b861a8a8add12f02229d
2016-04-15tdf#95845 Use CommandInfoProvider in formsSamuel Mehrbrodt6-195/+14
Change-Id: I697f8c442cc4db7b38601c32fb71e0201f145354 Reviewed-on: https://gerrit.libreoffice.org/24106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin7-13/+13
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in variousNoel Grandin6-9/+9
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-13tdf#97087 Give comprehensible names to timersMuhammet Kara1-1/+1
Timers and idles should have programmer comprehensible, unique names Change-Id: I837d1890c687936f8a31278c0102391e6f87212d Reviewed-on: https://gerrit.libreoffice.org/23917 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-12Avoid reserved identifiersStephan Bergmann2-6/+6
Change-Id: Ifc47504370a2ebc8119a60091fdf1ced4b532aa3
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke9-19/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11tdf#94306 replace boost::noncopyable ...Jochen Nitschke1-3/+3
... in modules editeng to oox. Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes and one unused boost/checked_delete.hpp include in linguistic. Change-Id: I5a38d8e5ac1b4286bdeb3858d56490a53d13fe80 Reviewed-on: https://gerrit.libreoffice.org/23928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-05loplugin:constantparamNoel Grandin2-16/+13
Change-Id: I821ed77a6c6014c9a82d31a4b117ed6f1b4abf18 Reviewed-on: https://gerrit.libreoffice.org/23832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke7-11/+0
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-01sequence->vector in formsNoel Grandin6-81/+77
Change-Id: Iea09367a51af8d0003a3ae58f8e7e0e825906367 Reviewed-on: https://gerrit.libreoffice.org/23691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-01tdf#97966 Drop 'static' keywordsWastack9-18/+18
Including no keywords from extern "C" blocks Change-Id: I8bcd7e8a492ee4dbfa5141416c7c038a1391cf20 Reviewed-on: https://gerrit.libreoffice.org/23673 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-23loplugin:constantparam in formsNoel Grandin8-29/+18
Change-Id: Iebce160fd6c3de63ba179d747768fd4cf420baec
2016-03-14inline some use-once macrosNoel Grandin2-50/+48
Change-Id: I7ebd8fe70b083a772118a1aab8cdfbf795d6f1e5 Reviewed-on: https://gerrit.libreoffice.org/23235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-11tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar2-9/+9
I removed OSL_DEBUG_LEVEL > 1 conditionals and in some places i replaced OSL_ENSURE(..) with assert() Change-Id: Ide7e4b633e85a699f680f47caac5bff36bf180a2 Reviewed-on: https://gerrit.libreoffice.org/23076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-11tdf#97966: Remove 'static' keywordsWastack3-3/+3
Change-Id: Iced527f48afa828cc9acf5b6461674a2706cbcd7 Reviewed-on: https://gerrit.libreoffice.org/23135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-10loplugin:constantparam in formsNoel Grandin2-4/+4
Change-Id: I5e2dce3a1fcdb0ce836b9297feb287852ebc7d17
2016-03-02loplugin:unuseddefaultparam in formsNoel Grandin6-10/+10
Change-Id: I5a2b50163acfda3878fe5625a605e3437a7cc700
2016-02-25use SearchOptions2Eike Rathke1-6/+5
Change-Id: I58d39616dc15fc973e1377ed205452a683baf080
2016-02-25convert FilterComponent to scoped enumNoel Grandin1-4/+4
and simplify the overly-general logic in FilterManager Change-Id: I2cbd9db6a53894cd13713a5cc0d1807cec456848
2016-02-25convert EComposeRule to scoped enumNoel Grandin3-3/+3
Change-Id: I5a2e4f6f6f0f353c75dff85e865608b12c2104f9
2016-02-23new loplugin: commaoperatorNoel Grandin1-2/+4
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-22loplugin:write only fieldsNoel Grandin3-15/+5
Change-Id: I44f249a17d0a510ec63a488b656d57a1a392f821
2016-02-09Remove excess newlinesChris Sherlock52-127/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock2-30/+11
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-06vcl: bmpacc.hxx -> bitmapaccess.hxxChris Sherlock1-1/+1
Change-Id: I4bb19d6103c4a6a902d86b62a857e3478493924c
2016-02-06vcl: split exception types from input typesChris Sherlock1-5/+3
Having them in the file apptypes.hxx isn't necessary helpful, IMO so I've split the types into inputtypes.hxx and exceptiontypes.hxx Change-Id: I89a1ff168c3ae276b2f5486669d4ec2dda062d57
2016-02-05interface to new XTextSearch2 with SearchOptions2, tdf#72196Eike Rathke1-1/+1
Places that had utl::TextSearch::UpgradeToSearchOptions2() introduced are worth an inspection if the new SearchAlgorithms2::WILDCARD search should be supported or at least use SearchOptions2 instead of SearchOptions to eliminate the small performance penalty that conversion involves. Change-Id: I565f73af2b551ae9ad0f488e672823dc6c5c1109
2016-02-05Fix typosAndrea Gelmini2-2/+2
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-04vcl: take into account the font width is the average font widthChris Sherlock1-2/+2
I'm changing the Font class function names: - SetSize -> SetFontSize - GetSize -> GetFontSize - SetHeight -> SetFontHeight - GetHeight -> GetFontHeight - SetWidth -> SetAverageFontWidth - GetWidth -> GetAverageFontWidth That's because it really makes no sense to say that there is a single constant font width because obviously proportional fonts don't have one - the best we can do is an average font width, which is what folks like Microsoft sort of do already. On a fixed font, the average is still accurate, for obvious reasons :-) I'm also not a fan of GetSize/SetSize as I find it a might too generic. Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70 Reviewed-on: https://gerrit.libreoffice.org/22069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin26-45/+46
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-21vcl: rename Font::GetFamily to Font::GetFamilyTypeChris Sherlock1-1/+1
Change-Id: Ie427a43bd126dcdd89c6f66582736e67130f2254 Reviewed-on: https://gerrit.libreoffice.org/21633 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-24 21:02:29 +0000