summaryrefslogtreecommitdiff
path: root/filter
AgeCommit message (Collapse)AuthorFilesLines
2017-05-02ofz#1284 InsertBundle may delete the bundle that pMarkerBundle is pointing toCaolán McNamara1-0/+15
Change-Id: Ic8bd538e80469b672ddd9c5fcceb2f5aac81d2a1 Reviewed-on: https://gerrit.libreoffice.org/37053 Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-04-04ofz: check bounds on readCaolán McNamara3-19/+31
Change-Id: I07779bec876b90e36f20a81d6dbf06ae727edf85 (cherry picked from commit fb05611064e12c8eda09bc32c42544cde8c2ab49) Reviewed-on: https://gerrit.libreoffice.org/36018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-28valgrind: use of uninitialized valuesCaolán McNamara1-24/+24
Change-Id: I5b8c6d4d4576fd88dbffdfc710cbd9b2e9429942 (cherry picked from commit b7152aff51665bc802af66e6e599a89e0344c92f) Reviewed-on: https://gerrit.libreoffice.org/35805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-21ofz#875 limit depth to max legal depthCaolán McNamara1-10/+18
Change-Id: Icbe9339148dc4aeb31c160e976385e3bcaef75b6 (cherry picked from commit 30e2b7203963af215c9aaaec12383e0d5e1f6a7f) Reviewed-on: https://gerrit.libreoffice.org/35259 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-21ofz: use after freeCaolán McNamara1-1/+12
Change-Id: I6d3f9108b02149165b020fc9c6677880456a1ef4 Reviewed-on: https://gerrit.libreoffice.org/35299 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-16ofz#876 avoid accessing empty rowsCaolán McNamara1-0/+4
(cherry picked from commit b9892037c303e645ee1a987d80734361700d91ac) Change-Id: Iba539fb03611bbe5627cc7976c1146d08a2ab5fd Reviewed-on: https://gerrit.libreoffice.org/35256 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-03-14ofz#829 ensure palette can fulfil largest index usedCaolán McNamara1-25/+40
Change-Id: I95aa4796875ee71e8b06a2bb8985845f270b8817 Reviewed-on: https://gerrit.libreoffice.org/35104 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-03-03ofz: init varsCaolán McNamara1-7/+7
Change-Id: Ie35617997845de25af9e528668bce4c332ac408a (cherry picked from commit 1c29456c9c9007b788297aebea58a1a765f77c84) Reviewed-on: https://gerrit.libreoffice.org/34785 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-02ofz#668: check nTargetBits sizeCaolán McNamara1-1/+4
Change-Id: I5cc7499cfdee58ffa480bb31dfc262d5b781180d (cherry picked from commit 99c361be16eb3a21aa679a103db2d07ecd0f5d3c) Reviewed-on: https://gerrit.libreoffice.org/34723 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-28ofz: don't read data that isn't thereCaolán McNamara1-5/+11
Change-Id: I7fdcb78bde8f650c1a57d34177d8993a6d8a0a2f (cherry picked from commit ee619fb344c7e8f491e09bd256df7f8567af9bef) improve scoping Change-Id: Ic79d46da4e322a0f52981c3a3df65f7f0294fdd8 (cherry picked from commit 840ad0a88045021c58644404a099a3678a371020) make this a little clearer no logic change intended Change-Id: Ibfc46d0aba9e220be54270734e0cdfbc123be9a5 (cherry picked from commit 46b1b5dd2a5368663fd56434160fa126f1a54d84) Reviewed-on: https://gerrit.libreoffice.org/34572 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-23Resolves: ofz#668 check for massive row lengths before trying to allocate themCaolán McNamara1-5/+15
Change-Id: I7b3f1abf5dcf457e8ff7d04a7cf48ffee70817a2 Reviewed-on: https://gerrit.libreoffice.org/34574 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-23ofz: don't read data that isn't thereCaolán McNamara1-0/+4
Change-Id: I9f730c321755cde169d940b49fc93bbe057ead57 (cherry picked from commit c5b1a01ddfa54156b4fa8e542d6936908257ca93)
2017-02-01Resolves: ofz#488 check remaining size while parsingCaolán McNamara1-28/+53
Change-Id: Ibb2b6c59a159f9fafa6a065be438b59a6d2d3f21 Reviewed-on: https://gerrit.libreoffice.org/33688 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-01ofz: tidy up eps preview importCaolán McNamara1-32/+46
a) check that the remaining stream length is >= the 14 bytes that are unconditionally skipped b) make the initial security count the min of the arbitrary 100 and the remaining stream len less that 14 bytes c) tweak ImplGetNumber not to reduce nSecurityCount if its already 0 Change-Id: Ifffa6d02d492affd578fb48007704457ad635b39 (cherry picked from commit 94ffb720b889c51665ebb789d84aee3b3bacb456) ofz: check eps seeks are sane and succeeded Change-Id: I0eb45e1c1ffd91682ed0ce6a6a74eab54666d715 (cherry picked from commit f85fb724d52a0fff9c64365cd202ae8975492c05) ofz: check if the stream is able to meet the eps len claim before reading Change-Id: I65407bffb67449e203b8ead23554a4e88387d214 (cherry picked from commit e17a34e957c21a8cd2977b1b0e1c9a427c244aed) ofz: check if the stream is able to meet the eps len claim before reading Change-Id: I440c7f38d6588c570a411f2a97c0164e5d7d646f (cherry picked from commit d1f31681623696e99b0bd9e98570cb1ebac518cc) make this a little more readable Change-Id: I83b6b0bd636b639ce0892f22f216410ce79dee03 (cherry picked from commit cf06348d9d4be8b8460d202cebf0d995fd4f6abf) move deref inside (laughable) nSecurityCount check Change-Id: Idf9a83ffa80137967d8c77d7a9b5133529fc2858 (cherry picked from commit 521723b1180a32c02a88ed47137d4242c06eaca7) Reviewed-on: https://gerrit.libreoffice.org/33634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-18ofz#414 crash in DXFHatchEntity::EvaluateGroupCaolán McNamara3-3/+17
(cherry picked from commit 5434d51d12611eb2726ce1394eb01921d008fa89) ofz#415 crash in DXFVector::DXFVector (cherry picked from commit 2a9b4363ca190f1d783d540e95a031357f852858) Change-Id: I15c8cb7aeb8c45f32357afd0ea2f550ffe11dbf7 Reviewed-on: https://gerrit.libreoffice.org/33233 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-01-16ofz: ensure nOldSize is > 0Caolán McNamara1-2/+2
Change-Id: Iaf385c9cd4fd37d56879908c00c7483762d66a0b (cherry picked from commit dd70861fd7123c826feefa86f8af1da1f4877c97) Reviewed-on: https://gerrit.libreoffice.org/33177 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2017-01-16guard against self-recursive GetBoundingBoxCaolán McNamara3-1/+13982
Change-Id: If33f0e5e326604bf731d6ad50644e3a0b24ccf51 (cherry picked from commit 7420e350906558556881afc213f942d45d3e0b60) Reviewed-on: https://gerrit.libreoffice.org/33050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-13avoid infinite loops in dxf renderingCaolán McNamara3-14/+17337
Change-Id: Id2eb5540241f0792cde35c444fc2c0c5b7778353 (cherry picked from commit 57779b5f3a49fedd952aed70ddcce22f48b98ea5) Reviewed-on: https://gerrit.libreoffice.org/33042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-11-28tdf#104144: Missing dashed border, "break" should be "fallthrough" after allStephan Bergmann1-2/+1
...5ffd2c1595d1f67f5e4b14e48188a1f37f1956b5 "Presumably missing break in switch" apparently decided wrongly in favor of "break" over "fallthrough". Change-Id: I90372faac84a26514f5dc936e0e393a1ca12effa (cherry picked from commit 787d31a94510ca3de9ce582d7b7402dfca584b23) Reviewed-on: https://gerrit.libreoffice.org/31313 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-22trivial makefile cleanupsMichael Stahl2-5/+5
Change-Id: Ida5bdfa06ecd7907305f4f171ca5ab64260d0259
2016-11-21convert inventorId to scoped enumNoel Grandin2-3/+3
SW_DRAWLAYER had the same value as SC_DRAWLAYER, so I merged it into the ScOrSwDraw enum constant Change-Id: I5c45d378c00364d11cc960c9e48a6e3f10928724 Reviewed-on: https://gerrit.libreoffice.org/31037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-21correct UIName of legacy StarOffice Text Documentosnola2-2/+2
Change-Id: I2f4a67ce439d913648c17d4770b94c5b4e7968f9
2016-11-21rename makefile to match the module nameDavid Tardon2-1/+1
Change-Id: I21685599e42c961407fa3de40e69e6e54dfe7c79
2016-11-21add missing deps on ui filesDavid Tardon1-0/+4
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud1-1/+1
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-16new loplugin finalprotectedNoel Grandin3-5/+0
look for final classes, and make sure they don't have protected members Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4 Reviewed-on: https://gerrit.libreoffice.org/30895 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15Fix typosSamuel Mehrbrodt1-1/+1
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-14Avoid -fsanitize=nullStephan Bergmann3-38/+27
...during CppunitTest_filter_dialogs_test: > filter/source/xsltdialog/xmlfiltersettingsdialog.cxx:1398:20: runtime error: reference binding to null pointer of type 'ResMgr' > #0 0x7f144bf5ab10 in XMLFilterListBox::XMLFilterListBox(vcl::Window*, SvxPathControl*) filter/source/xsltdialog/xmlfiltersettingsdialog.cxx:1398:20 > #1 0x7f144bf7abb8 in VclPtr<XMLFilterListBox> VclPtr<XMLFilterListBox>::Create<VclPtr<VclVBox>&, SvxPathControl*>(VclPtr<VclVBox>&, SvxPathControl*&&) include/vcl/vclptr.hxx:138:46 > #2 0x7f144bf50df8 in SvxPathControl::SvxPathControl(vcl::Window*) filter/source/xsltdialog/xmlfiltersettingsdialog.cxx:1312:20 > #3 0x7f144bf7d487 in VclPtr<SvxPathControl> VclPtr<SvxPathControl>::Create<VclPtr<vcl::Window>&>(VclPtr<vcl::Window>&) include/vcl/vclptr.hxx:138:46 > #4 0x7f144bf56a2f in makeSvxPathControl filter/source/xsltdialog/xmlfiltersettingsdialog.cxx:1378:1 > #5 0x7f14d2060a04 in VclBuilder::makeObject(vcl::Window*, rtl::OString const&, rtl::OString const&, std::__debug::map<rtl::OString, rtl::OString, std::less<rtl::OString>, std::allocator<std::pair<rtl::OString const, rtl::OString> > >&) vcl/source/window/builder.cxx:1793:17 > #6 0x7f14d2078ddb in VclBuilder::insertObject(vcl::Window*, rtl::OString const&, rtl::OString const&, std::__debug::map<rtl::OString, rtl::OString, std::less<rtl::OString>, std::allocator<std::pair<rtl::OString const, rtl::OString> > >&, std::__debug::map<rtl::OString, rtl::OString, std::less<rtl::OString>, std::allocator<std::pair<rtl::OString const, rtl::OString> > >&, std::__debug::map<rtl::OString, rtl::OString, std::less<rtl::OString>, std::allocator<std::pair<rtl::OString const, rtl::OString> > >&) vcl/source/window/builder.cxx:1887:25 > #7 0x7f14d208790a in VclBuilder::handleObject(vcl::Window*, xmlreader::XmlReader&) vcl/source/window/builder.cxx:2856:37 > #8 0x7f14d20215bc in VclBuilder::handleChild(vcl::Window*, xmlreader::XmlReader&) vcl/source/window/builder.cxx:2114:33 > #9 0x7f14d2087bea in VclBuilder::handleObject(vcl::Window*, xmlreader::XmlReader&) vcl/source/window/builder.cxx:2859:17 > #10 0x7f14d20215bc in VclBuilder::handleChild(vcl::Window*, xmlreader::XmlReader&) vcl/source/window/builder.cxx:2114:33 > #11 0x7f14d2087bea in VclBuilder::handleObject(vcl::Window*, xmlreader::XmlReader&) vcl/source/window/builder.cxx:2859:17 > #12 0x7f14d20215bc in VclBuilder::handleChild(vcl::Window*, xmlreader::XmlReader&) vcl/source/window/builder.cxx:2114:33 > #13 0x7f14d200c59a in VclBuilder::VclBuilder(vcl::Window*, rtl::OUString const&, rtl::OUString const&, rtl::OString const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) vcl/source/window/builder.cxx:206:9 > #14 0x7f1492275862 in ScreenshotTest::dumpDialogToPath(rtl::OString const&) test/source/screenshot_test.cxx:177:24 The existing code apparently depended on any calls to getXSLTDialogResMgr in xmlfiltersettingsdialog.cxx only happening after pXSLTResMgr had been set up in the outer XMLFilterDialogComponent::execute in xmlfilterdialogcomponent.cxx. That is not true when each dialog is opened independently in the screenshot test, so instead just call CreateResMgr on demand wherever needed. Change-Id: I9f6dc7c66d4999137352a8d91665b954f4088085
2016-11-11loplugin:countusersofdefaultparams in editeng..rscNoel Grandin3-4/+4
Change-Id: I8a8d13faf228cbc934ae21d6763d92d370eb42ec
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann1-2/+2
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann1-8/+1
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-08loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin1-6/+6
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04loplugin:oncevar in desktop..filterNoel Grandin7-166/+78
Change-Id: I21c47cacbcd68f06eea7ccbbfa6d04fc65e2b7ee Reviewed-on: https://gerrit.libreoffice.org/30564 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02check only Column elements when computing column indexDavid Tardon1-3/+3
Change-Id: I4856227c05e97daefbae7e98c0e9d70f84e1a2b4
2016-11-02check only Row elements when computing row indexDavid Tardon1-3/+3
Change-Id: I3bd1b0749f8889cbd1d92a0edfa84d754e888f03
2016-11-02rhbz#1390776 check only Row elements when computing row indexDavid Tardon1-3/+3
Change-Id: Ic5ef3971829597170acfdc0606b3c0f16c42be04
2016-11-01Decrease SpreadsheetML import time to prevent "General input/output error"Шиповський Роман1-2/+2
Change-Id: I39ed8fff7ba88042c74a11ddc58eec014c0bc6bd Reviewed-on: https://gerrit.libreoffice.org/30361 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-10-27filter: use comphelper::containerToSequence() in ImpPDFTabDialogMiklos Vajna1-61/+17
Change-Id: I9c6523d96e06901751d392bd76e7aa8717784697 Reviewed-on: https://gerrit.libreoffice.org/30307 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-26Revert "clang plugin for push_back after using sized constructor"Stephan Bergmann1-2/+1
This reverts commit e2fa592c770222344fccb0e39db3d500fc7690b5, sould no longer be necessary after 3be8c4c2bb919d69a2812c76edbaeaa41d149edb "The badvectorinit plug-in probably can be retired". Change-Id: I26fadaf002e8e21144a7e888a80bb40eb017a64b Reviewed-on: https://gerrit.libreoffice.org/30296 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-26try and silence coverity#1374267 Out-of-bounds accessCaolán McNamara1-11/+12
Change-Id: Ib7a8866dc4acdc243e7bfa975e760afde3bb43a6
2016-10-26The default std::less<sal_uInt16> is fineTakeshi Abe2-12/+2
Change-Id: I29cd62ef0b687613ed9bda5170511dcae2fc6e7e Reviewed-on: https://gerrit.libreoffice.org/30282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-24Simplify code furtherStephan Bergmann2-9/+3
...after 9ad0e56be46df46b021109acfd6ece9d17ce84f8 "fixes for >>= with rhs Any" Change-Id: Idf7b7033bd0ef5501e2884841ba897f8691a5f77
2016-10-24fixes for >>= with rhs AnyJochen Nitschke2-7/+4
this changes behaviour because >>= always returned true Change-Id: Ia7bbce1696e5c23f6e1e6f1a7e60b3c462cf0086 Reviewed-on: https://gerrit.libreoffice.org/30141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-21clang plugin for push_back after using sized constructorCaolán McNamara1-1/+2
the warning is bogus for this ctor, but the clang plugin is still active in gerrit at the moment. Change-Id: Ia55260491988a12a48e49dc4962733261d13e2a1
2016-10-21loplugin:expandablemethodds in include/filterNoel Grandin2-2/+2
Change-Id: I92f0e19845e921701eb139e19493effa47908b39
2016-10-21implement CryptoAPI RC4+SHA1 encryption scheme for xls importCaolán McNamara1-37/+105
there might be other variants out there in practice, but this works for default encrypted xls of excel 2013 Change-Id: I91c0e1d1d95fbd1c68966650e7ac7d23276bcbe3
2016-10-21split MSCodec_Std97 into a baseclass MSCodec97Caolán McNamara1-15/+19
Change-Id: Ia3c41a048169c78684800def94e53fc9f3201e30
2016-10-21move some useful header information to mscodec for reuseCaolán McNamara1-0/+20
Change-Id: Ic7adf3ed3c8279cc93a06975d6fb337210d1af87
2016-10-20be more c++yCaolán McNamara1-6/+2
Change-Id: I673b00e111a734bc626ba3d3f6ecf9692f1ce7db
2016-10-20Any can't be nested ...Jochen Nitschke1-18/+0
... don't check for it Change-Id: I0400ef365fdfcd8e1f516958225ae99289798f21 Reviewed-on: https://gerrit.libreoffice.org/30049 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-04 18:24:14 +0000