summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)AuthorFilesLines
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon2-7/+7
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16usage info: Checkbox to turn it on and off (Tools -> Options... -> General).Jan Holesovsky3-7/+66
Change-Id: I67143e604314f5553026c369bbed3fdd683c39a6
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann8-13/+0
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin1-1/+1
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-13vcl: Make ImplFontCharMap a pImpl and move functions to FontCharMapChris Sherlock1-3/+3
To do this, I've made FontCharMap a friend class for ImplFontCharMap, and have moved the functions directly into FontCharMap. In this patch, I am attempting to stop the direct use of ImplFontCharMap by anything other than FontCharMap. However, FontCharMap itself requires a refcounter, so we will use FontCharMapPtr to access the font character map. Change-Id: I509b990a8cbd911c5cc1572c7d24fc5348ca06d9 Reviewed-on: https://gerrit.libreoffice.org/11823 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin7-18/+18
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin5-6/+6
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca2-16/+16
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-07Better title for color picker dialogAdolfo Jayme Barrientos1-68/+16
Also: * Missing colons stuff (fdo#78826) Change-Id: I5b4c75d7fc9a2f84d17074e78dbe4875cfdca352 Reviewed-on: https://gerrit.libreoffice.org/11845 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-07disambiguate uniform_int_distributionCaolán McNamara1-1/+1
Change-Id: Ifa0c1b1983d1cc7f22d55b15dee88b7f709dbcf8
2014-10-06use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara1-2/+2
and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-04coverity#1242370: Unchecked return valueNorbert Thiebaud1-6/+5
Change-Id: I11d80ddea4a38ce69ad7076af6da0bf173bd8551
2014-10-03coverity#1242803 Unused valueCaolán McNamara1-3/+1
Change-Id: I674f8ef309052737d742802ca4756c8e51e4385c
2014-10-03coverity#1242834 Unused valueCaolán McNamara1-4/+3
Change-Id: I2a68873d335f5efc27679c7bae619d942bbc5efe
2014-10-03coverity#1242871 Unused valueCaolán McNamara1-2/+1
Change-Id: I1204b904b446c2ec3132064e89aa6f20c5523470
2014-10-03coverity#1242900 Unused valueCaolán McNamara1-4/+3
Change-Id: Ic556e9ca669af5d514ebe4d6bcff7bdc9271dc7a
2014-10-03rename SvRef::AddRef to AddFirstRefNoel Grandin1-1/+1
to make it's intended purpose clearly distinguishable from AddNextRef Change-Id: I5da780b48b19fd873667b648031bc394113f953b Reviewed-on: https://gerrit.libreoffice.org/11763 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-02coverity#1242752 Uninitialized pointer fieldCaolán McNamara1-1/+6
Change-Id: I3485a29fe5ce88834b2ef0d30b9c32516befa0ff
2014-10-02coverity#1242766 Unused valueCaolán McNamara1-1/+0
Change-Id: If7d33882d612788fba051ebae56468b80e96e09f
2014-10-02coverity#1242776 Unused valueCaolán McNamara1-34/+0
Change-Id: Ia84bfbcdd4de08c9e87c877b3c1be84c0b712a07
2014-10-02coverity#1242785 Uninitialized pointer fieldCaolán McNamara1-4/+6
Change-Id: Ic97bd7c3fa2f192113d702f9338cb3eaeae6109c
2014-10-02coverity#1242826 Uninitialized pointer fieldCaolán McNamara1-1/+6
Change-Id: I6292d16d8925aa8562942a016bb02ba3785196a3
2014-10-02coverity#1242829 Uninitialized pointer fieldCaolán McNamara1-0/+1
Change-Id: I902d5ed03979264b9d228f91a4a50b912a1eade5
2014-10-02coverity#1242909 Unused value and const things upCaolán McNamara1-3/+1
Change-Id: Ib98a81a04f721917ee3c1fdd19d23a37c5d2c481
2014-10-02Improved striped rows implementationSamuel Mehrbrodt1-1/+1
Some renaming, use variable for row background when not striped Change-Id: I5b36fc751aa163dbb127406d7aefad01974fa371
2014-10-01coverity#1242928 Uninitialized pointer fieldCaolán McNamara1-3/+1
Change-Id: I841306c664ddc5d81ce1c84357de3b2daf32964a
2014-10-01coverity#1242929 Uninitialized scalar fieldCaolán McNamara1-3/+4
Change-Id: I77d19b131a378b16e82ce789c5d0fc99845e92db
2014-10-01coverity#1242943 unused memberCaolán McNamara1-1/+0
Change-Id: I6a5a0efdfa45814a59d4b7b5885850e1618a526e
2014-10-01fdo#82577: Handle TimeNoel Grandin3-5/+5
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30Improve SvTreeListBox classPalenik Mihály1-0/+1
It is possible to set alternating rows. Expert Configuration dialog use it. Change-Id: Ie43a87ca05be73fdb345fa4866f31c2c36b7cdf1 Reviewed-on: https://gerrit.libreoffice.org/11663 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-30cui: std::auto_ptr -> std::unique_ptrStephan Bergmann4-27/+13
Change-Id: Iea8b3def77842541129c16346270aa262654fea4
2014-09-30fdo#82577: Handle RegionNoel Grandin2-2/+2
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-28border_width from 12 to 6, as the rest of dialogsAdolfo Jayme Barrientos16-16/+16
Second pass. Change-Id: Ic4702d2ca7a9d54ee4712dcd073006f16b2d5d1d Reviewed-on: https://gerrit.libreoffice.org/11669 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-28fdo#60123: Make rotation angle spinbox wrapKatarina Behrens1-0/+1
like all the other rotation-setting spinboxes elsewhere do Change-Id: I9df819abbafecb975bf9db698d0da99de851f5a7
2014-09-26fixed behavior of Writer's Special Character dialogSzymon Kłos1-2/+15
before: the character is inserted at the end after: The character will be inserted where the cursor is or will replace the selected string. Change-Id: If5f7cac24c98a9105c38864da5a4c6363a35a834 Reviewed-on: https://gerrit.libreoffice.org/11642 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-25Resolves: fdo#83010 remove svx::WrapFieldCaolán McNamara2-3/+2
in favour of a wrap property on NumericField Change-Id: I62c6bdb69a16f37ae6018a2fe41070fb18dbe4a0
2014-09-25Consistently use APP_WRITER as an integer, never as a nullptrStephan Bergmann1-13/+13
(not that it matters much in practice, on platforms where nullptr is all-zero anyway) Change-Id: I640e4e3e8c77f8c5c59c8e4b51c04f72dc1fadf9
2014-09-25fdo#78783: fixed init position to 1 and using cssStefan Weiberg1-13/+28
Change-Id: Ib7c62ce23290056c42bfa89fbac91212e7ae0ab6 Reviewed-on: https://gerrit.libreoffice.org/11409 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-24fdo#64302: Writer’s Special Character dialog could be simplerSzymon Kłos3-181/+103
Change-Id: Ia321a9df77a8741245378e5b995b3bc6922266e8 Reviewed-on: https://gerrit.libreoffice.org/11621 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-23fdo#82577: Handle WindowNoel Grandin202-896/+896
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23fdo#62281 Add a title to the About dialogAdolfo Jayme Barrientos1-16/+6
Change-Id: Idc9d9631dbb4990f878ee2f64b0f6fa36973307b Reviewed-on: https://gerrit.libreoffice.org/11598 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-21Remove the term “Persona” from visible UI stringsAdolfo Jayme Barrientos3-8/+8
Their official name is “Firefox Themes” nowadays. While I was there, tweak some strings. Change-Id: I2505df2fb810fa7de51d28f5704bc1178671c3ac Reviewed-on: https://gerrit.libreoffice.org/11483 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-18fdo#82577: Handle FontNoel Grandin16-65/+65
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-12cui: sal_Bool -> boolStephan Bergmann4-4/+4
Change-Id: Ib472f25eb1625dadca8c2078b3f9cdab98763c8d
2014-09-12Turn SfxItemState into a C++11 scoped enumerationStephan Bergmann35-413/+413
...to gain further confidence in the claim "that none of the existing code tries to uses combinations of these enum values" (d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState") Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13 Reviewed-on: https://gerrit.libreoffice.org/11384 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-10Replace uses of old SFX_ITEM_AVAILABLE alias with SFX_ITEM_DEFAULTStephan Bergmann7-43/+43
Change-Id: I88eeac06413fc3935cbbdb357ff8bf9acaa383a8
2014-09-09fdo#45071: Remove ENABLE_NPAPI_INTO_BROWSER left-oversStephan Bergmann6-462/+0
...from previous commit Change-Id: I945faa6215f971ce817c6450fe0786da0696091f
2014-09-09fdo#45071 Remove Libreoffice browser pluginBryan Quigley3-31/+0
This removes ENABLE_NPAPI_INTO_BROWSER while it should keep ENABLE_NPAPI_FROM_BROWSER (embed flash in LO) intact. Signed-off-by: Stephan Bergmann <sbergman@redhat.com> Conflicts: extensions/source/nsplugin/source/npshell.cxx Change-Id: I80a9159a75653c74423d8fdc7c188568d3188e04
2014-09-09semibold -> bold in Color Picker headingsAdolfo Jayme Barrientos1-3/+3
Change-Id: Ibd591ff43b0128eb8d7fb80468eb38ae68d187b2 Reviewed-on: https://gerrit.libreoffice.org/11328 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-09-08don't make reason for exception a mysteryCaolán McNamara1-4/+4
Change-Id: I3a3a2273dc0f97931dd6ddfd9492d5a883448aa3
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-09 02:53:24 +0000