summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)AuthorFilesLines
2013-09-11Change of precision is equivalent to type change. (firebird-sdbc)Andrzej J.R. Hunt1-3/+5
Change-Id: I5f8c80b01917028fe80d468f5e96de56b917bd7e
2013-09-11Remove redundant comment. (firebird-sdbc)Andrzej J.R. Hunt1-2/+0
Change-Id: I17105f474dea07a1a980252309a3ccd88a558db9
2013-09-11Remove unnecessary sal_Bool(bool) casting. (firebird-sdbc)Andrzej J.R. Hunt1-11/+11
Change-Id: I3d9cf598404d137e0f13667ea8f0dc7be6253f7a
2013-09-11Don't format integers as currency by default. (firebird-sdbc)Andrzej J.R. Hunt1-8/+5
Change-Id: I228bb9f5d1121c1e328daa3d677cc54254255beb
2013-09-11Ensure we have prepared the statement before modify null.Andrzej J.R. Hunt1-0/+1
Currently if the first set* method to be called is setNull, then we segfault since we try to access m_pInSqlda which doesn't exist yet. Change-Id: I4ad9c0a7d68da11b2260a596dd95c4c2cb5bcd4c
2013-09-10Reintroduce Statement specific mutexes. (firebird-sdbc)Andrzej J.R. Hunt7-55/+62
This replaces the erronous Connection wide mutex. Libfbembed is multithreaded hence we don't need a connection wide mutex. Change-Id: Ifae79cdefecfe6597a535e36bda318563092bf6c
2013-09-09gbuild: install rdb files directly in module they come fromMatúš Kukan1-0/+2
Change-Id: I3a9cb4ce71cfb02b7378289a36aa0eb6e3a42f26
2013-09-09Cleanup public parts of Connection a little.Andrzej J.R. Hunt1-40/+35
Change-Id: I76b0f9e547ce604aaace129a60c99b0beceac300
2013-09-09Cleanup Connection and rename from OConnection. (firebird-sdbc)Andrzej J.R. Hunt13-198/+236
Change-Id: I06cfdc29d7613638d3cea080e7b39c67c74d4de0
2013-09-09Cleanup findColumn. (firebird-sdbc)Andrzej J.R. Hunt1-8/+12
Change-Id: I0458892d9688a8618789652caf67251a61cc63aa Reviewed-on: https://gerrit.libreoffice.org/5884 Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org> Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
2013-09-07s/wiki.services.openoffice.org/wiki.openoffice.org/gAndras Timar1-2/+2
Change-Id: I059fbee385a109069c70f3869021c8e2ee48fee1
2013-09-06Some stylistic cleanup in PreparedStatement.Andrzej J.R. Hunt1-5/+2
Change-Id: Idaddaeff58fa9433c678e7913435ad81bd615934
2013-09-06Use throwFunctionNotSupportedException as appropriate. (firebird-sdbc)Andrzej J.R. Hunt1-8/+8
Change-Id: Ia2eb42ea2bf0f70a6d1fef29438a43a7a2f69388
2013-09-06Comment out unused parameters instead of (void) cast. (firebird-sdbc)Andrzej J.R. Hunt1-29/+15
Firebird doesn't support catalogs or schemas hence these parameters are unused in the various get[...] methods. Previously these were (void) casted however commenting out the parameters seems more correct and reduces the amount of code. (This was omitted for as-of-yet unimplemented methods since they will still be looked at in detail.) Change-Id: Ic6566ff0b3e873b802deec79d5497efdd21e577d
2013-09-06Implement set[Float|Double]. (firebird-sdbc)Andrzej J.R. Hunt1-6/+2
This commit somehow got lost on my old computer, so here it is recreated. Change-Id: Ib4001a21c92976fe0e3dea3778360ff67cbfa3a9
2013-09-06Extend OIndexesHelper::dropObject to use correct DROP INDEX. (firebird-sdbc)Andrzej J.R. Hunt4-4/+83
Firebird's DROP INDEX statements only need to contain the index name, including the table name causes an error. Change-Id: I5b61d82bda7176148f7849e31bd050e025f84e02
2013-09-06Keep a TempFile instead of using TempFile::CreateTempName.Andrzej J.R. Hunt2-11/+9
This ensures that the enclosing directory is kept while we work with it. Conflicts: connectivity/source/drivers/firebird/Connection.cxx Change-Id: I5c095d481414e345cf05efc3d40d314f8f40ed12 Reviewed-on: https://gerrit.libreoffice.org/5814 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2013-09-06Use the user specific tmp directory for firebird.Andrzej J.R. Hunt3-8/+16
osl::FileBase::getTempDirURL uses the general tmp directory which can be the system wide directory (i.e. /tmp). This can lead to conflicts e.g. if we have multiple instances each trying to create /tmp/firebird. Instead we use ::utl::TempFile which uses a user-specific directory (as a subdirectory of what osl::FileBase::getTempDirURL provides), in which we can have the FIREBIRD_TMP and FIREBIRD_LOCK directories. Change-Id: Ic868f12b0a56900eac75f2418986193dd5fe0f10 Reviewed-on: https://gerrit.libreoffice.org/5797 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-06CID#1079053 Uncaught Exception.Andrzej J.R. Hunt2-2/+3
In this case we can just propagate the DeploymentException (is a RuntimeException). Change-Id: Ic807ec039af3856f90d4e798e1304a72421b4db6
2013-09-06CID#1079054 Uncaught exception.Andrzej J.R. Hunt2-2/+3
In this case we should just propagate the DisposedException to the caller. Change-Id: I3c2699ad6c2144007d98447b133cdbb13f5d50d9
2013-09-06CID#1079051 Uncaught exception. (firebird-sdbc)Andrzej J.R. Hunt2-4/+6
In this case we can just pass the DisposedException (is a RuntimeException) onto the calling methods. Change-Id: I89d2421c03a5f8e81f209b94109ffde117cfb0cd
2013-09-06CID#1079048 CID#1079049 CID#1079050 Uncaught exception. (firebird-sdbc)Andrzej J.R. Hunt2-2/+3
In this case we can just pass the DisposedException (is a RuntimeException) onto the calling methods. Change-Id: Ia85a2d147ed3822847fe64b8cac671c88c6444fe
2013-09-06CID#1079047 Uncaught exception. (firebird-sdbc)Andrzej J.R. Hunt2-3/+5
In this case we can just pass the DisposedException (is a RuntimeException) onto the calling methods. Change-Id: I379974fd7998151d503020742ae7ae18cbdfaf7c
2013-09-06CID#1079045 CID#107946 Uncaught exception. (firebird-sdbc)Andrzej J.R. Hunt2-2/+3
In this case we can just pass the DisposedException (is a RuntimeException) onto the get* methods. Change-Id: I97a3575709e2f50fa651a5d26c3029ed014630da
2013-09-06Add error checking in rebuildIndexes. (firebird-sdbc)Andrzej J.R. Hunt1-1/+6
Change-Id: If59c9fe7d7253347717aeb5b1aadf212b7d536a6
2013-09-05update pchThomas Arnhold2-3/+1
Change-Id: I6d5e8d3fd69189935a3338fee19b60022f70a7eb
2013-09-05use replaceFirstThomas Arnhold1-2/+2
Change-Id: Ia20eec6e868579ed31e478514b7f2722a0972094 Reviewed-on: https://gerrit.libreoffice.org/5828 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-09-05WaE: unused variableCaolán McNamara1-2/+1
Change-Id: Id360f83149ba281c806e4c71ba283603f4480954
2013-09-06Actually use table name in getIndexInfo. (firebird-sdbc)Andrzej J.R. Hunt1-1/+2
Otherwise dbaccess's indexcollection gets confused and can segfault when indexes not belonging to the desired table are returned. Change-Id: I4dfe62bf1053c65cac907bf490749ee2cc24e6ca
2013-09-06Actually rebuild indexes in rebuildIndexes. (firebird-sdbc)Andrzej J.R. Hunt1-7/+28
Change-Id: I76ac3b261bce830879f17e82ddd22a9f4d957f11
2013-09-06Retrieve all char indexes for rebuildIndexes. (firebird-sdbc)Andrzej J.R. Hunt2-0/+52
This provides the SQL SELECT statement necessary to retrieve all the indexes needing rebuilding. Change-Id: I07661277682f83dc3f2d33a398abd83593c9928d
2013-09-06Implement getIndexInfo. (firebird-sdbc)Andrzej J.R. Hunt1-9/+92
Change-Id: I8c3393fbc7c4fb418f31a80b23360c6c7bf21a25
2013-09-05CID#1079186 ununinitialized pointerCaolán McNamara1-0/+1
Change-Id: Ie22e82904dc12f064c3b7d47bce294c5515590de
2013-09-05CID#1079332 Uninitialized scalar fieldCaolán McNamara1-2/+0
Change-Id: I07239ddec7806261fa9098839fd3fc9e5c400594
2013-09-04WaE: Unreachable code: Use SAL_WNOUNREACHABLE_CODE_PUSH/POPTor Lillqvist3-29/+30
Cleaner than my first attempt. This reverts commit aa4868de78b3a3893722f7a079f4d05e18abd8db. Change-Id: I9c92be72e69292731983a53fc2de29ba333071c9
2013-09-04WaE: Unreachable codeTor Lillqvist3-0/+28
Noticed by the MS linker when doing link-time code generation (!). In all cases, a "return" after a call to a function that always throws an exception. To avoid other compilers perhaps warning about missing return of a value, put the "returns" inside ifdefs. Change-Id: I83aa04cb5c3ff8413d3ed4dc85fb57f2a41fd589
2013-09-03Add some comments on foreign key retrieval (firebird-sdbc)Andrzej J.R. Hunt1-0/+6
These two methods don't seem to be used at all within the LO codebase. They are also extremely complicated to implement hence will be left for later implementation -- my part implementation will be put on the wiki firebird page. Change-Id: I72922a4f3c4705fdcc3bbca140d6df64a1e16253
2013-09-03Remove outdated/useless comments. (firebird-sdbc)Andrzej J.R. Hunt1-6/+3
Change-Id: Iab163debab1513369b75183efdaa3c03f7193a70
2013-09-03ResultSet: add FunctionNotSupportedException, some cleanup. (firebird-sdbc)Andrzej J.R. Hunt1-56/+60
Change-Id: Iee897766841af980d93aeb73255c82851172601a
2013-09-01Remove some unused code from unusedcode.easyMarcos Paulo de Souza1-38/+0
Change-Id: Ic3e96eebbb914c5b905a8c58532ead9cb01dd41d Reviewed-on: https://gerrit.libreoffice.org/5721 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-08-31delete more code that was commented outPhilipp Riemer1-1/+0
Change-Id: I8a37b482ca4abb440691b2490e43ecd93a8dbbc5
2013-08-31fix indentationPhilipp Riemer2-17/+17
This is a follow up commit to - 22d1beb78a475e4846af945afde1c4d6c263b5d6 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75 Change-Id: I55ff666c357c89ad355a1a5bc0d0347fcc188476
2013-08-31deleted code that was commented outPhilipp Riemer2-12/+0
This is a follow up commit to - 22d1beb78a475e4846af945afde1c4d6c263b5d6 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75 Change-Id: I7a67c3768c0d7e36784ee88fc46680037acb244d
2013-08-31fdo#62475 - remove visual noisePhilipp Riemer2-128/+20
This is a follow up commit to - 22d1beb78a475e4846af945afde1c4d6c263b5d6 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75 Change-Id: I102685391125f3b4f7bdf838f8bd17a2283d558d
2013-08-30Set path and not url for FIREBIRD_[TMP|LOCK]. (firebird-sdbc)Andrzej J.R. Hunt1-5/+6
Otherwise firbird fails to load databases since it can't access a url. Change-Id: I1bebc6fa18c2d1920291dcf5a7300009ede4452a
2013-08-30Improve TIMESTAMP display. (firebird-sdbc)Andrzej J.R. Hunt1-1/+1
Change-Id: Ief7ec180e3787a3354e2034693052ebf05a30e81
2013-08-30Implement setTimeStamp. (firebird-sdbc)Andrzej J.R. Hunt1-5/+13
Change-Id: I58907d42ec9e1b4098e2947fdb89b1ab264358a6
2013-08-30Cast pointer before dereferencing. (firebird-sdbc)Andrzej J.R. Hunt1-1/+2
We have a char* pointing to arbitrary data hence we need to cast to the right type, othwerwise we retrieve the first byte only. Change-Id: I6d3d08d15105a506c140044008c5255a8a8e4c39
2013-08-30Implement set[Date|Time]. (firebird-sdbc)Andrzej J.R. Hunt1-10/+22
Change-Id: Ibf3bc34f316c0a299afc2e015ff4c49ad57099a5
2013-08-30Implement malloc'ing of date/time/timestamp (firebird-sdbc)Andrzej J.R. Hunt1-9/+5
Change-Id: I22abb334a337ae2e25188ae43696789d37ecd7d4