summaryrefslogtreecommitdiff
path: root/connectivity
AgeCommit message (Collapse)AuthorFilesLines
2021-04-02Simplify some static variable initializationsMike Kaganski1-3/+1
Change-Id: I6cdd44aa66b9597ccc51fc3fd69b57485ccb3230 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113515 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-27tdf#141115 semi-userfriendly message on UNION query on file driverLionel Elie Mamane1-0/+7
Rather than silently returning only the first (left) part of the UNION, error out. Change-Id: I6ed1eba55ad33f149d9010933a3c7a835fce0451 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113207 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Lionel Mamane <lionel@mamane.lu> Tested-by: Jenkins
2021-03-27tdf#141115: correctly find the ORDER BY clause of a UNIONLionel Elie Mamane1-5/+22
instead of blindly assuming a SELECT is not a UNION, leading to an out-of-bounds array access when it is. Change-Id: I8f904ae65acba8d8ee23b95299058207af68c0ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113189 Reviewed-by: Lionel Mamane <lionel@mamane.lu> Tested-by: Jenkins
2021-03-25fix connectivity buildCaolán McNamara1-2/+2
since... commit a0656ec6fc2b41e65f1b40dbd64f546175e2762f Date: Thu Mar 25 09:53:33 2021 +0300 const OUString -> const OUStringLiteral Mostly automated rewrite Change-Id: Id15273edde05933927378e45baadebc0727d558e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113083 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-25const OUString -> const OUStringLiteralMike Kaganski7-10/+10
Mostly automated rewrite Change-Id: Ie020a083f898bc126b8fb039d4ecb2e687172da1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112965 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-24Using .md extension/Markdown syntax for modules READMEHossein1-0/+0
Renaming all README files for all top level modules to README.md, applying no content change at this stage to be able to track history of the files. These files should be edited to use correct Markdown syntax later. Change-Id: I542fa3f3d32072156f16eaad2211a397cc212665 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112977 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-03-23tdf#124176: Use pragma once instead of include guardsMehmet Sait Gülmez1-3/+1
Change-Id: Ie396c62d7743918c36ee0a2041f26c7a7e70c802 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112945 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-03-23tdf#124176 replace include guards with pragma oncePanos20-74/+20
Change-Id: Iac0caac45130fd7da21ed9e7869abbd288931747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112975 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-03-23tdf#124176 Use pragma once in connectivityVincent LE GARREC247-866/+247
Change-Id: I4a57cd6dcbc180fe9a378d2713c687a66476ee79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111979 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-03-21fix typo in code: anylizeSQL->analyzeSQLJulien Nabet2-4/+4
Change-Id: Ibee6322c03c6bd03a72bcb66b27077527f5529ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112855 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-21update pchesCaolán McNamara2-3/+2
Change-Id: I60e61133c305673bb305e41957f5414820c7c358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112790 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-13update pchesJulien Nabet2-4/+3
Change-Id: Id6dfae9fb97fbe3fc89b9f2e083d7a3d5c1d36d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112411 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-10Drop 'static_cast<cppu::OWeakObject*>' syntactic noiseMike Kaganski2-4/+2
... a leftover from 96388e5e809a48573970df9b6b2649517a08447f. Change-Id: I909a470612c421472d8bf94f80e3e94ecb51d6e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112257 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-10Drop 'static_cast<cppu::OWeakObject*>' syntactic noiseMike Kaganski1-1/+1
... where the object is created in-place, and its type is known Change-Id: Ifabfcf2f3ad0d60152f14e8d970c1faa42115288 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112256 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-09loplugin:refcounting (clang-cl)Stephan Bergmann8-98/+62
Change-Id: I91189ebd902b70e2fbe42fe8cc09b8677af1a5fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112194 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-09Make sal/config.h the first in pchMike Kaganski11-22/+22
By convention, it should be the first include in C/CXX files; so use of pch should not break that. Change-Id: Ic329c5f39e8f48ad1778724368e262e48972342b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112123 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-08loplugin:refcounting (macOS)Stephan Bergmann2-3/+4
Change-Id: Id9c5035933453bad617d1a2f78241e435e42fe91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112168 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-06update pchesJulien Nabet1-1/+1
Change-Id: Id892e426343746df2f01f4cdc5f470351bdb6a12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112099 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-06update pchesJulien Nabet3-4/+8
I just used ./bin/update_pch.sh Change-Id: I06a7f36eb4c511b8d6c6477fd87e57f0d9702457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112097 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-05loplugin:refcounting (--enable-evolution2)Stephan Bergmann8-35/+28
Change-Id: I83f16646e5bd7c3814d9d3dd3fa6408c40f96bd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111968 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-03update pchesCaolán McNamara1-1/+1
Change-Id: Ide49c48738ecd537d4eb69390d22807561d3b4e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111828 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-03loplugin:refcounting (--enable-postgresql-sdbc)Stephan Bergmann24-75/+108
Change-Id: I79a1d05be3a4e7a8e278665ff5863cdc4b182009 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111832 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-03loplugin:refcounting (clang-cl)Stephan Bergmann1-5/+3
Change-Id: I400ef428921573ae345de15e94695e98f0b02a92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111813 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-03loplugin:referencecasting (clang-cl)Stephan Bergmann1-1/+1
Change-Id: If32c6f6d3618c134cfb2ac89e827491525c34687 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111811 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-02loplugin:refcounting (macOS)Stephan Bergmann5-31/+23
Change-Id: Ia68887778e6779cfaee58c88344c748a2b3d4579 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111831 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-26loplugin:refcounting in connectivityNoel16-19/+19
Change-Id: Iee324d84334f60a13615a4d422d480c9c597fdbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111539 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-23update pchesCaolán McNamara1-1/+1
Change-Id: I44424081b7f55710c4db7f10d1829de1ae08be76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111363 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-22loplugin:refcounting in connectivityNoel63-304/+226
Change-Id: Iff2f096e7ee00d9cb29d47462dd7e1963c6b06e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-19loplugin:referencecasting (--enable-evolution2)Stephan Bergmann2-2/+2
Change-Id: I7e4470e0713a69ecbae3aebac2129557bd8a16c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111249 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-19update pchesCaolán McNamara1-1/+1
Change-Id: Ic4586057346b6de700c1bb6ff4cd759a11bb3e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111231 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-18loplugin:referencecasting (macOS)Stephan Bergmann3-4/+4
Change-Id: I99470067a34fab9fbc2ea53d2f8a634240f0d223 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111127 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-18createResulSet -> createResultSetNoel Grandin4-5/+5
Change-Id: If0ca3c8dfaade4764832fe7ccf506a4451795d7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111068 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17loplugin:referencecasting in connectivityNoel20-29/+28
Change-Id: I4b91c3e4a225323235ea37d77f0f96600bf412be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110969 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-10Remove unneeded breaksAndrea Gelmini1-1/+0
Extending this: https://gerrit.libreoffice.org/c/core/+/110512 Change-Id: If7e6f9c4079c2e0b48e642aa0b140fb4e03996bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110520 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-09loplugin:referencecasting check for Reference::queryNoel1-1/+1
Change-Id: I008d16d933c70df132699872ac4c39a5c1f87b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110592 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-08update pchesCaolán McNamara1-1/+1
Change-Id: Icf55ddda055d11b649e7607c2cdd8b6d6ddfefbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110483 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-05restore com.sun.star.mozilla.MozillaBootstrapCaolán McNamara12-0/+921
its used to find mozilla profile dirs for cert-related reasons removed overzealously with... commit ee9ed2192b56c98e5b8ee9890ddb4c533117332a Date: Thu Dec 10 18:39:26 2020 +0100 tdf#138715 remove mork driver Change-Id: I52f1ace5d4aac100c7652dc499ffe9c8312c9474 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110413 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-29loplugin:stringviewparam extend to new..Noel11-42/+42
O[U]StringBuffer methods Change-Id: I0ffbc33d54ae7c98b5652434f3370ee4f819f6f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-28simplify code, use more subView()Noel3-6/+6
Change-Id: I569c7f34acbdf8451cd5c9acf1abd334637072d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110051 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-27tdf#96505 Get rid of cargo cult 'long' integer literalsAlchemist1-7/+7
Change-Id: I8746b7b32cbebd275fe9f47cce9c80aa87fbc583 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108809 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-26loplugin:passstuffbyrefNoel2-2/+2
Change-Id: I330e0ab6c9955939dad313f9d472f93e39dbd313 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109924 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-24Use ContainerType().swap and avoid local variablesMike Kaganski3-8/+4
Change-Id: I773555180758a97aff37f9bc27de83c355d71521 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109761 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-20connectivity: document how to test postgresql manuallyMichael Stahl1-0/+20
Change-Id: I16f091b35a8246cb43842a6b864ba6061013ea7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109695 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-13Fix some warnings for Raspberry pi 4 (part6)Julien Nabet4-1/+30
Change-Id: I1114968f38a5309862723dde9554e3df97309f23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109239 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-13loplugin:stringviewparam (clang-cl)Stephan Bergmann12-57/+86
Change-Id: Ie66996f905fcb68ee413171c8727cb42dcb28dbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109178 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-12loplugin:stringview (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I64177842c3f77a5ae43574a18f389b64f61bc868 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109176 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-10tdf#124176 Use pragma once instead of include guardsanirudhS3-12/+3
Change-Id: I609925d09086c764ae0360e08e0d74c8d4b7d484 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109053 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-09fix coverity parse errorsCaolán McNamara12-31/+31
Change-Id: I3a1179947704452e3ffec02be59d0f7bf0b75ab0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109017 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-08Fix uses of OTools::get/putValue with string argumentsStephan Bergmann6-13/+44
...after 723a2623bd11c51d506873862893ee4009caaab1 "Use string view here". My clang-cl build's > connectivity/source/drivers/ado/AColumn.cxx(164,62): error: implicit conversion of constant &u"Autoincrement"[0] of type 'const char16_t *' to 'bool'; use 'true' instead [loplugin:consttobool] > OTools::putValue(m_aColumn.get_Properties(), u"Autoincrement", getBOOL(rValue)); > ^~~~~~~~~~~~~~~~ > connectivity/source/drivers/ado/AColumn.cxx(239,62): error: implicit conversion of constant &u"Autoincrement"[0] of type 'const char16_t *' to 'bool'; use 'true' instead [loplugin:consttobool] > m_IsAutoIncrement = OTools::getValue(aProps, u"Autoincrement").getBool(); > ^~~~~~~~~~~~~~~~ etc. revealed that those arguments were now silently picking the OLEVariant(bool) overload. Change-Id: I83f0d790591d6be9b84fb6263747085dc7bd94d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108962 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-04loplugin:stringviewparam: operator +=Stephan Bergmann1-1/+2
Change-Id: I30ce1b5bd8fb168da7067c1967c5af2569df2653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108512 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>