summaryrefslogtreecommitdiff
path: root/comphelper
AgeCommit message (Collapse)AuthorFilesLines
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann2-2/+0
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-10coverity#706285 Uncaught exceptionCaolán McNamara1-4/+15
Change-Id: I6d7227a0614042f7a65520fc79b31afa3d7ca744
2014-10-10coverity#706284 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: I748d34fd7f56b1c9c739f15fbb596932484195a4
2014-10-10coverity#706275 Uncaught exceptionCaolán McNamara1-5/+12
Change-Id: I538cca9505411e8984ba821807c0072c0ce40e7b
2014-10-10coverity#1242878 Unused valueCaolán McNamara1-1/+1
Change-Id: I85bc3fffb2d350a13aeb30c75f0c2d0a7bc5e7a3
2014-10-09Revert "coverity#1224993 Uncaught exception"Stephan Bergmann1-4/+9
This reverts commit b66a96d792e9ef8022547f835ed4633c8e7f4c10, follow-up commit will fix w/o breaking JunitTest_framework_unoapi. Change-Id: Iac12d52c2eb9a1e4ab09d24910cee1838cc7d883
2014-10-08coverity#1224993 Uncaught exceptionCaolán McNamara1-9/+4
Change-Id: If5dcb4bbd728f7396e19382f85bdf2a3d77a6db6
2014-10-08coverity#706283 Uncaught exceptionCaolán McNamara2-4/+2
Change-Id: I2c3f10894ffe514dbc71cd1dd672685aa8f09a0d
2014-10-07disambiguate uniform_int_distributionCaolán McNamara1-6/+2
Change-Id: Ifa0c1b1983d1cc7f22d55b15dee88b7f709dbcf8
2014-10-07I shouldn't be shy, just assert()Tor Lillqvist1-3/+1
Stephan dislikes "defensive programming" and I trust him. Change-Id: Ic4864de98a5155129179eb89873f3ffdc8921614
2014-10-07Handle incorrect usage of uniform_real_distribution()Tor Lillqvist1-0/+3
uniform_real_distribution(a,b) should be called with a < b, otherwise the result is undefined. Currently, when called with both zero, it gets stuck in a loop. Not sure if a blunt assert() would be the right thing here, so I just return a if a >= b. Change-Id: I769688c7192bd02bad24ad597948984db56dd4fc
2014-10-06when size_t == unsigned intCaolán McNamara1-0/+4
Change-Id: If8cd3632d69f6456b0e1351efac0e428e0093e3b
2014-10-06use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara1-13/+45
and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-02coverity#1242878 Unused valueCaolán McNamara1-1/+1
Change-Id: I123855003be3eb5ef6494cda8f42b4daeba1c272
2014-09-25comphelper: std::auto_ptr -> std::unique_ptrStephan Bergmann4-17/+16
Change-Id: I364d6252f470dcc6d71a191f1249e95ca1f284ce
2014-09-22loplugin: cstylecastNoel Grandin4-9/+9
Change-Id: I84873c9f84651dc8a1337f37c63020b461314e1b
2014-09-11create a master document template typeCaolán McNamara1-0/+1
of application/vnd.oasis.opendocument.text-master-template with suffic otm https://lists.oasis-open.org/archives/office-comment/201002/msg00042.html desktop/icons/oasis-master-document-template.icns is just a copy of desktop/icons/oasis-master-document.icns because I can't draw Change-Id: I0d18c79c4c893e97505052884ee8be97d0f117a1 Reviewed-on: https://gerrit.libreoffice.org/11350 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-08-30coverity#706466 Uncaught exceptionCaolán McNamara2-5/+0
and coverity#706463 Uncaught exception Change-Id: I77cb09054f00d86cd3e206e44ef4942ddf148a7f
2014-08-21stario -> css::ioThomas Arnhold3-41/+41
Change-Id: Iad96e0a2bfd6c126c696f14919dbfd8e072dd230
2014-08-21starcontainer -> css::containerThomas Arnhold1-9/+9
Change-Id: Ie6e75483aa4262a5f66a4c557015af8b3c02d592
2014-08-21starawt -> css::awtThomas Arnhold1-3/+3
Change-Id: I76dd16aa2c42a649162ea2e37c824af30cdd557b
2014-08-21comphelper: starbeans -> css::beansThomas Arnhold1-6/+2
Change-Id: Iedfc4460194f179b20d734cb7671894213c77008
2014-08-21comphelper: starutil -> css::utilThomas Arnhold1-10/+10
Change-Id: If4c0d404b0f7027837dcc245b5b7d21b1f749347
2014-08-21comphelper: starlang -> css::langThomas Arnhold3-12/+11
Change-Id: Ie8adb5b81df51fd973cbb786f27ea3ef1462679c
2014-08-21comphelper: staruno -> css::unoThomas Arnhold6-81/+81
Change-Id: I21991280c5b7e4c6d0c200f4489c89a9f4fbc385
2014-08-20java: remove modifiers implied by the contextNoel Grandin1-1/+1
found by PMD Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-20java: remove unnecessary return statementsNoel Grandin1-1/+1
found by PMD Change-Id: I3d150421948d17eaed34fac2b1a212da34288d1a
2014-08-19java: use 'Short.valueOf' instead of 'new Short'Noel Grandin1-1/+1
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
2014-08-19java: use 'Long.valueOf' instead of 'new Long'Noel Grandin1-1/+1
Change-Id: If4fff3dd37326fbcdd01b743355a16591d71fa69
2014-08-19java: use 'Integer.valueOf' instead of 'new Integer'Noel Grandin1-1/+1
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19java: use Boolean.valueOf instead of instantiating Boolean objectsNoel Grandin1-1/+1
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-17coverity#1231667 Unchecked return valueCaolán McNamara1-7/+7
Change-Id: I40d8fc61b1e488955faa61c868877c7b6487c529
2014-08-09Resolves: #i125386# secured user request and changed some bools to bitfieldArmin Le Grand1-8/+28
(cherry picked from commit 5e3cbe056c19bea5018dbf1fd4b2bc8f8b030ff3) Conflicts: comphelper/inc/comphelper/embeddedobjectcontainer.hxx comphelper/source/container/embeddedobjectcontainer.cxx sfx2/source/appl/linkmgr2.cxx svtools/source/misc/embedhlp.cxx Change-Id: I7e9b20a87ca6afe8cb91c577860a6c6b72368ee9
2014-08-05java: remove commented out codeNoel Grandin2-41/+0
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-07-29Include <algorithm> for std::minTor Lillqvist2-0/+2
Change-Id: If2bf31494f1354ff3856ad8b32f6799042e23b18
2014-07-13coverity#706282 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: Icca233fdc6d841d1bf51f918b83f3eef2cd5952e
2014-07-13coverity#706281 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: I469b812c666801db5e3a6fac1d6152afd80cf39a
2014-07-10Use OUStringHash here.Kohei Yoshida1-25/+2
Change-Id: I37625fb421e5b20f299fccccbc9d5ac74c31de3c
2014-07-09Pass a useful exception message.Kohei Yoshida1-1/+8
Change-Id: Idde024a7b6896571d159c3983ef1985fa12d0c5a
2014-07-08use SimpleReferenceObject in comphelper moduleNoel Grandin1-18/+0
to replace hand-rolled version Change-Id: Ie4e66d2f1f893c04be589877ef53f470ca74c9eb
2014-07-07DBG_ASSERT->assert when followed by dereferenceCaolán McNamara1-1/+1
Change-Id: Ic1c999ffdc391ea01be5711721e7c9e63179473e
2014-07-03comphelper: sal_Bool -> boolStephan Bergmann2-5/+5
Change-Id: I7d7ae1f5ddff0cf7d11a407b190256f37a71d48a
2014-07-02Revert "comphelper: sal_Bool -> bool"Stephan Bergmann2-5/+5
Oops, this reverts commit c95ff75df274e3d84458e928ee96870bc8b663b3.
2014-07-02comphelper: sal_Bool -> boolStephan Bergmann2-5/+5
Change-Id: Icde90101b6adfa766c8abbeb55c518725e6596e1
2014-06-29Typo: conteiner->containerJulien Nabet1-1/+1
Change-Id: Idf1294c7da00621900d41c16473b862ee8fc502d
2014-06-26clang: Result of operation is garbage or undefinedCaolán McNamara3-3/+3
Change-Id: I49f58ae6a7c046af4c3de8d35219ffe2e4ba8f20
2014-06-25fixes for up-casting to Reference<XInterface>Noel Grandin1-2/+2
Fix regressions introduced with 6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking Reference constructor to reduce code noise" Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-06-24new compilerplugin returnbyrefNoel Grandin2-4/+4
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-19fdo#71076, fdo#71767: Preserve number formats when charts are copied.Kohei Yoshida1-5/+16
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin2-9/+1
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-08 22:44:01 +0000