summaryrefslogtreecommitdiff
path: root/basic
AgeCommit message (Collapse)AuthorFilesLines
2015-08-04basic,basctl: inline some use-once typedefsNoel Grandin5-22/+12
Change-Id: I60619a5bfe9507fb5ed24123f62f6b5c2f2c8712
2015-08-03new loplugin: refcountingNoel Grandin4-54/+54
This was a feature requested by mmeeks, as a result of tdf#92611. It validates that things that extend XInterface are not directly heap/stack-allocated, but have their lifecycle managed via css::uno::Reference or rtl::Reference. Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692 Reviewed-on: https://gerrit.libreoffice.org/16924 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-29convert SBSTRM constants to scoped enumNoel Grandin5-27/+36
Change-Id: I478a9c7eca6509baf3e9a3dd3ce3dd8f3060f842
2015-07-28inline "old" SbERR constantsNoel Grandin27-843/+843
Change-Id: I3e6665351de97692ae70207e8b623ad008ca8c9a
2015-07-28inline the "old" SbxErr constantsNoel Grandin27-438/+438
Change-Id: I1c54c792e0397d61c97d5067963b343f912275fc
2015-07-28convert SbxFlagsBits to scoped enumNoel Grandin23-226/+226
Change-Id: I3dd699ca675be2ff4a8bfb7938bd5d43719b304c
2015-07-24loplugin:unusedmethodsNoel Grandin1-9/+0
Change-Id: If5090c330e12d6e537766bf4a9be0a2360381a7a Reviewed-on: https://gerrit.libreoffice.org/17312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21Miscellaneous typosAdolfo Jayme Barrientos1-2/+2
Change-Id: I5187364d420ab78c36a91632efab9c32951d867a
2015-07-20com::sun::star->css in basicNoel Grandin29-513/+496
Change-Id: I637fd7aedeb97b7dca22521474a54a1d4274f212 Reviewed-on: https://gerrit.libreoffice.org/17206 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-19Fix indentationMatteo Casalin1-6/+6
Change-Id: I5cff1cda3c6882e751b88a4a4d1aacbec8942578
2015-07-19sal_uIntPtr to sal_uInt32, for consistencyMatteo Casalin5-12/+12
Change-Id: Ib78dce61e8fb8c8e3bf8c7a2b02966100a4db0e8
2015-07-19sal_uInt16 to sal_Int32 with some cleanupMatteo Casalin1-5/+4
Change-Id: Ib6e42702dd1ce29645215114b26286f05ccc1332
2015-07-19Use more proper integer typesMatteo Casalin1-5/+5
Change-Id: If86163ddeff91571419a37becbbe75f98e681d7d
2015-07-17basic: replace boost::ptr_vector with std::vector<std::unique_ptr>>Michael Stahl2-12/+14
Change-Id: I96ea97c1df7903a28387d8e1171075be55a80ca7
2015-07-16loplugin:simplifyboolStephan Bergmann1-9/+9
Change-Id: I2dc7883e23c1437c4a8bf9fce19acfd3fe700ec0
2015-07-15fix Windows buildNoel Grandin1-1/+1
after commit 22b094f5d8e1e82375b135abd3a6f99a9a555244 "loplugin:unusedmethods basic" Change-Id: I7586d2487e47731db93335c3d9969626bf2eb6ab
2015-07-15loplugin:unusedmethods basicNoel Grandin15-67/+5
Change-Id: Iddfbde451088750f8c74f3ac72c35b5ccfbe0ab1 Reviewed-on: https://gerrit.libreoffice.org/17044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann2-19/+5
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-08Fix typosAndrea Gelmini2-2/+2
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0 Reviewed-on: https://gerrit.libreoffice.org/16834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-07-07Replace GetAppData(SHL_IDL) with a static pointer varStephan Bergmann1-7/+12
Change-Id: Ia1e22ff95457a958ef26974091aa2092b32505bd
2015-07-06tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe10-37/+33
with the variadic variants, in basic. Change-Id: I13c5644bd6b9e964e42a98bee9c3019d959efb36 Reviewed-on: https://gerrit.libreoffice.org/16719 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-04Fix typosAndrea Gelmini7-7/+7
Change-Id: I75b4ad61785bf0ba1cb07735d938c0977356b8cc Reviewed-on: https://gerrit.libreoffice.org/16705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-02error: 'pGen' was not declared in this scopeMiklos Vajna1-1/+1
Change-Id: I6ebf100be3a90b315491e2735da9c82e5901fc59
2015-07-02BASIC : Remove SbCodeGen attribute from SbiExprNode and user std::unique_ptr.Arnaud Versini4-141/+129
Change-Id: I9f44f6a4b61987de960b77f54bac8cf2c981bd2a Reviewed-on: https://gerrit.libreoffice.org/16551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-06-28coverity#1308521 Uncaught exceptionCaolán McNamara4-4/+4
Change-Id: I6a189e0d1c4eb04e727fdf12585d46a1f4121f68
2015-06-28Fix typosAndrea Gelmini1-1/+1
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9 Reviewed-on: https://gerrit.libreoffice.org/16523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-28Fix typosAndrea Gelmini1-1/+1
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-27coverity#1308445 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I831637f7f2fb2c552de8c20dc9f5da4e8783b935
2015-06-27coverity#1308444 Uncaught exceptionCaolán McNamara1-2/+2
Change-Id: I103965dfb3e19964e58b3ca4ef34dcee2141d882
2015-06-27coverity#1308435 Uncaught exceptionCaolán McNamara1-2/+2
Change-Id: I8d4ba326e94565bc1ae8b57e406883f737049aea
2015-06-25loplugin:stringconstant: Flag more inefficienciesStephan Bergmann1-1/+1
Change-Id: Ie6ca3065ee60fb2ad75f3bab53059046a981da8d
2015-06-24Simplify uses of comphelper::string::equals with constant argumentStephan Bergmann1-1/+1
Change-Id: I7b12dd04f6811f71b776ee9168703434217b59c8
2015-06-24remove SFX_NOTIFY macroNoel Grandin12-67/+46
it has not served any purpose since we switched to using normal C++ RTTI for the SfxHint objects Change-Id: Ic81353bcb7863ce892eb75296248ca14d8fd6c86
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe8-23/+23
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16Fix typosAndrea Gelmini1-1/+1
Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56 Reviewed-on: https://gerrit.libreoffice.org/16300 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini1-1/+1
Change-Id: I549635318f46718042e50c8f89ce3c620cade990 Reviewed-on: https://gerrit.libreoffice.org/16281 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15cppcheck:redundantAssignmentNoel Grandin1-2/+2
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-15cppcheck:redundantConditionNoel Grandin1-1/+1
Change-Id: Ib8b6342d1da526df6104125ded546b3f053c448b
2015-06-14cppcheck: redundantCondition [part1]Julien Nabet1-3/+3
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
2015-06-13BASIC: Don't use SbiStringPool to pass SbiParser.Arnaud Versini3-19/+12
Change-Id: I15949e604285d804de1554d36acf36e8a407ebd9 Reviewed-on: https://gerrit.libreoffice.org/16137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2015-06-13TyposJulien Nabet1-2/+2
Change-Id: I21c352a63d668c174eef212dbfbe6346c678ce4d
2015-06-09cppcheck: variableScopeCaolán McNamara1-2/+1
Change-Id: If0c56c89e2722d47a401363f3854331229856490
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann18-105/+105
Change-Id: I8bce930283301130ec7a2b1eab2a2c8f65c8abf9
2015-06-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin2-2/+2
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-04convert PropertyMode to scoped enumNoel Grandin3-15/+15
Change-Id: I9b0bbf6273aa18ae918d1d69af5dcc7652181f5c
2015-06-02loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann1-2/+2
Change-Id: I1788ad7d9f9dec892b31a0610d0f44ae1ccd2e64
2015-06-02cppcheck: noExplicitConstructorCaolán McNamara10-16/+16
Change-Id: I8ae8623252546ca94f65fc04b331dd9cafa4fc92
2015-05-29tdf#91702 - fix stack-based MessBox allocation.Michael Meeks2-3/+4
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7 Reviewed-on: https://gerrit.libreoffice.org/15954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-29loplugin:loopvartoosmallNoel Grandin5-6/+6
Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
2015-05-28Rewrite all calls like Dialog(params).Execute()Philippe Jung1-2/+2
Replace all calls looking like ADialog(some params).Execute() by ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute() Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639 Reviewed-on: https://gerrit.libreoffice.org/15915 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>