summaryrefslogtreecommitdiff
path: root/basegfx
AgeCommit message (Collapse)AuthorFilesLines
2017-04-28loplugin:salunicodeliteral: basegfxStephan Bergmann1-4/+4
Change-Id: Ice43bae52ac244815ee62ee843108fd36b9918d7
2017-04-28loplugin:cppunitassertequals: basegfxStephan Bergmann5-203/+209
Change-Id: I942634a688d7728bb21c3ce9bd530e07467cb7c5
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky2-2/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-19clang-tidy readability-simplify-boolean-expr in accessibility..cuiNoel Grandin2-14/+2
Change-Id: Iae27da322c6ede592e6b268fb2210d3525ed22cc Reviewed-on: https://gerrit.libreoffice.org/36677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06loplugin:useuniqueptr extend to catch more localvar casesNoel Grandin2-12/+8
i.e. where the code looks like { foo * p = new foo; ... delete p; return ...; } Change-Id: Id5f2e55d0363fc62c72535a23faeaaf1f0ac6aee Reviewed-on: https://gerrit.libreoffice.org/36190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05loplugin:redundantcast find c-style bool castsNoel Grandin1-1/+1
Change-Id: I3237b93babc67de12c3771aa84766c2141ca93b2 Reviewed-on: https://gerrit.libreoffice.org/36137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-26Fix typosAndrea Gelmini1-1/+1
Change-Id: Idbf0aa261b829e83d4c08a2e989a4ced871dc6de Reviewed-on: https://gerrit.libreoffice.org/35616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-21Only need an OStringBuffer in number2PolyPolygonStephan Bergmann1-3/+3
...so that later passing the OStringBuffer's aNum[i] to createSevenSegmentPolyPolygon (taking a first parameter of type char) doesn't need to implicitly convert from sal_Unicode to char. Requires addition of some missing OStringBuffer-related function variants in rtl/math.hxx and rtl/strbuf.hxx. Change-Id: I79e6b2a791abc62b6556a6668e4411cced490c11
2017-03-19Fix typosAndrea Gelmini1-1/+1
Change-Id: I5c89a47e658ae4ad2b0cdfcdb4988c4b79353085 Reviewed-on: https://gerrit.libreoffice.org/35413 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann1-3/+3
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-01ofz: timeout loading emf with move clip recordCaolán McNamara2-0/+25
Change-Id: Id5d60f0037873598e1447b063e66e9c29840587c Reviewed-on: https://gerrit.libreoffice.org/34740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-26loplugin:loopvartoosmallStephan Bergmann1-3/+4
Change-Id: I085d409f3271c5a4d8237fa3e3c4a74bed296acb
2017-02-24vector::data seems more natural than &vector::frontCaolán McNamara2-16/+16
Change-Id: I0ce48075ad186cf1f9bd3e13fa76269fa9819af1
2017-02-23change intervall -> intervalDavid Tardon1-2/+2
Change-Id: Ib211619428f16304603d9c0a9fce0b22dde2a617
2017-02-15Drop :: prefix from std in [a-b]*/Tor Lillqvist24-113/+113
Change-Id: I0422aaf39bbce889c95ed9a81a0784cb03a1badd Reviewed-on: https://gerrit.libreoffice.org/34320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-02-06Add missing #includesStephan Bergmann3-0/+3
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin1-3/+2
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann2-22/+18
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-24loplugin: unnecessary destructor: basctl..codemakerNoel Grandin2-20/+0
Change-Id: Iadcfa9bc4fe9efb8d24d6d6afaf2b9b3def0bc3c Reviewed-on: https://gerrit.libreoffice.org/33452 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-10New loplugin:conststringvar: basegfxStephan Bergmann4-44/+41
Change-Id: Ia298e6a3515de9bde212dfd6159032859a965df1
2017-01-07coverity#1398371 Useless callCaolán McNamara2-24/+0
Change-Id: I3614bb162cec889ee102e0284b6a3a33a98df470
2016-12-06cppcheck unreadVariable: curr_OffsetTibor Móger1-1/+0
Change-Id: Iffc1d36a0e1921f55f24f5e3f9fc1b063b7c0f16 Reviewed-on: https://gerrit.libreoffice.org/31672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-02convert some anonymous enums to scopedNoel Grandin1-6/+2
Change-Id: Ia989376c983ff475359e4964abeb1f5a2300ff5b Reviewed-on: https://gerrit.libreoffice.org/31486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-18includes should be at the top of the fileNoel Grandin2-2/+2
not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18loplugin:unusedmethodsNoel Grandin2-99/+0
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11loplugin:constantfunctionNoel Grandin1-5/+0
update the plugin similarly to commit 3ee3b36ae0c064fb5c81268d8d63444309d1b970 Author: Stephan Bergmann <sbergman@redhat.com> Date: Fri Oct 7 12:05:49 2016 +0200 loplugin:staticmethods: Don't be fooled by decls starting with macros Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510 Reviewed-on: https://gerrit.libreoffice.org/29665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-06rtl::math::approxEqual(value,0.0) never yields true for value!=0.0Eike Rathke5-13/+13
... so replace with a simple value == 0.0 also in other modules than sc. Change-Id: Ie7316505a1cf9c15100114b45d300facceb03b7e Reviewed-on: https://gerrit.libreoffice.org/29575 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-06CPPUNIT_ASSERT[_DOUBLES]_EQUALStephan Bergmann2-31/+53
Change-Id: I417cea926abcc511e74a090ee90a851c138ac0c0
2016-10-03Fix typosAndrea Gelmini1-1/+1
Change-Id: Ie44267e7c9f92eb1920f05235826abff761251f1 Reviewed-on: https://gerrit.libreoffice.org/29430 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-09-23coverity#1371281 Missing move assignment operatorCaolán McNamara1-0/+11
Change-Id: I7d0351931b0baa434bd24db05358e096cfa1b6e2
2016-09-13Remove nonsense comments: // bitfieldTor Lillqvist1-1/+0
Surely the actual bitfield syntax is enough to tell the code reader that it is a bitfield. Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
2016-09-05tdf#43157 - Clean up OSL_ASSERT, DBG_ASSERT, etc.Gökhan Gurbetoğlu1-3/+4
Change-Id: I8114e338451b5b2e79b2318f558cbd075f024f08 Reviewed-on: https://gerrit.libreoffice.org/28584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-08-29tdf#43157 Clean up OSL_ASSERTdrazil1-6/+6
Clean up OSL_ASSERT in basegfx/source/tools/b2dclipstate.cxx Change-Id: I4107980aa079b0e0e8605de34ecfd01587647af6 Reviewed-on: https://gerrit.libreoffice.org/28417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-08-29cid#1371223 Missing move assignment operatorNoel Grandin3-0/+32
and cid#1371216, cid#1371179 Change-Id: I64faaada85cc92a8b47c2a665488f07050be6fc3
2016-08-25cid#1371276 Missing move assignment operatorNoel Grandin1-0/+10
also cid#1371234, cid#1371249, cid#1371208, cid#1371250, cid#1371258, cid#1371266, cid#1371257, cid#1371221 Change-Id: I18d952887b684e1999d003cec0f668789c851b52
2016-08-25cid#1371281 Missing move assignment operatorNoel Grandin1-0/+11
Change-Id: I29e1b042d2550bbe909ea432b161bdcb418d8976
2016-08-25cid#1371285 Missing move assignment operatorNoel Grandin1-0/+11
Change-Id: Ia822a01caec28f8137e30c05b6904c9fac367ce4
2016-08-17loplugin:unusedenumconstants in basctl..editengNoel Grandin1-10/+0
Change-Id: I49a23a197969d58a3a2d6b2be1fbe4a647c7fa08
2016-08-04loplugin:countusersofdefaultparams in basctl..basicNoel Grandin2-4/+4
Change-Id: I16fac3317ebf55581cb9aaef676a9759de51d695 Reviewed-on: https://gerrit.libreoffice.org/27793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-04tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMuhammet Kara1-3/+1
in basctl, basegfx, canvas Change-Id: I59383d2599793b99b560333387e163a3d80eecec Reviewed-on: https://gerrit.libreoffice.org/27778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-30tdf#96505 get rid of "long" integer literals 'L'Asela Dasanayaka13-117/+117
Remove L from integer literals in module basegfx all 0L, 1L, and 2L Change-Id: Ia8a0d660033651f6d0a35392b74b67358b639fb3 Reviewed-on: https://gerrit.libreoffice.org/27717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-27improve passstuffbyref return analysisNoel Grandin1-1/+1
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-25basegfx: use polygon initializer_list in some placesTomaž Vajngerl2-59/+63
Change-Id: Ibb83476376e1c46aedf67c9455292405219a45c1 Reviewed-on: https://gerrit.libreoffice.org/27476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-25basegfx: initializer_list from polygonTomaž Vajngerl1-0/+9
Change-Id: I2d6cdb7189217e1fadb1ecf4e11cf4dd04043ec6 Reviewed-on: https://gerrit.libreoffice.org/27475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-19simplify code nowCaolán McNamara1-27/+8
Change-Id: Ic9fed523c9077f3e9efa2af00ac5f9e9071a0dc9
2016-07-19Resolves: tdf#100909 artifacts in hole of polypolygon shapeCaolán McNamara1-8/+0
regression from... commit 1ca06ce59b7d3cea873d2dc109a2acaec0a80759 Date: Tue Aug 5 16:11:21 2014 +0000 Related: #i125349# moved clip enhancements to base clipping functionality The "reversed" clipPolyPolygonOnRange path is the problem apparently. The case in #i125349# uses the other clipPolyPolygonOnRange path. So for simplicity just remove the branch that's causing trouble here. Change-Id: Ia4c60ebc44a8c239c1a7d5c84e9b970c2885ff05
2016-07-07tdf#82214 optimize performance for primitivesArmin Le Grand1-0/+8
See svg bug doc, which is processed quite slowly. Beyond needing faster renderers, there is also demand to improve the handling of primitives created by SVG import. Conflicts: drawinglayer/source/primitive2d/patternfillprimitive2d.cxx vcl/win/gdi/gdiimpl.cxx Change-Id: I10992a5746b8b2d6b50e3ee3fe415a035685c9ba
2016-07-07tdf#50613 speedup fat line drawing on linux using cairoArmin Le Grand1-0/+61
Drawing fat lines is slow on linux due to X11 having no direct support for it. This leads to creating the PolyPolygon geometry for each fat line, then tesselate and draw as trapezoids. This is not buffered in any way and is done at each paint. As a side effect, fat lines composed of multiple anti-aliased lines also show errors since AA-ed edges do not add up graphically. Since we have cairo now available it makes sense to use it for fat line drawing, it is markedly faster despite being a software renderer. No such gains for PolyPolygons though. Change-Id: If4001556e2dd4c15ecf2587cad6ce1e864558f2d
2016-07-04"it is working properly", not "it is working property"Christian Lohmaier1-1/+1
Change-Id: Ief34f2e110060dc9d6200e8533c64b1e12bfb37b
2016-07-04Fix some spelling errors in comments and stringsOtto Kekäläinen2-4/+4
Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e Reviewed-on: https://gerrit.libreoffice.org/26883 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>