summaryrefslogtreecommitdiff
path: root/basegfx
AgeCommit message (Collapse)AuthorFilesLines
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin1-2/+2
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-21clang-tidy modernize-loop-convert in b*Noel Grandin5-10/+8
Change-Id: I8ac6eb59e213eafa78e3dc4578738b53e8adef5b
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin1-1/+1
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin4-7/+7
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-13loplugin:passstuffbyref in basegfxNoel Grandin1-1/+1
Change-Id: Ia7fc22152af2facf3134d9e0975cfb9608b2e931
2016-03-31tdf#96505 Remove 0L occurences from avmedia and basegfx modulesslideon14-166/+166
No compiler warnings on my machine Change-Id: Ibd303c64f04f6f52272ac19c3069da2f14cb4e9a Reviewed-on: https://gerrit.libreoffice.org/23558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-30loplugin:nullptr: Find some more cases in templatesStephan Bergmann1-1/+1
Change-Id: I1f127d56e40b04f2b4df85c0afbcfd424d68a8cc
2016-03-30loplugin:nullptrStephan Bergmann1-4/+4
Change-Id: I7f6d030317fc7910e69c742b3160b0156e9f9200
2016-03-10Avoid reserved identifiersStephan Bergmann1-4/+4
Change-Id: I036cb407c29ee375e1893b7418c7fa63bf1d592a
2016-03-08tdf#97703 Removed empty setUp/tearDown methodsChirag Manwani3-15/+0
Change-Id: Ia62de30ae94bdae87cd5109c44eab40af4d020e5 Reviewed-on: https://gerrit.libreoffice.org/22985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-03loplugin:unuseddefaultparams variousNoel Grandin1-3/+2
Change-Id: Ibf8489c957b307156689de4c7cb8440ddd4e4546 Reviewed-on: https://gerrit.libreoffice.org/22852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-25opengl: shader based polyline rendering - fixes tdf#97137 for OGLTomaž Vajngerl1-0/+29
Adds native opengl polyline rendering to draw polylines, line joins and line caps as triangle strips. The vertex shader allows for the dynamic line width by calculating the correct vertex posiitons, and the fragment shader is used for anti-aliasing. Change-Id: If7982c828cae1fae59c57194c8ac77e5ad7f1d26
2016-02-19tdf#97703 Removed a few redundant calls to setUp and tearDownJaskaran3-47/+0
Calls to CppUnit::TextFixture::setUp and CppUnit::TextFixture::tearDown have been removed. I hope that saves a few milliseconds of build time :) Change-Id: I611db2f5c5673ab86bf8f92beb4f6e8a70443b34 Reviewed-on: https://gerrit.libreoffice.org/22496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09crashtesting: crash on loading moz414782-1.svgCaolán McNamara1-1/+1
Change-Id: I1324b902c0790350bc8c44e7d63ce45915e3b33f
2016-02-05Fix typosAndrea Gelmini5-7/+7
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-31boost::tuple -> std::tupleCaolán McNamara1-10/+7
Change-Id: Ia08c184b792ff73d3ed49d6a5d54dec1a35943e9 Reviewed-on: https://gerrit.libreoffice.org/21955 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-22loplugin:fpcomparison in basegfxNoel Grandin7-26/+26
fix comparing of floating point values Change-Id: I54db66968cb999514747171eed82082612e0cac8 Reviewed-on: https://gerrit.libreoffice.org/21708 Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2016-01-21loplugin: unused return valuesNoel Grandin2-37/+0
Change-Id: I4eb1f0c9245c04058fd5e47046f043f8840a79c7 Reviewed-on: https://gerrit.libreoffice.org/21628 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-19Bin unneeded variableTor Lillqvist1-3/+1
As far as I see, the only use of aNormalizedEdgeVector is as a parameter to areParallel(), and there is no need for that to be normalized, is there? Change-Id: I31ca09391894ab441e5b88dbdd636cf4b91ac5c2
2016-01-05Fix typosAndrea Gelmini6-7/+7
Change-Id: I3fba2c76c83381eb398c80947ef4849bccf7ab27 Reviewed-on: https://gerrit.libreoffice.org/21078 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2015-12-10More loplugin:nullptr automatic rewrite (within templates)Stephan Bergmann1-1/+1
Change-Id: I9bc06cfb5eeb38fd7ae7fb25f876ea9f96e4a65a
2015-11-20loplugin:unusedfields in basegfxNoel Grandin1-7/+0
Change-Id: Ibf7455fd20522ad52031089d2700533efc56c395 Reviewed-on: https://gerrit.libreoffice.org/20077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15Fast PCH generator and optimized PCH filesAshod Nakashian1-40/+59
Ported update_pch.sh to Python with improved performance and features. The new script is invoked from the same update_pch.sh which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts (update_pch_autotune.sh) which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: https://gerrit.libreoffice.org/19965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin1-2/+1
using variations of: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\; \s*OUString\* pArray.*; .*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g" Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3 Reviewed-on: https://gerrit.libreoffice.org/19971 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-13tdf#88352 correct triangulator numerical problemArmin Le Grand1-2/+5
The basegfx Triangulator is used in slideshow with canvas to triangulate the mask geometres. This uses tools::isPointInTriangle which uses basegfx::tools::arePointsOnSameSideOfLine. This uses the cross product to solve and for tests against zero the fTools::equalZero call. The triangulator then uses the more precise rtl::math::approxEqual to test if one of the points of the triangle is equal to the test point. In rare cases this can lead to a position where a point is seen as inside the triangle wrongly because it is not detected as equal to one of the triangle points. To solve, use increased accuracy. Change-Id: I73e12b711f14d4c48e829d5db1cadefa0917c19b Reviewed-on: https://gerrit.libreoffice.org/19925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-11-11new loplugin: memoryvarNoel Grandin1-3/+2
detect when we can convert a new/delete sequence on a local variable to use std::unique_ptr Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc Reviewed-on: https://gerrit.libreoffice.org/19884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann16-74/+74
Change-Id: Ib64fc63905cf44a0d32393d52ee587d0aa2d9dfa
2015-10-30basegfx tree cleanupMario J. Rugiero5-58/+30
- Eliminated an unnecessary boost/bind.hxx include. - Replaced simple old-style for loops that iterated over a container by ranged based for loops. - Replaced for_each by ranged based for loops wherever valid. Change-Id: Ib5c8291cf6d417047b350560f0428723efeccd1c Reviewed-on: https://gerrit.libreoffice.org/19679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27loplugin:unusedmethodsNoel Grandin5-112/+0
Change-Id: I73180266c0af98dbd8d29bd3b11850996b94def9 Reviewed-on: https://gerrit.libreoffice.org/19195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-10-26WaE: loplugin:defaultparamsTor Lillqvist1-2/+1
Change-Id: Ibb93059d4adab6b672cb9122b2dc8fe8af5bbbd6
2015-10-26Replace boost::bind by lambdas in basegfx tree.Mario J. Rugiero3-38/+14
Change-Id: I8f72bec11b5dfd71cc60a18b980629c176d43f49 Reviewed-on: https://gerrit.libreoffice.org/19595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-22coverity#1326120 try and silence Constant expression resultCaolán McNamara2-4/+4
Change-Id: Iafd034dd51135ad99f56279ceee1c770f91436b0
2015-10-20loplugin:defaultparamsStephan Bergmann1-2/+1
Change-Id: I44f3c4c2b6adf766f569f90367dcc294ec734616
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann6-22/+22
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann1-1/+1
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-05clang-analyzer-deadcode.DeadStoresStephan Bergmann2-5/+0
Change-Id: Id2d7c2aa0ba1783710a141bd910af785ecf81f8a
2015-09-30Fix typosAndrea Gelmini4-5/+5
Change-Id: Ie0e941d48457d758525353d6c5cf858652f86fd3 Reviewed-on: https://gerrit.libreoffice.org/18938 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-29loplugin:removeunusedmethods, remove unused stuffNoel Grandin1-22/+0
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-18boost->stdCaolán McNamara2-7/+6
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0 Reviewed-on: https://gerrit.libreoffice.org/18670 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-11loplugin: defaultparamsNoel Grandin5-9/+9
Change-Id: I29ef505ee77965df33677f8051ec39398ef0c74e
2015-07-20com::sun::star->css in basegfxNoel Grandin6-70/+70
Change-Id: I27f28e6a09e8bc9e90f0b60a7ac8519b2ab41860 Reviewed-on: https://gerrit.libreoffice.org/17166 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-14Revert "Avoid loplugin:staticmethods in non-debug build"Stephan Bergmann1-1/+0
This reverts commit d0ba487bae3a0f6d1fcb9af13397c85e70ad8e1b, obsoleted by cbce40e965acef51822b31d73da5fbc271fbcad0 "Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds."
2015-07-10do not include boost/utility.hppMichael Stahl2-2/+2
It just includes a bunch of other boost headers; mostly we need boost/noncopyable.hpp so include that directly. This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp completely, which is the 2nd biggest header after ustring.hxx. Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2015-07-08Avoid loplugin:staticmethods in non-debug buildStephan Bergmann1-0/+1
Change-Id: Ie943f6a998f142014c0405892264c8257dccaf6f
2015-07-08s/Coordiante/CoordinateTor Lillqvist2-61/+61
Change-Id: Iac584b09844b5877586061e9a44b1f7473bffed4
2015-07-08Fix typosAndrea Gelmini1-1/+1
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0 Reviewed-on: https://gerrit.libreoffice.org/16834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-07-07Fix some misspellingsTor Lillqvist2-2/+2
Change-Id: Iff2303650e1dcfc56064907a28df1c4c452eac56
2015-07-04Fix typosAndrea Gelmini3-3/+3
Change-Id: I75b4ad61785bf0ba1cb07735d938c0977356b8cc Reviewed-on: https://gerrit.libreoffice.org/16705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-30Fix typosAndrea Gelmini2-2/+2
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e Reviewed-on: https://gerrit.libreoffice.org/16582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-28Fix typosAndrea Gelmini2-2/+2
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>