summaryrefslogtreecommitdiff
path: root/basctl
AgeCommit message (Collapse)AuthorFilesLines
2014-10-11Resolves: fdo#60904 allow export of VBAProjectCaolán McNamara1-2/+8
xModLibContainerExport has a "VBAProject" entry but xDlgLibContainerExport doesn't, so just export the one we do have Change-Id: I15f7794904a5aff7679f2cf9fd654d741fd5cbe3 Reviewed-on: https://gerrit.libreoffice.org/11883 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-09-15Resolves: fdo#81039 crash on adding new macro libraryCaolán McNamara1-1/+1
regression from commit bf28399df0b73364b12309032e4a8b571389c2cf Date: Fri Feb 7 15:54:45 2014 +0100 auto_ptr -> heap_ptr Change-Id: Ib54c708cbdcb97a7489df4a1b3a7e9367f81ff6b (cherry picked from commit a88b2d841856026ea1a0539d670e07fafd296c6e) Reviewed-on: https://gerrit.libreoffice.org/11447 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-07-22Resolves fdo#80906: Delete any control on Dialog editing window crashes LOJulien Nabet1-1/+1
Quick fix for this bt: 3 0x00002aaaab2935d2 in __GI___assert_fail (assertion=0x2aaae1f2806a "_pInterface != 0", file=0x2aaae1f28018 "/home/julien/compile-libreoffice/libreoffice/include/com/sun/star/uno/Reference.h", line=402, function=0x2aaae1f28480 <com::sun::star::uno::Reference<com::sun::star::resource::XStringResourceManager>::operator->() const::__PRETTY_FUNCTION__> "interface_type* com::sun::star::uno::Reference< <template-parameter-1-1> >::operator->() const [with interface_type = com::sun::star::resource::XStringResourceManager]") at assert.c:101 4 0x00002aaae1e2963b in com::sun::star::uno::Reference<com::sun::star::resource::XStringResourceManager>::operator-> (this=0x7fffffff2d00) at /home/julien/compile-libreoffice/libreoffice/include/com/sun/star/uno/Reference.h:402 5 0x00002aaae1eb5c87 in basctl::LocalizationMgr::implHandleControlResourceProperties (aControlAny= uno::Any {<com::sun::star::uno::XInterface> = {_vptr.XInterface = 0x8935ea8}, <No data fields>}, aDialogName="Dialog1", aCtrlName="TextField1", xStringResourceManager=empty uno::Reference, xSourceStringResolver=empty uno::Reference, eMode=basctl::LocalizationMgr::REMOVE_IDS_FROM_RESOURCE) at /home/julien/compile-libreoffice/libreoffice/basctl/source/basicide/localizationmgr.cxx:202 6 0x00002aaae1eb92a0 in basctl::LocalizationMgr::deleteControlResourceIDsForDeletedEditorObject (pEditor=0x919d820, aControlAny= uno::Any {<com::sun::star::uno::XInterface> = {_vptr.XInterface = 0x8935ea8}, <No data fields>}, aCtrlName="TextField1") at /home/julien/compile-libreoffice/libreoffice/basctl/source/basicide/localizationmgr.cxx:896 Indeed, LocalizationMgr::setControlResourceIDsForNewEditorObject just returns if !xStringResourceManager.is() So let's do the same when trying to delete ControlResources See http://opengrok.libreoffice.org/xref/core/basctl/source/basicide/localizationmgr.cxx#835 Cherry-picked from e1840cf944b36b7ead5800a036870e38f4ddb049 Change-Id: I4be49503cd2464f97a25840dfdc29877e5fb2b93 Reviewed-on: https://gerrit.libreoffice.org/10448 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-22bnc#467278: Introduce a warning that changes to VBA macros cannot be saved.Jan Holesovsky3-1/+14
As an InfoBar, so hopefully not annoying... Change-Id: I5d4e79273edc03829fdab2d6d5a291576c954e4b
2014-05-19hrc and src files: squeeze multiple newlinesThomas Arnhold2-5/+0
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19Resolves: #i76558# jump by Enter key on the Object catalogTsutomu Uchino2-22/+39
(cherry picked from commit 7bc75c1a7b05d81631ebccf05bf022636d1a3a14) Conflicts: basctl/source/basicide/objdlg.cxx basctl/source/basicide/objdlg.hxx Change-Id: Id3fa3686fd60df192c02cc8137c9bc59e68c1d49
2014-05-15remove legacy svheader.hxxThomas Arnhold9-68/+0
none of the corresponding headers is included... Change-Id: I85061dc159ace0fd727e3d32e52b14c123690584
2014-05-14Find places where uno::Sequence is passed by value.Noel Grandin3-7/+7
Implement a clang plugin to find them, and clean up existing code to pass them by reference. Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8 Reviewed-on: https://gerrit.libreoffice.org/9351 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-09'!= false' is redundant, and confusing - kill it.Jan Holesovsky1-3/+3
Change-Id: I1a52b9ce7b590e8cf274a2daaa1c55cfc1efe48b
2014-05-09update_pch: add a bunch of pch filesThomas Arnhold3-0/+250
I had to fix some source files because of macro redefinitions and such stuff. Small modules like basic have a great win, too: make basic.clean && time make basic: with w/o pch pch accessibility 23s 1m59s basctl 30s 1m42s basic 56s 1m35s comphelper 23s 51s editeng 48s 2m04s forms 40s 1m40s unotools 19s 38s sd 3m37s 4m33s Change-Id: Id24cdcddbe2ff64820b42266325c25af1355558f Reviewed-on: https://gerrit.libreoffice.org/9293 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-09coverity#1209811 Dereference before null checkCaolán McNamara1-1/+1
Change-Id: I7e3778e5203438bc5db942c813a03896d7df895b
2014-05-07coverity#1209554 Explicit null dereferencedCaolán McNamara1-2/+1
Change-Id: Iacf4373221b93a97e030b09501cc91589f2fdff7
2014-05-05simplify ternary conditions "xxx ? yyy : false"Noel Grandin1-1/+1
Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-04-28Improve TabBar return typesNoel Grandin2-2/+2
DeactivatePage() goes from returning long to returning bool. StartRenaming goes from returning long to returning bool. AllowRenaming goes from returning long to returning a constant from a new enum. Change-Id: Ib87e8d7ceb4e23846547257b358ca4dfd41eb6ca Reviewed-on: https://gerrit.libreoffice.org/9161 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-25coverity#736993 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ib8e5d13da0e26f67da16edf0eb55341208ec2337
2014-04-25coverity#736992 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ia074dc867cc068fccb2d4eb613d04b945b8711e7
2014-04-25coverity#736990 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I3b7f4c732a5a3369c05c75ede1580b32837be671
2014-04-24basic macro dialog: let it expand vertically, tooThomas Arnhold1-0/+6
it already expands horizontally, however hexpand is not set... Change-Id: I8e0bfb9dfc841c66eeb2d14f5f73a997b6862cb5
2014-04-24fdo#77886: add language: expand list if dialog gets resizedThomas Arnhold1-0/+2
Yes, I actually figured out how to do that ;) Change-Id: I9c62f57bbd07f44c9bf94a308a49df8c82eb2097
2014-04-24manage breakpoints: expand list if dialog gets resizedThomas Arnhold1-1/+8
Change-Id: I818a19a0a95991c97be539761d1f75e247880256
2014-04-23huge hrc and src file cleanupThomas Arnhold2-23/+0
* mostly fallout from ui conversion * some completely unused defines from src files * lots of unused HID ids Change-Id: I976561205798db3d06ee139de6223f638e58f47a Reviewed-on: https://gerrit.libreoffice.org/9142 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-04-19fixincludeguards.sh: basctlThomas Arnhold46-138/+138
2014-04-18sfx2: Move InitInterface_Impl() out of SFX_DECL_INTERFACE too.Jan Holesovsky2-0/+11
Change-Id: Ib737e0d1b5888986b308aa60d4140f65e4e90243
2014-04-18sfx2: Move InitInterface_Impl() method out of SFX_IMPL_INTERFACE.Jan Holesovsky2-3/+5
SFX_IMPL_INTERFACE previously looked like a function; where in fact it is several methods defined at once, and only the last one has a body. This is extremely confusing and hard to read; let's kill that nonsense. Change-Id: Ia4ae22eb58b1260c9c827c894f5345693bad49e7
2014-04-18sfx2: Kill SFX_STATUSBAR_REGISTRATION macro.Jan Holesovsky1-1/+1
Change-Id: Iff0ffdb955892117a767e1f31c1f854a93feb560
2014-04-18sfx2: Kill SFX_FEATURED_CHILDWINDOW_REGISTRATION macro.Jan Holesovsky1-1/+1
Change-Id: I9bf1c2404eeb6c59525061157e91b8777f2da540
2014-04-18sfx2: Kill SFX_CHILDWINDOW_REGISTRATION macro.Jan Holesovsky1-3/+2
Change-Id: Icd56e0cee1ce0283e8a1cbaafc81ecca25469185
2014-04-18sfx2: Kill SFX_POPUPMENU_REGISTRATION macro.Jan Holesovsky1-1/+2
Change-Id: Ie68ccbe5874ec7c7e1bb73cb2937e06bb4910cd0
2014-04-17no temporary instance of SvtLanguageTable necessary hereEike Rathke1-2/+1
Change-Id: I3172e4d174a7f632a4259bd7330b41d3f065daed
2014-04-17no temporary instance of SvtLanguageTable necessary hereEike Rathke1-2/+1
Change-Id: Iabb3aadf35eb6b3575d916f2400f606264572537
2014-04-15basctl: sal_Bool->boolNoel Grandin4-4/+4
Change-Id: I85e1e94557a238f629151d9ce46a502efed3696d
2014-04-08use TriState instead of sal_Bool as there's three possibilitiesCaolán McNamara2-13/+7
Change-Id: If24d4cec9ef4369f20419fe70de7392614a35316
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann16-30/+30
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-28Remove remaining DBG_NAME* usesStephan Bergmann1-2/+0
...that had been used for DBG_CTOR, DBG_PROF, etc. Change-Id: I8eac38e24b7110511feb7813aaf5a20ab82bdbe0
2014-03-28Remove remaining DBG_CTOR etc. remnants from basctlStephan Bergmann7-91/+0
Change-Id: I383021580f69ac51ca65f3464bf863b800ccd931
2014-03-27Second batch of adding SAL_OVERRIDE to overriding function declarationsStephan Bergmann32-335/+335
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-26Split TYPEINFO into plain and TYPEINFO_OVERRIDEStephan Bergmann10-11/+11
...where the latter contains SAL_OVERRIDE annotations Change-Id: Id64794b388d83dfe7026440e8b20a5b5efd412d1
2014-03-25svtools: sal_Bool->boolNoel Grandin5-14/+14
Change-Id: Ifd3e643dbc6755839ad4af73ae141fd115ddb4f4
2014-03-19sfx2: sal_Bool->boolNoel Grandin3-7/+7
Change-Id: I73acb3a150b01114d32274a6842f6db9654b3e63
2014-03-18sfx2: sal_Bool->boolNoel Grandin2-6/+6
Change-Id: I375a72c34e46778385a9fdc24c9ebd0f0a3f3c9b
2014-03-17basct: prefer passing OUString by referenceNoel Grandin11-13/+14
Change-Id: Ide803f793e829767fad89ab2aef776ef24fedb37
2014-03-16sal_Bool to boolMatteo Casalin2-2/+2
Change-Id: Ib19ecab287396dc6d6cf4a77dcf7072c5c4c84f8
2014-03-14No need for a virtual OPropertyContainer::getTypesStephan Bergmann1-1/+1
(and rename to getBaseTypes for clarity) Change-Id: Icfe6202eea9b1f4ec2e46ade3fc8e001ca6b649f
2014-03-11No need for implGetBounds to be SAL_CALLStephan Bergmann2-2/+2
Change-Id: I4eb1f998de57a4ceeb7990c6e4a964ce0d07ea88
2014-03-11svx: sal_Bool->boolNoel Grandin1-1/+1
Change-Id: I78da39fc553b2e5040ee6665377ea51a1c4d04d7
2014-03-10basctl: simplify deprecated XTypeProvider.getImplementationIdStephan Bergmann1-11/+1
Change-Id: I422ec5b0ad485d1f74191d4bf713367aeb7a0a3d
2014-03-05made ListBox handle more than 64k elements, fdo#61520 relatedEike Rathke4-20/+20
ListBox and related now handle up to sal_Int32 elements correctly. sal_Int32 instead of sal_Size or size_t because of UNO and a11y API. Also disentangled some of the mess of SvTreeList and other containers regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures. Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a Reviewed-on: https://gerrit.libreoffice.org/8460 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-02-28sal_Bool -> bool in mostly vcl moduleChris Sherlock2-2/+2
Conflicts: include/vcl/settings.hxx svtools/source/table/tablecontrol_impl.cxx sw/source/core/frmedt/fecopy.cxx vcl/inc/canvasbitmap.hxx vcl/inc/headless/svpframe.hxx vcl/inc/unx/salframe.h vcl/inc/win/salframe.h vcl/inc/win/salprn.h vcl/inc/win/salvd.h vcl/osx/DragSource.cxx vcl/osx/DragSource.hxx vcl/osx/DropTarget.cxx vcl/osx/DropTarget.hxx vcl/osx/OSXTransferable.cxx vcl/osx/OSXTransferable.hxx vcl/osx/clipboard.cxx vcl/osx/clipboard.hxx vcl/osx/salprn.cxx vcl/qa/cppunit/canvasbitmaptest.cxx vcl/source/components/fontident.cxx vcl/source/control/edit.cxx vcl/source/control/spinfld.cxx vcl/source/gdi/gdimtf.cxx vcl/source/gdi/virdev.cxx vcl/source/helper/canvasbitmap.cxx vcl/source/window/dockwin.cxx vcl/unx/generic/dtrans/X11_selection.hxx vcl/unx/kde/UnxFilePicker.cxx vcl/unx/kde/UnxFilePicker.hxx vcl/unx/kde4/KDE4FilePicker.cxx vcl/unx/kde4/KDE4FilePicker.hxx vcl/unx/kde4/KDESalFrame.hxx Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0 Reviewed-on: https://gerrit.libreoffice.org/8219 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann18-166/+166
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-25Remove visual noise from basctlAlexander Wilms36-164/+164
Change-Id: I3e6a238a0bafbb70a7c22bde1f2258b8014ed2d2 Reviewed-on: https://gerrit.libreoffice.org/8232 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-14 14:21:35 +0000