summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-07-18cid#1487495 Division or modulo by zeroCaolán McNamara1-0/+1
the width of zero isn't going to end up as 0 in any real world situation Change-Id: I28eca0b495b139c4b2d70497a9c15898547d85fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119114 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-18Fix typosAndrea Gelmini1-2/+2
Change-Id: I0a8ce634944df4af5c9e2000af5f6429b4e40b2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119097 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-07-18binaryurp : use std::mutex in outgoingrequestsArnaud Versini2-7/+5
Change-Id: Ib0670af4596c5a40da27138d62b78df69bb77b9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-18better to use a std::vector hereNoel Grandin1-1/+1
Change-Id: Ibd875907bc0618df3b27ed77625ff62c352019ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-18nlpsolver: DEPSAgent doesn't implement ILibEngineJulien Nabet1-1/+1
Fix this error: /home/julien/lo/libreoffice/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java:45: error: DEPSAgent is not abstract and does not override abstract method setLibrary(Library) in ILibEngine public class DEPSAgent implements ILibEngine { ^ 1 error (on pc Debian testing x86-64 with master sources updated today openjdk 11.0.11 2021-04-20 OpenJDK Runtime Environment (build 11.0.11+9-post-Debian-1) OpenJDK 64-Bit Server VM (build 11.0.11+9-post-Debian-1, mixed mode, sharing) ) Change-Id: I1ce2d1a9ddee1020889f1a7a8fcd3387980b241f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119119 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-07-18osl::Mutex->std::mutex in EnumerationNoel Grandin1-2/+3
Change-Id: I1f4e99e4a3619b1381d01a16b98128ae9bbbce07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-18Revert "Some lower objects coupling."Noel Grandin2-14/+23
This reverts commit 7b93bae224c7c2c49b105ef97304bb46f8b68da5. Reason for revert: Does not compile /home/tdf/lode/jenkins/workspace/lo_ubsan/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java:45: error: DEPSAgent is not abstract and does not override abstract method setLibrary(Library) in ILibEngine public class DEPSAgent implements ILibEngine { ^ 1 error Change-Id: I72f2a22ab1f4119178f8002c21ba0845c4cd1bdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119040 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-18osl::Mutex->std::mutex in ContentEnumerationNoel Grandin1-3/+4
Change-Id: I79457a4ffc957f6de47880fdc888648ab69d1349 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119107 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-18osl::Mutex->std::mutex in CachedTextSearchNoel Grandin1-12/+10
and drop an rtl::Static Change-Id: I17bd6ad0b81ecb947e4306819ddc7d83f8a51dba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119112 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-18osl::Mutex->std::mutex in ModeratorsActiveDataStreamerNoel Grandin1-3/+3
Change-Id: I9ea32f7f843a0255ce37de8b95d9fc9d29c43157 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119111 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-17make calendar button small-button style so it fits in limited heightCaolán McNamara1-0/+3
Change-Id: I1997ae2a3916372ded3d4120e4510144c6700777 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119081 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-17Some lower objects coupling.Todor Balabanov2-23/+14
Change-Id: I0a7c658d830f82d627d20b9ed7000f3c5b8f1f89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119105 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-17osl::Mutex->std::mutex in SequenceOutputStreamServiceNoel Grandin1-5/+6
Change-Id: I1aaa9ebd76e2376be82b25f2659d4b0f22dc14e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119113 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-17osl::Mutex->std::mutex in ModeratorsActiveDataSinkNoel Grandin1-3/+4
Change-Id: If1e4af0d9acf75bd0f2744f134a42c29e41d56f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119110 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-17osl::Mutex->std::mutex in PropertySetMixinImplNoel Grandin1-8/+8
Change-Id: I45ae292e95efc57a125807d15c6c259533dd5f92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119106 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-17Related: tdf#143357 set blank label for no dateCaolán McNamara1-2/+5
instead of current system date Change-Id: Ic504b34990a8ea5151ec653de2db860c1cd4b8ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119079 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-17blind fix for ubsan div/0Noel Grandin1-1/+4
Change-Id: I0ee929c79d5ac94299adc84ba91d6b0683a8193d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119095 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-17cppu : use std::mutex in DisposedCallerAdminArnaud Versini2-5/+4
Change-Id: I3db567a9aed42167ea24eebcf673f19106595f83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117948 Tested-by: Jenkins Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2021-07-17drop sal_uInt16* constructor in SfxItemSetNoel Grandin4-22/+5
Change-Id: Ifb283a49b01c9c6421e385f697e749439db6a53f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119008 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-17use WhichRangesContainer in swNoel Grandin29-190/+147
Change-Id: I8662b2e03b0dbe3a7206d8b59ae3556e3b2e75a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119007 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-17Revert "Notebookbar: skip early init in all apps"Szymon Kłos1-1/+2
This reverts commit 6af0a488a059982a8b5d72fe399c7e8841a2e9b4. Delayed notebookbar init in Calc causes "number format" combobox to not work. (it works after some number is typed into document only). Original problem fixed by reverted change doesn't exist anymore because new shortcuts for paste special and paste unformatted text were introduced Change-Id: Ie112ae0df7b6d3782916b98c96f1a17b15396115 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118771 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119101 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-07-17Update git submodulesSteve Fanning1-0/+0
* Update helpcontent2 from branch 'master' to b31f5bed5155ffcda336c3e7a1e18e60a7382228 - Add example to help description of Calc's ROT13 function. Change-Id: I32c654dd8f86f508fce8555f033faa34b81b3e6c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119038 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-07-17jsdialog: move list of enabled dialogs to separate fileSzymon Kłos4-49/+97
Change-Id: I98c92b336fbf76f3dc94265a408c9b3b46fcea08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115453 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119014 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-07-17Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 2271ad00c7e0312071b78706da40a778171bfb9a - Refactor database files Change-Id: I10909197c08cec40819658d2d0951800133409da Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119099 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-07-17move BuildWhichTable and simplifyNoel Grandin4-65/+11
move it to the only place using it, and simplify Change-Id: I4a46b5d01f042e7b2e99b7dd1d28f67feda037d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119086 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-17osl::Mutex->std::mutex in SharedStringPoolNoel Grandin1-6/+6
std::mutex is slightly faster Change-Id: I0741cd1ed0a011d5e8d6099c189c85f50060a326 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119087 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-17sdremote: introduce early return to improve handleAcceptedConnectionAndrzej Hunt1-49/+51
This should make it easier to understand the handshake sequence. Change-Id: If06e98cdfe7295ed00efae61815a8696a90e9533 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119085 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-17sdremote: clean up now-unneeded "found" flagAndrzej Hunt1-8/+3
Since ???, this code now lives in a standalone method, allowing us to return as soon as know that the handshake is complete. This lets us remove aFound and simplify the code a little. Change-Id: I51d5281492d2e4280a101e67d606073f4d064c29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119084 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-17sdremote: avoid infinite loop if client disconnects during handshakeAndrzej Hunt2-54/+64
The following loop can turn into an infinite loop if the client disconnects at the wrong point in time, because pSocket->readLine() returns 0 (indicating disconnection), aLine remains empty (no data was read), and we just keep looping because we never bothered to check the return value: do { pSocket->readLine( aLine ); } while ( aLine.getLength() > 0 ); Aside from spinning unnecessarily, this infinite loop also stops the server from being able to accept any new incoming connections - in effect this causes a DOS of the server. Hence we need to start checking readLine's return value, and break out of this loop - and in fact break of the surrounding outer loop too (because we discard this connection and want to wait for another connection to arrive). Because of the nested looping it's hard to come up with a clean solution that only involves changing this loop - we'd probably need to introduce a temporary to remember that the client has disconnected, and check that temporary after the do...while - letting us 'continue' the outer loop. Therefore we first extract the code that handles newly accepted clients into a separate method, which then lets us simplify the implementation by returning at those points that we know a client has disappeared. That unfortunately makes this bug-fix patch a little more noisy than expected, but it is a refactoring that we'd want to make anyway. (There are further improvement we can make here, but I'll put those in a separate commit to simplify cherry-picking of just this fix. Examples include moving to smart pointers instead of new/delete, introducing an early return instead of the really long if statement, etc.) Change-Id: I13c6efa622a1b1de10b72757ea07e5f4660749fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119083 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-17sdremote: remove commented out experimental checkAndrzej Hunt1-7/+0
The entire if statement was introduced only to check for experimental mode in the following commit - the xContext check is seemingly only needed for null safety: 79c1b16a96a6 (sdremote: make it possible to have only bluetooth enabled, 2012-11-27) Later, the epxerimental mode check was disabled in: b9d2671ae11d (merge WiFi support into remote control feature toggle, 2013-08-01) Given that the remote is clearly no longer experimental, it's time to remove the commented code entirely - and I think it's also safe to remove the xContext check too. (Note: the remote IS still controlled by the EnableSdRemote option, and IS disabled by default.) Change-Id: Id118924021d5029b4f15df9cbb3eba28f3b902c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119091 Tested-by: Jenkins Reviewed-by: Andrzej Hunt <andrzej@ahunt.org>
2021-07-17[API CHANGE] reduce cost of numeric conversionNoel Grandin5-3/+78
on a hot path, since we already know the length of these strings. Which requires adding some new variants of our string conversion functions Change-Id: I1877f8f3c72934c07f14eec7e73bbe8d7b0f1808 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119065 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-17osl::Mutex->std::mutex in OWeakConnectionPointNoel Grandin1-24/+23
it is at least a little bit cheaper than osl::Mutex (since it's not recursive) Change-Id: I4ecbbf33045888b9f5111c4224346341e71d4b05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119066 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-17tdf#143400: fix query with most functions could not be created in GUIJulien Nabet1-4/+2
Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=04aafba860f613c20e7078d038cc83eb02de0b54 loplugin:stringadd simplify some *StringBuffer operations pulled from a larger patch which I created with a more permissive variant of this plugin Specifically here: -------------- dbaccess/source/ui/querydesign/QueryDesignView.cxx -------------- index 22408bbc58aa..63c5d07998ec 100644 @@ -658,11 +658,10 @@ namespace if ( field->isAggregateFunction() ) { OSL_ENSURE(!field->GetFunction().isEmpty(),"Function name must not be empty! ;-("); - OUStringBuffer aTmpStr2( field->GetFunction()); - aTmpStr2.append("("); - aTmpStr2.append(aTmpStr.makeStringAndClear()); - aTmpStr2.append(")"); - aTmpStr = aTmpStr2; + aTmpStr = field->GetFunction() + + "(" + + aTmpStr + + ")"; } if (!rFieldAlias.isEmpty() && Change-Id: Ib0b57e6c44a58a6a5f9c98aebc6a1213b35108d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119088 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2021-07-17Bin useless commentTor Lillqvist1-3/+0
Change-Id: Ifc7e36aa1df56cf532b698c8671cabbb35061bac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119076 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-07-16update creditsChristian Lohmaier1-2314/+2367
Change-Id: I1a09193e888318084a7d9b3c76c049e373db545b
2021-07-16tdf#142923 Deleting comment in Writer leaves visual artifact behindNoel Grandin1-6/+6
Change-Id: Ia2e55886513e81847dd0ac6c697e7cea34e01bdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119075 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-16Removed executable bits on source fileAndrea Gelmini1-0/+0
Change-Id: I540ce9b69fcae15f12ac11ca6f66bb8fc7459985 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119073 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-07-16fix svl::detail::validRanges2(m_pWhichRanges) assert seen in dbaccessCaolán McNamara1-5/+5
Change-Id: I4328d0eae0030d6455b80d8506496fe44cf02195 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119080 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-16Update git submodulesAndrea Gelmini1-0/+0
* Update helpcontent2 from branch 'master' to ac68c2a4c5efff2c13ae474b37d12fb08be691ff - Fix typo Change-Id: I687dab780da7bcb3379cd2e2e52c1a5b47e98923 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119071 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-07-16Removed executable bits on source fileAndrea Gelmini1-0/+0
Change-Id: I37cf25d37b8b3e5a7c7c1dd2f54bbcc2c9d77a65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119072 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-07-16Fix typosAndrea Gelmini5-5/+5
Change-Id: Iae3eec214849676be51ded133c1ffd9cf2e56ef0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119074 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-07-16tdf#92796 ODF import: remove unused bitmap fillsMichael Stahl17-114/+353
With CWS impress64 a partial fix for this was implemented to drop unreferenced named items including all non-color fills after ODF import, but this is only done in sd so move the code that does that to svx and call it from sc and sw as well. Implement some UNO interface for this, it's at least better than a magic string, and not obvious how a better solution would look like since it's known only at the end of the import if a bitmap is used or not. Another problem: when the Area tab is used to change to a different kind of fill, the items with the details for the previous fill aren't cleared, and so they are written to ODF files. Hence bitmaps in the file can be referenced even if they aren't actually used, and bloat up the files. Fix this by dropping all unused draw:fill-image-name attributes in ODF import. Also do the same for Gradient and Hatch fills; Transparency gradients can be combined with anything so leave them as they are. Change-Id: I0b591fd9f963d974d0c3e7208b99621ad61dd93c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118950 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-07-16avoid a map lookup on a hot pathNoel Grandin1-4/+4
Change-Id: I4e514c7212c0b349796f3791b4c7f3f06d3fa22a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119064 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-16Related: tdf#143357 explicitly set the default of focus-on-clickCaolán McNamara3-0/+3
this should already be the default according to https://developer.gnome.org/gtk3/stable/GtkWidget.html but it's apparently False nevertheless, so make it explicit here for these widgets where there is a focus watcher to commit their changes and the absence of this is non-cosmetic. Just these initially for a small backportable change. Change-Id: I96442b4e844ce0446f56276c1b648ca5ce57b740 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-16crashtesting: UaF on layout of fdo53985-1.docxCaolán McNamara2-1/+58
Change-Id: Id8ca0d277f485347e21bd8d6d68de2a7de13de48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119060 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-16Only change SwLayAction::m_bAgain via SetAgainCaolán McNamara4-8/+12
no logic change intended Change-Id: Ib0174f8040faa3efde7b9c5ba9b062bac5a35da3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118983 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-16vcl: check mpWindowImpl for nullptr.Michael Meeks1-1/+2
Crash in calc's mouse capture / end tracking. Change-Id: If5b4cded8ebfc04d1fcf645a7b74184532ab2338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119034 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-07-16Output proper language tag instead of Language+Country concatenationEike Rathke1-1/+2
Change-Id: I83d7f94cf304a58f2ff68b2a667ba66de262f4f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119070 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-07-16Output proper language tag instead of Language+Country concatenationEike Rathke1-2/+2
That way also for more complex tags with 'qlt' language you get a meaningful output. It's only stderr, but.. Change-Id: I3c6e2451ace5ac9f192a11c97e95376c17046f17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119068 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-07-16Porting C++/Java DocumentLoader example to PythonHossein2-0/+56
* Using UNO for Python * Opening the file in LibreOffice if it is listeing on port 2083 Change-Id: I14b1a38da5d66dd2ee8c859071c148ce08a080d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118142 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 12:00:28 +0000