summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-05-27Revert "bloaty: use -ffunction-sections and --gc-sections for linking"Noel Grandin1-3/+1
This reverts commit bd39ec554f90badccfb26c843fd0d43237f1b622. Reason for revert: For -ffunction-sections and -fdata-sections, <https://gcc.gnu.org/onlinedocs/gcc-10.1.0/gcc/Optimize-Options.html#Optimize-Options> warns: "Only use these options when there are significant benefits from doing so. When you specify these options, the assembler and linker create larger object and executable files and are also slower. These options affect code generation. They prevent optimizations by the compiler and assembler using relative locations inside a translation unit since the locations are unknown until link time. An example of such an optimization is relaxing calls to short call instructions." Change-Id: I84225ca94de9afff23bdd2913c77095d5d26f7ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94950 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-27tdf#74244 Fix version info shown for major release candidatesEivind Samseth2-10/+2
Previous approach of setting the bundle version made e.g., 6.4.0.3 show up as version 6.4.3 which was clearly wrong CFBundleShortVersionString is supposed to be only three integers, but this does not seem to be enforced by Apple. Other applications, such as Spotiy, include even more than LO Removed CFBundleGetInfoString as it's been deprecated since 10.5 Change-Id: I7c64553f6bc2712506062d8f8ec388f5279b333d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94623 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-27bloaty: use -ffunction-sections and --gc-sections for linkingNoel Grandin1-1/+3
strips out 3+ megabytes of duplicate functions (which originate in the generated UNO header files) Change-Id: I69ba5f478b2b062e2b05516bbaa2d18fa8312aa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94868 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-27tdf#133370 docx export: don't export unseen columnbreakJustin Luth6-10/+8
A compatibility option indicates whether a column break is treated as a page break when there are no columns. (Currently true only for DOCX). Don't export this column break when compat is off, because it WILL show up as a page-break in Word and LO when loaded. In theory, the RTF and DOC code that converts these into page-breaks on import could now be removed, but I can't think of any reason why that would be of benefit. testColumnBreak_ColumnCountIsZero in ooxmlexport4 covers the situation where docx MUST round-trip these. Change-Id: I5c17e43d90469bdb86087c61dadf48a9440f7b96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94799 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-27Remove some unused includesMiklos Vajna11-48/+11
Change-Id: Id5a31185faf2a3a13b6ea266e058a7df41d44423 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94890 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-26Update git submodulesSteve Fanning1-0/+0
* Update helpcontent2 from branch 'master' to cd96ed80cb27d31987cb878b379c3fa8c1dd0c03 - Added square brackets around applicable parameter in eight syntax statements (to indicate parameters are optional). All changes contained in one XHP file. Change-Id: Ia4855d44b49f7d4198e8d644f5b53741b5083371 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94838 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-26Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptrStephan Bergmann189-577/+912
...where the get member function is defined on a std::__shared_ptr base class, so loplugin:simplifypointertobool used to miss those until now. (While e.g. using libc++ on macOS found those cases.) 366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool" was mistaken in breaking isSmartPointerType(const clang::Type* t) out of isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had introduced that indivisible two-step algorithm on purpose. The amount of additional hits (on Linux) apparently asked for turning loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed that the naive adivce to just "drop the get()" is not sufficient in places that are not contextually converted to bool, as those places need to be wrapped in a bool(...) functional cast now. If the expression was already wrapped in parentheses, those could be reused as part of the functional cast, but implementing that showed that such cases are not yet found at all by the existing loplugin:simplifypointertobool. Lets leave that TODO for another commit. Besides the changes to compilerplugins/ itself, this change has been generated fully automatically with the rewriting plugin on Linux. Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-05-26Update git submodulesSteve Fanning1-0/+0
* Update helpcontent2 from branch 'master' to 190b78fd2add6bb8468cd69f3d6a7bcccd692fef - Add square brackets around final two parameters in syntax statement (to indicate parameters are optional) Change-Id: Icbe4f4d834244dc8bb397b0eb5fa5df5d543ddbb Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94840 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-26Update git submodulesSteve Fanning1-0/+0
* Update helpcontent2 from branch 'master' to f9285f35a17dbdc69b0412cc73e4816906f85d9d - Add square brackets around final parameter in syntax statement (to indicate parameter is optional) Change-Id: I9703c7e556009613e377324b30a2a15accd33f5d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94839 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-26Update git submodulesSteve Fanning1-0/+0
* Update helpcontent2 from branch 'master' to 1e6411ced00a5459e70a5f27651f2c55595ea9c5 - Add square brackets around final parameter in syntax statement (to indicate parameter is optional) Change-Id: I9c60cc607f157114da48e5369866adf68394dcf4 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94837 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-26Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 3dbc5d6b39165002e1de2f3ba6d99d6d7d9a5dd4 - tdf#126813 Fix scrolling of targeted references Change-Id: Ic7ce644cc0a5053905e980952ad31767fa87125c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94885 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-26make highlight of get_dest_row_at_pos optionalCaolán McNamara6-14/+22
Change-Id: I280e1a49e938f45402f373896669fd6f7e8a66fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-26emit activate-row in vcl treeview on returnCaolán McNamara1-2/+1
to align it with the gtk one which does this Change-Id: Id439fe684f263f59285ba9291fc803f88309c066 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94875 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-26Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 695cea8d8ed485a8c32f9ccb67e2a182159a6734 - Remove unused CSS class Change-Id: I9db4df3062c411570a77686ec2b4fe3124f71539 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94879 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-26Update git submodulesSteve Fanning1-0/+0
* Update helpcontent2 from branch 'master' to a736b5e008fad1d0c05c961669cb62e1876218b9 - Add square brackets around final two parameters in syntax statement (to indicate parametes are optional) Change-Id: I756376f90b8c9f51875ad1887142a82c6595daed Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94836 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-26Don't run CompilerTest_o3tl_* with COMPILER_PLUGIN_TOOL=...Stephan Bergmann1-2/+3
...similar to 2228203a8211dea1c8addb98298096a094ec788b "Don't run CompilerTest_compilerplugins_clang with COMPILER_PLUGIN_TOOL=...", as otherwise e.g., `make check COMPILER_PLUGIN_TOOL=fakebool` failed with > o3tl/qa/compile-temporary.cxx:22:8: error: call to deleted function 'temporary' > f(&o3tl::temporary(n)); // expected-error {{}} expected-note@o3tl/temporary.hxx:* 0+ {{}} > ^~~~~~~~~~~~~~~ > include/o3tl/temporary.hxx:22:36: note: candidate function [with T = int] has been explicitly deleted > template <typename T> constexpr T& temporary(T&) = delete; > ^ > include/o3tl/temporary.hxx:21:36: note: candidate function [with T = int &] > template <typename T> constexpr T& temporary(T&& x) { return x; } > ^ Change-Id: I4dfa433708c064413f365375c84b85ced63c8d4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94871 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-26Drop -I$(dir $(2)) also from gb_*Object__tool_commandStephan Bergmann1-5/+0
...after ecbaf980625a9e7b06abe91c7c70e78f6ad469a7 "-I$(dir $(3)) in gb_CObject__command_pattern is no longer needed" and f218f8f6c8c587d2d78679f935093329f145fede "-I$(dir $(3)) in gb_CObject__command_pattern is no longer needed" had already dropped it from plain gb_CObject__command_pattern. (0349c738da5970d9f0fc10d7cf4d7b766ce10e13 "support for compiler rewriters" had created gb_*Object__tool_command at a time when plain gb_*Object__command still contained those -I arguments, so had presumably just copied them over without a specific additional need to have them in the tool_command variants; and ecbaf980625a9e7b06abe91c7c70e78f6ad469a7 and f218f8f6c8c587d2d78679f935093329f145fede then just failed to also remove them from the tool_command variants.) Presence of the -I arguments in the tool_command variants caused e.g. `make COMPILER_PLUGIN_TOOL=fakebool` to fail with > sw/source/filter/ww8/ww8par.cxx:97:10: error: replace <...> include form with "..." for inclusion of a source file next to the current source file, sw/source/filter/ww8/../../core/inc/DocumentRedlineManager.hxx [loplugin:includeform] > #include <../../core/inc/DocumentRedlineManager.hxx> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I7ef513507375dcee5d88db53cef58433f7f68e36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94867 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-26tdf#133216 - Objects are not printed (Win-only)Chris Sherlock1-388/+342
Seem to have been introduced in commit 6fa6704a7e7c6970b7a7c:6 "vcl: move functionality out of checkRect(), rendering function obsolete" This reverts: commit 7b47a96b20122863e77aa1918e878372b3485c9f. "vcl: refactor code into GenerateConnectedComponents()" commit 5ef0f7dfafd8b83818c831914467f93e47a5bb2f. "vcl: refactor code into GenerateIntersectingConnectedComponents()" commit 93649784ddbb7d9ca779d14fd60fb97385325d17. "vcl: move stage 1 functionality into DetectBackground()" commit 34a699f1894f30f68c3243784586617e01e60ab6. "vcl: refactor by creating GetActionAfterBackgroundAction() function" commit f85769f61b2d2380750be564c6de47f28be35b8a. "vcl: refactor by creating RecordMapModeChanges() function" commit 8318a636336dd6d6b5862a3366f85f96c64d8243. "vcl: refactor by creating SetBackgroundColorAndBounds() function" commit f0ca5a0c447f4fe4667693d744af61eaeb0625ee. "vcl: move functionality into FindIncompletelyOccludedBackground()" commit 449f23c44ccdf6d2bfe7baa143d32d8f585aef4b. "vcl: new local function setComponentsSizeAndColor()" commit 6fa6704a7e7c6970b7a7c695a4a548f8dc693d03. "vcl: move functionality out of checkRect(), rendering function obsolete" Change-Id: Ic85397c1b69f2b529cff90206387d017692cecf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94804 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-05-26oox smartart import: fix aspect ratio of shape with composite algoMiklos Vajna3-20/+109
The layout node has alg=composite, then a parTx and a desTx child layout nodes. No matter what order is used (parent first, child first), the result will be wrong, as the constraints refer to each other. I did not spot any description in ISO 29500-1 that would describe what is the expected behavior. Researching this, found "One other consideration when specifying composite constraints is that the constraints must be specified in the same order as the nested layout nodes." at <http://web.archive.org/web/20111015151600/http://msdn.microsoft.com/en-us/magazine/cc163470.aspx>, which suggests to handle constraints for each shape in a parent -> child order, but keep a shared state when iterating over the children which gives us: - parent node, all direct constraints - for each child node: - child's constraints from parent - child's own constraints This way the desTx top value can depend on the parTx's height, and it's supported to define parTx's height only in the parTx layout node, not in the composite parent. And after all, it matches what PowerPoint does, so the column headings in the bugdoc have a 4:10 height:width aspect ratio. Change-Id: Ideb76c1ddd1ffff8d2a217cddf81106d1bb97eb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94872 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-26tdf#133094 NotebookbarToolBox is not in the sidebarCaolán McNamara8-18/+27
though it is inheriting from SidebarToolBox and we're distinguish the sidebar case from the non-sidebar case wrt certain color toolbuttons Change-Id: Ieffe45adfab95d426bb36296ee3428b6bd3dbd3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94806 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-26make disabling of Skia override forcing it (tdf#133399)Luboš Luňák1-3/+3
Makes more sense if it's disabled because the VCL backend doesn't actually support Skia. Change-Id: I3f14c6ae1172c0a2cba3bf19c4cb5288e214eb2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94861 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-26weld SwFieldListBoxCaolán McNamara3-33/+125
Change-Id: I205ce5b300d869d6424c3552a2799c3b02282ff7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94810 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-26followed the advice from Mike at https://gerrit.libreoffice.org/c/core/+/94687himajin1000001-3/+3
Change-Id: If961da88f3ecba03416394ab8e8093af1b20f664 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94832 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-26reduce dynamic_cast usage in an O(N^2) algorithmLuboš Luňák3-55/+52
When scrolling down in tdf#130431 this is the major CPU cost. Move the dynamic_cast out of the loops as much as possible. Change-Id: I0ea9f457bb17fbdde880f09b059f07dec4b1790b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94858 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-26use Skia to do dashed lines, no need to do it manually (tdf#130431)Luboš Luňák7-33/+131
Change-Id: Id5efe7227f3c2bcb5ef6f1b990327e72014e8c47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94857 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-26jenkins linux configs: use jdk 11 for masterChristian Lohmaier8-0/+8
mac uses /usr/libexec/java_home to determine jdk and without -v option to limit to a specific version returns latest one Change-Id: I8c8122ed71a31f990c3ffa1e71b180cbece7f172 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94862 Tested-by: Jenkins Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-05-26uitest: replace sleep with processEventsToIdleXisco Fauli1-4/+4
Change-Id: I48798e98718cae11b9ef7902cb48fe2d8ab9c2b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94812 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-26Update git submodulesSteve Fanning1-0/+0
* Update helpcontent2 from branch 'master' to 52d629e6d5d3599cdead037425021c288b224278 - Add square brackets around final parameter in syntax definition (to indicate that the parameter is optional) Change-Id: If2e6489a28c7429b8c638c9bcdc6cc28ff3d8078 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94834 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-26Update git submodulesSteve Fanning1-0/+0
* Update helpcontent2 from branch 'master' to 0e5f1058e25d21ea590e3fbfc6c87e925b791fc5 - Add square brackets around final parameter in syntax statement (to indicate parameter is optional) Change-Id: I6ef58dab8926eb739b7477493ce228e43606124c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94833 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-26-Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
...since b9353394f46e46485fd148f2842f0c1e8e5322e3 "[MS-OFFCRYPTO] convert oox implementation into UNO service" Change-Id: I0f226858ef9a1195fb26c1afe6c904d7cef6f541 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94813 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-26tdf#49247, tdf#101181: gtk needs "upper", otherwise the control is disabledMike Kaganski2-0/+2
Change-Id: I3a3204ab0ad2376ee88adca5935813e241e6a049 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94831 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-26Revert "Resolves tdf#133265 - Save state indicator must not be hidden"Stephan Bergmann1-3/+3
This reverts commit 194538345691272bf9d7c642f069cc1061a0b4d9, as it is suspected of causing massive Jenkins JunitTest_toolkit_unoapi_1 toolkit.AccessibleStatusBarItem::com::sun::star::accessibility::XAccessibleText ::getIndexAtPoint() failures. Change-Id: I1c13ecd660f6694edb3e164fca372962b0ccdd19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94827 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-26Update git submodulesAdolfo Jayme Barrientos1-0/+0
* Update helpcontent2 from branch 'master' to 55480f9f761aac470b97326ab13b5444cc57cb74 - Translating these is not worth it In the vein of commit 8bece13f73046ebebfb5c18d02d857a961a4cdab. Change-Id: I5273298a55cd13e5954c6e5a727feb58ac6ec831
2020-05-26Fix typoAndrea Gelmini1-1/+1
Change-Id: I44b332e840a5e3084c0c16fe05f0918e42217c13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94821 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-26Update git submodulesMichael Stahl1-0/+0
* Update helpcontent2 from branch 'master' to 8444c2c1af48ac5f7f4fd9555bae695c88b682bc - document new ODF 1.3 versions in Tools->Options->Load/Save Change-Id: I40a7f06274d311a537b8290cec4d7708c4c4ea4d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/94705 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-05-26cfg.cxx build fixhimajin1000001-8/+8
Change-Id: I7bab3dc64f0976b3d3e8711a05ea826243a6be67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94687 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-26tdf#131715: uitest: add wrapper for roadmapwizardXisco Fauli5-0/+116
Change-Id: I8e8999b7862ad13cb6d3328e05abe120da3ed5c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94759 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-26use -Xclang -debug-info-kind=constructor if availableLuboš Luňák3-0/+18
The option, available since Clang10, emits debuginfo for classes with explicit ctors only together with the ctor, which avoids redundant debuginfo for such classes, noticeably saving both build time and disk space. https://reviews.llvm.org/D72427 I've been using this for quite some time, without problems. Change-Id: I24e5339f983cb8d8990185436dd63e00f0d3ce60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94756 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-26tdf#130456 sw: enable semi-transparent text for char style dialogMiklos Vajna4-1/+57
The code is shared, so this fixed the para style dialog as well. Change-Id: I742231bf76c562b3255700fc4eeb4c870c3deb6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94805 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-26Add an option to create encyrpted PDF files with mailmerge.Gülşah Köse11-18/+235
With that option user can create encyrpted pdf files with a password column in database via mailmerge. Change-Id: I081ef050bc269b1fec24fd01ecc812acd7b857ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94709 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-05-26tdf#133030: DOCX export: fix formula alignment - part 3Attila Bakos15-29/+133
Follow-up of commit 1237acf9851f8b12d1ccd929e2aa8b184c06d552 (tdf#132811 DOCX: fix formula alignment – part 2) Co-authored-by: Tibor Nagy (NISZ) Change-Id: I5466649a2aa6b7ffdb0def723f79dfbecdf1495f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93665 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-26tdf#106181 XLSX export: output form controlsSerge Krot8-41/+419
Prepared general algorithm to ouput form controls into XLSX. For now only CHECKBOX is supported with a possibility to link withem to any worksheet/cell. Change-Id: Ide8739d81ffb755aeae074c4ebecf24251383e34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94161 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-25Remapping NatNum-DBNum in Korean for compatibility tdf#130193DaeHyun Sung2-21/+21
Remapping NatNum-DBNum in Korean for compatibility tdf#130193 Unlike Japanese and Chinese[Simplified, Traditional] environment on Excel, In Korean Situation, Excel exist DBNum1~4. I checked DBNum1~4 series on Excel 2016 in Korean Environment. DBNum1 1234567890 一十二億三千四百五十六万七千八百九十 DBNum2 1234567890 壹拾貳億參阡四百伍拾六萬七阡八百九拾 DBNum3 1234567890 十２億３千４百５十６万７千８百９十 DBNum4 1234567890 일십이억삼천사백오십육만칠천팔백구십 Also, I checked Korean Number to Strings on LibreOffice. [natnum1] 1234567890 一二三四五六七八九〇 [natnum2] 1234567890 壹貳參四伍六七八九零 [natnum3] 1234567890 １２３４５６７８９０ [natnum4] 1234567890 一十二億三千四百五十六万七千八百九十 [natnum5] 1234567890 壹拾貳億參阡四佰伍拾六萬七阡八佰九拾 [natnum6] 1234567890 １십２억３천４백５십６만７천８백９십 [natnum7] 1234567890 十二億三千四百五十六万七千八百九十 [natnum8] 1234567890 拾貳億參阡四佰伍拾六萬七阡八佰九拾 [natnum9] 1234567890 일이삼사오육칠팔구영 [natnum10] 1234567890 일십이억삼천사백오십육만칠천팔백구십 [natnum11] 1234567890 십이억삼천사백오십육만칠천팔백구십 I also checked Korean billion units test. [natnum1] 123456789012 一二三四五六七八九〇一二 [natnum2] 123456789012 壹貳參四五六七八九零壹貳 [natnum3] 123456789012 １２３４５６７８９０１２ [natnum4] 123456789012 一千二百三十四億五千六百七十八万九千一十二 [natnum5] 123456789012 壹仟貳佰參拾四億五仟六佰七拾八萬九仟壹拾貳 [natnum6] 123456789012 １천２백３십４억５천６백７십８만９천１십２ [natnum7] 123456789012 千二百三十四億五千六百七十八万九千十二 [natnum8] 123456789012 仟貳佰參拾四億五仟六佰七拾八萬九仟拾貳 [natnum9] 123456789012 일이삼사오육칠팔구영일이 [natnum10] 123456789012 일천이백삼십사억오천육백칠십팔만구천일십이 [natnum11] 123456789012 천이백삼십사억오천육백칠십팔만구천십이 As a result, 1. from DBNum to NatNum (import): - DBNum1 -> NatNum4 (Korean Hanja text 한자숫자) - DBNum2 -> NatNum5 (Korean Upper Hanja text 갖은자) - DBNum3 -> NatNum6 (fullwidth Arabic digits with Korean hanja unit of Numbering) - DBNum4 -> NatNum10 (Korean Hangul text) I found the Bug for NatNum6 (I'll change Korean Hangul to Hanja for compatibility) 2. From NatNum to DBNum - NatNum1 -> DBNum1 - NatNum2 -> DBNum2 - NatNum3 -> DBNum3 - NatNum4 -> DBNum1 - NatNum5 -> DBNum2 - NatNum6 -> DBNum3 - NatNum7 -> DBNum1 - NatNum8 -> DBNum2 - NatNum9 -> DBNum4 - NatNum10 -> DBNum4 - NatNum11 -> DBNum4 By the way, I change test cases for Korean. It is included in svl/qa/unit/svl.cxx It solves the issue tdf#130140 Also, It related the issue tdf#130077 Change-Id: Idb7f3defc5f19e3edc4c179b0a081d2abe8ee3a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94747 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-05-25tdf#130193: Asian Excel-Calc number format interopNaruhiko Ogasawara2-76/+111
remap NatNum - DBNum in Japanese/Chinese to improve Excel interoprability from DBNum to NatNum (import) in ja/zh: - DBNum1 -> NatNum4 (modern long Kanji text) - DBNum2 -> NatNum5 (traditional long Kanji text) - DBNum3 -> NatNum3 (fullwidth Arabic digits) from NatNum to DBNum (export) in ja: - NatNum1 -> DBNum1 - NatNum2 -> DBNum2 - NatNum3 -> DBNum3 - NatNum4 -> DBNum1 - NatNum5 -> DBNum2 - NatNum6 -> DBNum3 - NatNum7 -> DBNum1 - NatNum8 -> DBNum2 - NatNum9 -> (DBNum0, as Arabic) in zh, nothing change about export. It also partially solves the issue tdf#130140 (about Japanese, not Korean) To do this, more data-drivened MapDBNumToNatNum() and MapNatNumToDBNum() in svl/source/numbers/zformat.cxx By mapping "NatNum - DBNum" to a table using map and array, it makes the specification for each language more understandable The new test cases are also included in svl/qa/unit/svl.cxx Change-Id: I34a70d970ef2e46c1b3db5db1c397ab89c056191 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94376 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-05-25tdf#133342 Add user defined percent stringLaurent BP3-1/+37
With Add/Delete decimal place, insert percent char and string text between number and '%' Change-Id: I4a97e4361228020803810692d7977e5806baf180 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94757 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-05-25UITest_writer_tests4: fix this under high loadMiklos Vajna1-1/+3
The failure I had: ====================================================================== FAIL: test_tdf113284 (tdf113284.tdf113284) ---------------------------------------------------------------------- Traceback (most recent call last): File "sw/qa/uitest/writer_tests4/tdf113284.py", line 34, in test_tdf113284 self.assertEqual(get_state_as_dict(xWriterEdit)["CurrentPage"], str(xPageCount)) AssertionError: '1' != '91' - 1 + 91 ? + And with this in place 'make check' passes just fine. I assume the go to page dialog goes to the relevant page in an async way. Change-Id: Ic4b2a755c589f113af58b5fb3e43f537a52a50d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94803 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-25Adapt to changed clang::ASTContext::getParents behavior on Clang 11 trunkStephan Bergmann11-32/+81
...since <https://github.com/llvm/llvm-project/commit/ d0da5d2bbe8305d06dc01a98706fd73e11e24a9f> "Change default traversal in AST Matchers to ignore invisible nodes". This caused failures > [CPT] compilerplugins/clang/test/constparams.cxx > ParmVarDecl 0x11d76c730 <compilerplugins/clang/test/constparams.cxx:15:12, col:18> col:18 used f1 'int *' > DeclRefExpr 0x11d76c948 'int *' lvalue ParmVar 0x11d76c730 'f1' 'int *' > ParmVarDecl 0x11d76cc80 <compilerplugins/clang/test/constparams.cxx:21:12, col:18> col:18 used f2 'int *' > DeclRefExpr 0x11d76ce60 'int *' lvalue ParmVar 0x11d76cc80 'f2' 'int *' > error: 'error' diagnostics expected but not seen: > File compilerplugins/clang/test/constparams.cxx Line 15: this parameter can be const Class1::Class1 [loplugin:constparams] > error: 'error' diagnostics seen but not expected: > File compilerplugins/clang/test/constparams.cxx Line 15: no parent? [loplugin:constparams] > File compilerplugins/clang/test/constparams.cxx Line 21: no parent? [loplugin:constparams] > 3 errors generated. [...] > [CPT] compilerplugins/clang/test/unusedenumconstants.cxx > error: 'error' diagnostics expected but not seen: > File compilerplugins/clang/test/unusedenumconstants.cxx Line 30: read Bottom [loplugin:unusedenumconstants] > error: 'error' diagnostics seen but not expected: > File compilerplugins/clang/test/unusedenumconstants.cxx Line 30: write Bottom [loplugin:unusedenumconstants] > 2 errors generated. [...] > [CPT] compilerplugins/clang/test/unusedfields.cxx > error: 'error' diagnostics expected but not seen: > File compilerplugins/clang/test/unusedfields.cxx Line 156 (directive at compilerplugins/clang/test/unusedfields.cxx:164): write m_f5 [loplugin:unusedfields] > File compilerplugins/clang/test/unusedfields.cxx Line 210 (directive at compilerplugins/clang/test/unusedfields.cxx:211): read m_f1 [loplugin:unusedfields] > 2 errors generated. For compilerplugins/clang/test/constparams.cxx at least it would have worked to fix that locally with > diff --git a/compilerplugins/clang/constparams.cxx b/compilerplugins/clang/constparams.cxx > index 95c8184009d7..70f056fa5a69 100644 > --- a/compilerplugins/clang/constparams.cxx > +++ b/compilerplugins/clang/constparams.cxx > @@ -274,7 +274,7 @@ bool ConstParams::checkIfCanBeConst(const Stmt* stmt, const ParmVarDecl* parmVar > { > for ( auto cxxCtorInitializer : cxxConstructorDecl->inits()) > { > - if ( cxxCtorInitializer->getInit() == stmt) > + if ( cxxCtorInitializer->getInit()->IgnoreImpCasts() == stmt) > { > if (cxxCtorInitializer->isAnyMemberInitializer()) > { (somewhat unintuitively, given the Clang change is apparently about ignoring more implicit nodes), but overall it appears better---at least for now---to use a getParents variant that keeps the old traversal behavior. For that, instead of using the clang::ASTContext::ParentMapCtx, we create our own loplugin::Plugin::parentMapContext_. There appear to be no uses of ASTContext::getParent across the Clang codebase itself, outside of ASTMatcher code, so it looks unlikely that creating our own ParentMapContext instance would degrade performance by no longer sharing cached data between Clang's internals and our plugin. (And given that ASTContext::getParents is deprecated with the note "New callers should use ParentMapContext::getParents() directly", this may well be the correct way in the long run, anyway.) Change-Id: I46c7912f2737e7c224fd45ab41441f69e2f10bd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94795 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-25weld ScFilterListBoxCaolán McNamara4-172/+189
use the same positioning and sizing logic for DataSelectMenu and ScenarioMenu Change-Id: I34d183f72b6719528ce357b1fd40a1fdd1a4a29a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94774 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-25support activate-on-single-clickCaolán McNamara3-4/+15
Change-Id: Iac0231b3bd84d664b1ab59023ef8242f3bd08940 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94773 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-25Clean up dead codeStephan Bergmann1-31/+1
...after 5bfa8b8d5e1cf3cb572dbd91bf3b0cfcf29fb65a "tdf#118314 Code clean up on imestatuswindow" had removed the sole consumer of aText. (It is unclear to me whether the use of StatusDrawCallback in the SalI18N_InputContext in vcl/unx/generic/app/i18n_ic.cxx is still necessary when StatusDrawCallback does not do anything. But StatusStartCallback and StatusDoneCallback do not do anything, either, and are used exactly the same way there, so lets keep all that, at least for now.) Change-Id: Ic2a61819c6bb8ed192231ca309f03b6c29768f29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94760 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-02 02:56:05 +0000