summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2022-08-06tdf#150235: use correct types in XMLTextColumnsExportMike Kaganski3-6/+66
The types for the properties are defined in css::text::TextColumns servise. But before commit 95ebd24a629b4c8cd62cc20c0701683512cc8fa0 Author Mike Kaganski <mike.kaganski@collabora.com> Date Thu May 27 13:00:10 2021 +0300 editengine-columns: ODF support [API CHANGE] the implementation of the service (SwXTextColumns) used smaller types for some properties. The export code (XMLTextColumnsExport::exportXML) mathced those implementation types. The mentioned commit changed the implementation to use proper types; but the export code wasn't corrected. This fixes the export code. Change-Id: I95838dec382edc61bb2e5b39177bf57a7d79e0bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137900 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-08-06crashtesting: keep a reference to the passed in LibXSLTTransformerCaolán McNamara1-1/+1
otherwise, as seen with: soffice --headless --convert-to docx forum-mso-de-42789.docx and error will notify the other thread that the load has ended and the other thread will destroy the passed in LibXSLTTransformer early while this thread assumes it continues to exist Change-Id: Ieea9ecc3439ea73cd0433e5e12b87811906c49aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-06tdf#150232: put Intel Iris driver Skia/Vulkan in denylist for all versionsJulien Nabet1-1/+4
+ Nvidia on Windows just for device id "0x1401" in order to not being too restrictive. Change-Id: Ie2cb2c6c6bb50ac6080721230ca3e451e886bb07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137768 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-08-06the "CreateWindow" function in svtools is newly removedCaolán McNamara2-63/+1
Change-Id: I6fb569cf293a896c92bec4c6aae647a0bd02d012 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137871 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-06cid#1507764 Unintended comparison to logical negationCaolán McNamara1-1/+1
missing - from -> Change-Id: Ieca42cf3fd3e1c10186ba57dd422f3e4ddf9e20a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137898 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-06make SeekEntry take a SwNode, not an SwNodeIndexNoel Grandin8-9/+10
as part of the process of hiding the internals of SwPosition Change-Id: Id43211f221f3b90c46629bedec25f9078c7bf9dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137894 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-06turn on -Wshadow-all for clang compilersNoel Grandin1-0/+1
mostly so that it matches the existing behaviour of the GCC compiler, which makes it easier submitting patches when building locally with clang Change-Id: I0197ec61bc97a3899c2b379efa0f2ad8ed028986 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137896 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-06VBA Add conversion methods to globalHannah Meeks3-0/+64
Change-Id: I920799321f245c015a527c816272c1038cc04544 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137851 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-08-06move SVTXGridControl to toolkitCaolán McNamara34-246/+169
Change-Id: I513a2885027d0295f70e7c64269d1653a6c2642b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137870 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-06ScDataTableView has visible grid in the rectangle at the scrollbar junctionCaolán McNamara2-7/+7
so over paint it with the face color, and replace the unusual use of ScrollBarBox as painter for topleft corner with same Change-Id: I922541122d725a2feeee0db6a1078b953da3156d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137878 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-06tdf#117388 use native scrollbar under gtk in calc data view browserCaolán McNamara2-25/+28
Change-Id: Ia0ab035473da7b5b64e18876bb81e25fd63effda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137877 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-06tdf#117388 use native scrollbar under gtk in reportdesignerCaolán McNamara4-30/+39
Change-Id: If7a66055dbae6d8ee31768ff438eb8105b8f980f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137880 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-06tdf#117388 use native scrollbar under gtk in database scrolled windowCaolán McNamara2-15/+22
Change-Id: I84486f8c8761b80fc45cdccc620485b67afdd048 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137879 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-06Revert "align horz scrollbar to top if assigned more space than it wants"Caolán McNamara1-2/+0
This reverts commit 106bc0fd7a94eb48e8a81be753c156496b83578a. it has an unusual effect in writer on hiding and reshowing scrollbars Change-Id: I0569bf3ddb9b04f1afc6c26add84086bdf4ff5fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137886 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-06ofz#49832 Integer-overflowCaolán McNamara1-1/+2
Change-Id: I35efe0b78546b4804206f78159b2fc18172ca4f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137885 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-06Drop some conversion from vbahelper; use usual functions where neededMike Kaganski4-26/+23
Change-Id: I71bea54f095072a0e403bfc7aa48a0f0f9a0ebaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137891 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-08-06no need to allocate on heap hereNoel Grandin3-12/+12
Change-Id: I889690c136f200cffd0398254ec9935e2027a32c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137893 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-06Related: tdf#135993 Destroy temporary OpCodeMap when reading configEike Rathke3-31/+167
Initialized at FormulaCompiler base class instance it lacks AddIn mapping and a still existing OpCodeMap prevents necessary reinitialization from derived ScCompiler instance later. Change-Id: I0c2db41dd45829abfb8460730264f097ab76ab2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137881 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-08-06make CheckNodesRange take a SwNode, not an SwNodeIndexNoel Grandin10-32/+32
as part of the process of hiding the internals of SwPosition Change-Id: If8e9426df4b78ebf95bbac54ebfdcff4b19b6292 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-06make GetFirstAndLastNode take a SwNode, not an SwNodeIndexNoel Grandin6-8/+8
as part of the process of hiding the internals of SwPosition Change-Id: Ic26ed0fef1d7394ed2673b5949718fe8099b3d8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137873 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-06make GetParaPropsNode take a SwNode, not an SwNodeIndexNoel Grandin11-34/+35
as part of the process of hiding the internals of SwPosition Change-Id: Idefc1cd390c551bf7b54ee122c7fc7e4feb8f45d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137872 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-06tdf#150222 reporbuilder, set font for a text box crashesNoel Grandin1-61/+66
regression from commit c4cf2e82e8d0aaef9b1daedc033d6edf647e5284 Author: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Date: Mon Jun 13 08:53:22 2022 +0200 tdf#128150 Add OOXML import/export for "use background fill" which modified XATTR_FILL_LAST. Ideally, I would just adjust the ranges for the pool, but I can't do that because we are using static defaults, and the range for static defaults has to be contiguous. Also update the aItemInfos array to avoid a DBG_UTIL check that complains about mapping a SID to itself Change-Id: Ie76bdc83fa0a0ad07b6b2afdb678193889373cb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137867 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-06tdf#148240 follow up: Make Outline-Folding non-experimentalJim Raykowski1-4/+2
Change-Id: I147591c8088b1fad0575b2efe46f862573147fe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137774 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-08-06Make parallelism configurable for BZ attachment fetchersThorsten Behrens2-3/+4
Both forum and BZ document fetchers use a hardcoded size for their threadpools. Use the habitual env var PARALLELISM to override that optionally. Change-Id: I374a33ab0cfe481e0940a1f4d5d9a53ae647f135 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137888 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-08-06Disable abisource from BZ attachment fetcherThorsten Behrens1-1/+2
Expired TLS cert since a while, worth checking if it comes back. Change-Id: I4bd98d847ede6ac25d6d4a3361d7365396ad40fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137887 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-08-05tdf#117388 use native scrollbar under gtk in data browserCaolán McNamara5-90/+53
Change-Id: I22745f1c910f68fd2c0b31e8392c111fc76ef529 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137864 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-05resave with latest gladeCaolán McNamara1-111/+110
Change-Id: I0454f8285e819c0a0b320c0652db8e6042a07999 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137876 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-05Use 1 meter, not 10 meters divided by 10Mike Kaganski1-3/+3
Change-Id: I035bd25509db608d2273949cecd438d412e5a4c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137816 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-08-05wina11y: Drop unused AccessibleKey{Binding,Stroke}.idlMichael Weghorn4-213/+0
The only include of the generated header file `AccessibleKeyBinding.h` was in `AccActionBase.cxx`, but that doesn't make any use of what's defined in the header, so just drop the include and the unused IDL files altogether. (The IDL files are part of the winaccessibility-specific UAccCOMIDL, unrelated to the IDL files for the UNO API.) `CMAccessible::get_accKeyboardShortcut` directly operates on the `XAccessibleKeyBinding` UNO interface ever since commit a18bdb3bc05e761704cc345a66a9d642bc4f4a0a Date: Thu Nov 14 08:18:05 2013 +0000 Integrate branch of IAccessible2 Just the winaccessibility directory initially. (the commit also adding those 2 IDL files), so it's unclear to me what might have been the intended use. Change-Id: I1a08e8ea789ca92e52640a0006f20fac219f6733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137866 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-08-05wina11y: Drop unused Charset.idlMichael Weghorn2-34/+0
This is one of the LO- and winaccessibility-specific (i.e. not part of the UNO API and not from upstream IAccessible2) IDL files and it's unused, so drop it. Change-Id: I8802934da174dda3c8b35c39c2196a0ac14a7c1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137865 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-08-05align horz scrollbar to top if assigned more space than it wantsCaolán McNamara1-0/+2
as is currently the case for the databrowser scrollbar, and do the same to the vert for consistency Change-Id: Icf8694f172c3121f35f612a47faa2e2caef890c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137863 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-05tdf#117388 use native scrollbar under gtk in basic editorCaolán McNamara13-61/+59
Change-Id: Id8f2b4fdc40116bb28053dc6fbbf6fa86e6808fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137862 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-05wina11y: Fix indentation of this lineMichael Weghorn1-1/+1
Change-Id: I5b2344c90315aec974e27bba5e3a44e201ffc283 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137860 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-08-05wina11y: Drop unused AccChildNode struct from defines.idlMichael Weghorn1-5/+0
Change-Id: Ia725d6655512632b78abfa4f3791406724ca29ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137859 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-08-05wina11y: Drop extra location bookkeepingMichael Weghorn6-85/+16
The location is already retrieved on demand from the underlying `XAccessible` in `CMAccessible::accLocation` and the separately remembered location was just used as fallback in case `m_xAccessible` was not (no more) set. However, when there is no valid associated `XAccessible`, there is probably no value in returning any location anyway, so just return `S_FALSE` for that case, as other `CMAccessible` methods also do. Whether the separately remembered `m_sLocation` was up to date is also questionable, s.a. Change-Id I04d0230d3599466aaa92082caba54da22a3b1a28, "wina11y: Drop AccObjectManagerAgent::UpdateLocation". This is also in line with what's mentioned in commit fcf4a26275d7503835f9aa23cb94938809840300 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Jan 5 13:41:53 2022 +0000 tdf#146306 wina11y: Retrieve accessible desc on demand > Querying up-to-date values from the underlying > UNO interfaces on demand instead of doing extra > manual bookkeeping in the winaccessibility code > may be possible for more a11y attributes in addition > to the accessible description handled in this commit, > but each one will have to be looked at separately. Change-Id: I2fc51939a5db1896e02efacb1cf5fbc90ce87c04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137858 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-08-05wina11y: Drop AccObjectManagerAgent::UpdateLocationMichael Weghorn6-39/+0
That static method doesn't do anything. `_IMPL_WIN` is not defined, so the #ifdef _IMPL_WIN if( pWinManager ) pWinManager->SetLocation( pXAcc, top, left, width, height ); #endif in the method is unused. Since `CMAccessible::accLocation` already retrieves the current location from the underlying `XAccessible` on demand, I don't see a need to update the location manually in the first place, so there should be no need to enable that, code, just drop it. Also drop `AccObjectWinManager::SetLocation` which was unused since `AccObjectManagerAgent::UpdateLocation` (s. above) would have been the only call site. Change-Id: I04d0230d3599466aaa92082caba54da22a3b1a28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137857 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-08-05Resolves tdf#114508: Individual selection in recovery dialogHeiko Tietze4-51/+185
Based on work by Danie Truter at I397119a6e50c256e87e3a484a6c17a252f191981 Change-Id: I75fd321cbfeb7a92bd14e94b0c1ae0bb25be73cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136845 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-05clang-tidy modernize-pass-by-value in starmathNoel Grandin12-24/+34
Change-Id: Ib6bd1ed629980d4ff122114bc45396886c94ab78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137842 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-05tdf#117388 use native scrollbar under gtk in calc print previewCaolán McNamara2-11/+34
This changes the scrolling to happen immediately during scrolling and not when the user releases the scrollbar at the end. Change-Id: Id8fdb8205964416ad25a99e2c71b061cabee8388 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137853 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-05tdf#117388 use native scrollbar under gtk in writer's html source viewCaolán McNamara2-25/+24
Change-Id: I233745165140ff47d9bb462ad2248fdb8d9dd3e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137854 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-05Use o3tl::convert in VbaApplicationBase::CentimetersToPointsMike Kaganski1-3/+1
Note that the old conversion was incorrect; it likely followed MS documentation [1], which is inaccurate: running in Word MsgBox CentimetersToPoints(1.0) gives 28.34646 (expected given the 1 in = 72 pt definition). [1] https://docs.microsoft.com/en-us/office/vba/api/word.application.centimeterstopoints Change-Id: I4eefccc4bd17958f944f364bc3ea579a8fdbd703 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137855 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-08-05introduce GoNextSection(SwPosition... and similarNoel Grandin7-17/+137
as part of the process of hiding the internals of SwPosition No functional change intended Change-Id: Ia34d7f19685308ff2b9bddcfc40f9d13df348b16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137849 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-08-05wina11y: Implement IAccessibleTableCell::get{column,row}HeaderCellsMichael Weghorn2-2/+84
This is essentially the Windows version of commit 12f96c3d0f61018cfa83c940765311aa9015f60a Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Aug 4 13:27:32 2022 +0200 qt a11y: implement QtAccessibleWidget::{row,column}HeaderCells Tested using NVDA's Python Console as follows: 1) start LO Writer, "Table" -> "Insert Table" 2) select to create table with 2 rows, 2 columns 3) make sure "Heading" is checked, "Heading rows": 1 4) "Insert" 5) in the first row, type "First heading" into first column, "Second heading" into second column 5) start NVDA 6) move cursor to the table cell in second row first column (i.e. the cell below "Heading 1") 7) press KP_Insert+Ctrl+Z to start NVDA's Python console 8) Use NVDA's Python console to call corresponding IAccessible2 methods and check the result: >>> from IAccessibleHandler import IA2 >>> cell = focus.parent.IAccessibleObject.QueryInterface(IA2.IAccessibleTableCell) >>> cell.columnHeaderCells (<comtypes.LP_POINTER(IUnknown) object at 0x010528A0>, 2) >>> header_cell = cell.columnHeaderCells[0].contents >>> header_cell.QueryInterface(IA2.IAccessibleTableCell).columnIndex 0 >>> header_cell.QueryInterface(IA2.IAccessibleTableCell).rowIndex 0 9) Repeat steps 6-8, but now with the cursor in cell in second row, second column (i.e. the cell below "Heading 2") instead, which correctly returns the cell with row index 0 and column index 1 as header cell: >>> from IAccessibleHandler import IA2 >>> cell = focus.parent.IAccessibleObject.QueryInterface(IA2.IAccessibleTableCell) >>> cell.columnHeaderCells (<comtypes.LP_POINTER(IUnknown) object at 0x01024B70>, 2) >>> header_cell = cell.columnHeaderCells[0].contents >>> header_cell.QueryInterface(IA2.IAccessibleTableCell).columnIndex 1 >>> header_cell.QueryInterface(IA2.IAccessibleTableCell).rowIndex 0 Without this commit, this would fail like this: >>> from IAccessibleHandler import IA2 >>> cell = focus.parent.IAccessibleObject.QueryInterface(IA2.IAccessibleTableCell) >>> cell.columnHeaderCells Traceback (most recent call last): File "<console>", line 1, in <module> File "monkeyPatches\comtypesMonkeyPatches.pyc", line 32, in __call__ _ctypes.COMError: (-2147467259, 'Unspecified error', (None, None, None, 0, None)) Change-Id: I8de495ad28b2bece971fe4462e539bcc242ed440 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137847 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-08-05wina11y: Implement IAccessibleTableCell::get_tableMichael Weghorn2-1/+24
Tested using NVDA's Python Console as follows: 1) start LO Writer, "Table" -> "Insert Table" 2) select to create table with 2 rows, 2 columns 3) make sure "Heading" is checked, "Heading rows": 1 4) "Insert" 5) in the first row, type "First heading" into first column, "Second heading" into second column 5) start NVDA 6) make sure cursor is in the first table cell ("Heading 1") 7) press KP_Insert+Ctrl+Z to start NVDA's Python console 8) Use NVDA's Python console to call the corresponding IAccessible2 methods and check the result: >>> from IAccessibleHandler import IA2 >>> cell = focus.parent.IAccessibleObject.QueryInterface(IA2.IAccessibleTableCell) >>> cell.table <POINTER(IUnknown) ptr=0x7cc5b24 at 13f3850> >>> cell.table.QueryInterface(IA2.IAccessibleTable) <POINTER(IAccessibleTable) ptr=0x378d47c at 13f38f0> >>> cell.table.QueryInterface(IA2.IAccessibleTable).nRows 2 >>> cell.table.QueryInterface(IA2.IAccessibleTable).nColumns 2 Without this commit in place, this would fail as follows: >>> from IAccessibleHandler import IA2 >>> cell = focus.parent.IAccessibleObject.QueryInterface(IA2.IAccessibleTableCell) >>> cell.table Traceback (most recent call last): File "<console>", line 1, in <module> File "monkeyPatches\comtypesMonkeyPatches.pyc", line 32, in __call__ _ctypes.COMError: (-2147467259, 'Unspecified error', (None, None, None, 0, None)) Change-Id: I67b84f1fd9d397a3aa40b5336c3baafad35eec29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137846 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-08-05wina11y: Implement IAccessibleTableCell:get_rowColumnExtentsMichael Weghorn2-1/+24
The doc says [1]: > Gets the row and column indexes and extents of this cell accessible and > whether or not it is selected. > > This is a convenience function. It is not mandatory to implement it. Just use the existing methods to retrieve the information. [1] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible_table_cell.html#a686348f0b7ecae19d4be5d7ef37ff201 Change-Id: If009c3913e6e837317255266251bd7696d423118 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137845 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-08-05tdf#117388 use native scrollbar under gtk in impress/draw documentsCaolán McNamara11-56/+56
Change-Id: I5dbcc14af083584fe4b73ecd4e4bf4187fb9af39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137836 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-05start with size at optimal sizeCaolán McNamara1-0/+1
Change-Id: Ibd5f009c4717ce236334e5fc407512a5ef8c2a70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137844 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-05drop unnecessary nDelta of 0 optimizationCaolán McNamara1-5/+0
Change-Id: Idce5a4272314785382fbb7acf078ddb84ff61ebc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137843 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-08-05VBA Add conversion methods to ApplicationHannah Meeks3-2/+82
Change-Id: Ic0de06699a647565deca7985742965a72614df16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137787 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-08-05VBA Add Padding properties to XTableHannah Meeks5-8/+107
Change-Id: I021ad15b81ce55c4f9e9e9b515be1ddaaca8d07d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137630 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 09:54:00 +0000