summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-08-23external/liborcus: Blind fix attempt for older macOS builds, take 2Stephan Bergmann1-7/+64
More places that need a workaround like 5c2c08f635c30b732df48faca7ba3d411074e05a "external/liborcus: Blind fix attempt for older macOS builds". Change-Id: Idcdfbddabac63bcc778a43ce5dfbf6b9f70d20e1 Reviewed-on: https://gerrit.libreoffice.org/78008 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-23weld SwMailMergeWizardCaolán McNamara24-251/+150
Change-Id: I03a7fd1f7676792387155db986d710a001887c8d Reviewed-on: https://gerrit.libreoffice.org/77977 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23Access2Base - Change version numberJean-Pierre Ledure1-1/+1
6.4 i.o. 6.3 Change-Id: I0a03de3ad6b67373f809433cd3dba6c2a7a461b3
2019-08-23tdf#119388 add new UNO listener/broadcasterNoel Grandin17-85/+288
so that we only need to fire each event to the exact shape that wants it, instead of spamming all the shapes. Takes deleting a column from 20s to 10s for me. Note that none of the broadcasters are calling disposing(EventObject), so I did not make XShapeEventListener extend lang::XEventListener. If a memory leak regression points at this commit, possibly I missed something. Change-Id: I2b8db08247d3e0203d41faf77491368168994e4d Reviewed-on: https://gerrit.libreoffice.org/77857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23rename AddressPreview back to SwAddressPreviewCaolán McNamara7-40/+40
Change-Id: I2afd5580fd94621163a5217d08d5b60190673fd2 Reviewed-on: https://gerrit.libreoffice.org/77973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23Clean up OSL_ASSERT in stoc/source/uriproc/Stephan Bergmann3-8/+15
Change-Id: Ia474439d4e35009ec0941b122653a649692aead7 Reviewed-on: https://gerrit.libreoffice.org/77943 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-23Check that XUriReferenceFactory.makeAbsolute matches rtl::Uri::convertRelToAbsStephan Bergmann1-318/+338
Change-Id: I7fefdc7ca23a2f505944288c30c820ef70da14ae Reviewed-on: https://gerrit.libreoffice.org/77942 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-23[API CHANGE] Adapt css.uri UNOIDL entities to RFC 3986Stephan Bergmann16-232/+735
...which obsoleted RFC 2396. Notable changes are that the distinction between hierarchical and opaque URIs has been dropped, and that the relative URI resolution specification has been made more rigid. As a consequence, various features of css.uri entities have changed: * XUriReference.isHierarchical is obsolete and deprecated. * The behavior of XUriReference.hasAuthority, XUriReference.getAuthority, XUriReference.getPath, XUriReference.hasRelativePath, XUriReference.getPathSegmentCount, XUriReference.getPathSegment, XUriReference.hasQuery, and XUriReference.getQuery has been made consistent for all URIs, no matter whether they were considered hierarchical or opaque in the past. * The behavior of XUriReferenceFactory.makeAbsolute and XUriReferenceFactory.makeRelative has been changed to match the RFC 3986 reference resolution specification. The XUriReferenceFactory.makeAbsolulte parameter processSpecialBaseSegments has been renamed to processAdditionalSpecialSegments, as per the updated specification it now controls treatment of special segments in the given uriReference, in addition to special segments in the given baseUriReference. (Renaming UNOIDL interface method parameters is technically an incompatible change, but the benefits of improved clarity presumably outweigh any potential drawbacks in this case.) The implementation in stoc has been adapted, and various call sites have been adapted to the deprecated XUriReference.isHierarchical semantics. Change-Id: Ic6e00fdbce5abef70d75ec2f753d22fefe361457 Reviewed-on: https://gerrit.libreoffice.org/77861 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-23Improve loplugin:sequenceloop warningStephan Bergmann1-1/+1
...from > sfx2/source/appl/shutdowniconaqua.mm:416:13: error: use std::as_const, or make range var const, to avoid creating a copy of the Sequence [loplugin:sequenceloop] > for ( auto const & newMenuProp : aNewMenu ) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ to > sfx2/source/appl/shutdowniconaqua.mm:416:46: error: use std::as_const, or make range var const, to avoid creating a copy of the Sequence [loplugin:sequenceloop] > for ( auto const & newMenuProp : aNewMenu ) > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ Change-Id: I1eabe80abeed1784a246a6e3c9b7036f664ee681 Reviewed-on: https://gerrit.libreoffice.org/77989 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-23don't call Show on the SfxTabPageCaolán McNamara1-1/+0
it causes spurious toplevels in the welded case Change-Id: I321dfaf1d9df1d4a0b80435814e844d8fa29847b Reviewed-on: https://gerrit.libreoffice.org/78004 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23loplugin:returnconstval in comphelperNoel Grandin6-10/+10
Change-Id: I6e8d45e4d5e6223ffa7ae844a8bd46eae8e1f3c8 Reviewed-on: https://gerrit.libreoffice.org/78000 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23loplugin:returnconstval in toolsNoel Grandin3-5/+5
Change-Id: Ic00c0a6788e65ba2b50e93d49592e67596354f96 Reviewed-on: https://gerrit.libreoffice.org/77998 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23tdf#126741 - fix dash dot dot line style import problem, for pptxnd1014-2/+32
To make it consistent with MS PowerPoint, make the dash dot dot line start with dash instead of dots. Based on Regina Henschel's technical analysis and code pointers, but only make change to the lgDashDotDot case and leave everything else untouched. Change-Id: Ide533a562005c617eca9d556a63b6aec39017e93 Reviewed-on: https://gerrit.libreoffice.org/77443 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-08-23Access2Base - Implement Find and ProcOfLineJean-Pierre Ledure2-13/+41
Find and ProcOfLine are methods of the MODULE class They return a value (as usual) but also parameters passed by reference, which is not supported by Python As a workaround, specific properties are set after their execution Change-Id: I70ed3646a6d701a4853d071d4ca6eb213276d5e9
2019-08-23external/liborcus: Blind fix attempt for older macOS buildsStephan Bergmann2-0/+60
see external/liborcus/0001-Blind-fix-attempt-for-older-macOS-builds.patch for details Change-Id: I7be71524da1cf702218170fd2c921d35c176ea4c Reviewed-on: https://gerrit.libreoffice.org/77997 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-23Update commentStephan Bergmann1-3/+0
external/liborcus/create-element.patch.0 has been removed with 52800fd6d9867252b795b6afacce19f66b5a5107 "Update orcus to 0.15.1." Change-Id: Ie127466778f9c15c8edd9de8511c3f60f6da1cd7 Reviewed-on: https://gerrit.libreoffice.org/77988 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-23Mark move ctors/assignments noexceptMike Kaganski70-132/+131
This should enable using move semantics where possible e.g. in standard containers. According to https://en.cppreference.com/w/cpp/language/move_constructor: To make strong exception guarantee possible, user-defined move constructors should not throw exceptions. For example, std::vector relies on std::move_if_noexcept to choose between move and copy when the elements need to be relocated. Change-Id: I6e1e1cdd5cd430b139ffa2fa7031fb0bb625decb Reviewed-on: https://gerrit.libreoffice.org/77957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-23tdf#127101 Change tracking: fix format reject at paragraph joinLászló Németh4-6/+33
Now "Reject tracked change" can restore the original format of multiple paragraphs of a tracked deletion during editing. Change-Id: I83a307b4206ab610af3458f8cb6e9de905b88776 Reviewed-on: https://gerrit.libreoffice.org/77101 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-23tdf#127101 Change tracking: reject format at paragraph joinLászló Németh2-17/+128
Now "Reject tracked change" can restore the original format of the paragraphs of a tracked deletion during editing, storing the format change using SetExtraData() of SwRangeRedline. Change-Id: I916f624de081bf2fab020e0574aa4ec3136946c4 Reviewed-on: https://gerrit.libreoffice.org/77100 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-08-23tdf#126720 Fixing label length fix UI breakShubham Goyal1-11/+26
Change-Id: I4fefc4fcb64388fb3c3ca35b73a7264b381d4e6f Reviewed-on: https://gerrit.libreoffice.org/77751 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2019-08-23Add missing "See also"Samuel Mehrbrodt1-1/+1
Change-Id: If226fcb97cd67ad2239f55f4138703d712b70a08 Reviewed-on: https://gerrit.libreoffice.org/77991 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-23loplugin:returnconstval in o3tlNoel Grandin1-3/+3
Change-Id: Ib36382243552cd80dab431741f45dc767beccf59 Reviewed-on: https://gerrit.libreoffice.org/77993 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23tdf#103345 Import decimalEnclosedCircle correctlySamuel Mehrbrodt3-1/+21
Change-Id: I227d149d07ea0f7b2569e5df5a5589834374fac9 Reviewed-on: https://gerrit.libreoffice.org/77992 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-23loplugin:returnconstval in saxNoel Grandin10-17/+17
Change-Id: Icf5c337164b71aab10dd960815eee516822c276c Reviewed-on: https://gerrit.libreoffice.org/77990 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23an assistant might have no parentCaolán McNamara2-3/+4
Change-Id: Id85bfe822b68aafd4bccdbae3a4ebdc6baa6be4a Reviewed-on: https://gerrit.libreoffice.org/77967 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-23SmartArt: add Edit Diagram dialogGrzegorz Araminowicz13-0/+231
Currently it displays only text representation of diagram. Change-Id: I3ff12c4abf2ed32f68ea9d7437905afc13279e62 Reviewed-on: https://gerrit.libreoffice.org/77873 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-23RTF filter: handle tbrl section text directionMiklos Vajna4-12/+56
Makes no sense to support btlr, Word can't handle it. (UI is disabled.) Change-Id: I036a1e98e8b1ac07e688eedf45b4a2c21c4a8859 Reviewed-on: https://gerrit.libreoffice.org/77986 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-23loplugin:returnconstval in vclNoel Grandin30-49/+44
Change-Id: Id4a0b460ba3c43e80b80ae6e2da9e40a6753e14c Reviewed-on: https://gerrit.libreoffice.org/77965 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23new loplugin:returnconstvalNoel Grandin3-0/+98
look for code that thwarts copy-elision/move optimisations by returning const values. Change-Id: Iafa038d15051e06ee76d8a1c0ce8b7d234cd8488 Reviewed-on: https://gerrit.libreoffice.org/77964 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-23tdf#39593 extract UnoTunnelId comparison to template functionArkadiy Illarionov49-139/+77
Change-Id: Ia2b5dea273c8de7b8c54e74780193a8d4cba7b45 Reviewed-on: https://gerrit.libreoffice.org/73874 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-23Removed executable permission on fileAndrea Gelmini1-0/+0
Change-Id: I8888cc51eaef76e48e3acdbc9602720a3e12902a Reviewed-on: https://gerrit.libreoffice.org/77981 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-23Fix typoAndrea Gelmini1-1/+1
Change-Id: I94efc4ce7e197fb8dc68840939ed75393983be1c Reviewed-on: https://gerrit.libreoffice.org/77980 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-23tdf#126784 sw: only distribute across selected columnsJustin Luth7-23/+50
partial revert of LO6.2 commit ab18c17d70e1dcf5cf9db38256d35e6af479373e because MERGED cells had a very unexpected effect on the columns that were altered. Unselected columns are INCLUDED in the calculation IF they extend over the selected columns when SwTableSearchType::Col uses the entire table column. The last table in the unit test demonstrates why the regressive behaviour was included. A user can make an ugly layout if they don't choose a good set of columns. However, the merged cell really changes the way the calculation works, and since giving power to the user is ultimately the best, just revert the portion that tries to save the user from themself. I struggled then and now to get a good enough understanding to improve the documentation - which really is needed since reading it didn't help me a lot. However, since my understanding was and is obviously flawed, I'll just revert back to the original wording. Change-Id: Icf8f01f095652e2a023e0398852f43aa6b90332f Reviewed-on: https://gerrit.libreoffice.org/77976 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-08-23Update orcus to 0.15.1.Kohei Yoshida3-58/+2
Change-Id: Ifd945d03719bf2ed1fb145b405f1ea9297ebeb68 Reviewed-on: https://gerrit.libreoffice.org/77983 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2019-08-22kf5backend.cxx: Use 'free()' instead of 'delete'Michael Weghorn1-1/+1
'strdup' doc [1] mentions: "The returned pointer must be passed to 'free' to avoid a memory leak." This silences a "Mismatched free() / delete / delete []" error that valgrind outputs. [1] https://en.cppreference.com/w/c/experimental/dynamic/strdup Change-Id: I28877be762256a7b995c09415a8ad9977b7998c4 Reviewed-on: https://gerrit.libreoffice.org/77974 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-08-22Replace use of INetURLObject::GetNewAbsURL with rtl::Uri::convertRelToAbsStephan Bergmann1-4/+7
Change-Id: Ida2a0553ede3d6d9d7ff4a50bca6256a70286bc2 Reviewed-on: https://gerrit.libreoffice.org/77970 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-22OControlWizard->vcl::WindowCaolán McNamara2-2/+2
Change-Id: Ibb007621aca910cd2fd983b2f255e93160bddb5c Reviewed-on: https://gerrit.libreoffice.org/77968 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-22drop newly unused SwAddressPreviewCaolán McNamara5-309/+11
Change-Id: I84cf6570d048df86b4690cb70cc3e7a256303951 Reviewed-on: https://gerrit.libreoffice.org/77972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-22weld SwMailMergeAddressBlockPageCaolán McNamara8-137/+181
Change-Id: Ib3383f1ae590766ecb1371cab2ccdb7c835c95a8 Reviewed-on: https://gerrit.libreoffice.org/77971 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-22tdf#71087 sfx2: avoid flicker in the start centerMiklos Vajna5-2/+37
There were a couple of problems here: 1) BackingWindow now does double-buffering to avoid flicker when e.g. navigating with the keyboard in sfx2::RecentDocsView 2) But then the menu background turned into white (instead of the gradient), so MenuBarWindow needs to differentiate between doing its own buffering vs painting into a buffer. 3) The focus rectangles were always painted directly, so keyboard navigation in the startcenter lost focus rectangles, making it hard to see which button is active currently. Fix this by explicitly painting a tracking rectangle in PushButton::ImplDrawPushButton(). This brings an improvement for the Windows GDI and Linux gen backends. Windows GL and Linux gtk3 is meant to be unchanged, they were already flicker-free here. Change-Id: Ib01e330c244c2b38a5b5c52399692e19ff811de3 Reviewed-on: https://gerrit.libreoffice.org/77969 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-22weld ODbTypeWizDialogCaolán McNamara3-41/+38
Change-Id: Ie85e8f7a9a7551078e3108e7be9747ae4501d5eb Reviewed-on: https://gerrit.libreoffice.org/77966 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-22weld chart CreationWizardCaolán McNamara23-140/+112
Change-Id: I7ee88c1e1b0eca5c2510a4bbba8b60c0d8a4e3e8 Reviewed-on: https://gerrit.libreoffice.org/77954 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-22Simplify Sequence iterations in packageArkadiy Illarionov8-546/+441
Use range-based loops, STL and comphelper functions Change-Id: Ibd836b9b2df2f30b42f2d7a621188d78f5b53196 Reviewed-on: https://gerrit.libreoffice.org/77246 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-08-22This is an export test.Tamás Zolnai1-1/+1
Change-Id: Idad907f192c7a4e536bd1b8ca899fc6f9d55bbdf Reviewed-on: https://gerrit.libreoffice.org/77962 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-08-22tdf#127085: FILESAVE: Transparency is lost after RTTamás Zolnai3-3/+14
Change-Id: I22ba83b5cc00f84112a3755898ee2be58337afd6 Reviewed-on: https://gerrit.libreoffice.org/77963 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-08-22weld ODbTypeWizDialogSetupCaolán McNamara34-280/+2219
split up RoadmapWizard to sit its wizard logic on top of a a native GtkAssistant a) awkwardly GtkAssistant is not a GtkDialog, but derives directly from GtkWindow so some shuffling around required due to that b) hidden/unused pages are shuffled to the end of the list of pages and their titles turned off in order to hide them from the roadmap c) some nonstandard hackery required to get the gtk roadmap titles to wrap Change-Id: I0d2346c489fef744136a2785f33c846d97bd8dc6 Reviewed-on: https://gerrit.libreoffice.org/76876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-22loplugin:constmethod in testNoel Grandin4-5/+5
Change-Id: I15aa90d962b9d428a911f4b47a06d55318b42ba4 Reviewed-on: https://gerrit.libreoffice.org/77953 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-22loplugin:constmethod in toolkitNoel Grandin3-6/+6
Change-Id: Id80ee487d7083da5c1f1c4d012d6339700471204 Reviewed-on: https://gerrit.libreoffice.org/77952 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-22oox: typos, comments, formattingAshod Nakashian1-5/+4
Change-Id: I6bb138be2a8da91a85248e85d408f54a9b885f9b Reviewed-on: https://gerrit.libreoffice.org/77686 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2019-08-22tdf#127097 Change tracking: change style of whole deletion at paragraph joinLászló Németh2-7/+46
in all deleted paragraphs to avoid editing problems later. This reverts the behaviour of paragraph join changed by commit 705b728d26b4480ec6b51d9fe1362a0154ea9bf9 "tdf#119571 fix style & numbering at tracked deletion", but now Undo undoes the (sometimes different) styles of the deleted paragraphs in the same deletion, instead of losing them. Change-Id: Ic4641356c28f005efb43bf71b5b23a7bd054fecd Reviewed-on: https://gerrit.libreoffice.org/76862 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 09:17:31 +0000