summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-02-07weld URLBox ItemWindowCaolán McNamara11-31/+146
Change-Id: I7dad000404a188e2f5588b90d73ea9b1236bd301 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88183 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07Fix typoAndrea Gelmini1-1/+1
Change-Id: I9bae8051b27eddca47ca5ffbd17006bf23d4f232 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88149 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-07Fix typoAndrea Gelmini1-2/+2
Change-Id: I2df1bab891cb1661da48ded41f0bc669fb4b0bbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88147 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-07Fix typoAndrea Gelmini1-2/+2
Change-Id: Ia1cd4fc4e6f5cfbf327132cdd499cb42c1f7d3e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88148 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-07Fix typoAndrea Gelmini1-1/+1
Change-Id: I44241cf4c81543ad2a3091e3b19639f63e016cd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88193 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-07remove unused suppressionsCaolán McNamara1-12/+0
Change-Id: Ibee4281b884cf65a0f99ebd7a52087c6a5ebb66c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88177 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07move some headers inside svtools moduleNoel Grandin19-45/+30
Change-Id: I62fe3345aebe148010971bc8c487d96fa601d420 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88164 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07weld GlueEscDirLB ItemWindowCaolán McNamara4-31/+84
Change-Id: I472ba595bb2f31bedf1d0e0a890024f9ac3ada39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88176 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07neon: escape broken SharePoint 2016 URIsJan-Marek Glogowski2-0/+23
SharePoint returns broken URIs in its href replies, which aren't correctly URI encoded, but still "valid" URIs w.r.t. general and UTF8 encoding, e.g. http://<host>/Shared%20Documents/ümlaut.docx As a workaround, this allows all invalid / other bytes (except '\0') in the path of the URI in ne_uri_parse. Change-Id: I70e7d323837469d7ced429a42c009972f4fb0ebc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88120 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins
2020-02-07tdf#54938: Adapt supportsService implementations to cppu::supportsServiceMehmet Emin Başoğlu1-6/+5
Change-Id: I5484047a8b0e87d012ca3a37466b9ebf718257b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87494 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-07weld ScNumberFormat ItemWindowCaolán McNamara5-27/+82
Change-Id: Ib019912e91be617edbbcdf2fafb92d6685487b98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07weld SwZoomBox_ImplCaolán McNamara3-53/+128
Change-Id: I3cf7046eeb5bf58afc8d1db06fd50d42c6131d40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88145 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07neon: enable NE_DEBUG support for gb_ENABLE_DBGUTILJan-Marek Glogowski1-0/+6
This builds NEON with its debugging / logging facility, if gb_ENABLE_DBGUTIL is set. This still has to be enabled in code by calling something like ne_debug_init(stderr, NE_DBG_XML) to enable and ne_debug_init(NULL, 0) to disable it again. Change-Id: I85ea1cb2bd9586072d5a12a1cb809dd8c76b37d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88171 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-02-07remove unnecessary includeCaolán McNamara1-1/+1
Change-Id: I205966f40472d187c63717ddf6e8153584c6b284 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88141 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07weld SwJumpToSpecificBox_ImplCaolán McNamara5-17/+56
Change-Id: I4c140bccf821b6ee0ce0e734cebae722267f5430 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88140 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07tdf#129809 take a reference in case m_aContents is replacedCaolán McNamara1-1/+4
Change-Id: I36ae74b6b3424bd2f0b71bc54838ec39e504b6d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88168 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07use swap instead of copy and clearNoel Grandin1-7/+6
Change-Id: I51aa680e66aa0a5186edadf9d5a2d57798be4103 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88165 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07Update git submodulesSophia Schröder1-0/+0
* Update helpcontent2 from branch 'master' to 3533996771482653d9e38b6839ba79ca48164164 - Visibility improvements + small cleanups Change-Id: Id8de3abf26a470525110e3940a6f266dcd4b8915 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88060 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-07libxstl.dll: Reduce code when symboles enabledJuergen Funk1-1/+1
Change-Id: I189ac6346758c4accadc6b268c321654ae151752 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88157 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-07tdf#99693 Add Highlighting tab for CalcMaxim Monastirsky9-9/+66
Works with shapes and comments. Change-Id: I2a91a6038ab618bf7e6fd4eb2d129a9485a47fef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88163 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-07sw: improve DOCX export of footnote separatorMichael Stahl3-3/+111
Don't only check the width of the line, but also the line style and the thickness (0 is not visible). Also there isn't a separate continuationSeparator in sw, so it should depend on the same condition as the separator. Unfortuantely Word doesn't support different separators per section. Change-Id: I55cb3d82ff20c7a21f7d256ec8ba4a43f1e71faa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88131 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-07loplugin:singlevalfieldsNoel Grandin4-139/+112
Change-Id: I5d1b08532e6a4e444d61ff8ee1b913999df40ae9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88079 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07test: move component context from subclasses to BootstrapFixtureMiklos Vajna25-48/+5
To avoid duplication. Change-Id: I0ee7c26d5d55bd868ead04c77e7f4ef2582f90e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88138 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-07add OpenCLZone in suitable places in Calc's OpenCL codeLuboš Luňák1-0/+16
Change-Id: I0ce230a9a876c2f1fdbcd7ed81a1aba043cc5fb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88012 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-07add Skia crash zone checkingLuboš Luňák10-0/+138
Just like with OpenGL, mark zones where Skia code may call into graphics drivers in order to be able to detect cases where the driver has caused a crash or a lockup. Change-Id: I0fdbcc2260e3ab7821a595e9960145ae1fc1adfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88011 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-07Add missing test dependency on instdir/share/config/images_*.zipStephan Bergmann1-0/+2
...without which `make clean && make CppunitTest_sd_misc_tests` would fire > cppunittester: vcl/source/gdi/bmpacc.cxx:38: BitmapInfoAccess::BitmapInfoAccess(Bitmap &, BitmapAccessMode): Assertion `xImpBmp && "Forbidden Access to empty bitmap!"' failed. because > #3 0x00007ffff6deba66 in __GI___assert_fail > #4 0x00007fffd23c14af in BitmapInfoAccess::BitmapInfoAccess(Bitmap&, BitmapAccessMode) at vcl/source/gdi/bmpacc.cxx:38 > #5 0x00007fffd23c36fc in BitmapReadAccess::BitmapReadAccess(Bitmap&, BitmapAccessMode) at vcl/source/gdi/bmpacc.cxx:87 > #6 0x00007fffd23c89a0 in BitmapWriteAccess::BitmapWriteAccess(Bitmap&) at vcl/source/gdi/bmpacc.cxx:355 > #7 0x00007fffd3359a02 in Bitmap::AcquireWriteAccess() at vcl/source/bitmap/bitmap.cxx:388 > #8 0x00007fffd1cb15cf in vcl::ScopedBitmapAccess<BitmapWriteAccess, Bitmap, &Bitmap::AcquireWriteAccess>::ScopedBitmapAccess(Bitmap&) at include/vcl/scopedbitmapaccess.hxx:53 > #9 0x00007fffd3375fe6 in BitmapDisabledImageFilter::execute(BitmapEx const&) const at vcl/source/bitmap/BitmapDisabledImageFilter.cxx:28 > #10 0x00007fffd336ed1d in BitmapFilter::Filter(BitmapEx&, BitmapFilter const&) at vcl/source/bitmap/bitmapfilter.cxx:22 > #11 0x00007fffd34c1875 in ImplImage::getBitmapEx(bool) at vcl/source/image/ImplImage.cxx:123 > #12 0x00007fffd34c212c in ImplImage::getBitmapExForHiDPI(bool) at vcl/source/image/ImplImage.cxx:153 > #13 0x00007fffd34b3c7b in Image::Draw(OutputDevice*, Point const&, DrawImageFlags, Size const*) at vcl/source/image/Image.cxx:123 > #14 0x00007fffd1cec66e in OutputDevice::DrawImage(Point const&, Size const&, Image const&, DrawImageFlags) at vcl/source/outdev/bitmap.cxx:1388 > #15 0x00007fffd1cec1f7 in OutputDevice::DrawImage(Point const&, Image const&, DrawImageFlags) at vcl/source/outdev/bitmap.cxx:1372 > #16 0x00007fffd0ea7ca4 in ToolBox::ImplDrawItem(OutputDevice&, unsigned long, unsigned short) at vcl/source/window/toolbox.cxx:2696 > #17 0x00007fffd0ec629d in ToolBox::Paint(OutputDevice&, tools::Rectangle const&) at vcl/source/window/toolbox.cxx:3490 > #18 0x00007fffd003daed in PaintHelper::DoPaint(vcl::Region const*) at vcl/source/window/paint.cxx:309 wants to draw sfx2/res/symphony/morebutton.png Change-Id: I9c21eb7891a6dfa29033618177c97370695e413d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88146 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-07disable watchdog if using valgrind or debuggerLuboš Luňák1-0/+13
It generally shouldn't activate if the process is progressing slowly because of debugging. Change-Id: Iacabe0fee762d5bf292582fdbb1a8f5ce67abb5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88010 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-07make isDebuggerAttached() public comphelper APILuboš Luňák4-30/+98
So that it can be used also from other places. Change-Id: Iab90350fd02872ffde180ce74f01f7ff5e4448b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88009 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-07merge OpenGLZone and OpenCLZone into one generic codeLuboš Luňák14-264/+318
To be used also by Skia code to detect problems with Vulkan drivers. The watchdog does not handle OpenCL because neither did the original code, but also because OpenCLZone::hardDisable() called from it would deadlock on SolarMutex for some reason. Change-Id: I483d8cb0b11a4e1e65c564f4e4c29ab68843ff71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88008 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-07remove use of macro DeclPrimitive2DIDBlock in everywhereTomaž Vajngerl20-34/+31
Change-Id: I3fcba604ee3bc95274700ae7406f27e292cd09ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88154 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-07Missing test dependenciesStephan Bergmann1-0/+6
First, there was a SIGABRT due to > Could not find platform independent libraries <prefix> > Could not find platform dependent libraries <exec_prefix> > Consider setting $PYTHONHOME to <prefix>[:<exec_prefix>] > Fatal Python error: initfsencoding: Unable to get the locale encoding > ModuleNotFoundError: No module named 'encodings' at > #1 0x00007ffff6ddc8d9 in __GI_abort () > #2 0x00007ffd654459db in fatal_error (prefix=<optimized out>, msg=<optimized out>, status=<optimized out>) at workdir/UnpackedTarball/python3/Python/pylifecycle.c:2187 > #3 0x00007ffd654430fe in _Py_FatalInitError (err=...) at workdir/UnpackedTarball/python3/Python/pylifecycle.c:2206 > #4 0x00007ffd65443348 in Py_InitializeEx (install_sigs=1) at workdir/UnpackedTarball/python3/Python/pylifecycle.c:1041 > #5 Py_Initialize () at workdir/UnpackedTarball/python3/Python/pylifecycle.c:1048 > #6 0x00007ffd65d88a65 in pyuno_loader::(anonymous namespace)::PythonInit::PythonInit() (this=0x7ffd65da0820 <pyuno_loader::CreateInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&)::s_Init>) at pyuno/source/loader/pyuno_loader.cxx:229 > #7 0x00007ffd65d87b54 in pyuno_loader::CreateInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (ctx=...) at pyuno/source/loader/pyuno_loader.cxx:247 And then there was a failure > postprocess/qa/services.cxx:318:(anonymous namespace)::Test::test > forced failure > - instantiating "com.sun.star.wizards.agenda.CallWizard" via "com.sun.star.wizards.agenda.CallWizard" caused com.sun.star.uno.RuntimeException "<class 'ImportError'>: No module named 'wizards.ui' (or 'ui.WizardDialog.WizardDialog' is unknown), traceback follows > File "instdir/program/pythonloader.py", line 136, in activate > mod = self.getModuleFromUrl( locationUrl ) > File "instdir/program/pythonloader.py", line 114, in getModuleFromUrl > mod = __import__( dependent ) > File "instdir/program/uno.py", line 356, in _uno_import > return _builtin_import(name, *optargs, **kwargs) > File "instdir/program/wizards/agenda/CallWizard.py", line 21, in <module> > from .AgendaWizardDialogImpl import AgendaWizardDialogImpl, Desktop > File "instdir/program/uno.py", line 356, in _uno_import > return _builtin_import(name, *optargs, **kwargs) > File "instdir/program/wizards/agenda/AgendaWizardDialogImpl.py", line 20, in <module> > from .AgendaWizardDialog import AgendaWizardDialog, uno > File "instdir/program/uno.py", line 356, in _uno_import > return _builtin_import(name, *optargs, **kwargs) > File "instdir/program/wizards/agenda/AgendaWizardDialog.py", line 18, in <module> > from ..ui.WizardDialog import WizardDialog, uno, UIConsts, PropertyNames > File "instdir/program/uno.py", line 434, in _uno_import > raise uno_import_exc > File "instdir/program/uno.py", line 356, in _uno_import > return _builtin_import(name, *optargs, **kwargs) > > " Change-Id: I80160dccd162641e6a9d5633e45a498f230abfdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88144 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-07clang-format cui with under 5-percent lines of changeMuhammet Kara9-36/+28
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: I2886b6da85043218505ff9f3e40a8e28289c6f37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88152 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-07loplugin:unusedmethodsNoel Grandin6-191/+30
Change-Id: I7296b2fc2862d0ad1f68658b19b2a25cb7609df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88080 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07put clang-format commits to .git-blame-ignore-revsTomaž Vajngerl1-0/+5
Change-Id: I9407ada626dbc81d53688d938948d45dc8927bb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88137 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-07use "pragma once" for *primitive2d.hxxTomaž Vajngerl48-197/+51
Change-Id: I7b6dff10cc02eaec81c9aececda86374fc61a8da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88136 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-07Remove erroneous whitespace in update_pchMuhammet Kara4-10/+8
This was causing generation of code in violation of clang-format conformance in these files: * xmlsecurity/inc/pch/precompiled_xsec_xmlsec.hxx * connectivity/inc/pch/precompiled_ado.hxx Also remove these 2 files from the clang-format blacklist. Change-Id: I882028c0553a3ff7fb356611f498d50dea984a7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88143 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-06GenericCommands: fix Fontwork tooltipsJustin Luth2-5/+5
These were terribly confusing. .uno:Fontwork does NOT insert fontwork text, despite the tooltip name. It opens up the old fontwork dialog that modifies contour properties so that the text can flow along the contour. The UIname is Fontwork, so lets have an automatic tooltip for that. .uno:FontworkGalleryFloater has a UIname of "Fontwork Style", but the auto-generated tooltip was "Fontwork". (Notice that this conflicts with the UIname of the other one. So when you add "Fontwork" to your toolbar, and chose the icon with the tooltip "Fontwork" you get a different item.) Since this one actually inserts text, and doesn't actually modify any existing style (that's the function of Fontwork Shape), lets give this one the tooltip "Insert Fontwork Text". Therefore, this patch effectively switches the two tooltip names around, which much better matches their function, and their UIname. I expect that this was the original 2016 intention anyway... At the end, I decided to also change the UIname to "Insert Fontwork", since the gallery is normally added to insert menus... The unit test I had to modify just looked like a functionality test and had nothing to do specifically with the label's string. (It was last changed for tdf#91781 which made no specific reference to fontwork.) This might help documentation bug tdf#118336 a bit too. Change-Id: I152596781def2d8dba47f53e345976543e3131bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88101 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-06gb_CppunitTest__use_java_ure can be private againStephan Bergmann2-4/+2
...(which it already was until 1f6e670605cc856a6e9febb024f9cb2427156020 "gbuild: require java UNO runtime explicitly"), as 2a87b3b5aed8296a7506374fd5324c5659a88cb5 made that implicitly called from gb_CppunitTest_use_jar(s), so its (sole outside) use in postprocess/CppunitTest_services.mk is redundant Change-Id: I9928521d184c54688de134ff3b9b5743ba3509c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88134 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-06Fix mis-mergeStephan Bergmann1-2/+1
d4b1d9b75572fdcc55a925254943a3cf29354f98 "sb123: #i111655# when, within build env, calling javaldx within OOo installation sets, set UNO_JAVA_JFW_ENV_JREHOME, but not UNO_JAVA_JFW_ENV_CLASSPATH" had removed the -env:UNO_JAVA_JFW_ENV_CLASSPATH=true arg, but 8c59580b88a33d7f0c892c9c53776716ad661fcf "Merge commit 'ooo/DEV300_m101' into integration/dev300_m101", in what looks like an accidental mis-merge, brought it back Change-Id: If2313642a1a737c9711fb36dcab5c340bf7dcecb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88133 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-06Remove correctly formatted files from the clang-format blacklistMuhammet Kara1-390/+0
Change-Id: I80554560d55601ece243620a11dc2931144c7e52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88132 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-06weld ClassificationControl ToolboxWindowCaolán McNamara15-153/+215
Change-Id: Idda0b5187201aa77b5b6d682b740a8e55719742a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88129 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06always define GLM_FORCE_CTOR_INIT when using glmCaolán McNamara2-2/+10
Change-Id: I2a4ed756c6d18937d2c720243652df7a2d629959 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88121 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06tdf#130462 call SetMinOutputSizePixel before SetOutputSizePixelCaolán McNamara1-1/+1
Change-Id: I04716e91b7c9b5f1e9db1fd175f5dcbe0600bf1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88115 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06fix "Use data for document properties" checkbuttonCaolán McNamara1-1/+1
regression since... commit 3a15c034be9f557f350d0ba1f3a842151066eaae Date: Tue Mar 12 09:59:35 2019 +0000 weld SvxGeneralTabPage Change-Id: I7c4624255f70c3f0c4ccd4b79ebae7750ed2bbe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88108 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06Typo fix.Michael Meeks1-1/+1
Change-Id: Id638f16f522b335ca9af7a805556f2061df55bf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88111 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-02-06lok: calc: formula input bar: set text selection as requested by clientMarco Cecchetti5-2/+63
Change-Id: If04ed3c1637249329530a73d20df9b9296d1004e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88089 Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com> (cherry picked from commit 01f0d42f5ca9fb0e6e45b7bfcf51cb33c1a27bec) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88117 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-06Missing test dependencyStephan Bergmann1-1/+2
...for CppunitTest that use Java, like CppunitTest_dbaccess_hsqldb_test failing with something like > warn:jfw:2880195:2880195:jvmfwk/source/fwkbase.cxx:94: [Java framework] A vendor settings file was not specified.Check the bootstrap parameter UNO_JAVA_JFW_VENDOR_SETTINGS. > warn:jfw:2880195:2880195:jvmfwk/source/framework.cxx:582: [Java framework] A vendor settings file was not specified.Check the bootstrap parameter UNO_JAVA_JFW_VENDOR_SETTINGS. because the jvmfwk3 ini file is missing from instdir. (Should those tests also set UNO_JAVA_JFW_ENV_JREHOME=true, as is done in unotest/source/cpp/officeconnection.cxx and unotest/source/java/org/openoffice/test/OfficeConnection.java?) Change-Id: Iabf1198246c17410e71d5b85454662ff85a7b478 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88112 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-06DOCX export: fix handling of section starts that originally had headersMiklos Vajna2-1/+86
Both the DOC import (in wwSectionManager::InsertSegments()) and DOCX import (in SectionPropertyMap::CloseSectionGroup()) have a mechanism to try to attach changed headers/footers from a continuous section break somewhere, so they are not lost. This means that even if the rendering of such documents is OK, explicit code is needed to undo the effect of the importer at export time, or those headers will be lost. Start doing this for the DOCX export case when the headers/footers are placed at the "previous-in-practice" paragraph, more cases (handled at the import side) can be added later. Change-Id: Ic2304a74919d18da3ba9cb4afe301e0247a50dc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88103 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-06Fix typoAndrea Gelmini1-1/+1
Change-Id: I8ece4e0ea5ba4756a6b0f9d87ccf1451290a7adc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88119 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-06drop duplicate line in custom_widgets listCaolán McNamara1-1/+0
Change-Id: Id2b8c36e2dd4c7ab6b4158c40b85ec8c13dd6b6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88107 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>