summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-10-08add EditViewCallbacks handler to support updating scrollbar stateCaolán McNamara5-1/+31
the problem is that since... commit 319d8be9dad248a3ced5ac311e0b20ec3ed4cef7 Date: Tue Nov 22 16:21:20 2011 +0000 tweak experimental gsoc multiline input bar, better resizing, enable scroll that uses SetNofifyHdl to try and keep its scrollbar up to date, but that SetNotifyHdl is also used by a11y to listen to the editengine and only one can be set at a time, so with a11y enabled (the gtk default case) either a11y works or the multiline scroll doesn't or vice versa. Seeing as the a11y case is the very complicated case, leave a11y alone and plot a route to disentangle the straightforward calc multiline edit from a11y. Change-Id: Iedc7ffc39940354e8a05c0620944f617eee6b550 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104080 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-08external/liborcus: Missing includesStephan Bergmann2-0/+31
...as seen with recent GCC 11 trunk libstdc++: > orcus_xlsx.cpp: In function ‘size_t orcus::{anonymous}::get_schema_rank(orcus::schema_t)’: > orcus_xlsx.cpp:313:59: error: incomplete type ‘std::numeric_limits<long unsigned int>’ used in nested name specifier > 313 | return it == rank_map.end() ? numeric_limits<size_t>::max() : it->second; > | ^~~ etc. Change-Id: If92cfb565ed9344b2ec1403793d7aeff8bd019ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104074 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-08tdf#130314 space counting for input field.Mark Hung1-4/+4
1. Input field should be counted like other fields, with its content expanded with GetExpText(). 2. Use only GetLen() instead of rInf.GetLen() in SwTextInputFieldPortion::GetExpText() because when justifying the text, rInf.GetLen() isn't always updated corresponding to rInf.GetIdx(). ( Check SwTextAdjuster::CalcNewBlock() for ref.) Change-Id: I6a41275295607887c476fdd3f8e5a90c936c9d31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103782 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2020-10-08track dirty areas for Skia drawingLuboš Luňák6-24/+153
Updates to the screen in raster mode aren't _that_ slow, in fact it seems using SkRegion can make things slower because of manipulating the region, but with SkIRect this could sometimes help a bit. It also appears that StretchDIBits() that is used by the Windows raster code doesn't work correctly if only a subset of the y-axis range is specified, which reduces the usefulness. Change-Id: Ia93d2b60f2c62461e4c2c81210ab1d5d652a2cfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104047 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-08pdfium: remove non-public headers from include pathMiklos Vajna1-1/+0
This was only needed to use upstream scopers, but we don't use those anymore. Change-Id: Idac60119d4d4e8587170fe3e5c69b3ec069e6a6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104069 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-08Related tdf#135202: declare libmariadb/secure/win_crypt in mk file for MariaDBJulien Nabet1-0/+1
Change-Id: Ib9634d9e88d7e97a5c03ff4d8b7808c598c3b8bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104040 Tested-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-10-08we only should have one has_default==True in these dialogsCaolán McNamara4-7/+0
undo the part of 3d056824c687df567c05bf31554fa40ea2baef18 to restore the part of c9e3952e76a9c06d5a1d2f583829ce9eb5b9df64. where the code does no special show/hide of buttons Change-Id: Iacc37e5250468f2b626c3212c30bdd254966fdb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104067 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-08Do not redefine ETIME unconditionally on FreeBSD.Gleb Popov1-1/+3
Change-Id: Iee5e7d3e91b6da5eb6c87d8d3547e0cd65742db7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103945 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-10-08Replace UI submenu by dialogHeiko Tietze8-8/+8
Related 0dce53516011f5d2d9408501714e2b1865517119 Change-Id: I04e0fc602c5eb70f9522d646de36373f7691098b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103391 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-07we only should have one has_default==True in these dialogsCaolán McNamara13-14/+0
undo the part of 3d056824c687df567c05bf31554fa40ea2baef18 to restore the part of c9e3952e76a9c06d5a1d2f583829ce9eb5b9df64. which refers to the statistics dialogs of sc/source/ui/StatisticsDialogs/ where the code does no special show/hide of buttons and they are all a copy and paste job of the same duplicate has-default template Change-Id: I244594399ca3be43e0ac22673487c7e6fe6c37ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07Resolves: tdf#137315 explicitly use FloatWinPopupFlags::NoMouseUpCloseCaolán McNamara1-1/+1
so the popup won't disappear on releasing the mouse Change-Id: Ib496ad286c06305eca67f865946a8303e93118f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07tdf#137295 missing frames on roundtrip through docxCaolán McNamara1-1/+15
because they had the same name because GetUniqueDrawObjectName returned the same name twice because the drawing objects were replaced by flys so there was no actual drawing objects inserted Change-Id: Icbe1848b7115c441f8205b8f566ec5ae4b0c55a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104063 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07lint-ui: add exclusionNoel1-1/+4
Change-Id: Idae99392593c87c7d3b36e426c8d1363434786be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104059 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-07lint-ui: remove checks for top-level widgetsNoel1-7/+4
lots of .ui files are loaded, and then widgets extracted by name by the code, so this check does not make sense. Change-Id: Ia8292c5808587d98f0015280ad17b00402c8b96d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-07Resolves: tdf#137274 comment node not expandable when there are commentsCaolán McNamara1-4/+5
if it was opened and closed before deleting (or undoing thereof) comments If the node is currently not expanded, but it was previously expanded, then it is not filled-on-demand because it is already filled. If the content it tracks has changed, remove its current children and set it to filled-on-demand if there would be a non-zero set of new children Change-Id: Ic8eafea7f298d285d1e6c4a60cb21b57a971bd86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104061 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07Resolves tdf#117463 - Dialog to show UI optionsHeiko Tietze32-6/+775
* New dialog to pick and apply one of the UI variants * Tip-of-the-Day enhanced to execute UNO commands in order to advertise the UI chooser on first start Change-Id: I5e5c4a8e0fb11d11bafc99cc37b7ec244a993781 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99957 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-07raise min version of gtk to 3.20.0Caolán McNamara7-1303/+359
Change-Id: I7e463f48dabbcc27b0d5533fa2c46610cbd7aa82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07dynamic_cast followed by static_castCaolán McNamara2-12/+7
Change-Id: I0e5b7a2531f10d7a9cafa45f33f128f82603f30f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104062 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07RTF import: copy direct para formatting for first para in insert modeMiklos Vajna3-0/+58
This is really similar to commit ae9fe9d7107b2e25c9316033651e49c08537c0e9 (ODT import: copy direct para formatting for first para in insert mode, 2020-10-02), except that was for the ODT import. Change-Id: I5f4e82162f1c18335f472c004c742e0e0f0664f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104060 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-10-07better way of ensuring Skia is used only with canvas that workLuboš Luňák1-5/+5
Most canvas implementations fall flat on their face when used with Skia for various reasons, such as assuming presence of cairo canvas or GDI bitmaps. I kind of already blocked them in b4c28826e0f8716583e7663ca2ea7a2, when I just copy&pasted the OpenGL case. That just selects the last implementation, which in reality appears to be always vclcanvas, which is probably just luck. Also this wouldn't work with more than one possible canvas implementation for Skia. Change-Id: If644abbaeed72f1a649f8974d00f564131aa9329 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103784 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Jenkins
2020-10-07let a subclass destroy and recreate its EditViewCaolán McNamara2-24/+45
Change-Id: I743592b0d6d864f3d72c2fd111ef8adf13a3eb4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104052 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07support pan-down-symbolic/pan-up-symbolic as SPIN_DOWN/SPIN_UPCaolán McNamara2-13/+22
Change-Id: I37bb7474207a084cfce7a3c2a6d9ec507b963aba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104044 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07try more to match Skia's alpha type for source and destinationLuboš Luňák5-20/+44
This is an extension of the other recent commit, matching alpha type is faster, and knowing the content is opaque should also allow more optimizations. Change-Id: I632d3f50e3f4729a64403c3c3ed1b79d63f0c5dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104046 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-07faster Skia from-image conversions if no alpha is involvedLuboš Luňák1-0/+3
Skia's drawImage() is faster if alpha types match. So if the source is opaque, use that and not unpremultiplied alpha (which is technically the same if no alpha is involved, but it leads to a slower path). Change-Id: Ie55eaa55099a9a4c9e6db1e66e212da0acef71f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104043 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-07lint-ui: add exclusions for remaining capitalisation warningsNoel1-3/+33
Change-Id: I572f914fa9a51f992110585ab032fb500f998bc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104055 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-07CppunitTest_vcl_pdfexport: use CPPUNIT_TEST_FIXTURE()Miklos Vajna1-147/+56
This suite is large enough so that avoiding the declaration/registration/definition of each test manually saves a lot of space. Change-Id: I0fd161f54312370cc1ce13f4111ce1724dc22c4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104041 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-07update creditsChristian Lohmaier1-647/+648
Change-Id: Iaa1726883202c35a3d5ce76893f05de46551e672
2020-10-07CustomWeld is finalCaolán McNamara1-1/+1
Change-Id: I2a9b774a58481453232a9925367bf136447ea27c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104036 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07ui files: fix some capitalisation issuesNoel28-38/+38
Change-Id: Id2efb6e5f1c115cb31a6afd3f988fe156c5ad56e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-07Revert "lint-ui: check that we only have one has_default==True"Noel Grandin23-10/+29
This reverts commit c9e3952e76a9c06d5a1d2f583829ce9eb5b9df64. Reason for revert: Some of the code manipulates visibility programmatically, and it is quite fine to has more than one has_default if only one of them is visible at a time. Change-Id: Ia4f565c7d21d232d3038c3489952782c8e2a7be5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103977 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-07tdf#136555 drop custom start center button colorsJan-Marek Glogowski3-31/+0
Custom button text or background colors don't play nice with any complex theming. Maybe we should still allow a custom background color for the button bar, but probably that attempt is also futile and clashes with theming easily. As long as the botton bar uses themable push-buttons as a control custom coloring will break at some point, as these buttons can have too many states, which curently depend on the theme. There is no way for LO to know, if a roll-over button will return with a different backround or just some changed border from a themed paint call. So this reverts the button part of tdf#90452. It doesn't affect the preview area, as that is a custom widget, which doesn't use any theming, but has it's own setting - for better or worse. Change-Id: I1ef17a50d15a5876a11bce89ae3f764aa91f66bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103041 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-10-06SwGrammarContext: ::Modify no moreBjoern Michaelsen1-11/+7
Change-Id: I5569ba4f7fb00477233a5ffaabf9b2c8dca207c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103939 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-10-06Online: Copy hyperlink location. / Core side.gokaysatir6-11/+50
Payload format is added to LOK_CALLBACK_CLIPBOARD_CHANGED. Clipboard changed event is not fired when "copy hyperlink location" command is issued. So i added a call to LOK_CALLBACK_CLIPBOARD_CHANGED inside TextDataObject::CopyStringTo function. Change-Id: I8157572288da88b5522662e13abe151ef8548b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103164 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103872 Tested-by: Jenkins
2020-10-06loplugin:const* make some params and methods constNoel32-54/+54
Change-Id: I97c5bbb929a2a4a029af4e6cb0fd571bbc2b698b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104030 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06loplugin:const* make some params and methods constNoel25-62/+62
Change-Id: If621bb2585fda4afef4be9a189c7f4c00008d358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104029 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06loplugin:const* make some params and methods constNoel28-33/+34
Change-Id: I3c8ca72b2b41a4f82ee20cbe025b41425f32e715 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104028 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06loplugin:const* make some params and methods constNoel49-78/+81
Change-Id: Idec482c21c270912f9bcaeb980077c1616f67c8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06tdf#123025 - fixed broken tests for cverr methodAndreas Heinisch1-17/+9
Change-Id: I44eb44107a24207764da24b4e01b407570342013 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103956 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-10-06move set_user_managed_scrolling to an initial weld argumentCaolán McNamara48-88/+68
gtk is creating a11y objects on widgets changing parents so manage when that can happen to avoid premature creation of custom widget a11y objects Change-Id: I4879a93a897b2e4084cf6af0c9c0b0f0c1062254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104025 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-06tdf#137165: sc: Add UItestXisco Fauli1-4/+5
Change-Id: Id5c777d5c85cda53924c9b8efae7a6cfa55de839 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103866 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-06loplugin:const& make some params and methods constNoel24-53/+54
Change-Id: I2973128a9c6c53187e1da400d1a5df763d515596 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104020 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06add missing null pointer checkLuboš Luňák1-1/+2
It's possible to trigger this case, and the windows variant already has the check. Change-Id: I465fbccb8910bd1b529a2639f34249c18289baa8
2020-10-06drop ownership argumentCaolán McNamara6-377/+261
we have never needed to diverge from the defaults of true for toplevels and false for non-toplevels Change-Id: I884b1e221d0ec44895214363d391c27e3e1707f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104019 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-06reparent to nothing to break gtk ownership cycleCaolán McNamara3-3/+21
which is our usual solution, instead of using less common flag Change-Id: I9dd54a161df53a5b6ffb0b7655e510a6cc4c4824 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-06Allow to save file if chart editing is activeSzymon Kłos1-1/+1
This helps in online where autosave after user closed view with chart editing active caused document to be broken and not allowing to open again. Change-Id: Iab6a9bfe2c5f67c155ee97726e752c83fc47af5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103091 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104011 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-10-06lok: Add posibility to change chart fill colorSzymon Kłos3-0/+30
Change-Id: I519a0fe15c4983803109aed7eef840d36a5e7b21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102920 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103141 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-10-06Use default diagram page selection for chartsSzymon Kłos1-1/+14
Change-Id: I0bf0e5d2d1ef43a61c1bb723b25bafa30b5ad5c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103602 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104013 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-10-06loplugin:const* make some params and methods constNoel43-81/+87
Change-Id: If7fbb25037343e18081a8ee7064840d75e9a45a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104010 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06tdf#136430, tdf#136573: sc: Add UItest (take 2)Xisco Fauli1-0/+41
Take 1 was submitted in 647958099600923d9ba3a57101891f62de326f4b and later reverted in 5872f0c0d206466ad78e92be3d7d551b7ff4dbf1 The reason why jenkins hung was that the position of the label changed from 0.43,2.84 to 0.5,2.89 in a91ac466e2a996a07248ec4a2518d5ba9bdf3d61 For some reason, jenkins didn't fail and the builds were just aborted after some time. Change-Id: If325d74e19b8fe6d8ad06700bfb05620c9d321cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103992 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-06Drop unused codeMike Kaganski1-14/+2
... a leftover in commit 3187eeab10df77a6c0dd6397be993a68276d7141, copypasted in commit 4f4a668e04bdd68655a0f574027f486cea953857. Change-Id: I7a634ba432cb4736ec85a420b0f77288cd1e0802 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104004 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 09:12:15 +0000