summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-06-19tdf#125971: map file URLs from QFileDialog to LO internal formatStephan Bergmann8-19/+54
jmux' suggestion at <https://bugs.documentfoundation.org/show_bug.cgi?id=125971#c7> turns out to be the correct fix after all; explained in a lengthy comment why that seemingly wrong call of translateToInternal happens to do the right thing. (Much of this patch is about passing the XComponentContext down to where it is now needed in Qt5FilePicker::getSelectedFiles.) Change-Id: I235554f8494cd3094a011d5a903059326db499fc Reviewed-on: https://gerrit.libreoffice.org/74359 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-19Update git submodulesRoman Kuznetsov1-0/+0
* Update helpcontent2 from branch 'master' - tdf#92083 Help: Move Color bar item from View->Toolbars to View menu Change-Id: I05f65e0c00517fc7b4b8f4d4a93fdb0b4a6d185e Reviewed-on: https://gerrit.libreoffice.org/74112 Tested-by: Jenkins Reviewed-by: Sophia Schröder <sophia.schroeder@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-06-19tdf#125309 XLSX editing: fix hyperlink at numeric dataTünde Tóth1-3/+12
Long Cell-level hyperlink was clickable in neighboring cells. Change-Id: I3e2a4db170975d997f3fe471188fd0ead593ad6e Reviewed-on: https://gerrit.libreoffice.org/74033 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-06-19allow copy/paste when not hosted in vcl::WindowCaolán McNamara1-4/+4
Change-Id: I1b30cb700461fa66192a4b86bf577d1babc76cb7 Reviewed-on: https://gerrit.libreoffice.org/74353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-19fix memory usage regression when loading files with lots of marksNoel Grandin1-3/+6
regression from commit 3c3a371c799d00475deb13b4c3e0a8860c7e4fb3 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed May 15 15:35:51 2019 +0200 tdf#125254 Performance: A spreadsheet opens too slow, part2 without this fix, the file from the above bug chews up more than 16G and crashes my box. With the fix, it loads, and requires about 2G. Change-Id: I87063196e56b49eab52e77126347bf8d421b1e0f Reviewed-on: https://gerrit.libreoffice.org/74352 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-19sw: improve translation of comments in tabfrm.cxxMichael Stahl2-60/+61
Change-Id: I17eda9a9cb0425983fe6d23ee2c5b5db4a221b5e Reviewed-on: https://gerrit.libreoffice.org/74346 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-06-19NB tabbed_compact cleanupandreas kainz3-249/+88
Change-Id: I070f81e2c5a623374c72a8a4ff5a034bf3d1f11c Reviewed-on: https://gerrit.libreoffice.org/74338 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-06-19sw: convert that to assert()Michael Stahl1-1/+1
Change-Id: I126c2565720770ca0fca9fef69a1690cc0bca948 Reviewed-on: https://gerrit.libreoffice.org/74345 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-06-19sw: fix assert on layout of ooo63564-1.odtMichael Stahl1-1/+23
The problem is that some SwTextFrames (1415 in particular) inside the follow-flow-row of a table move backwards, during(!) which the follow-flow-row is deleted; i.e., the SwTextFrame was already moved backwards by the pNewUpper->Calc() in MoveBwd(), then it is Cut and Pasted at the end of pNewUpper, when it is actually already a lower, somewhere in the middle... This triggers the assert in SwFrame::PrepareMake() that was added in commit e14056e6e88d9b8d988b7b88b2776a8fc952031b Prevent this by using the IsDeleteForbidden() check that was introduced in commit 0005b330eaed0b5559042d2597fb45e0c9125d7e; this is similar to how MoveBwd() already locks section frames to prevent such problems. Ultimately a regression from 18765b9fa739337d2d891513f6e2fb7c3ce23b50. Change-Id: I893ec3e491b4cbe1569edf97fec31d3dd74548ed Reviewed-on: https://gerrit.libreoffice.org/74298 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-06-19Use for loop with explicit number of iterationsArkadiy Illarionov1-7/+3
96be3821f7dad19004a43696555eaa4fa2e1aef5 follow-up Change-Id: I1e585a1f4bcd68757cce7b6327757cd7e9ee660f Reviewed-on: https://gerrit.libreoffice.org/74306 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-19Fix typoAndrea Gelmini1-1/+1
Change-Id: I373dbfe89f7563adf7abd44f458da4c79d6f6ca8 Reviewed-on: https://gerrit.libreoffice.org/74314 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-19tdf#42949 Fix IWYU warnings in vcl/qa/* & vcl/backendtest/*Gabor Kelemen34-111/+10
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I2d5ab9fd1117a4c57eb42ca849daf0949a79ff50 Reviewed-on: https://gerrit.libreoffice.org/73999 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-19connectivity, oox: remove some unused includesMiklos Vajna3-6/+0
Change-Id: I8b39caafc157e309e638eec1a66d9302f1a11a73 Reviewed-on: https://gerrit.libreoffice.org/74307 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-19tdf#45904 Move XShape Java tests to C++Jens Carl5-4/+104
Move XShape Java tests to C++ for ScShapeObj. Change-Id: I349c4abb09c3e9e43285b63ee5f19f55d967b38f Reviewed-on: https://gerrit.libreoffice.org/74331 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-19Fix typoAndrea Gelmini1-1/+1
Change-Id: I02b5d5d7a294fe368e54b4f84d643a55eecadd9c Reviewed-on: https://gerrit.libreoffice.org/74311 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-19Fix typoAndrea Gelmini1-1/+1
Change-Id: I64022d6d94560d695271393b27e3b008755bd7a6 Reviewed-on: https://gerrit.libreoffice.org/74315 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-19Fix typoAndrea Gelmini1-1/+1
Change-Id: I1a74632221a1ae05e035c9aa5bd04914cfe7e7d6 Reviewed-on: https://gerrit.libreoffice.org/74318 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-19Fix typoAndrea Gelmini1-1/+1
Change-Id: I3df900c495faee29f8ecd42ba5a64e26d403d2fd Reviewed-on: https://gerrit.libreoffice.org/74320 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-19Fix typoAndrea Gelmini1-1/+1
Change-Id: If44f7ab2c9925b60b2fb75c1178827f2f3ace44e Reviewed-on: https://gerrit.libreoffice.org/74321 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-19Fix typoAndrea Gelmini1-1/+1
Change-Id: Id0af0141be1fc09241a5ed564585f88ea452b17a Reviewed-on: https://gerrit.libreoffice.org/74322 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-19Fix typoAndrea Gelmini1-3/+3
Change-Id: I24c9df4caed8fa87a31efb93ab1cb0e88225605e Reviewed-on: https://gerrit.libreoffice.org/74324 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-19Fix typoAndrea Gelmini1-1/+1
Change-Id: I95d7efef5021b1a43c1e8a9e4b6aa0be47ad3302 Reviewed-on: https://gerrit.libreoffice.org/74312 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-19Fix typoAndrea Gelmini1-1/+1
Change-Id: Id041587ea926d0fcc289cc9b4c8e57c251aeeecb Reviewed-on: https://gerrit.libreoffice.org/74323 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-19tdf#39593 Remove GetImplementation from ConstItemContainer and ItemContainerArkadiy Illarionov5-24/+8
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I87e1d3afd3a742926c7054179092d3b58b6b4563 Reviewed-on: https://gerrit.libreoffice.org/74310 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-18Colibre, elementary, KJ: Fix for tdf#107144rizmut64-58/+60
elementary: - Fix blurred zoom icons - Reverse top arrow on Small Capitals icons Change-Id: I81883334e5cfaf3dab528ed61ea46894017a6c36 Reviewed-on: https://gerrit.libreoffice.org/74301 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-06-18Copy targets instead of moving during redactionMuhammet Kara3-26/+13
To allow properly remembering the last state. * And some clean-up. Change-Id: Id0b0f4251e3578b8baced1e6e6b1161f46e324dc Reviewed-on: https://gerrit.libreoffice.org/74302 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-18VCL cleanup WidgetDrawInterfaceJan-Marek Glogowski24-495/+193
I don't understand why WidgetDrawInterface, which is basically a copy of the SalGraphics native controls interface, duplicated it, instead of cleaning things up. The whole commit message of commit 8fcfa3853a81, which added this code, is just: "custom widgets: Custom Widget Themes". That's it. So this patch does, what the original one skipped: replacing the SalGraphics interface with the WidgetDrawInterface. One result is the addition of handleDamage to SalGraphics to correctly handle the damage done by a custom widget theme to the underlying SalGraphics implementation. Change-Id: I5fda1a64b28e6560fb3c62e02b6dcda827f698e2 Reviewed-on: https://gerrit.libreoffice.org/74118 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-18tdf#125934 Qt5 set the desktop file name...Jan-Marek Glogowski1-2/+4
.. but only on wayland, as this also overrides the individual window icons on X11. Change-Id: I1b453b23f0dfd4ef2616d7b8054580a6018cdc53 Reviewed-on: https://gerrit.libreoffice.org/74293 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-18Let autoredact dialog remember last stateMuhammet Kara1-6/+67
* By storing the JSON string as SvtViewOptions Change-Id: I08e323005612cb0181d2176af659eb54267fbb3f Reviewed-on: https://gerrit.libreoffice.org/74169 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-06-18Qt5 initialize bool before lcl_textMimeInfo callJan-Marek Glogowski1-2/+2
Change-Id: Ie1b2e77145c4f84dc7d2c1edd214363b7fa0625e Reviewed-on: https://gerrit.libreoffice.org/74294 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-18loplugin:passstuffbyrefNoel Grandin44-71/+81
Change-Id: Icb7c22cf4ac95eab54d04e79312fb471ca27bceb Reviewed-on: https://gerrit.libreoffice.org/74246 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18loplugin:logexceptionnicely in xmlhelp..xmlsecurityNoel Grandin17-74/+87
Change-Id: Idbf0de3f953b08f98144241346533ad30f49269e Reviewed-on: https://gerrit.libreoffice.org/74285 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18loplugin:logexceptionnicely in writerfilterNoel Grandin12-68/+69
Change-Id: Ie01d0e6af6af0cfeb46cdde38f52ab068b64db6b Reviewed-on: https://gerrit.libreoffice.org/74284 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18sw: implement inserting comments when an as-char image is selectedMiklos Vajna6-0/+74
Only the UI was missing in this case: creating a text selection around the placeholder character does what the user expects. Change-Id: I1068fcee3e3b6d0a6fa47b37beb1bd1b918a82df Reviewed-on: https://gerrit.libreoffice.org/74297 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-18Remove redundant writeStephan Bergmann1-1/+0
...that had been there ever since the code's introduction with b5a9cc71d246c26da8aca4203da84c10c104c222 "Exif reading/writing and Jpeg lossless transformations support." Change-Id: I490eb85abb9966c6152bfc00e81589d6aef374cf Reviewed-on: https://gerrit.libreoffice.org/74295 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2019-06-18fix crash in header/footer calc dialogCaolán McNamara2-6/+17
cut and paste can happen when the EditView isn't in a vcl::Window Change-Id: I9fdbfe28c5ca5dd680b821ff8ce4e0133ab203aa Reviewed-on: https://gerrit.libreoffice.org/74279 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-18tdf#111707 Add 'Remove Hyperlink' to context menu in ImpressSamuel Mehrbrodt8-13/+63
"Clear formatting" no longer removes the hyperlink, as now there is a dedicated context menu entry for this. Change-Id: Ic47795b9ecb238470f853da527c648f6edb94c09 Reviewed-on: https://gerrit.libreoffice.org/74272 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-06-18SmartArt: support ForEach referencesGrzegorz Araminowicz7-1/+90
ForEach 'ref' parameter causes specified ForEach node to be used instead. Used to create recursive structures like organisation charts. Change-Id: Iee61b2e103759355b59beb8d3f33eb3cce47c590 Reviewed-on: https://gerrit.libreoffice.org/74271 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-06-18sd: remove pre-gbuild map fileMiklos Vajna1-7/+0
As far as I see this map file is not used to control linker-level visibility in sd since the gbuild migration. Change-Id: Iaf8bbd7a87a994aef1758fc85d3e33b590ae04b7 Reviewed-on: https://gerrit.libreoffice.org/74270 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-18NB tabbed compact big update and syncronisation between appsandreas kainz5-2706/+7773
Change-Id: Ie1178e1e36334b35c7a00b2ec918c79041150c80 Reviewed-on: https://gerrit.libreoffice.org/74268 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-06-18Better type safetyStephan Bergmann1-4/+4
...following up on 42c0e433aca68c669bc0f55af404b6bae1655fba "Avoid -fsanitize=misaligned-pointer-use" Change-Id: I1ff787c7da829e838843c895d32dea3aa26e2cf4 Reviewed-on: https://gerrit.libreoffice.org/74263 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-18tdf#39593 Remove toolkit::GridColumn::getImplementationArkadiy Illarionov3-13/+4
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I6b32cf388f32e7aa8f073daea0423fcbf169386d Reviewed-on: https://gerrit.libreoffice.org/74235 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-18tdf#39593 Remove ScModelObj::getImplementationArkadiy Illarionov26-54/+55
Replace with comphelper::getUnoTunnelImplementation. Change-Id: I06a8db37b5c5c38c52a15a76e6e2df3b431a2040 Reviewed-on: https://gerrit.libreoffice.org/74237 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-18tdf#39593 Remove Graphic::getImplementationArkadiy Illarionov3-10/+2
Replace with comphelper::getUnoTunnelImplementation. Change-Id: Ic0e2e78fea575af6da4870fbd372f2148a328e26 Reviewed-on: https://gerrit.libreoffice.org/74203 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-18sw: extract postit insert code from SwTextShell::ExecField()Miklos Vajna3-64/+80
Into a new SwWrtShell::InsertPostIt(), so I can reuse it in SwFrameShell. Change-Id: Ib327aed033067250f021f3857f4ba3adb8e6c597 Reviewed-on: https://gerrit.libreoffice.org/74264 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-18tdf#111824 Chart OOXML Export: fix Z axis labelsBalazs Varga3-0/+16
Export 3D barchart Z ("deep") axis properties into <serAx> xml tag, as the OOXML Standard requires. Change-Id: I8ee2282a28e9b4bdea6e96c96256f832b1a1aada Reviewed-on: https://gerrit.libreoffice.org/74170 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-06-18tdf#39593 Remove DOM::CNode::GetImplementationArkadiy Illarionov4-22/+17
Replace with comphelper::getUnoTunnelImplementation. Change-Id: If98801fd85bf0967c54e1924a04b6de371868942 Reviewed-on: https://gerrit.libreoffice.org/74234 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-06-18android: Fix non-debug build.Jan Holesovsky1-1/+1
Change-Id: If8bb944417da9a0aa6343d7dc87e7a1931689f1f Reviewed-on: https://gerrit.libreoffice.org/74149 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-06-18Fix typosAndrea Gelmini2-2/+2
Change-Id: I7afd722b18759366bda139c8b881c03c35623e24 Reviewed-on: https://gerrit.libreoffice.org/74256 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-18loplugin:logexceptionnicely in swNoel Grandin14-52/+64
Change-Id: I92c84f5c869e5ccab344f7e3591d68a90a20eefa Reviewed-on: https://gerrit.libreoffice.org/74243 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>