summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2021-07-19offsetof is only guaranteed to work with standard layout typesMike Kaganski2-0/+2
Change-Id: If9ba41a219d3c3b5bff838104b9a0df53030b8f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119181 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-07-19no need to allocate Sequence separately in CommandProcessorInfoNoel Grandin1-12/+13
Change-Id: I325e63f822af1d9a0213837f40e9cc2b3e466c98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119212 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-19sw: fix indentation for better readibilityXisco Fauli1-4/+4
After 9a8c8053b4fb322edb1e45b891307cdad1f3d41f < Resolves tdf#113171 - Text box must not toggle command > Change-Id: I867a012f18634ee8f83bfa2899f97eec1fae4630 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119202 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-19tdf#129571 Change translation context for one time unit dropdownGabor Kelemen1-3/+3
Change-Id: I8e7b81557c5552a1406adc6e89bbbc707cff6ded Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119102 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-07-19Fix updating WhichRangesContainer using MergeRangeMike Kaganski2-3/+3
I forgot that MergeRange is not modifying its object, but returns a modified copy. Added SAL_WARN_UNUSED_RESULT to it (but it seems to not have effect on Windows). Change-Id: I919146fc25a0992d543890464ccac75737647ee5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119230 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-07-19Use reference to WhichRangesContainer instead of pointer in swMike Kaganski9-29/+29
Change-Id: I8e6418ce08f339824433e9af52259b2a8f3bb71d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119226 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-07-19qt5 a11y: Set proper a11y statesMichael Weghorn1-2/+2
Set the states actually set in the 'XAccessibleStateSet', rather than setting states 0 to n-1, with n being the number of states present in the state set. With this commit in place, Accerciser now e.g. initially correctly shows the 'checked' attribute for checkboxes only if they are actually checked. (Better handling of updating states still needs to be implemented separately.) Change-Id: Idbc84f5754eae65cee471834c322b8ddfdb0bb29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119223 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-07-19no need for pimpl in PersistentPropertySetNoel Grandin2-109/+92
Change-Id: Ib5328b4d8e67c69f8dff1fc6406a9447d83a667e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119207 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-19no need for pimpl in PropertySetRegistryNoel Grandin2-69/+56
Change-Id: I3186a4d6df95679ebb1ad3f127c01cd1dca8c94b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119206 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-19Fix typoAndrea Gelmini3-3/+3
Change-Id: I8babf7975eb3b8f3e43f72572e75cbf46f510b20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119147 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-07-19OStorage can be finalNoel Grandin1-3/+1
Change-Id: I8c55993040245c51cd499d00757065e9914a18fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-19no need to allocate FetchResult separately in CCRS_CacheNoel Grandin2-3/+2
Change-Id: Ia4d85bd6f7c667a612b247178e4f1a2321f7940c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119211 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-19no need to allocate Sequence separately in CCRS_CacheNoel Grandin2-8/+9
Change-Id: Ia433c56f512f70f92926de851363d95071a760f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119210 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-19no need to allocate Sequence separately in CCRS_PropertySetInfoNoel Grandin1-17/+16
Change-Id: I8d3ad7909793cbd757b4cef34f363c17f45889cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119209 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-19no need to allocate separately in PropertySetInfo_ImplNoel Grandin1-12/+11
Change-Id: Id5d4f360efd4e583557ba9d61544d34d895e0dcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119208 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-19sw XHTML import: improve handling of <object> with imagesMiklos Vajna5-2/+53
The reqif/xhtml export can map images to a pair of <object> elements: the outer one contains the real image and the inner one contains a PNG fallback. We used to import this back to OLE objects, except for PNG, which has a single <object> element. Improve this by allowing the pair of <object> elements as well: if the outer type is GIF, then map this to an image and ignore the inner PNG. Change-Id: I5c56720cf6a054208cd0478a54bdac15ffece9aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119221 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-07-19jsdialog: sidebar: avoid duplicated widget idsSzymon Kłos15-14/+70
all controls for sidebar goes to the same window id we need different names for every widget so create valuesets with different name every time Change-Id: I69074e607bfe5fa6db665c0dbcae1f029d13a161 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116836 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119196 Tested-by: Jenkins
2021-07-19AbsGTBehavior should implement ILibEngineJulien Nabet2-3/+3
so we're sure all derivatives will have to Change-Id: I4e62d02f01382dbc95b28ffcb3d278aa31427f85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119145 Tested-by: Jenkins Reviewed-by: Todor Balabanov <todor.balabanov@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-07-19no need for pimpl in UcbStoreNoel Grandin2-24/+11
Change-Id: I2cb101a9bbb01a5d48d6eeb3aca08a2befa89133 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119205 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-19no need for pimpl in ScCellRangesObjNoel Grandin2-45/+27
Change-Id: If5f32a3d0eebf739187f3ce2efb69198e8baf8a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119203 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-19flatten RTTI codeNoel Grandin1-139/+134
Change-Id: If56de2708254348b6b759ecdd2b1fb259562af69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119169 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-19Add Handler for Transparent Readpanoskorovesis3-1/+20
The handler separates MetaTransparentAction::Read from metaact.hxx Read implementation is now in SvmReader.hxx Change-Id: Icd044f6c4422222323a9898ef5d7f67732fbbc2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119170 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-07-19tdf#59323 pptx export: test for datetime footer backwards compatibilitySarper Akdemir1-0/+4
Extends the existing pptx export slide footers test to make sure exported datetime footers will be importable by previous versions of Impress. Change-Id: I0026860adb9bebdacc5b2b10fe5d0bf9d7ab419f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118028 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-07-19tdf#59323 tdf#142228 pptx export: fix datetime footers backwards compatibilitySarper Akdemir1-6/+10
Versions before 166671f4aa19deec47c10a220ae1d29fa57faa93 do not import the datetime field as expected if there's no text in the datetime field. To compensate that, added placeholder text "Date" inside them. Fixes regression from: 25ae0de974befb9c279936046056a850d77e0dca tdf#59323: pptx export: add support for slide footers Change-Id: I8e35102bc0bb9a2e540cfdd59fb0dc2a0b23f185 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118008 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-07-19tdf#59323 tdf#142221: fix pptx datetime import export formatSarper Akdemir5-24/+35
fixed some problems from the original implementation of pptx datetime field formatting (2b0669eec0d86e973a7d8def8744c522bbf8af8b) also the comments on tests seemed to be based on en-IN which seems to differ a lot for SvxDateFormat::StdBig. So converted them to en-US's StdBig. expanded the tests, so it covers previously poorly imported types. Also made them use the SvxDateFormat and SvxTimeFormat Change-Id: I675c482d3095b5373975abb2e6e7eca2d353243d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118135 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-07-19Move svl::Items to include/svl/whichranges.hxx, and unify its usageMike Kaganski330-837/+835
... in WhichRangesContainer and SfxItemSet ctors. Now it's not needed to explicitly use 'value' in WhichRangesContainer's ctor, or create an instance for use in SfxItemSet ctor (svl::Items is already defined as a template value of corresponding type). Instead of WhichRangesContainer Foo(svl::Items<1, 2>::value); SfxItemSet Bar(rItemPool, svl::Items<1, 2>{}); now use: WhichRangesContainer Foo(svl::Items<1, 2>); SfxItemSet Bar(rItemPool, svl::Items<1, 2>); Change-Id: I4681d952b6442732025e5a26768098878907a238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119157 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-07-19uitest: sd: put similar tests in the same fileXisco Fauli2-22/+9
Besides, self.ui_test.close_doc() is already called within the create_doc_in_start_center context manager Change-Id: Ic5bb4cfa55fb3892172a073a1f40b8e916802c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119167 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-19Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to 66f80c13fa59a7c6d02470c8bcaaa11af7cc2c42 - tdf#132643 Translate German section IDs Change-Id: Id2ebf1ae3753e1bd2473a2ec8c9fcdbdaf5a68b6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119059 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-07-19Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to 480cbadb642932d29b6ffe602ac1bb84a3edc333 - tdf#132643 Translate German section IDs Change-Id: Ibb2f0fc3af3b987ed19be43db2e11ee56ddaedbe Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119057 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-07-19Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to decea6cf1217df3b62aa780087f483777876c06e - tdf#132643 Translate German section IDs Change-Id: Ie2d8ced954d7b49d67a097da06037d0d6c57ad80 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119056 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-07-19Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to 30aa68716f23a5bcdd0476ce676faf1674bc42f8 - tdf#132643 Translate German section IDs Remove unused. Change-Id: I075a27bf7d60809770970b52487fe7b96e6e4b94 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119052 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-07-19Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to 4bc45fb43ee33c82fb8f4c8cf55928827d937f0e - tdf#132643 Translate German section IDs Change-Id: I74da86977b01fc4d90cdb3e9da6a1b5590c04355 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119055 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-07-19Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to dae7cea036b324f41fc2d230fb79114b49d12fc5 - tdf#132643 Translate German section IDs Change-Id: I7153df88f46e51da0458ac5136a2c5cf9ec448be Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119054 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-07-19Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to 7abf32e2ba0775448b94e6a2770fe5d08cfda1c1 - tdf#132643 Translate German section IDs Change-Id: I132207aa2f2afb55d109a1281e5929710c69cf1a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119053 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-07-19Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to ab07ab3a351ec70f5561bd959cce02fa02e2487b - tdf#132643 Translate German section IDs Change-Id: I08f8757bc0308084de4d68efbbfb633c7bf83323 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119031 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-07-19Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to 5d2c62b18ac9c553c53f28a83beaa484ff4339be - tdf#132643 Translate German section IDs Change-Id: I0d7cc4572918ee0ad759a9a8d6a94bce2806ad4d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119030 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-07-19Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to 9b9111bc680a5e5a23e5fe6c6db98532430eb2c9 - tdf#132643 Translate German section IDs Change-Id: I234fc5c3533b5f52ee0a4fc601517589319546d2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119029 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-07-19Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to b328960e2e09bba428a8f62a1b0926f006b0404e - tdf#132643 Translate German section IDs Change-Id: I7e011dcf8e6ba82a28ac3868c817320b538fbec3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119028 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-07-19Update git submodulesJohnny_M1-0/+0
* Update helpcontent2 from branch 'master' to e43bde91ae0080f71c6871bdd2f7e62873be9bca - tdf#132643 Translate German section IDs Change-Id: Iee18a847073c19c8b2ad6442306f45f5f581737c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119027 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-07-19jsdialog: allow fraction numbers in spinfieldSzymon Kłos1-2/+6
Change-Id: I9849c6a798f0ade60606be75125fde98362d26b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119162 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-07-19jsdialog: normalize value for spinfieldSzymon Kłos1-1/+1
Change-Id: Ia65b1342222952cbec1ddfba4b7464172fd2b40c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119161 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-07-19jsdialog: execute value action on spinfieldSzymon Kłos1-1/+1
Change-Id: Iee0a5c90ebbd9ca96a60e70678f2b20c32d1bb28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116137 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119160 Tested-by: Jenkins
2021-07-19jsdialog: send action event on show/hideSzymon Kłos2-4/+11
This fixes non working comboboxes in the sidebar in online. Where we simulate picking from the list. Change-Id: Ie78e461b2bce7fa0ccd68731e76d0c721242b98e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116097 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119155 Tested-by: Jenkins
2021-07-19no need for pimpl in CellValueConversionNoel Grandin2-323/+286
Change-Id: I4d01fa33a8d9c4cf5610f25890ee6df9bca061bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119158 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-19tdf#143332 - Use utl::TextSearch to implement the InStrRev functionAndreas Heinisch2-7/+20
Change-Id: I2dae038d061f036b3b7c0fbbcb6a821305d4839e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119094 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-07-19Make obvious that this is in a try/catch blockSamuel Mehrbrodt1-17/+20
Change-Id: I1118ef026730481eeef127b570bfd59de4434455 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119163 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-07-19osl::Mutex->std::mutex in bridges/exceptNoel Grandin20-62/+71
I changed all the bridges to keep them in sync, but only tested on the LibreOffice CI machines. Change-Id: Id8fef017cc6c99c60d64b8f849220d5336abc5d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119140 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-19no need for a pimpl in BulkDataHintNoel Grandin3-59/+11
Change-Id: I82c1d61b79d6486f20e51a8814b08149765861d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119159 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-19merge ModuleImageManager into ImageManagerNoel Grandin7-252/+15
they share an underlying impl, so no need to have separate classes Change-Id: I1093f72265f67c7ccf3c2a064c86441d792512d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119156 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-19sw: prefix members of SwXMLConditionParser_Impl, ...Miklos Vajna3-110/+110
... SwXMLItemSetStyleContext_Impl, SwXMLTextParagraphExport and SwXMLTextStyleContext_Impl. See tdf#94879 for motivation. Change-Id: Ia48f9840dde06531c2178ddf5c8ee5457b3706cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119152 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins