summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2022-07-29tdf#126754: Wrong OpenType tag for fractions in "font features" dialogJulien Nabet2-8/+2
Opentype defines only "frac" and not parameters values like 1 or 2 for "frac" See: https://en.wikipedia.org/wiki/List_of_typographic_features https://docs.microsoft.com/en-us/typography/opentype/spec/features_fj So remove STR_FONT_FEATURE_ID_FRAC_PARAM_0/1/2 + remove the extra ":" for STR_FONT_FEATURE_ID_FRAC I gave a try with "Alegraya" font, it worked. I also give a try with "Linux Biolinum G", there are still "None" (value "0"), "Diagonal fractions" (value "1") and "Nut fractions" (value "2"). It seems they're on the font itself like entry "'frac' Diagonal and nut Fractions". So it shouldn't bring regression. Change-Id: I2f46a3f4a53dc498b764dbeb1c1266589cc8d8c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137574 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-29svgio: qa: add unittest for fill-ruleXisco Fauli2-0/+24
Change-Id: I76c0594d634c4154bd2b63027e93934b521998d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137573 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-29tdf#148810 ppt import: Depth set by EE_PARA_OUTLLEVELJustin Luth1-0/+2
It isn't enough to set Paragraph->SetDepth. It must match the property set. Change-Id: I96a22057c57ae869542b4ffbc069a7cd89bb06c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137543 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-07-29Revert "tdf#141652 partial revert "Reset ShapeProperty priority..."Justin Luth3-11/+4
This reverts 7.4 commit 18cc1240565e697859dd7d17058f91d5e01df929. Someone backported it to 7.3 as well. Change-Id: Ie04595e11dd9d2e15fa940b8ada71714bd434f6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137581 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-07-28Update git submodulesRafael Lima1-0/+0
* Update helpcontent2 from branch 'master' to fbbbb4dedd4e42ed16056ba9c98a829601f61833 - Improve description of how to invoke Documents and Calc SF services Change-Id: Id9b9cc379bd838bdbae882554c8320f30595453e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/137416 Tested-by: Jenkins Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2022-07-28oox export: export line/fill and text props. of a data tableTomaž Vajngerl1-0/+3
Change-Id: I02a4c35693b599578e073d52a2d22ad59bc31786 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137409 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-28pdfium: fix build on windows aarch64 - no __popcntChristian Lohmaier2-0/+14
see https://docs.microsoft.com/en-us/cpp/intrinsics/arm64-intrinsics Change-Id: I291f727c1aa6e00d02d2339fcb338159ae49d0c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137568 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-07-28gtk4: don't attempt to create a visual junction between float and launcherCaolán McNamara3-1/+7
the alignment won't match when using GtkPopover to implement these, there's an extra border+margin between the launcher and the contents Change-Id: Idb78d903874fee5a28e87c89951d9b3f9063c547 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137554 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-28vcl: Animation - cleanup pause functions and fieldsChris Sherlock3-6/+6
Change-Id: I8a338a92823bd4e4c1f8123d52711d0925357ee6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76430 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-28Use bitmap width instead of scanline size in combineScanlineChannelsofftkp1-18/+14
Change-Id: I9f5de7ed1bdcd39e5d6e580a2edbd5c0dd2027e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137278 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-28tdf#143148 tools: Use pragma once instead of include guardsChris Sherlock1-4/+2
Change-Id: Ie34bc66eb1dc475566b315db698976913c8aa37b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137390 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-28chart2: set the char props. to the cells of a data table from modelTomaž Vajngerl1-1/+59
This copies the char. properties from the model to the cells of a data table, so the correct char width, font is used for text when the table is rendered. Also add margin to the text, so it looks better. Change-Id: Ib74a8136459a31d64a86dec36a6ba14d2c313cf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137408 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-28tdf#150181 vcl: first column is editable by default in SvTabListBoxMichael Stahl1-0/+3
(regression from commit fe38553aef2121f358fb58e450ec69314aad851e) Change-Id: I58e1afb228dfd87b7d642ccf1b58277960f01e14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137561 Tested-by: Jenkins Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-28lok: add dumpState feature for better in-field diagnostics.Michael Meeks12-1/+149
Always suspicious that some un-expected dialog / state can cause strange behavior in a client. An initial cut at an API to make it easier to unwind such problems by exposing the toolkit state. Change-Id: If8f17943fa4837df4f9ca659a111dcdce5c23244 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137504 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-07-28remove unused SETBULLETTEXT flag in editengJustin Luth3-9/+0
Already unused in initial import. Change-Id: I423442a2b036c64727af608fa667f1f8a427391f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137542 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-07-28tdf#119246: Dimensions dialog has wrong values in several fieldsJulien Nabet1-0/+5
Regression from a8dd49b9fc59371ff8edb31082bbd4f1b6179b1c Convert dimension lines tab page to widget UI Min and max should be -10000 and 10000 (in mm). Change-Id: I936857f4c10bd2b6fec7b0e492c069b88cc071dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137553 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-28these classes can be finalNoel Grandin1-17/+17
Change-Id: I84bb39b6365e445998a793798279c7f9f1064581 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137552 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-28tdf#119840 elide some allocationsNoel Grandin3-19/+31
Change-Id: Ibff6a80a65463641337dc30d88c7ee8432cf816c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137551 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-28gtk4: use GtkPopovers to replace popupsCaolán McNamara1-6/+35
still a bit rough, but functional at least Change-Id: I4b5f896a0d895ed20da3534173c20241a7fe7ea1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137510 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-28clang-tidy modernize-pass-by-value in xml*Noel Grandin31-99/+117
Change-Id: I9bd5f6adfd138c391d76aebfe08ba01e6b3ab3bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137550 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-28work around rounding difference on i386 in descriptiveStatistics testRene Engelhard1-1/+1
No idea why this only appears now, but: ====================================================================== FAIL: test_descriptive_statistics (descriptiveStatistics.descriptiveStatistics) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/rene/tmp/autopkgtest-lxc.4j23khs6/downtmp/build.zIT/src/sc/qa/uitest/statistics/descriptiveStatistics.py", line 108, in te st_descriptive_statistics self.assertEqual(round(get_cell_by_position(document, 0, 6, 10).getValue(),14) , 0.01524095329036) AssertionError: 0.01524095329035 != 0.01524095329036 Change-Id: I496daf61a9542ea0da78e6092dd7070a2665ab0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127363 Tested-by: René Engelhard <rene@debian.org> Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-07-28tdf#119840 reduce OUString allocationNoel Grandin1-34/+42
this is hit fairly hard when iterating over the document Change-Id: I08050fc3262ab1951c1800e6daedb720b1f216df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137537 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-28tdf#119840 remove some OUString allocationNoel Grandin6-10/+18
Change-Id: I488db37b3a60feb351d1ecd46278f6d5c3cdde5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137535 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-28lok: Properly update sidebar context in MathMike Kaganski4-47/+29
Change-Id: I830c0d9bdeaa6340283eafc3e91251d02602d7aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137247 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-28lok: Enable sidebar in MathMike Kaganski10-26/+79
Change-Id: I1554a924eef0bfcaffa893057a37ef45321a0cf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137246 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-28Enable Math sidebar panels for JSInstanceBuilderMike Kaganski1-1/+3
Change-Id: I9c71dd3cad1e45d0a01ab187c652711c19fe3b89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135444 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-27gtk4: for gtk4 set the size of both layers of the overlayCaolán McNamara1-0/+3
the size request for the overlay comes from its main child, the drawing area in this case Change-Id: If814aaa1d1fc38b331b18f5e9685c405d4f0d1b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137509 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-27Unnecessary to remember mbFiltering at column, tdf#140968 tdf#140978 follow-upEike Rathke3-8/+5
It's inviting confusion and only needed for FilterEntriesHandler, so pass it there. Change-Id: I8056bf8e8f563b28358c46b19071e7caa69c88a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137513 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-07-27tdf#148291 sw clearing breaks: fix RTL layoutMiklos Vajna2-1/+49
The bugreport has two documents that show clear=left and clear=right is basically ignored in Word in the RTL paragraph case, while clear=none and clear=all work as expected. There was no special-casing for RTL in SwBreakPortion::Format() previously, as the OOXML spec does talk about left/right even in case of RTL, i.e. no expected mirroring is documented as the behavior. Looking at [MS-OI29500], "2.1.528 Part 1 Section 17.18.3, ST_BrClear" does say that the Word "behaves unpredictably" in the normal (non-web) layout. Fix the problem by handling clear=left and clear=right as clear=none in the RTL case, this fixes the rendering differences for both bugdocuments. If later we do want the mirrored layout, then such mirroring could be done in SwTextFly::GetMaxBottom(). Change-Id: I6265e64540fa9e5b893cfbea146152854416dce2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137507 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-07-27FilteredRow is not a property of the column, tdf#117276 follow-upEike Rathke2-9/+7
It's only needed in the FilterEntriesHandler, so pass it there. Change-Id: I5554ad13a43ccce6aafbba82b33418f060173a43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137512 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-07-27Name FilteredRow what it is, not hidden; tdf#117276 follow-upEike Rathke3-6/+6
Also avoid defaulted parameter, it's only one more place to change. Change-Id: I64468fcd7085eff7a49bd0c359fdf14a31058af6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137511 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-07-27tdf#119840 Store pointer to redlineNoel Grandin4-5/+36
in SwContentIndex, so we can walk the sw::Ring of SwContentIndex attached to a SwContentNode, which is considerably faster than scanning the redline array. Shaves 10% off load time Change-Id: I98c9815d98846862280f5a2b0a656667cf63f05d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137438 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-27sw: delete bookmark if paragraph is fully selectedMichael Stahl8-16/+59
testTdf96479 requires inserting with absorb=true to be treated as Replace, and there is of course no string in insertTextContent(). testDeleteFlyAtCharAtStart requires setString("") to be treated as Delete. Annoyingly this requires API setString() call to be replaced with internal call, do this for SwXTextRange and SwXTextCursor which are the 2 classes typically used in practice. Change-Id: I87caa1aa11abe298cdd3d9a9bbb602e547c7b443 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137370 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2022-07-27tdf#119840 elide some dynamic_castNoel Grandin4-4/+7
Change-Id: Iafaedf26231bac142759d2bf667dfba083cf0122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137503 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-27sw: SolarMutexGuard missing in SwXBookmark::setPropertyValue()Michael Stahl1-0/+2
Change-Id: I41187b02e6b0545529e2a2c5b07da671eae89079 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137506 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2022-07-27Better report unknown constant names by including their valuesColomban Wendling1-3/+11
Change-Id: Id93dedf39ad0e2d1968e80878dd1a1bb07d94b61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137336 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-07-27Don't use magic numbers or off-range enum valuesColomban Wendling1-5/+6
Stop using magic numbers standing for enumeration items. It makes the code clearer, and this test is not here to verify the API stays stable but that the semantics are correct so there's no need for magic values. Also don't use placeholder values outside the enumeration range and replace them with the legitimate and pretty appropriate INVALID value, which has the same effect in the context of this test, and avoids abusing the APIs. Change-Id: Ib5c9d768ba83470d41c65e00ebe3e8878ce32f3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137505 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2022-07-27tdf#108560 horribly slow to paste many lines into editeng with a11y activeCaolán McNamara1-4/+14
looks to me that once the bound rect (and visible children) are synced that they won't change again so continued recalculation of bounds doesn't achieve anything except super expensive calc for no effect. Change-Id: I1684e3724bca28d03f7c255c2d7a40eee1b70eae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137497 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-27Fix comparing some Writer objectsColomban Wendling1-0/+21
Offscreen objects in Writer are not exposed as children of their parent, but might be reachable through relations. In this case, similar objects can easily be mistakenly deemed equal (e.g. empty paragraphs will have the same role, empty name and description, etc.). Try to avoid this by taking into account the object's relations, which should at least have different targets if they are not the same. Change-Id: Ie6e1aaf388006b76d014ba2bd26aabef88d7dd6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137335 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2022-07-27chart2: add char properties to the DataTable modelTomaž Vajngerl1-1/+3
Change-Id: Ie4b49f36def7d20f89695157c3b95e6ee5d16d83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137407 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-27sw content controls, plain text: send state changes to LOKMiklos Vajna2-0/+2
This is similar to commit 373f655acbdad88ff5d76324f32650fe3a005e2e (Send state changes of content control UNO commands to LOK, 2022-07-22), but plain text was not a type at that point. Change-Id: Ia317c60411280c07e1e063ee4b23f12e0d9f6dd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137502 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-07-27gtk4: don't use an arrow for the gtk3->gtk4 menusCaolán McNamara1-0/+1
this was the clipboard dropdown matches the save one Change-Id: I423aeed097cd22d48aa9efcaf95e0e8d6fd36d98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-27gtk4: fill in more of this menu related stubCaolán McNamara1-4/+20
Change-Id: Ia646d6f98804ffbec1177d5964550708588ce88f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137500 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-27tdf#150089: not all databases know "RESTART WITH"Julien Nabet1-27/+31
Regression from: https://cgit.freedesktop.org/libreoffice/core/commit tdf#119962 Fix autoincrement for copied table in 2021 so use the block added in the patch only when detecting "hsql" or "firebird" in the string returned by getDatabaseProductName put in lowercase Change-Id: Ic35a03039e6d06846892d93d5b30186c53f24052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137499 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-07-27tdf#150161: senddoc: use corrected name url: original can be a file pathVasily Melenchuk1-1/+1
...and in this case file name will be not parsed and --attach-name parameter will be empty. This leads to missing file name of attachment. In case of Thunderbird it is not a big problem, but Outlook does not want to attach .tmp files: it is "potentially unsafe attachment". Change-Id: I7c2f696391e1183211a169b08004c6668771f288 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137480 Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-07-27HPPA is 32bitRene Engelhard1-1/+1
as already handled as such in postprocess/CustomTarget_registry.mk Change-Id: Idc7ead94db8f14e656c36db0438c916b0f2565e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137498 Tested-by: René Engelhard <rene@debian.org> Reviewed-by: René Engelhard <rene@debian.org>
2022-07-27rename GODSON/GODSON64 to MIPS/MIPS64Rene Engelhard5-8/+8
as that what it actually is and the compiler defines are already -DMIPS/-DMIPS64 anyway (as are the PLATFORMID and the bridges' name mips/mips64) Change-Id: I274e7a3b0e140375a8e697c1790cbdb972251d29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137489 Tested-by: René Engelhard <rene@debian.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: René Engelhard <rene@debian.org>
2022-07-27tdf#149439 Update Custom values that may have changed since last printer checkCaolán McNamara4-33/+55
keep any value the user explicitly set, but update one that was taken from lpoptions if that changed Change-Id: I02ed4ff575cb7b2580b777bb0948de2ff7211621 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137484 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-27Make AccessibilityTools available more widely and use itColomban Wendling10-62/+58
Move AccessibilityTools helper to test/ and use it in accessible_relation_set test replacing the copied over feature and consolidating the test as well. Change-Id: Ia5ea69bb08bb2a86e3eb6c3dba2ab182b612561d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-07-27tdf#67669 - Make narrow no-break space visible by drawing a gray backgroundAndreas Heinisch1-0/+2
Make narrow no-break space visible by drawing a gray background like for non-breaking spaces. Change-Id: I3f2b4374a08ea8305c8c84eb497bc362866ad352 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137490 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>